From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3933AC5B543 for ; Fri, 6 Jun 2025 02:29:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 52FB56B00B3; Thu, 5 Jun 2025 22:29:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E0596B00B6; Thu, 5 Jun 2025 22:29:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 41D036B00B8; Thu, 5 Jun 2025 22:29:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 22A3F6B00B3 for ; Thu, 5 Jun 2025 22:29:46 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 34043141F5B for ; Fri, 6 Jun 2025 02:29:45 +0000 (UTC) X-FDA: 83523395130.02.4C540BC Received: from dggsgout12.his.huawei.com (dggsgout12.his.huawei.com [45.249.212.56]) by imf04.hostedemail.com (Postfix) with ESMTP id C6CE340013 for ; Fri, 6 Jun 2025 02:29:41 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf04.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.56 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749176983; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DGyQaiUbrVp9ivT5pF5JpUw+1aHMMfr2jE5JnYxoSgU=; b=MaDpm7FUHJW8ZfYLnpU7CLOpCjH0wLHwtLhnLQ0aBoVpJLEuId+DITeSCW0Ev0bB4IC03S Yi3YFeVuEih5UuYG1x8x+lDLBcpPBgOki9G4qO1koeoEW8vSuGaR4JruPI234GHcOLHucW CcUhEzuD7Bhw9aeT0ZL69lmjYRBHbB8= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf04.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.56 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749176983; a=rsa-sha256; cv=none; b=8AqES8o1cGkiIT+C5QVJ+cDW+edqcEs/1i2UbAfjdwBOVu6vX+VN8d5Yt3wUgFQ2rr6zOP Bk81jKPwB7tTkq6Xm8PS9Q0P9FDfULgwrC0IVqT7n99xX53a7RcQzD5YUHbR4ydaJ47/zY P4Ij9t/5V9jsQBhubw2/fPFML7HDZv4= Received: from mail.maildlp.com (unknown [172.19.163.235]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTPS id 4bD4yq6kNBzKHNFP for ; Fri, 6 Jun 2025 10:29:39 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.75]) by mail.maildlp.com (Postfix) with ESMTP id 539F61A0846 for ; Fri, 6 Jun 2025 10:29:38 +0800 (CST) Received: from [10.174.99.169] (unknown [10.174.99.169]) by APP2 (Coremail) with SMTP id Syh0CgAnMGOQUkJo1_4aOg--.17761S2; Fri, 06 Jun 2025 10:29:38 +0800 (CST) Subject: Re: [PATCH 1/7] mm: shmem: correctly pass alloced parameter to shmem_recalc_inode() to avoid WARN_ON() To: Andrew Morton Cc: hughd@google.com, baolin.wang@linux.alibaba.com, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <20250605221037.7872-1-shikemeng@huaweicloud.com> <20250605221037.7872-2-shikemeng@huaweicloud.com> <20250605125724.d2e3db9c23af7627a53d8914@linux-foundation.org> <721923ac-4bb1-1b2b-fce5-9d957c535c97@huaweicloud.com> <20250605182802.ec8d869bc02583cbc9de9648@linux-foundation.org> From: Kemeng Shi Message-ID: Date: Fri, 6 Jun 2025 10:29:36 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <20250605182802.ec8d869bc02583cbc9de9648@linux-foundation.org> Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 7bit X-CM-TRANSID:Syh0CgAnMGOQUkJo1_4aOg--.17761S2 X-Coremail-Antispam: 1UD129KBjvJXoWruw45Jr17GrWUKr45ur18AFb_yoW8JF1rpr WUua45Arn3Wryxtr1Ivwn7Wr1S9FZ7GFWUt3W5Ww13Kas8X3sFyF4kArW5u3W5CrykXw4a vFsruF9rXFW7ArJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvjb4IE77IF4wAFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x 0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG 6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFV Cjc4AY6r1j6r4UM4x0Y48IcVAKI48JMxk0xIA0c2IEe2xFo4CEbIxvr21lc7CjxVAaw2AF wI0_JF0_Jw1l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4 xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1D MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I 0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWU JVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjxUwx hLUUUUU X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-Rspam-User: X-Rspamd-Queue-Id: C6CE340013 X-Rspamd-Server: rspam09 X-Stat-Signature: zq3tpbspbac4z55tk471gqrzka94qqki X-HE-Tag: 1749176981-291777 X-HE-Meta: U2FsdGVkX1+xGPnx8QlDf25EI0O7SpkRW8mEKA1BZ5or8ZdfElHHciP7QlfVZtkN83jIhg6BjAUSxkuj1sKii9aEGDp+KR/lIZKjIZlBlEoqTx9oU6SVjqjRdkuPwAJ0mx7J/RifXIwZDtB2+aTnT8LO3I1eBj36ub80b1aisXFpRVldroZnodh5ZjdQKmTyabRksnDP1TxQcZJe8IJhYL7BsRHTwL8og9BwyZke6+bfDJgbClWyBJXEtR+gmBp0IuWN8KWPSiRkQN6tVSlqINPOONCygB3BIQQRzzOdXQ18gBvwVjOdweTYLtrjdz9ugUbhzyNlWTVtjdKAUu5H0t+ovQvUnAf1yAf91k2XB45X9Rh8Nyb7vdgPyK6sNl4dcOI5SeaWLC0JmM+PLt6NUJvnXr/prpDSjm8HwyF8ItHDQnNObhi7Nel3CuBHy/LiChGUEHAAgFyP8SIFY9AUEVTjscnHjnNoaZKVzcOu2p205UcEWVWaePhHhWpzeV5o3NtMNZjRi4qfDsRkCD9AhHcUwxpYbDJwHP62NiPLYOsmUWH92B7vp7KjhbSlVA7H+q1Vn+4mQoZV3f1CFijWjgefYYzRbwUgSooqaa89jhwxOfcT6BBPkb3wVa80H3PcDWQHj4MQkpOS1svIvcjt1ITmo0Bh17W/MLNMFUxazvS+40562mipt5+UkxJBQgE++DtcVJJbvOvSFway1AcXe3ysAudPiq+yy6qgK7y4sKQQuMg3LgvGR0zWINN5cc6o5IQfqfPjHtKXO+guDOrF2wJOXbQkNv/nsmnlrhVZ9/rBavuvuXjVwA+2HDgItX9NpZnP40MwTTIZWWLUvKZmGx35vZsYrJOyHkNDn+qggcKntd+xBYbuo94IwhXmi+P+Jgl/Rv6SEOYigusedzO7GwUDHx0jOJ9f8P1ykNwmLUxg3w7s9K0J5GFq2aqtBwWPoeJ4oALx3iSJ7GdEtO7 Z1fSba93 N+OpSh4faCn4TEFk5/7p1B16GMmh6xOm1gi2l5Ub7HlNOEsk/7D5Q1EYydTTuNNmeJqLyFwb2ItCV/MQYqiR2RaF+Kq0JVzFCQ8pB9VMarC7NGh6d6AL/VW10+178jSw/K9ZDFhVmwQ+Kt1bjDwx6NoCQn2XOaH0nUJXIkiWO6vYLppQQOvwUlyapD5L2XQUaz6Tj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: on 6/6/2025 9:28 AM, Andrew Morton wrote: > On Fri, 6 Jun 2025 09:11:37 +0800 Kemeng Shi wrote: > >>>> --- a/mm/shmem.c >>>> +++ b/mm/shmem.c >>>> @@ -2145,7 +2145,7 @@ static void shmem_set_folio_swapin_error(struct inode *inode, pgoff_t index, >>>> * won't be 0 when inode is released and thus trigger WARN_ON(i_blocks) >>>> * in shmem_evict_inode(). >>>> */ >>>> - shmem_recalc_inode(inode, -nr_pages, -nr_pages); >>>> + shmem_recalc_inode(inode, 0, -nr_pages); >>>> swap_free_nr(swap, nr_pages); >>>> } >>> >>> Huh, three years ago. What do we think might be the userspace-visible >>> runtime effects of this? >> This could trigger WARN_ON(i_blocks) in shmem_evict_inode() as i_blocks >> is supposed to be dropped in the quota free routine. > > I don't believe we've seen such a report in those three years so perhaps > no need to backport. But it's a one-liner so let's backport ;) And > possibly [2/7] and [3/7] should receive the same treatment. > > I don't think any of these need to be fast-tracked into mm-hotfixes so > please resend after a suitable review period and include the cc:stable > on those which -stable needs. > Sure, all issues are hard to trigger. I will resend this series later. Thanks!