From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14557E77188 for ; Sat, 28 Dec 2024 13:41:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2EAC96B007B; Sat, 28 Dec 2024 08:41:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 29B2A6B0082; Sat, 28 Dec 2024 08:41:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 13C636B0083; Sat, 28 Dec 2024 08:41:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E91336B007B for ; Sat, 28 Dec 2024 08:41:03 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6C69AC1750 for ; Sat, 28 Dec 2024 13:41:03 +0000 (UTC) X-FDA: 82944477504.26.DD85E90 Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by imf15.hostedemail.com (Postfix) with ESMTP id D5FDFA0003 for ; Sat, 28 Dec 2024 13:39:42 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of yukaixiong@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=yukaixiong@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735393241; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lRD9Gi9DQzr62oMZrRDxCI9jnXOqhJzDPSYYYveOKfU=; b=j+sb7cEsKqNyVATPwFXnTM+MbIuaO7gObS2MWKQv+nErzEvU3wu4/p9WMdjPhQlSLISGOX Rt+1tXrWHY8PJkbPkveu+t2I584E8rbpqEMACoCJLyFDf407qZ88Eha3UBx5edHGSA1pM2 GEKgiI9xgmu18imPWd9mlloU2yeiq30= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735393241; a=rsa-sha256; cv=none; b=7Q5kFW57ncYhddl2DLPfdfPJjrimwCl77drDXKrJ1WSxO3Bsmun8C8U8iUMkNuV3kXUwKC y2JuO2ASdOyzur8CNNcIZ41jjafj00Zk+OlV6MtXtRcNx05RBm/cFHIefjHSPkLJZTODNE GCMDBCpCrGoq6AoLljSUTZH9KQdhX78= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of yukaixiong@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=yukaixiong@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.234]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4YL3Nq6kB8z22jlg; Sat, 28 Dec 2024 21:38:51 +0800 (CST) Received: from kwepemh100016.china.huawei.com (unknown [7.202.181.102]) by mail.maildlp.com (Postfix) with ESMTPS id 3D6EC1401E0; Sat, 28 Dec 2024 21:40:55 +0800 (CST) Received: from [10.174.179.93] (10.174.179.93) by kwepemh100016.china.huawei.com (7.202.181.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Sat, 28 Dec 2024 21:40:51 +0800 Subject: Re: [PATCH v4 -next 00/15] sysctl: move sysctls from vm_table into its own files To: Joel Granados References: <20241223141550.638616-1-yukaixiong@huawei.com> <42tsyuvdvym6i3j4ppsluvx7kejxjzbma5z4jjgccni6kuwtj7@rhuklbyko7yf> CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , From: yukaixiong Message-ID: Date: Sat, 28 Dec 2024 21:40:50 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <42tsyuvdvym6i3j4ppsluvx7kejxjzbma5z4jjgccni6kuwtj7@rhuklbyko7yf> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.93] X-ClientProxiedBy: dggpeml100008.china.huawei.com (7.185.36.48) To kwepemh100016.china.huawei.com (7.202.181.102) X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: D5FDFA0003 X-Stat-Signature: z6mkkqit6smyqwfe5n3hjm51kcfwo4pg X-Rspam-User: X-HE-Tag: 1735393182-694422 X-HE-Meta: U2FsdGVkX198chYP82+/7QHHJPVayxq9YjFFnZ99Ff+G14CzWTgfHcIZicMraNHCoOfmF50ncOnclbqTdz5BhetBKN1FtVRPTe3Zb5gCoZ19XzzRvPysYypY7Z9VjHalqTMvi3lezxs/pzHSzxo5HVruXFcsUt/st7AvvX+E+0xbNBrmm9e9xCNFo1IzJxM4q3ZDVB/vYt3yrpJJhsrcbsAr6Y06Jg1p/MoebvnvxWxMAo+ygttOJJHyiHXd1gGbtMC45AaF486yDnByyYxj4MWXf+SNDvU3A0v3WA/ahbnw6leg2ePmQKUQq6BNjEEM+E76ZIXuxdukXc8fbktprU4/hC4jyeioiTTjMQUX6sAjA/H2dBv0rXBGX8NtC7ASkGXQfRgOKozTnHky5DbvUnhGdOyJpvEGva3VeUvP2xZ9uVTK+qMEJqqG4fUK9JZIevk6ABGeoqGaakcG4FavxjZhJ0XkMCM0liJm1upKeywbDbTChnADcfoEYD2TwjhZfW+hXg5MWkRRQFYb5U9i/+6AId5jfj4m3jq0G5dYu5CSuG4We+IWdG9Ji9XfAc0es0JvoY9mIVBGF6zA+BF1IrUrVbmz+MykxkpS+ORtX8KNyWOuenaxj5DsB0TFt8PFxC8WPNEcAUN5lefOb2X13uQhR2Mr0o6/Gm7IDVKn/yOHA1rqHwZM4A1PNqiYisB+JhCfHfZgE4AEtx0VJH9qQlNNm0S5+rwXLytjXKZhCBiU/fkKHba1aVsnLlcAgJ0DJB58fFevEb5u/2L9ewbG1wIMHu+EULU8tuneYMhqkhyvrANAvCZoKDNZuLYBp33fgB2A/YywT0NG/AJ6pIIj/UCtNNv+v0gw71b4exZM+ejEPJnFubdv+G2S5+UhdxpFRG5ku5hcP3JmrjmafKS8mL40/4eFbJpg11s9/7rt3Xf8+tLmkrzjd4wZl7gc4d4+85FydUaUxC683pbyoSn vAXMEF6o 9bv4c980rfa39sK6ufcn5HMR1hNOv579kPfyCd8vDQVn/3sSvgqKKsEJHoUqMBnAXXXSEquKlL0HirrnVV1m5ciGCcbN/gX8xwxQgAnRdNtmG7anhUe5+t0qxczfiK+49g+M/TJhcvc+L2W/ttHMWJtbnNOd6cYKEPIytet9kvf0YbepEN+pAs4PLh5aUkyDwd23BkXPU848HHJJezWLRcAet6q1BN/HwGNGY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/12/28 20:15, Joel Granados wrote: > On Mon, Dec 23, 2024 at 10:15:19PM +0800, Kaixiong Yu wrote: >> This patch series moves sysctls of vm_table in kernel/sysctl.c to >> places where they actually belong, and do some related code clean-ups. >> After this patch series, all sysctls in vm_table have been moved into its >> own files, meanwhile, delete vm_table. >> >> All the modifications of this patch series base on >> linux-next(tags/next-20241219). To test this patch series, the code was >> compiled with both the CONFIG_SYSCTL enabled and disabled on arm64 and >> x86_64 architectures. After this patch series is applied, all files >> under /proc/sys/vm can be read or written normally. >> >> Changes in v4: >> - change all "static struct ctl_table" type into >> "static const struct ctl_table" type in patch1~10,12,13,14 >> - simplify result of rpcauth_cache_shrink_count() in patch11 >> >> Changes in v3: >> - change patch1~10, patch14 title suggested by Joel Granados >> - change sysctl_stat_interval to static type in patch1 >> - add acked-by from Paul Moore in patch7 >> - change dirtytime_expire_interval to static type in patch9 >> - add acked-by from Anna Schumaker in patch11 >> >> Changes in v2: >> - fix sysctl_max_map_count undeclared issue in mm/nommu.c for patch6 >> - update changelog for patch7/12, suggested by Kees/Paul >> - fix patch8, sorry for wrong changes and forget to built with NOMMU >> - add reviewed-by from Kees except patch8 since patch8 is wrong in v1 >> - add reviewed-by from Jan Kara, Christian Brauner in patch12 >> >> Kaixiong Yu (15): >> mm: vmstat: move sysctls to mm/vmstat.c >> mm: filemap: move sysctl to mm/filemap.c >> mm: swap: move sysctl to mm/swap.c >> mm: vmscan: move vmscan sysctls to mm/vmscan.c >> mm: util: move sysctls to mm/util.c >> mm: mmap: move sysctl to mm/mmap.c >> security: min_addr: move sysctl to security/min_addr.c >> mm: nommu: move sysctl to mm/nommu.c >> fs: fs-writeback: move sysctl to fs/fs-writeback.c >> fs: drop_caches: move sysctl to fs/drop_caches.c >> sunrpc: simplify rpcauth_cache_shrink_count() >> fs: dcache: move the sysctl to fs/dcache.c >> x86: vdso: move the sysctl to arch/x86/entry/vdso/vdso32-setup.c >> sh: vdso: move the sysctl to arch/sh/kernel/vsyscall/vsyscall.c >> sysctl: remove unneeded include > This patchset looks strange. There seems to be 15 patches, but there are > 30 e-mails in the thread? You can also see this when you look at it in > lore [1]. And they are different repeated e-mails (mutt does not > de-duplicate them). Also `b4 shazam ...` does not work. What happened? > Did you send it twice with the same mail ID? Am I the only one seeing > this? > > I would suggest the following (hopefully you are using b4): > 1. Check to see how things will be sent with b4. `b4 send --resend -o OUTPUT_DIR` > If you see 30 emails in that dir from your patchset then something is > still wrong. > 2. After you make sure that everything is in order. Do the resend > without bumping the version up (leave it at version 4) > > Best > > [1] : https://lore.kernel.org/all/20241223141550.638616-1-yukaixiong@huawei.com/ I'm very sorry, due to my mistake, 15 patches were sent twice. Sorry, again! I will resend these 15 patches, and leave it at version 4 >> arch/sh/kernel/vsyscall/vsyscall.c | 14 ++ >> arch/x86/entry/vdso/vdso32-setup.c | 16 ++- >> fs/dcache.c | 21 ++- >> fs/drop_caches.c | 23 ++- >> fs/fs-writeback.c | 30 ++-- >> include/linux/dcache.h | 7 +- >> include/linux/mm.h | 23 --- >> include/linux/mman.h | 2 - >> include/linux/swap.h | 9 -- >> include/linux/vmstat.h | 11 -- >> include/linux/writeback.h | 4 - >> kernel/sysctl.c | 221 ----------------------------- >> mm/filemap.c | 18 ++- >> mm/internal.h | 10 ++ >> mm/mmap.c | 54 +++++++ >> mm/nommu.c | 15 +- >> mm/swap.c | 16 ++- >> mm/swap.h | 1 + >> mm/util.c | 67 +++++++-- >> mm/vmscan.c | 23 +++ >> mm/vmstat.c | 44 +++++- >> net/sunrpc/auth.c | 2 +- >> security/min_addr.c | 11 ++ >> 23 files changed, 330 insertions(+), 312 deletions(-) >> >> -- >> 2.34.1 >>