From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E2D5C3DA49 for ; Thu, 25 Jul 2024 13:07:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E7EFD6B0089; Thu, 25 Jul 2024 09:07:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E2E376B0092; Thu, 25 Jul 2024 09:07:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CCF806B0093; Thu, 25 Jul 2024 09:07:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id ABEB96B0089 for ; Thu, 25 Jul 2024 09:07:42 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 51617121150 for ; Thu, 25 Jul 2024 13:07:42 +0000 (UTC) X-FDA: 82378301964.24.F93272D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id DBD8B1C003D for ; Thu, 25 Jul 2024 13:07:39 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=M58BL6hD; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721912835; a=rsa-sha256; cv=none; b=mQsC7FFTnTyZdcJ34mnhSNFnPWBLCS9lofIjcL8hlMsOiDkEt1wrzD8wX/ox0hpvuikrUM 3q2ew6nk5k63q4OQ3774VuM087VGOb5Di52M4Rz8C/ONgo/4XzTmwOh6Tqlfw5U3zuhJ7t aYvOi1W1Bj8p1VzvY2LasJsZGzd6kvE= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=M58BL6hD; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721912835; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NFOfnXod23eXLrrcZDgNCx1C4bEGvgqLi4FsG5UaOVw=; b=wj/2oiYYp9osgDxBhyIdPgOZ0cZICGHh3JSI4XAvk2KvhesiMBXivD0hF8P9bzwENZlZSV 4dBlcMU7lAasnSQUGtmbD/OAf2T8211UWb6N/7jetX4ZAQupa/gBR0LRR8NJ5yvqDZrWH9 fLNR9CjzkeKbwHUkwxicNqDA1GttnUc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721912859; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=NFOfnXod23eXLrrcZDgNCx1C4bEGvgqLi4FsG5UaOVw=; b=M58BL6hDDeyJ+jFlQftP62hf84dmTDTgT6dTQeFMg2E0Ky6L+HESqfc1RFcntwgjpYQltQ DlB4TEkxOboaokOVWo8l2/4IZtficWTlqUcr+ftlR59KhLvv4gn33KD+b93ln/akGcEChm DVkOkfVVQn8yNI8TNSFS0U47HOV6SLI= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-649-ALNq075qOtqR3EQAe24zOQ-1; Thu, 25 Jul 2024 09:07:36 -0400 X-MC-Unique: ALNq075qOtqR3EQAe24zOQ-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-428076fef5dso4489345e9.2 for ; Thu, 25 Jul 2024 06:07:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721912854; x=1722517654; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=NFOfnXod23eXLrrcZDgNCx1C4bEGvgqLi4FsG5UaOVw=; b=F0O5XN6QBLRCb5sFlrURC8/6Xk/8hPTfNAhUT7m05zMoPo7NPke5WtPmddy65korzh dRCsUnJdV2k/zTAycZBG9RRBWCDzpim5hVeSq+JA71F6Vsv2AGqg2F942UwWM2ksZmSn 1DIVFJ2HwmVHHIq2+wTYwn2lzVFnp4B0ewpgX7itJUn7kH64aTSVYfsa6xUqp8w6PRO2 10sIHn5yG8pEUUwknDVw7HmDU23tcpWs1+4LksDV6F/WtQFNxCKJWWNnDahlpOCHPwzF dsbNFaTIgiKDxhAK5u6z+BDqWfreQcJhdqp9/RG9pozX4zQrGHeBXjvzsPQ+qiz27HY0 8eyw== X-Forwarded-Encrypted: i=1; AJvYcCWwhnmrKZdiRIKNkGL1yYo0Vn61rixjg2gDGVS35O4U1wRg49WUf0dSTzutkXEBzBiyNV4bekcg+Tw0/MQyXcaIj98= X-Gm-Message-State: AOJu0Yz4HXuT4W1D8E/k1FXzJZyg6ArAEZPdRhRhv+kkecBt5xrSmBZ4 OnEz0inxq3S6OcUbPNaQS5VbUlunfQOs4i5TcNxhYwzJtWJwiEg6gkuqftQe6YTk1Snu6XgGWD0 MsJI6+g1CH40JJ8g0VUD4d108EeacqQ84lBPa5ijUPCwneeU6 X-Received: by 2002:a05:600c:a4b:b0:426:4f47:6037 with SMTP id 5b1f17b1804b1-42805711e0dmr15837305e9.19.1721912854245; Thu, 25 Jul 2024 06:07:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFE4/40Ipsovkw8qmvQ3TpfowfqGoM/UQA10Uy+POeRRIv/gssEEbMYj4OAz/h1elI/71Kw5A== X-Received: by 2002:a05:600c:a4b:b0:426:4f47:6037 with SMTP id 5b1f17b1804b1-42805711e0dmr15837085e9.19.1721912853816; Thu, 25 Jul 2024 06:07:33 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:2c00:5f6:3120:375a:3e4? (p200300cbc7062c0005f63120375a03e4.dip0.t-ipconnect.de. [2003:cb:c706:2c00:5f6:3120:375a:3e4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36b36861b61sm2124670f8f.97.2024.07.25.06.07.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Jul 2024 06:07:33 -0700 (PDT) Message-ID: Date: Thu, 25 Jul 2024 15:07:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] mm: shmem: simplify the suitable huge orders validation for tmpfs To: Baolin Wang , akpm@linux-foundation.org, hughd@google.com Cc: willy@infradead.org, 21cnbao@gmail.com, ryan.roberts@arm.com, ziy@nvidia.com, ioworker0@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 517iywmo4kmjghikabsa6tds4a54bt5j X-Rspamd-Queue-Id: DBD8B1C003D X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1721912859-977602 X-HE-Meta: U2FsdGVkX1+pPe9Y8JC5fnVtNqgCnDVHh1GLQbuc4vsXMjuKKTgS++ylNjRlUJ8IktTclPD9cX+XB6FwT0mK7uaJOlontiSaijHjxtG6LetFkzwqjhX9xy2fwFQsnMwPXblQYhIbM/Asj2FXpaXwe0H6cuK8mzCnm64tZyARWej3D+VC9LeoDlWTu7f7wf3RtXYn7CO9IiQDfEsJK8TUycBV7FDtSD+AZNuhEgXt0vZhOKQb5LJf4Z/OPczC56VlilVhqy6MYiyHrV6nI0YZ8h25JxLsiCCGJIaBkppm/+zt5X9t1/JjX6Zeuf3xam82mbdxle8LgcaZ7O5Aicie0abwGPjyzXoU+3LdbrIzi5eufOVhhHZ6vrPQBWc4gfxnsPV7r4EtYdzwKAbl0dULkhXcQ9arLf1tpZQnS50TCk3P8KaUR9gw3a2FLqXk+00Kk61tPmV1jvav8jHDQqoQc4Mugga2j2o9m18BhIiDqnzfu/MJMH11gDpekkLEqXoRYwZXwqIWPcgSmWb/Vu1LMZix+kLeOF6Xer0+dCwVgdBhNERs23sL/U2vzp6PqbuvA6i4NlqGtBqrSl+wchF/laoGUMCuYcTJDWrNqN+c7S7smyytdFQ+tW4YBD5+GzzkzvOoLy9iDlpfkU2cOCY+7mroRAHB6+o6QnwHfU+dz06t+5OaHeidb3CmwfNKjHextgbKVJ/c8GnRHFXuGNcTRdIUaD2mmkOGiqsN2vFDWjxZkyNrn4Tyr7LVY0wdRHVWw5txs/sWZ1IcQeYHRvo5kB9mzEem7hRsIPYdj/BHzdgpnB5CXFyTbSvN00skKsUysLrKcnG8lUAKQcig5SHJ6YC5QCWywyRAWkJvmmh1Pukdwg+Zv8UYa7tit4KiW0UanF/2QSWDh0N4Wjfr3VyRu8xCH8ZjLizYGVasZGzbwMvfFxyFMNNLLFwQndYyKVRYkSUqzX7V184BP+jzGYi WaS6duIW id9eHjrMfacU/rVflcWPrM/wwzyckU2UssPODt5YnDOxDMHwgG/Lv3XCXH2egFCXqpP8qj9ZGLDvA0zc5EnMX0DPUr2F9ADki50LXwdPHAaRHs9Y6Cq/LIUihRbc6rflwrQo2+K1B9TJB625/IJ+qp92CoFJXt6PIck3w45bs7L8EnDyKP70PfmJxZ0NoIQdTbkrdU8r7eQWGrNl4PiIpijl8P8YIuwT6vNNGiTC8QqHRl2UFK7sUsjZH5Xxh2S4yMJ7XZXiUS7Sj5Jgdril1qpRJu2Q+33K8Mx1hYKh7zulJTnFOtMVpwaYu2YXmfGyyirRhVLPDm1HJIBNTibNfia54pS+1RJivgedDgtblYWQE6tjFf7R+H6THvSnL4A0aUZ1hu9CqFO0HIvdBnyueAyDTOKKZPjBdOPC11r8r3tlXupX20o1uTLrs3Wi5igRazlz7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.038641, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13.07.24 15:24, Baolin Wang wrote: > Move the suitable huge orders validation into shmem_suitable_orders() for > tmpfs, which can reuse some code to simplify the logic. > > In addition, we don't have special handling for the error code -E2BIG when > checking for conflicts with PMD sized THP in the pagecache for tmpfs, instead, > it will just fallback to order-0 allocations like this patch does, so this > simplification will not add functional changes. > > Signed-off-by: Baolin Wang > --- Acked-by: David Hildenbrand -- Cheers, David / dhildenb