From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DF8CC0219B for ; Fri, 7 Feb 2025 18:22:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DE6496B0096; Fri, 7 Feb 2025 13:22:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D960C6B0098; Fri, 7 Feb 2025 13:22:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C5E4D6B0099; Fri, 7 Feb 2025 13:22:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A67D06B0096 for ; Fri, 7 Feb 2025 13:22:21 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id F09AA81EC8 for ; Fri, 7 Feb 2025 18:22:08 +0000 (UTC) X-FDA: 83093967936.06.D808851 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by imf19.hostedemail.com (Postfix) with ESMTP id E50BC1A0008 for ; Fri, 7 Feb 2025 18:22:06 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=V9Zm2v1y; spf=pass (imf19.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738952527; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3+YGX1DTK4BSkbmjULQJUOSzdL9bhIcw7veskFtned4=; b=UVY3Dluo0jCr/AParzT0LbnOU52WifxRX0u1sCXIH9/+TEY5y/dJaiRiziPni1xCEFnpL4 rIGp3Oz69IgdsdG1+QfNX6lbX5qzcMhhxFVVumIyPXYI85/9ACbB2PIPAiaY2GS4COCln+ Fc2A/kVgKMcVEEGviKxtU0tKuP15goE= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=V9Zm2v1y; spf=pass (imf19.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738952527; a=rsa-sha256; cv=none; b=KmGw4aQ/VkQrwxxkEqzboPAm1b1QMzT+c3edsDs9x1SQst/d5oaFV+8DOJp/ZY4paeADiM PVILT8K3OESK4VSLmA6oTyuZy51Sw2Mq0Afmul+y4AjKaSSDkmOCkieECeQUkIIiFiab/p EmnAxzsBvVEKukAp3AVD8sS4yTPgDg8= Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-38dc627eba6so1105047f8f.2 for ; Fri, 07 Feb 2025 10:22:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738952525; x=1739557325; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3+YGX1DTK4BSkbmjULQJUOSzdL9bhIcw7veskFtned4=; b=V9Zm2v1y1dCezjAKdMu4DvjF6slKOIpS2S/xbRbAo1UCODvWbvSwec+hubVY1TFlzD jbEIPdd3rFqWzemkxLHp74jwep3OjWv6i4CXdNelIdtycEbTuCzEUV8xl44dH0lqk1Nf CwgYE3aJdtBlr3MyL9PhcQpHyJ/0U4rIvlJrz5dAu0sHLi4fn+wWTgmnwy7ksvh7vVou gAzOinj9H4RBxQ8p3qxBGu3a3F4tIwHvdx8MBo/EBrl4HO8IHcj4RrhUtV4Kq4fNNB0g k+KHKIhoZv7UpTUPkFEmtvOhKR6r8Hn3IJpDdqJUlUYVzGeZYxqPtWvHGbiZppQazFHi pp9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738952525; x=1739557325; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3+YGX1DTK4BSkbmjULQJUOSzdL9bhIcw7veskFtned4=; b=g6kqUXCUCv7kHcdiuz4Ep1QWSxUVgIekG5luFBJkscJjwAX6ZySMrV0cPs3tVu0WeM rsDiFEtfKa311I022gGgfLW4LYBMPUmr/ul8oxfaTGJiQ1HHvlU96M4JRYm+91JntL/L 6pxIU9awOQNqWfpgmYLhnr05J54X122g0cSMpNw9V/X9evEpw0Q9+S0U95vnKoZCnon3 M+O9xI9PfZj6zcqYnDLwkf8aOZj6D13TTCW4oNlAwQgETR5R21jmoF5f94ME8v6GxRuF 0cfSm4v/EhgfMRQ/N07XbV5O8ZZj8NvxWSbjfxvjkYOSxmyQ0jl/qxGzWlZVDpUGA+Qq gabg== X-Forwarded-Encrypted: i=1; AJvYcCWuASkxZRy/dsYu0OzwXtn9XvgWP/8b17Gn2SRJa7uxp+qe0/mIVcClkDSaIOC9s7olkZhLvvRkDg==@kvack.org X-Gm-Message-State: AOJu0YwIblE4moaBdNsv1h2z7iOEkRrMERmDW+EUJuddg5WVIHHeOM21 0FJ6kSmyFrGQ9nywJBKFX/jJuGtz9MEaanNvBwCfApI/nzvvblzL X-Gm-Gg: ASbGnctUeihvCfePDkrfQhKuMuPfhuFU1jrHEOzRiLmCzEy62xCy9Qd9GbxqE6iL1ty +Xjwmq+8NTx0GybCdbmtdnfCXE10txKQt8WuHOCYPq13K+94UEEddd4UhOyw6S3umhRFyPRe7NS nxXIlYQm2ag7wxIB59xeWCIM6iNC/0qAO1CP+ARhE/Y9pO+QEdMXl02M154/MNvfJtusUMQwZ87 B1OaCf8UK4dM2suvIT/ih7SexV5Xwf6PKG1zsft0iY8rsXjCyh//9niOsa2PJHXVaYAArGOZsPs OFiPS0HJy6XiMPSWD182v5a9vPNyoJC7cnNzH02SSG+ZERF4bRJqFTcjwcewyMKo6D9wgqixWlC LkQ4HyTtbsg1HkA== X-Google-Smtp-Source: AGHT+IHX6rf5djK8JZZYNxsUJ2jiy0jGXj+xlR6Spwo29YcCOu4YWtI8TcXWQg2JmgngQcGzngpIew== X-Received: by 2002:a5d:64a3:0:b0:38d:cf33:31c6 with SMTP id ffacd0b85a97d-38dcf3336e9mr1574931f8f.50.1738952525138; Fri, 07 Feb 2025 10:22:05 -0800 (PST) Received: from ?IPV6:2a02:6b67:d752:5f00:c46:86ac:45ea:7590? ([2a02:6b67:d752:5f00:c46:86ac:45ea:7590]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38dc4458d71sm4072564f8f.63.2025.02.07.10.22.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Feb 2025 10:22:04 -0800 (PST) Message-ID: Date: Fri, 7 Feb 2025 18:22:04 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 4/6] mm/damon: introduce DAMOS filter type hugepage To: SeongJae Park Cc: akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, hannes@cmpxchg.org, david@redhat.com, kernel-team@meta.com References: <20250204231248.2729-1-sj@kernel.org> Content-Language: en-US From: Usama Arif In-Reply-To: <20250204231248.2729-1-sj@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: E50BC1A0008 X-Stat-Signature: k6k993xt7jjpmfwi8nnrkxrbqfcwxw1s X-HE-Tag: 1738952526-335764 X-HE-Meta: U2FsdGVkX1/LXMS9Ui8YLHgDXB0AmvqfO9xt5kOg+/L4+0Wz0RLoXjPm6tqJ2CQMXnHYEUu76D89Jkyh84EWZlXQ2aEcvTIcd/+7YjwXxXXKwr7yTusEgEh+m7ACw1JbTRZ+v5YBLAASkIwJjYX/Duf++myQk7iY47rcPcTyfOY6zFz4HfokH8IbS7PAioXk0PFyklXMjxKKei5+LKLSxu1vmuiDIQ6yf/CQ56mFZ4F1J7cd+bqSAPPsxjVxraQzCQLKs1Y2i7Xc/z075YYpf+Q0W4C1MZBYvAxMoRCtMHgKBVTNMZjHHGZlxNpACiRrF6drmEZmTr+OpAP3xhBVU+qdmark5WpTmlVp6H8Y1vxzud0xavfSRd/pfaMQwLd1ILsl8a/zYXc9HV120k83H2QGb4C3D/XYkBzUVRP9ZegPu096yBgg0HrAwM80uHRHsKOK+ElqyMl/O5fFiwOsDP3MvD/TEhRe/gyqugkmJcAdFZFfk+YJSEIAozB4WOjlD3y0n02uSLlmbKNKBjq4QWqrJ8yhHD8VBSQcmPAjdJd8x0mLXBlygeaLwsaT0tYqcO8RDf1fGfr1M4W7WB47Z8DvspF4k2V6uMJnObexBhKSLirNzYEUrWKlNC3A9LHVEiNt3SKANTikLSPDzEQip1yg4gVXMWiKXvWUaQnuVSrdNvPoBIcq7T7CgcWfvQxfkkPMFIwg9CNof68Vth+M7HAi/UdV8rZpjQsFrAymPhkeZKX2NLODAx/CBn67oh/jjRosMo6LHM5x/wtfvcI//L++7LehHTNRkoZKqoWGORxhRRE41K0iUZuiOkb7SPIz+9lntVWP48y6xk9Rmfu+gOFkefz+xeznsR+9EYzKbLSEVnKVYWPfLBJyKQJdhtsvMT+/1PHi1giQvJ7b5c7fnV4jrLda7MeYJONcFwlIGqDOt7W7EsCcpmCTD9wTeO0V9W3VnJIjbmjdrd9fAQP pDiNq1+z WwFDtaLbFP8koPO3sYuGkZzqyU6NTYN9+ACsTqidq/6eBcD3Q6fwFM8BoVxgK9a2NIHph8AHd5Zq3h8ybPNM8PWHuuU1pCtk0E19Ng/C85+2Vb0NIUu7Vo892pf/dW7EUgQJhVd7nrZ+zfc2s2gHfHKzgGXSeop4zRXfIrsUVQbqURRrK+69tNLEmDyxIg+mlLprVZWT+se8cIyjOPn9T9NBrbXXzctb/0XvYf77/CPz9Tr47KLsWRzqSuDagPqQ0o4C+IpuI7WNLtaJ02oRD4zFpwzkWPQKnHu63KZoZdWXN1d6OUS/l+y1L1Bh/RlZp9tao+HrWfHVSU6lQX8Wo7q6zwtlhoM5NJOzCXqFDL71FIfIQVh6j4wKMzk1xiCXIdxroR2ZCG67P+6s0waAg+N3XnuI/eopmVOaFPhiXdpfx/1JeXCbepZUcOZklZtp1dF5QwP4SLVOB2kY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.054310, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04/02/2025 23:12, SeongJae Park wrote: > On Mon, 3 Feb 2025 22:55:31 +0000 Usama Arif wrote: > > >> + case DAMOS_FILTER_TYPE_HUGEPAGE: >> + folio_sz = folio_size(folio); >> + matched = filter->folio_size.min <= folio_sz && folio_sz <= filter->folio_size.max; > > We should also return 'false' if the folio is not a large folio (folio_sz == > PAGE_SIZE), if we agreed to my suggestion on the previous version of this patch > series? > Thanks SJ for the reviews. I will address all of the changes in the next revision. The only thing over here is, I would like the filter to work for folios of all sizes, even PAGE_SIZE. It would give us a more convenient way of knowing if hot regions are mainly being backed by 4K pages, and improve observability. Let me know if thats ok?