From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DF41C6FD1D for ; Mon, 20 Mar 2023 08:40:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B8BB16B007E; Mon, 20 Mar 2023 04:40:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B3BE26B0080; Mon, 20 Mar 2023 04:40:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A03496B0081; Mon, 20 Mar 2023 04:40:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 948D16B007E for ; Mon, 20 Mar 2023 04:40:45 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 618F71A03D7 for ; Mon, 20 Mar 2023 08:40:45 +0000 (UTC) X-FDA: 80588630850.17.06C3339 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by imf27.hostedemail.com (Postfix) with ESMTP id 781D140012 for ; Mon, 20 Mar 2023 08:40:43 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ERS1o6I1; spf=pass (imf27.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679301643; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zcKnhemYdKHWThhsxV1AhOlClFynUX4pt1AKusVZUtM=; b=Y/jljm6OxhA54RqIXSIdEB/CArgWZ+k42Wkc/lk4hM0JHkX7YE2fU3Llhanx5Amgxtinmk CcmHud6ttsjMEnY9Bc5iaJ811NUbujwDps/Rq8u3bwN43ExeA6dZYQV79cRjJvB8PDRaUK VGvmwKqnGr2/lI3tFhWYtB7eIlX0ca0= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ERS1o6I1; spf=pass (imf27.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679301643; a=rsa-sha256; cv=none; b=wzvVAEtcLhEwRwCS48x20iUAeC7b6VQSTCNW844rzRkrZpTyhW9LS/JlfpO6J6hu2/7SEO OpxtRhYdPnks3fIc6Vc9sm5PAdi8OuSWSYvmpXePY5DaleVXg86ugM4SEsACGR0p1do/ep tCLh8qWoF31rORG64GAarGLsbEEXi/0= Received: by mail-wm1-f49.google.com with SMTP id w11so5838071wmo.2 for ; Mon, 20 Mar 2023 01:40:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679301642; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zcKnhemYdKHWThhsxV1AhOlClFynUX4pt1AKusVZUtM=; b=ERS1o6I1GyJB1x/Owu+aLzg/wa7KALPuXw34Y5/nyy/FPpP/dQAR5s65Sh+cpgQSUu 2WeXVR2YxURM6pF79L/vGRAHBTxBarR59IUS+PiP5dj2gULIVjfPD8KJT6ZbmmZGa55l HD/gjEvlaOpZNvho7lOMiOcEGfJ43sYrTM+Wo0qM9pqaL3DnjhLRlfkXbtQjc6/1Laj6 HH/PGtwgiA2+UhopsFytxDyc2BROSOZT7bdRokzb9/NpsLXY+DVHJ89IE5Rj3O4PUR5I xuX1PIIwK6DR6izzjFtsik1xfU4aTCr6bGydAA5AWzpaTySlU1uZ6uqqxokT35DkuPlS q3zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679301642; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zcKnhemYdKHWThhsxV1AhOlClFynUX4pt1AKusVZUtM=; b=lSC82FXP8WYMDYv7xRjtYfyHUuXW64h9SBlpwpIZ1jtk3vKpIl2jg8T7jgLx9STRxg Dm4kjoAt3QOesCfvCPowfUUkdoEDr6xIT7aJRDqljdDP7O0icIDTeHIQe3vmn+MXNhw+ 59hT9B/pNzrYzT2GZ075gzFZA3lAxyoG82Y929cZF6tstOTNZcgg8Ls/G+LIa6zTz4u/ Et+viRbHWWgaUjUoq9iZFwf/5BDBuglIxa8zyrFQQtexeYTv4O27xWJbumGRIbS5TA/I J8YZdT7FGHdo775Lgtyz/zjI8JSHH5niXAfODhEFgbfiuX18ZLOzy1WN6nr5JRnDEmg7 hK4A== X-Gm-Message-State: AO0yUKV1ccChCLxtbyWXf5C0G87jfjGfNSKnF9RWHiS/i/bkFXQ2oMLW BJzEbAtqzj9pQFN5cwdWYcs= X-Google-Smtp-Source: AK7set/x80FQjPZUn/3XtHXtVyfMUipTNm59Yq+rktAgdqJxPhM28LN40nX/xK7/Rl6DFvAQKJtv4A== X-Received: by 2002:a05:600c:2053:b0:3ed:5cf7:3080 with SMTP id p19-20020a05600c205300b003ed5cf73080mr12180070wmg.5.1679301642106; Mon, 20 Mar 2023 01:40:42 -0700 (PDT) Received: from localhost (host86-146-209-214.range86-146.btcentralplus.com. [86.146.209.214]) by smtp.gmail.com with ESMTPSA id i7-20020adffc07000000b002c5706f7c6dsm8295961wrr.94.2023.03.20.01.40.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Mar 2023 01:40:41 -0700 (PDT) Date: Mon, 20 Mar 2023 08:40:40 +0000 From: Lorenzo Stoakes To: Matthew Wilcox Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Baoquan He , Uladzislau Rezki , David Hildenbrand , Liu Shixin , Jiri Olsa Subject: Re: [PATCH v2 2/4] mm: vmalloc: use rwsem, mutex for vmap_area_lock and vmap_block->lock Message-ID: References: <6c7f1ac0aeb55faaa46a09108d3999e4595870d9.1679209395.git.lstoakes@gmail.com> <20230319131047.174fa4e29cabe4371b298ed0@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 781D140012 X-Rspam-User: X-Stat-Signature: itk53zdnh16cgpw7n7o1hczpkmsajrbi X-HE-Tag: 1679301643-415928 X-HE-Meta: U2FsdGVkX183BCwaXD9m0GqdukPo2vsb68mLJz0VEjo+Pz2snIfPoR9VaRBQatyKo4edT/ol7KtKARMsZGazTErROUGHxGo8jV+H5NI9vB9KqGztVQQ4PHtFU84nFO0pFMUYxXTAnP0xIIt1jAfeNfw3Ovfpl6f2ceceUr/xt0aUZ6wMQC67MotXJ/RfJduFl0HP43M8m4BIEVYT+aHekDsMXo/z37J5zwlMIneHjxufpGkzgL6mGMOwXV3DBgmq0CxUas44DsilNEybBtzZdpv6DtTHkmTlOCfRhdDimvctwsztLaGwlQr77+qo4YHZF8d5ZYyvU+JKZQqEVqYWyng67XZ6RI3u6/JMts4Un2nO5bb7Y0QI4cq0BJ+/Hr/dVvbcBZNjAqI63cN6xVSZsNL6DCxJnnmb6N3Dti2ZYiXlPXkILnqZgGzC6GSqPpxK/7H8o4yuqCT1woqB5W78j5WCKz5p7eAwz11o1oa+g0UhVp4UsqE9d2zRgFx0hc+MzcjZO3qnWBk2affFL07wXeHYCKoBQIACwla4ry80R3aZjwtCogEEYHUV0Jx6eo0HFEaJBj9Knm2xLP0j8qaxPgXlIKfOKjUQBhGNmvyXak73ma1FtsU/fhHHWSD8rwLxkv8e9U65EUEZR93QzYleK7kLgzXDZMXHG99m9yC8sIdxDEuneZWBiFHKPoy+lji6LrKU8NccamAeQiQQu+fZprz9TbfDeM9X74VxqRicVJkfQTHPYidmIlMioKLu5Vd69Owd8rkYLHkakvGnOKvkMuzoJ3JX+PImyF31yQO0Lr/0xo6ikJlS21epaWQyRhu43SX/EHOo83feSRiC5hN/5xbruK4n8G58Sjb+OxQDeXqg0mFzIrwb8sw8MkugK4So/EOjWYGL5aIpNdhiifdKYtN6EAiLgZP/9G97Tmq7u43HpU4i9Ge32e5BHlKEHz8VPIIb2OFud4CKPsI3x36 WYyNTSuS eda62zfB1BB8zEH/dY/3j1DZExDOuzjQW6b8uLY1IHmQT1Fcsnpt3GIkPMHCz93xMdhOHius6u1V/RIzDTvS2k1LtfvEw2hp3pHZuDMYfOiU2apH6r87FSnFBkf8h6TQcKC2RAgsuLiWuo4vAjtGjNiT4/Mq/thkPDmbOboQdvAdIWMe3hGNNmt3Z6lqRO53DNwRGzrj0O4qBZ/Dhx4K0wvlIYvEMC2f6oMC+G5W0iAqgxonRaWMm7mN4+ES06Vqz4Dx6gvhwVEXN9Z1nTqUyoZwd6zjvSpagfjEy3t22QLQYagPmpFuXWw1d6CoXzN8NS9oTBaPlc1Xj+4qqMLV0fzhFDGPMd+bSRmBLiKb0RAp8XSdhKmrDfQ/P4sT3LvXaF3roe1KJQrSFWG2x8p8g6pTdtD4uqCRWCHVmlcFM2xItZI9eITgUFgD3r6JuHsGHpMpyYOXEqEpPyug= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Mar 19, 2023 at 09:16:18PM +0000, Lorenzo Stoakes wrote: > On Sun, Mar 19, 2023 at 08:47:14PM +0000, Matthew Wilcox wrote: > > I wonder if we can't do something like prefaulting the page before > > taking the spinlock, then use copy_page_to_iter_atomic() > On second thoughts, and discussing with Uladzislau, this seems like a more sensible approach. I'm going to respin with prefaulting and revert to the previous locking.