From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B7F8C54798 for ; Tue, 5 Mar 2024 16:22:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CEF736B008A; Tue, 5 Mar 2024 11:22:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C9FB66B008C; Tue, 5 Mar 2024 11:22:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B405B6B0092; Tue, 5 Mar 2024 11:22:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A34AB6B008A for ; Tue, 5 Mar 2024 11:22:36 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8071D1402E3 for ; Tue, 5 Mar 2024 16:22:36 +0000 (UTC) X-FDA: 81863503512.02.CC38E0E Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by imf14.hostedemail.com (Postfix) with ESMTP id 4D19D100017 for ; Tue, 5 Mar 2024 16:22:34 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b="IE UIzBp"; spf=pass (imf14.hostedemail.com: domain of quic_charante@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_charante@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709655754; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GyoOYjG8AtCJtTRhGiNbiHQkvDveoZKQApi2jC3g58k=; b=4g1y/dU/O9hHPoxkBvlgSLTxk0AjIvXtifbfixYL5iTvia76YYbfOXTiA0RZjHw7OtWjc1 yNtyXICAQO7F6+mgKQMjfKkFa1yCja/IaKTsdKOmMysRT6/zWhyE3Jv+6gC1edLWocPNwN EcqDonAavH4fGGvp7S8yYSVa45gpf74= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b="IE UIzBp"; spf=pass (imf14.hostedemail.com: domain of quic_charante@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_charante@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709655754; a=rsa-sha256; cv=none; b=uzR4R6pKN3ydnhFzzTU1KAx4j/xKjI4cwAkLyVhO2tfSvGc+6HKSSr4gxOdcs/8g0UVeKM ezX64zmHznNmGu43vB2FMbOG2vompcSjlxNgShoVCHK2//9HLrLmIe9HrCbjqODexANUC3 gsHE2U4NwV06buzUe2TqS1OpwLBL4YQ= Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 425CLq65007611; Tue, 5 Mar 2024 16:22:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=GyoOYjG8AtCJtTRhGiNbiHQkvDveoZKQApi2jC3g58k=; b=IE UIzBpmbQ5oDCBbENjheptH8ZmQBzOAoIG55eYs11DgpGZERt5BqyvYQ26m9ct2ay N1mW97LLfrUrjhwDtzjPw/HPMMVf40RsQmqxB26GAq5JKJ4hDR1txyAthfMFosCv rSC51lh88boqgb30zsUktxMg+0o8O5JWt6GVkmhUjQwzIQLK+wj3VirzqE8R6srY UYudnXexe+MQZklXAa7W/W0V8M9qiwGZE6ZAX5K4owGOQh3b2+T7NNVq5BkZASOK baShFCQFslxDGw0QIDbp4ePpUHt+bU0CoVGAaamZsxp59YdU26Cf1wiXP7zjz2IW vGu+RsSOw7esP8SMiVGQ== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3wp2uwrk43-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 05 Mar 2024 16:22:19 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 425GMHhb017244 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 5 Mar 2024 16:22:17 GMT Received: from [10.216.59.96] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Tue, 5 Mar 2024 08:22:14 -0800 Message-ID: Date: Tue, 5 Mar 2024 21:52:10 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH STABLE v6.1.y] mm/migrate: set swap entry values of THP tail pages properly. Content-Language: en-US To: Zi Yan , , CC: , "Matthew Wilcox (Oracle)" , David Hildenbrand , Andrew Morton , Huang Ying , Naoya Horiguchi References: <20240305161313.90954-1-zi.yan@sent.com> From: Charan Teja Kalla In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: e7we7gjyIBSNQjU32dfUfXrz-1EycYy3 X-Proofpoint-ORIG-GUID: e7we7gjyIBSNQjU32dfUfXrz-1EycYy3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-05_13,2024-03-05_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 lowpriorityscore=0 phishscore=0 spamscore=0 suspectscore=0 priorityscore=1501 clxscore=1015 mlxlogscore=999 impostorscore=0 mlxscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2402120000 definitions=main-2403050130 X-Rspamd-Queue-Id: 4D19D100017 X-Rspam-User: X-Stat-Signature: wr4ytxaq5dx7py9qytxpecgutuft8yg3 X-Rspamd-Server: rspam01 X-HE-Tag: 1709655754-431144 X-HE-Meta: U2FsdGVkX18xOAXOLn8ZSwzXTaGiAIu+BgvtekD2t7gtpttGW5wQJ5gown9YAVwSnsED6GI6CsYfYcSs482ddapCyxF0BOVWxs95585gki/oY9D8I+bwYlOnxWj3Ks1zLVV7fR8LgPWou0BjNjYjhMfW1gmktwIdL4y2JJF93uPnisywatYOCvayTNTcH+0j+GcNQBUaxhvgamwXR8QB3GEZN0IYJawrkghKrWzpSqqurf/6kwQU0CmvypUdub+B/cGgihqczh2wEz7l65Hm4S1LJA1SDUXe13np3PDt21FAJOjiQS1qcafwj7EXc9gPV9xktt9O/+aC6Sh7Y+c2vQbUFVwk4ZPEfGfosR7bjSSqArkZJal/Q7urw+XJ+KqbjdMU0odvvx7/la0/zv2mFOxO4X30SLlGH5c6dyP+N6OR9gKRMrtThmllgENLU1Q39d462FrWa+rpcNuAXBySF4d3oiSFQWpxMouRzKhdeeqnmDAN+Qcrv/YhcKeV7f3ptnItZFAWUb+kkiLIPPJ2v3cGeE7XHDESf4h6XzTvd1/z8qFjQXxKWZPj3tnR1p1L8/MkvlOYLyVzI6C4J5X2B5MruHny6i2RNxA8RnOcA+5cb6zaIYkRzvuyhjgksCO18oOfQfWtCDWU63aNS8xwd+gbHtZtWhRlvPcZMqA2eiopzWMY/KY4Rzm5OMUBnQZkUoeE7L8KUcxxMSPqt3uAA7nY/YBkgsZW7UUQg0zvPFZvlfbThEMRVvo5aU3j0o1muqMzbCiINu24TqBsNinWgur/Jq19HoV7T5hWLvfUURz2dJ7Bl1lQZjRpf7Jvv/6N7p9EaZteA04HLpD2SOFTAS6j6SppzKkokUClVqZhWySXTnFPTCfnN+l/3xLa+DLF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Thanks David for various inputs on this patch!!. On 3/5/2024 9:47 PM, Zi Yan wrote: > On 5 Mar 2024, at 11:13, Zi Yan wrote: > >> From: Zi Yan >> >> The tail pages in a THP can have swap entry information stored in their >> private field. When migrating to a new page, all tail pages of the new >> page need to update ->private to avoid future data corruption. > > Corresponding swapcache entries need to be updated as well. > e71769ae5260 ("mm: enable thp migration for shmem thp") fixed it already. > > Fixes: 616b8371539a ("mm: thp: enable thp migration in generic path") > Thanks Zi Yan, for posting this patch. I think below tag too applicable? Closes: https://lore.kernel.org/linux-mm/1707814102-22682-1-git-send-email-quic_charante@quicinc.com/ > >> >> Signed-off-by: Zi Yan >> --- >> mm/migrate.c | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/mm/migrate.c b/mm/migrate.c >> index c93dd6a31c31..c5968021fde0 100644 >> --- a/mm/migrate.c >> +++ b/mm/migrate.c >> @@ -423,8 +423,12 @@ int folio_migrate_mapping(struct address_space *mapping, >> if (folio_test_swapbacked(folio)) { >> __folio_set_swapbacked(newfolio); >> if (folio_test_swapcache(folio)) { >> + int i; >> + >> folio_set_swapcache(newfolio); >> - newfolio->private = folio_get_private(folio); >> + for (i = 0; i < nr; i++) >> + set_page_private(folio_page(newfolio, i), >> + page_private(folio_page(folio, i))); >> } >> entries = nr; >> } else { >> -- >> 2.43.0 > > > -- > Best Regards, > Yan, Zi