linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Andrey Konovalov <andreyknvl@gmail.com>
Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com>,
	Alexander Potapenko <glider@google.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	Vincenzo Frascino <vincenzo.frascino@arm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	kasan-dev@googlegroups.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kasan: Add abbreviation KASAN to init log
Date: Mon, 13 Apr 2026 15:54:34 +0200	[thread overview]
Message-ID: <ce76f184-e463-4bfa-afab-0a71f05eb587@molgen.mpg.de> (raw)
In-Reply-To: <CA+fCnZdA6GzHRifhwKCU4pfZrHxzr-btOeaZqgH7KnNLme2u3A@mail.gmail.com>

Dear Andrey,


Am 13.04.26 um 14:37 schrieb Andrey Konovalov:
> On Mon, Apr 13, 2026 at 11:40 AM Paul Menzel <pmenzel@molgen.mpg.de> wrote:
>>
>> `sudo dmesg | grep -i kasan` comes back empty, at least confusing me.
>> So, include the abbreviation in the log line.
>>
>> Before:
>>
>>      KernelAddressSanitizer initialized (generic)
>>
>> After:
>>
>>      KernelAddressSanitizer (KASAN) initialized (generic)
>>
>> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
>> ---
>>   mm/kasan/generic.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/mm/kasan/generic.c b/mm/kasan/generic.c
>> index 2b8e73f5f6a7..1fccf7cc9fce 100644
>> --- a/mm/kasan/generic.c
>> +++ b/mm/kasan/generic.c
>> @@ -44,7 +44,7 @@ void __init kasan_init_generic(void)
>>   {
>>          kasan_enable();
>>
>> -       pr_info("KernelAddressSanitizer initialized (generic)\n");
>> +       pr_info("KernelAddressSanitizer (KASAN) initialized (generic)\n");
> 
> I think a better change would be to add:
> 
> #define pr_fmt(fmt) "kasan: " fmt
> 
> to generic.c.
> 
> Similar to how this is done in sw/hw_tags.c.

Isn’t there only this one log line in `generic.c`, so the generalization 
is not really needed?

> And arguably, we could also drop the "KernelAddressSanitizer" part
> from init messages, to make them look like:
> 
> kasan: initialized (generic)
Some analysis scripts might already depend on KernelAddressSanitizer, so 
I’d keep it.


Kind regards,

Paul


  reply	other threads:[~2026-04-13 13:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-13  9:40 Paul Menzel
2026-04-13 12:29 ` Alexander Potapenko
2026-04-13 12:37 ` Andrey Konovalov
2026-04-13 13:54   ` Paul Menzel [this message]
2026-04-13 15:05     ` Andrey Konovalov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce76f184-e463-4bfa-afab-0a71f05eb587@molgen.mpg.de \
    --to=pmenzel@molgen.mpg.de \
    --cc=akpm@linux-foundation.org \
    --cc=andreyknvl@gmail.com \
    --cc=dvyukov@google.com \
    --cc=glider@google.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ryabinin.a.a@gmail.com \
    --cc=vincenzo.frascino@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox