From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A50BC36014 for ; Mon, 31 Mar 2025 20:49:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E90EF280002; Mon, 31 Mar 2025 16:49:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E175F280001; Mon, 31 Mar 2025 16:49:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB958280002; Mon, 31 Mar 2025 16:49:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AAD48280001 for ; Mon, 31 Mar 2025 16:49:17 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 313B7160326 for ; Mon, 31 Mar 2025 20:49:18 +0000 (UTC) X-FDA: 83283036396.09.84E48AF Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf28.hostedemail.com (Postfix) with ESMTP id 9870EC0006 for ; Mon, 31 Mar 2025 20:49:16 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=G8LUdss4; spf=pass (imf28.hostedemail.com: domain of da.gomez@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=da.gomez@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743454156; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dKcoFdjXYmMz+uHs1GhXsDDdPc12WNTzQlI5GnJcHIw=; b=u0pmgRNwkOVf8EPaw5FntLT2CyAyeBynBv0RpqkHUEhjwkaxphwPy4OCsFPLIGwRztpewo He3OQLDJOjJE30lcDhCKlvppV/gESaB8zx3kKIQlaCBbXyMnyK9tFqGTH+E0VfmTALp6Cd jP0p5Amd6i2ZBoF4Ms52xyQNbwwq1V0= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=G8LUdss4; spf=pass (imf28.hostedemail.com: domain of da.gomez@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=da.gomez@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743454156; a=rsa-sha256; cv=none; b=TO6vKnwv8eThQLI6iOccl5AE3wqG6y4u5jHre2peXv2bZdlqBLO7oIHggTRug471MwL8vF lyf4fBe0Q9RQsDCi+aWazVeJi7St0RVe1WoZ+VZK4tRsrhPxPTRrkCJLnBKc79zl+3tmcA lrBs6N20V9Dp746dv6CpYtpPFa6CdMU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 1A213A42E58; Mon, 31 Mar 2025 20:43:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23E29C4CEE3; Mon, 31 Mar 2025 20:49:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743454155; bh=Zuyvkaus9ewz8j94k6nzMD+kOEvczQsm1hQlczpTEak=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=G8LUdss4E5AxEZy8XEcjSklmagmZAUi4p9h5yIettaAJls0JLcXdCSlEHWFx6gTAD YW3gey9S/iApGusZAZPbY0N+a3q72ewx08QMttiuq7dTkUHuzJWJQaIO0pegONx8wF HWCSJVWudEeWC2cS0mwC7dFrEfkuyC7UA9aiGCTh6l301WLCnNJHsFzrrX+CRZZWSi cniPvo/SbmUd12U3cr3qiLUzHxhdUUkASMy68+G7i95IAkthh3dRrvWfZ2L31f362x I/8B6uy/nL5YQ5yD2C4kxeu3YbvDJHE5pqJly2PbiFw4LIXDa82wPNXmfaAytm1iiP 2CZYH67vbUVvQ== Date: Mon, 31 Mar 2025 22:49:13 +0200 From: Daniel Gomez To: Sidhartha Kumar Cc: Peter Zijlstra , Ingo Molnar , Ravi Bangoria , Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, gost.dev@samsung.com, Daniel Gomez Subject: Re: [PATCH] radix-tree: add missing cleanup.h Message-ID: References: <20250321-fix-radix-tree-build-v1-1-838a1e6540e2@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 9870EC0006 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: tgxe4k3jyjz5dkffdqucrpxq7ohuwitw X-HE-Tag: 1743454156-945216 X-HE-Meta: U2FsdGVkX19Yr6HfJB/QTRB+P4hQsGkkG88cYuokRAjfpebFkyEkmgCA6lGixVScT9dWtw0wZ5LXCq7c5J6cKhVw5O9WCdu5vazG/+6HAWOhDoJtXkYXQZ2cVaGRefCDi6wx2jAZ/aAok4++vHeKeWYIzNqBGSuq71S9Lbtf8IxkPtJlSfH8bzIx58fZxf/ye8ehKXbSd2BdCyuuIoW7EOGHin80yBtGrzwUPN3ahGkFhxPxsHANTFXDwmHW2WVeeCgZTY6VIYb4AlYA2kOaPPtg+wrZbdg2L9Nj1QbKC9GHLTl5JxSQf7Jl6XtMOdiGcf6ZoENvIjKlO74M0Ip+TYyMCOPeThZDmeJk0m2q1U63CmDo5RQEO26psAPpY6/MHCmW2+vLVIo9AyepZHpc8gFwtVpFHkAs/90sZDIhC/OhiLVUNKMPrZDTaFgDeyCD8/bAYNL48YlhFadWtHOAwRI8VLlVJcedduPLkcNcJqIVrADQppoSKU2v3RqbBUVULqmECzil4xqBb+Gfl8d9dODoDoRfJBqCjDn69B5nbLuwhRfEFJtM1hTIepBfQ0NoCxcGeGwxtcRttWwIFyfXsLYx/eyGSxzoWd0SwEFB78TkOgWJkYlEYLSo7DIy5WKQ/iPDcrkiJ8ZikENJfGwV/lVJBop7YKwwcR6nsvJ0H/0yMZ5ZlonuH7avCUIkdDBDp/Yrxptih/efRKmIs2nNCxcKW4T1lzo9jp5JnSKCkWMI1Ox+LrAW/tQGn8NnU1yHw7Yd4kx5xriAyI8CoaFn5Gmsx44XVkI9wWRzyshNTC/AOrWK2SbiUbpNMh5bbJWHvOqcduJI7Aj8Bv94pb1ANWuTk7yj2KqcC37o1R4ix0HSlh91ObdxHTdX4JL8O5WjnU58yl+v+xRJtVd9wkP7jNu/A2GecWt7u7aRaWonzdKLs+QX6u1dJtHR5hj0kypBaIB7/c/7jBp6KlAiKzR qC6n5rHv 24oVrODbvqPuhx1P3n3yWZ6AYVFxZJ4xyeknJp4FgRfx18g0ycN7883D14QNSb7uW5jkg9ZL4xXUDzo4vxek2l3SvV+whnFfTkrbvikXd/+GloJ2m27I/61/A4rcqEzIGZYK1IB1XERT6pqjNqFochKBZU70zJD2OKDoRPNsfjCiuViUA7VHnkTyuHXaZ9Ft3By4WhWzraq+z43kHyI4UG+RGY/zp7JxtrkdZEC+MCc1jaNWRFeqtKFChIK1fs76nKcnM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 31, 2025 at 02:21:50PM +0100, Sidhartha Kumar wrote: > On 3/21/25 4:24 PM, Daniel Gomez wrote: > > diff --git a/tools/testing/shared/linux/cleanup.h b/tools/testing/shared/linux/cleanup.h > > new file mode 100644 > > index 0000000000000000000000000000000000000000..6e1691f56e300b498c16647bb4b91d8c8be9c3eb > > --- /dev/null > > +++ b/tools/testing/shared/linux/cleanup.h > > @@ -0,0 +1,7 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +#ifndef _TEST_CLEANUP_H > > +#define _TEST_CLEANUP_H > > are these header guards needed? I think that is correct, it's redundant as of now. Perhaps it could be removed when/if merged?