From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9063C4345F for ; Tue, 23 Apr 2024 11:38:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 541666B0100; Tue, 23 Apr 2024 07:38:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F1786B0101; Tue, 23 Apr 2024 07:38:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36C436B0102; Tue, 23 Apr 2024 07:38:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 189AC6B0100 for ; Tue, 23 Apr 2024 07:38:07 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 90FFBA0EE0 for ; Tue, 23 Apr 2024 11:38:06 +0000 (UTC) X-FDA: 82040597772.14.30D043E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 839362001A for ; Tue, 23 Apr 2024 11:38:03 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=b0vX4Zxm; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713872283; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UjO76X3N8uiKE88qJacfJA8nBoOAkuwJW8I/qg5fWk0=; b=bOWpdtGYj1I0EnK7G+i/hdjo2D1mQk2hd+pDtV+ypHCIV11FmgdK5GZ06jK97SJZM31f62 8lnZRd30N0MVbiWSdXiQddCkFdFYA7QSpe9MCwjS71C+Zi6ItOErp38pAYXSy9oZjgI27U zQ3U6qqRKgsK8M53COw61HUvxLqXBeU= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=b0vX4Zxm; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713872283; a=rsa-sha256; cv=none; b=FlZ24y/0MlOqFxMnPjl45AMvIseWPEfKw4ekJ7ZibAK4XTdF7LuwFqX7zh0F/OtICMG0Nj 8tvSzogUJCCMtejKWBTATc6JlaIzXIDIAWATV3f/D2MCoSvBvMlM6B2R8mV2wlvGqon6wC WTPdRfzRpOrb2jfrODpHrh+Y2lBJ/Q4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713872282; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UjO76X3N8uiKE88qJacfJA8nBoOAkuwJW8I/qg5fWk0=; b=b0vX4ZxmvR1Z+fGwjkXv5MD/IQupn7vOknVv0AyDQ9ZPeTOi0L9BPHgQrDIfcGo4lnCTpO /Uyedg3t0PO3gn0lXqC70Q1wElkgFAhJZ18hmZ9bdepIMvsXUdR+6Lfc215Yw13koctmPU 17xIgdzuAzyeNJoaSBzPjaXojEU2D8A= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-325-YaVo6avEPc2wulYxAPOzWg-1; Tue, 23 Apr 2024 07:38:01 -0400 X-MC-Unique: YaVo6avEPc2wulYxAPOzWg-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-41a074e2d69so8813905e9.3 for ; Tue, 23 Apr 2024 04:38:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713872280; x=1714477080; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=UjO76X3N8uiKE88qJacfJA8nBoOAkuwJW8I/qg5fWk0=; b=G9LcpseT4kzaYWJc4LHB7ur1klQOaf99l/HVdOuLuD+QNtIolrlNPyS0tJE/gCVNIr EHw7p3lxqeocjP0pU3HRaw9X3vq/1T/5OI1GvSRp44/C/S9EfZrvc2PFLSaIsTk3vqDX i1WuHFZyaqx2+wCddOAX2N6kZgx+2cRvwOXJTUrCvC4krSRSYCEA0FmOVT94JfOE/K+c TJJxEEMW5a9IO4VnCcEKRa0aYYx9RlWsx8Rk+EPgTVIm1bxn6DsyeQ7BTvsIr4NlHep8 5NNZgP0XT3P+KzpbayUWjfO5wwF6xkv0pZ1DM6/4NjoVHJpN8/YTsaHDcy8z3orsUUB7 v6Mg== X-Forwarded-Encrypted: i=1; AJvYcCWXULHjJ8reyID9uVrba2Hch52kom/J/2a4jgg73mzE50SGGFqfJKgRhmrhQ4h9xz+UhPUIRTO09bcPK2moee7lGrA= X-Gm-Message-State: AOJu0YxRw1V4FfiQHo5BkRhfS1t4nwoNo4fyK8MPvhw0NDHSfoh9m0bO ujM+2ztPihBRy9e7SOE7jkdouPKPmFSCmTi8VK1fy+gLvzoSLW7fauOPrY3hURveTxa6fC84nlL nB7jhkpBAdTDHMD/yuLBIvA20XKd1dJw+/ZG/vT0O/QjRH01C X-Received: by 2002:a05:600c:3b10:b0:418:7028:f4d1 with SMTP id m16-20020a05600c3b1000b004187028f4d1mr7529856wms.29.1713872280082; Tue, 23 Apr 2024 04:38:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE+SBvBWK4zAuvmISam4UyhDQKPzV1AN0dxSk+xrNs4wuppufjh+2jdJS2rmQYR/OJiIjrzkw== X-Received: by 2002:a05:600c:3b10:b0:418:7028:f4d1 with SMTP id m16-20020a05600c3b1000b004187028f4d1mr7529833wms.29.1713872279659; Tue, 23 Apr 2024 04:37:59 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:fd00:fb07:92f8:8f0c:6a08? (p200300cbc706fd00fb0792f88f0c6a08.dip0.t-ipconnect.de. [2003:cb:c706:fd00:fb07:92f8:8f0c:6a08]) by smtp.gmail.com with ESMTPSA id d5-20020a5d6445000000b0034659d971a6sm14321746wrw.26.2024.04.23.04.37.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Apr 2024 04:37:59 -0700 (PDT) Message-ID: Date: Tue, 23 Apr 2024 13:37:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 5/5] mm: shmem: add anonymous share mTHP counters To: Barry Song <21cnbao@gmail.com>, Baolin Wang Cc: akpm@linux-foundation.org, hughd@google.com, willy@infradead.org, wangkefeng.wang@huawei.com, ryan.roberts@arm.com, ying.huang@intel.com, shy828301@gmail.com, ziy@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <05d0096e4ec3e572d1d52d33a31a661321ac1551.1713755580.git.baolin.wang@linux.alibaba.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 839362001A X-Stat-Signature: 4kizpemoqbfz75q77yhgu4osam3kyide X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1713872283-717520 X-HE-Meta: U2FsdGVkX18V+BWTKWXYbsbwA4Y5mnUQrtS3ffBrKqGA9e5kPydmugnRTCsJ7Q8mZJ2CCpN9MHXHI0IX+rHfMb9XhZhFOtUd18ju2BKt/LD5jCDnmNaCCb2AkXk7KmwKKIr21WVMTPsC/KzT42WT5Pv8ckhji0HUtnKBbR+47BCFhp1BqG7npbWBVurFyQvezGdUsWia0uR08PQlrpGMIbZuS7Z0CjujvoPTQnbMbVQud1XsZOMOPuwMCu4188GB+5Jm9blnlWyK3xiPgSDUIpdZ7mnfP9D0134dooNlWe91Qmmmki0Z0uEDl/xXO65gkEVdg9MwJC2AstgPB9KVeZ/P5lgHgcOH0t8qeALugAPoX5xJXkrFLw1DNxuskb40WlKat5imnjszUuJPGmyZZnXLcg5zEpuxsCaq4foTrBeTASG8c3lPcviRy5KYnqwtl/bvOYiPNysuz6xYJ0ZvMVdmWhuzMF6MDJow5Lurpn8X3HKomFKbUYguw2pDzDmBJt7bWoGNSSEiB++PrA05pQNBadzV8uotoY/xmOa2ChnGRwn29WdAp8RfCexaZz+emnHpiA6T3aauJAN7N/tffFr2dNqOZhnuwpaGlqlrAm5Lal+QNs8YTm//+40keFUYSzMA+ODM3f+PKPcCdsQlFPql2S0wGCziFC6+Db9SyNMib2P3u1OSZStCRaxmLl7lWZw9YkK6X4DIiMfv0fo5y/kZh5cRo39hAhSbp84lS5QAtA/ApgkI82hNDokQ0Ojb6RkWekR4R+0w89WRwRCqFFoOXbxQfpE/bvNbbX1LZ8Og40KCntgE6ziSx6PEgBcFGxeWwI1bcC2ZKHQoQgMLpZTwAxlwQgyCAAagVXxlTcYEFK9qphw3/QzUHma4JPGNEIISyjXoi2fNG0eVfot0IxWwaGbozE8+BnAS+0JK2uGx89d1jH3XIrtN3E0LHJwuxinfYCdMmxQmkMv55p5 sIfEs6TU 0F7M6C9MrmTOoQYdXno5E6Ff53rrW17S3wdoGkL3aZ2UYG4Lj/YaL2qLuzBYS+EHHU5NNv8izpQqvPEDS3dBrWtHQrwf4lZ6dF7hMA4SZLrtQpbnzFpOoFy9tX+SgzVkMyiL4aLCmK/f89QWXe9xLbmn4xbVZy1hJEzuncYVfijDn0pw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 23.04.24 03:17, Barry Song wrote: > On Mon, Apr 22, 2024 at 3:03 PM Baolin Wang > wrote: >> >> Signed-off-by: Baolin Wang >> --- >> include/linux/huge_mm.h | 2 ++ >> mm/huge_memory.c | 4 ++++ >> mm/shmem.c | 5 ++++- >> 3 files changed, 10 insertions(+), 1 deletion(-) >> >> diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h >> index 26b6fa98d8ac..67b9c1acad31 100644 >> --- a/include/linux/huge_mm.h >> +++ b/include/linux/huge_mm.h >> @@ -270,6 +270,8 @@ enum mthp_stat_item { >> MTHP_STAT_ANON_SWPOUT, >> MTHP_STAT_ANON_SWPOUT_FALLBACK, >> MTHP_STAT_ANON_SWPIN_REFAULT, >> + MTHP_STAT_SHMEM_ANON_ALLOC, >> + MTHP_STAT_SHMEM_ANON_ALLOC_FALLBACK, > > not quite sure about this. for 2MB pmd-mapped THP shmem, we count them > as FILE_THP. > here we are counting as SHMEM_ANON. To me, SHMEM_ANON is more correct but > it doesn't align with pmd-mapped THP. David, Ryan, what do you think? The term "anonymous share" in the patch subject is weird to begin with ;) Easy to confuse with anonymous cow-shared memory. Let's just call it "anonymous shmem", which it is under the hood. ... regarding the question: if we add FILE_ALLOC and friends, at least initially, we wouldn't account other large pagecache folios. ... likely we should add that then as well so the counter matches the actual name? If we later realize that we need separate FILE vs. SHMEM vs. WHATEVER counters, we can always add more fine-grained counters later. Doing it consistently w.r.t. traditional THPs first sounds reasonable. -- Cheers, David / dhildenb