From: maobibo <maobibo@loongson.cn>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Andrew Morton <akpm@linux-foundation.org>,
Paul Burton <paulburton@kernel.org>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 1/2] MIPS: set page access bit with pgprot on some MIPS platform
Date: Fri, 5 Jun 2020 17:51:43 +0800 [thread overview]
Message-ID: <ce625c9d-a4bb-7138-c599-62b30b65c408@loongson.cn> (raw)
In-Reply-To: <20200605173909.000018ff@flygoat.com>
On 06/05/2020 05:39 PM, Jiaxun Yang wrote:
> On Fri, 5 Jun 2020 17:11:05 +0800
> Bibo Mao <maobibo@loongson.cn> wrote:
>
>> On MIPS system which has rixi hardware bit, page access bit is not
>> set in pgrot. For memory reading, there will be one page fault to
>> allocate physical page; however valid bit is not set, there will
>> be the second fast tlb-miss fault handling to set valid/access bit.
>>
>> This patch set page access/valid bit with pgrot if there is reading
>> access privilege. It will reduce one tlb-miss handling for memory
>> reading access.
>>
>> The valid/access bit will be cleared in order to track memory
>> accessing activity. If the page is accessed, tlb-miss fast handling
>> will set valid/access bit, pte_sw_mkyoung is not necessary in slow
>> page fault path. This patch removes pte_sw_mkyoung function which
>> is defined as empty function except MIPS system.
>>
>> Signed-off-by: Bibo Mao <maobibo@loongson.cn>
>> ---
>
> Thanks for tracking it down.
>
> Could you please make the patch tittle more clear?
> "Some" looks confuse to me, "systems with RIXI" would be better.
Sure, will add it.
>
> - Jiaxun
>
next prev parent reply other threads:[~2020-06-05 9:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 9:11 Bibo Mao
2020-06-05 9:11 ` [PATCH 2/2] MIPS: Add writable-applies-readable policy with pgrot Bibo Mao
2020-06-05 9:39 ` [PATCH 1/2] MIPS: set page access bit with pgprot on some MIPS platform Jiaxun Yang
2020-06-05 9:51 ` maobibo [this message]
2020-06-06 1:08 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce625c9d-a4bb-7138-c599-62b30b65c408@loongson.cn \
--to=maobibo@loongson.cn \
--cc=akpm@linux-foundation.org \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=paulburton@kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox