From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3166C0218A for ; Sat, 18 Jan 2025 16:13:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D31806B0082; Sat, 18 Jan 2025 11:13:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CE1636B0083; Sat, 18 Jan 2025 11:13:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5AD06B0085; Sat, 18 Jan 2025 11:13:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9802A6B0082 for ; Sat, 18 Jan 2025 11:13:12 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id F2D6D1A033D for ; Sat, 18 Jan 2025 16:13:11 +0000 (UTC) X-FDA: 83021066982.26.6FCE264 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf16.hostedemail.com (Postfix) with ESMTP id EEACF180003 for ; Sat, 18 Jan 2025 16:13:09 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="mgzM/Bm6"; spf=pass (imf16.hostedemail.com: domain of groeck7@gmail.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737216790; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PRxl7tw1tBVTf8wfl2sTflbbSC/aCmrPpnmfRo4YyNE=; b=p9NblobdePSm5/BS2tua4HXCrdV0uI9IvJOpQsmo4CHjUX3jMpbAFcfRGHghrNZZmBZsT7 tZv4sCDAmK/1jzbPevQObpdJ0JYlDFVJIWsmsbWd0VzNnM8vdmAvA6spdgVpwuRQQ3VuYe Zvra5+YI6OniOMAH4/6EnuOa2S6/Ysw= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="mgzM/Bm6"; spf=pass (imf16.hostedemail.com: domain of groeck7@gmail.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737216790; a=rsa-sha256; cv=none; b=q80yKboZVBmsR3sd4LMa0GUx0Sintx2fGUzPewLQxwQwGm4b13DNzX+ipcHz9kKIbnyQLV RbVT/soKmq8MZ20RfY0AzShcMNbVsgxCM4jabpYi/WIA88V6i0Z47t3hIDnUymyZwmcmeX eU2nLSyz8wtkaNWxLRxGzU27bXuwM7c= Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-219f8263ae0so57729715ad.0 for ; Sat, 18 Jan 2025 08:13:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737216788; x=1737821588; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=PRxl7tw1tBVTf8wfl2sTflbbSC/aCmrPpnmfRo4YyNE=; b=mgzM/Bm6q255JRdLJi64dZUB/PhJSE7NUY69NKmBGh2dztVhpvYEloH3aNMbbsvdLZ 2xDCXJJVA/B1VnsUsSCOdjyLGj4w7YCYqHtFvODUssm8QsIkJ5YC8JLgaZsHhaQEOWKF CrBSSRcWscJIPQasf97O+u962xgZa+99JcknNJHIq87D3SvA3ZYXmRZV/rBWly3SjL9A R4DPdqSoA749xRGc5s2uWDiBwIMw7widBIYPlheeePbhX0XbjEy21LswczFaPt3RcAmf xfALrN0Y+Qz0mwKwv6UzHsszlQHxclMP8Hidt3z5DWqNKCT6aTXuidzEZdY3osE2Xliz zp4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737216788; x=1737821588; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PRxl7tw1tBVTf8wfl2sTflbbSC/aCmrPpnmfRo4YyNE=; b=iVOvqkZHJ8of0Dwlc6afynONRu6dXyCAnvhbKb5DljifQpU/8lOe6f0opuGm8u+UMP wzcJaljzf560VMwxBGxdcJ7rUhc097WZcDFVeGzC0HlqOVVEroP03rPoVivMQ/CyjkE/ z6zFdpGH9mAZ7UNCboEGSlTALo82+BcPtzy+xhixQlpYrF8BoIsfmV4oRQ0Kkt/tT7vc eKcC7Y+hzA8o2JzP7QDoJ6fNkWM4EOrJjaIyx3JAo1XFGh223UG+QRJv4Pdy396jQ1S1 gzGRbjhSkI8oOKPtS9vQV27hQvIsY4TmEdgFd8uSRVhKh1aDHLdV1V+bMMJxmJBaixNE 1wRg== X-Forwarded-Encrypted: i=1; AJvYcCW3F0+7MI7XE5E5bg9ASsSaJCeqzrxeJHAK3NaG8gQ1Z2WnrIvMStMt1qRzQuogM7sMOxuH551pew==@kvack.org X-Gm-Message-State: AOJu0YyCOJob4/6/F6rqFLRE3Mdn6rEGoFwML5D8gpCmSgrUvG8cD51G c3dmDGmjBcd6pLmZ+RAmIEInqAvIcm84hpXKbXr9Ht8xQ3/XOjC0 X-Gm-Gg: ASbGnctbDK1UZSV7H32agwRzIuYtIz6v1T37Mn5qNNTnP8zkL/pIoNaWfbaHMt0PqxV a1kRPSlZ+ZHRRTRMM9TTKCFhdu6kYymS7ZFG0cAqu+VBHSvG5ONZD213L92zs7BgHDw1W+Z331P mIizxpEoDRSVJEJeegLKIr1+c1lr1u7DWaO+VTZ+pf/FbQPnbd+eQDEmCyzfJsqTxrKIVDI8iRV ZayXpLkeJbtFJenEgzkYTT4LAva9KpRS6V6BmyhiovPUYg2x4QOXV38IhmIgti0HzT3kF303vP/ Bx0CqKg= X-Google-Smtp-Source: AGHT+IGccmzskmYB9AUwNl5v5brzjltc2G9SiDMIOf8YUDLyCHNVVfV+jcvrChvPtP7dnXsTlgp1ow== X-Received: by 2002:a05:6a00:4c94:b0:724:e75b:22d1 with SMTP id d2e1a72fcca58-72dafa800c4mr10673668b3a.16.1737216788407; Sat, 18 Jan 2025 08:13:08 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72dab7f190fsm3916275b3a.26.2025.01.18.08.13.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jan 2025 08:13:07 -0800 (PST) Date: Sat, 18 Jan 2025 08:13:06 -0800 From: Guenter Roeck To: David Laight Cc: Linus Torvalds , 'Arnd Bergmann' , "'linux-kernel@vger.kernel.org'" , 'Jens Axboe' , 'Matthew Wilcox' , 'Christoph Hellwig' , 'Andrew Morton' , 'Andy Shevchenko' , 'Dan Carpenter' , "'Jason A . Donenfeld'" , "'pedro.falcato@gmail.com'" , 'Mateusz Guzik' , "'linux-mm@kvack.org'" , 'Lorenzo Stoakes' , intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, David Airlie , Simona Vetter , Jani Nikula , Rodrigo Vivi Subject: Buiild error in i915/xe (was: [PATCH next 4/7] minmax.h: Use BUILD_BUG_ON_MSG() for the lo < hi test in clamp()) Message-ID: References: <34d53778977747f19cce2abb287bb3e6@AcuMS.aculab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <34d53778977747f19cce2abb287bb3e6@AcuMS.aculab.com> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: EEACF180003 X-Stat-Signature: xy9dgxgpbqeibygppjwi9bhek5sqs4qt X-HE-Tag: 1737216789-684745 X-HE-Meta: U2FsdGVkX19LY2Vul3QPzyKGGfUQeehNuEbT6oWbjb+WGtTJFsFJ2+oAhFN6db/KRRDLR2sYlE253IoRpmy0MaHzBlM8AUoZb5sh8d639ipGX1nckpO5egdvDrI7kUQHfL+BPTFoZNTugS2qQmWXRah6l7JrlgfjfToPb4TE3vFr/RAinrn4siEjuinGXKq1HNOfjJ5kyk0S9zVqXze/gq49dm38xMZ0lgC2iWqPeOwJkGUYaHYgGmHYovzd7qaRI9pQVtn08psEzMqfOpwqWohSD2E9PLY2YcX2+A+tWH9lDWij2/8dphaFdMdGvVAQa6XY7rTAty8DtxjccriqKeMruPUuuQdKf7peh/jptO3R+iaA7LEIqaPvUhXmGccHcFTCj4USr7znwEF8aDYL+cMBLDiCnX3W2WRTt8QoWHug/IkdRDupbxW5inzuE4w5q+9ZQ7WuddRa9ak2Q+HzaT1AjYZr3Gd/yG8plAB6d4I2pDd22tFuOTG1wt8SUJyvRknqjJmThAgydrzPbWsPwDiqAVzZK9RPP1KGfH/4zcxWpJMxHMTvOZqgP+z2gQqkSauB1qxw+VYywJCq3WSm9qeHrIP0UJ5x7C1nKxy4VwrWr/Z+sQp6vwl/vYjtm4g6kzFiPLurgzp6QQSduBSYgmq9hwau/CmB+r2o/Nso5QX5UyjtMGoUIukfeNlkeOWsryPhQWoM0ic4zRMBSDzCZPmKtKOrAfGK2jvubJ6khB6xzHD/rqy85s2Qjlk7fod3lQP1chqH2cocPVw19V5TfCJFSZhYLaQCVeK7j3KlR39SJxfyx16MFvH3uufRXcMxGV22KgPlqJk9vdm3K2tJ3vZX80889BXMVoTwktYXf7m3XVh6qkU19z+38tfb+83dt3zuzWRYIxLlP051ss9anFiOZ82QiwzLJAkSkFdrK6mhf2gOVX8uIxbxxqu/fCthN+dRJV+bjrIT+xW1PRN Re84EEIT ix0KzaafH0KT7670LTA+e9a786Owx14u5jfBrACtWZKF6YsJmV9AylitET+B3MfclzHMSiXOB8PNvZ3KhP+5jVRiUrRbhj9pvSyhc2yETfnBfV20go8KB33k+gBo27O5s0eEGTbFh7mDcT5QbLQC9xNkVTRciViyl8l7k/Qa9Pwur7SyC/6n7jZqOFn7IQ652cEzrr2CR7pBfTXFxIS/ahNaLYjA45qwWBvovu/JNgHJ7B7UFJ3EC9tCyOq3MI3wfXJHyprNwf4W2E0QIv4Xqf4AOL0pwB+ndvCA/TKY1K6vfgn3pX9lqVgKN7pMjK4rjRnGu1dilTfkIibVeSsNcOXXb7w3vp6uNnFt9VgI3GlwCvwLlN4cGGuVwBO0WouD6YQItJ479QIJV/k3Me/p0DBNI+7YN1JadMRMhpzPXTl6PY1CgFJwt5bp4shfv8+Qc836ySRfMmkmMGx7dyawZTOkUckvK4i0hmtHp/eio1PBGNENfCHlYUsISBCdFRKauJZVcqTxxjjXKSHqplB54SsHF2E08Yu02aFwfZmyRGNUQsmWU3MfHAnRt9uqG7WAP37NtG/tb6d97vA9VHqWeELiyMx86j8L3WX97vpweNIttVuKBSDhK4TbFRD2CBANe8bhjYxVv6n/TpUVk1pEPXbEypvrqu1BnDIdAuy71VYMeK5WFirwgQQB9sxkL+gOrE8hw267rtKgRrQEjCBd06ZK+ZZfsG9bUPoUx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On Mon, Nov 18, 2024 at 07:13:31PM +0000, David Laight wrote: > Use BUILD_BUG_ON_MSG(statically_true(ulo > uhi), ...) for the sanity > check of the bounds in clamp(). > Gives better error coverage and one less expansion of the arguments. > > Signed-off-by: David Laight This patch triggers a build error when trying to build parisc:allmodconfig. See error message and bisect log below. I don't think there is anything wrong with the patch. The underlying problem seems to be that parisc:allmodconfig enables CONFIG_DRM_XE which tries to build the affected file even though CONFIG_DRM_I915 is not enabled/supported on parisc. Copying XE maintainers for feedback/advice. Thanks, Guenter --- Building parisc:allmodconfig ... failed -------------- Error log: In file included from : drivers/gpu/drm/i915/display/intel_backlight.c: In function 'scale': include/linux/compiler_types.h:542:45: error: call to '__compiletime_assert_415' declared with attribute error: clamp() low limit source_min greater than high limit source_max 542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^ include/linux/compiler_types.h:523:25: note: in definition of macro '__compiletime_assert' 523 | prefix ## suffix(); \ | ^~~~~~ include/linux/compiler_types.h:542:9: note: in expansion of macro '_compiletime_assert' 542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^~~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) | ^~~~~~~~~~~~~~~~~~ include/linux/minmax.h:188:9: note: in expansion of macro 'BUILD_BUG_ON_MSG' 188 | BUILD_BUG_ON_MSG(statically_true(ulo > uhi), \ | ^~~~~~~~~~~~~~~~ include/linux/minmax.h:195:9: note: in expansion of macro '__clamp_once' 195 | __clamp_once(type, val, lo, hi, __UNIQUE_ID(v_), __UNIQUE_ID(l_), __UNIQUE_ID(h_)) | ^~~~~~~~~~~~ include/linux/minmax.h:206:28: note: in expansion of macro '__careful_clamp' 206 | #define clamp(val, lo, hi) __careful_clamp(__auto_type, val, lo, hi) | ^~~~~~~~~~~~~~~ drivers/gpu/drm/i915/display/intel_backlight.c:48:22: note: in expansion of macro 'clamp' 48 | source_val = clamp(source_val, source_min, source_max); | ^~~~~ --- # bad: [0907e7fb35756464aa34c35d6abb02998418164b] Add linux-next specific files for 20250117 # good: [5bc55a333a2f7316b58edc7573e8e893f7acb532] Linux 6.13-rc7 git bisect start 'HEAD' 'v6.13-rc7' # bad: [195cedf4deacf84167c32b866ceac1cf4a16df15] Merge branch 'main' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git git bisect bad 195cedf4deacf84167c32b866ceac1cf4a16df15 # bad: [e8c0711b153b0db806410d8b31ed23b590f4eab4] Merge branch 'xtensa-for-next' of git://github.com/jcmvbkbc/linux-xtensa.git git bisect bad e8c0711b153b0db806410d8b31ed23b590f4eab4 # bad: [81d45722d699e594c66c150c8f7a0ec2e2bc9be6] Merge branch 'for-next/perf' of git://git.kernel.org/pub/scm/linux/kernel/git/will/linux.git git bisect bad 81d45722d699e594c66c150c8f7a0ec2e2bc9be6 # bad: [7acb844a672defb15cf202a501815ec22c68c800] foo git bisect bad 7acb844a672defb15cf202a501815ec22c68c800 # good: [fb2368075b135f174264071b851330649d55f9d0] mm/damon/core: add damos_filter->allow field git bisect good fb2368075b135f174264071b851330649d55f9d0 # bad: [fc83c501e385753c90db7316faf9fd4158caaa96] minmax.h: remove some #defines that are only expanded once git bisect bad fc83c501e385753c90db7316faf9fd4158caaa96 # good: [b04d305df1171448df5e87802c4d1f1022cc5784] ocfs2: use a folio in ocfs2_map_and_dirty_page() git bisect good b04d305df1171448df5e87802c4d1f1022cc5784 # good: [7e01619507058f90ab603acec482951f3c452aaa] kthread: correct comments before kthread_queue_work() git bisect good 7e01619507058f90ab603acec482951f3c452aaa # good: [21b510a64c223707caa6db6176128779f0806a73] nilfs2: correct return value kernel-doc descriptions for ioctl functions git bisect good 21b510a64c223707caa6db6176128779f0806a73 # good: [6afb87f23458f2d4e4334ee5a4efb8b0d07af68b] nilfs2: handle errors that nilfs_prepare_chunk() may return git bisect good 6afb87f23458f2d4e4334ee5a4efb8b0d07af68b # good: [8f6d46fed0bad163e5146fea1fdff150039235b2] minmax.h: reduce the #define expansion of min(), max() and clamp() git bisect good 8f6d46fed0bad163e5146fea1fdff150039235b2 # bad: [7a70c678548d71e609b95dbddf2d411a02d13b54] minmax.h: move all the clamp() definitions after the min/max() ones git bisect bad 7a70c678548d71e609b95dbddf2d411a02d13b54 # bad: [37f375aab0c585388b90d1af6968454fc2769cb9] minmax.h: use BUILD_BUG_ON_MSG() for the lo < hi test in clamp() git bisect bad 37f375aab0c585388b90d1af6968454fc2769cb9 # first bad commit: [37f375aab0c585388b90d1af6968454fc2769cb9] minmax.h: use BUILD_BUG_ON_MSG() for the lo < hi test in clamp()