From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D498C6FA8F for ; Tue, 29 Aug 2023 17:46:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 887238E003D; Tue, 29 Aug 2023 13:46:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8377B8E003B; Tue, 29 Aug 2023 13:46:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6FF6D8E003D; Tue, 29 Aug 2023 13:46:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5F1798E003B for ; Tue, 29 Aug 2023 13:46:47 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3336D120258 for ; Tue, 29 Aug 2023 17:46:47 +0000 (UTC) X-FDA: 81177872454.05.D312E75 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id 4E8DC40012 for ; Tue, 29 Aug 2023 17:46:45 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=e7+OKV8Z; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf01.hostedemail.com: domain of alx@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=alx@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693331205; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9B4D0aV1lQlN5bXT72cQZOGVJZhLcjNseaMLZaIKjN8=; b=WXzBCD9N1HS7Qh6eFYSXECujDQ/a9iYaE6DU6S+7RVXCt3owxD7yLQMddTE+tTbvFpDPxa TQmFOPLGUantuAVNTLm1Z/6R5bOoss0xXvHGMcSSo0YBy/cnPUzrjV+cYNDbD8v7r9QzGk SwS4OjDwk9ZIfxudtAtXVPNkFSXv86Q= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=e7+OKV8Z; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf01.hostedemail.com: domain of alx@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=alx@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693331205; a=rsa-sha256; cv=none; b=klYOWuW+uN30B0Whxk94swSCg+iMUo2QOpX6Kqbv110zZTZ71Ah+VzOoksBjrcpdhuPAog rzlotu8SFBBAMzR7GmEiKndj6DWJ8ly7HK1bIlFrWtuOZ4AKA3xSRkFuQL7eXYIEkMq0bl Xofx5M7PD/hQiaqbziT9JKE97iPWD7k= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 20DDC62891; Tue, 29 Aug 2023 17:46:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0B24C433C8; Tue, 29 Aug 2023 17:46:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693331203; bh=Chj7ONHTacpweEr7XGbX/Fqn6tGkweP7EVblhuG6Heo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=e7+OKV8ZBJUBn8G2f7gHwiWB4dzzD6BUBvKtF5gagmKD+UqO5GMzePDcKb750PmCw LfIUkwCfAQ+z/2hIszDelHx1AU7REcy9+4zmr6AsjUancOxwWhLB5AJY5ue27VEGt9 bXZyJI1XQc04QPbU2cvrJyElNKcot/9HGxDVctp1pzJksp1GPr0hptBJseEJo4Y6F0 gycerSu3tVjLcjex1H5/cXoVMpF0srtJxkjmoq9+fH+jGJP5dGzZw12N1xBcqML2+l HH/9Ky7L0Wjh/luL/TrDmGFLKC/BNhOXRkPx2+N688nHFwzGBQV1nBFHvGWq86mw6O oKreS30PL5oAg== Message-ID: Date: Tue, 29 Aug 2023 19:46:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: 'struct dynamic': struct tag leak in UAPI headers Content-Language: en-US To: "Eric W. Biederman" Cc: Matthew Wilcox , David Howells , Kees Cook , linux-mm@kvack.org, Rolf Eike Beer , Arnd Bergmann , Thomas Gleixner , "Paul E. McKenney" , Dave Jones References: <926f8e5c-40bd-dae0-2492-f6e6dbd6c96e@kernel.org> <8a7df4fd-9cf6-9a2e-feec-1c70197ed5fa@kernel.org> <87wmxdokum.fsf@email.froward.int.ebiederm.org> From: Alejandro Colomar Organization: Linux In-Reply-To: <87wmxdokum.fsf@email.froward.int.ebiederm.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------aoqq7qrWpFMhe4oFcSi6Yr0A" X-Rspamd-Queue-Id: 4E8DC40012 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: ywtqzzusnyqqryrs3pbhtr1exhbshfyz X-HE-Tag: 1693331205-406206 X-HE-Meta: U2FsdGVkX19iSM1wUrHfjth1WXjhJf1O4tqQjdq/yXyRmaV8KVeU9oNBd+deK72rTav91znekA2g0Dq3b0HUE30a/qQbO1qfDGlOR+At6MBD/UwH0Xx3ZxKkyPyGpf0Lv70prLOXdzxrStRs5TPDIClaXv9/9MJrIKDE2gcAM0tEuYNKzgO6e9crm6FZf4J23iYdFmz047RiyDMM9R5kXEDoOPe4tDEIWbfx+uFLWj82pWStSdD6D7kmvE6FxsGWMGiVviKI5P/xzyemtz+t2hcra1JihYrO7Z4XQQ9t4HkAXd2hRhuCP0IvYYwzdiENMzg2fs//GZJXOkrk4/gy9mEuuFSWpudoG83zyAMdRBTIpMoYDvIKjYgPcVfPzQy1FMtBYTOx6sBsSBNA6GkT7cxrVaJVhLaNL1xSfeZuiZXSIcVlQ4hcsD+SObwX8EF5r5Pxu1uGLOLaITRhKfMdZWeenfZC2SN8rd9x/mjAtyiiGFDSmY4PPcwv19kO30lQMIEENxbOqr86oDN4iDW9DZa6da2fTJnmGsiO+AVbXloy1cRkFI+ZnhWQHCYm5WtAKUlXe7GhQXZRjN0PrsZDlmdqGVdw4NNFEHa5Z+MXN26HBRUU04775lpTjrvutlnye+5s1sH39J7F+kqveCMVNBjnv1Oxm8/bM4Tl5HuC7OhACD93FVu8yjo/1rLVsLfgsviSN62oCd1m5kkydvjq763lqxr/WfEo7gHJNTZz/rK3ZxoVGUToPAr86VyB+kTwoe5kD13oIlfXAj1cLlB/Pr8K7tDfTVXPUCS1QccKCuGsZARVEATFFtzdVyeVJ+skCYEyXp/oqI9Q/1+YJ5InhDrG4OPW9HST+yPE8LKmUy3Mf2lcw0SsiPaVIr2wsovB9M0YBDdx7Hi7GiHDfJKSPgjR2lPd48xLQXZFQfOjS5l52NpP2Ak9Il3q6sXDs1zl94Drw/pK9pX3yF20t+T 0RSn6WPp ZzjYKBvAosYw9afjjmcm5BV6dpyzUOxuUIydIb9gEeaHdR+g1ORsNW2jBLTovkS2MGrmU+Pnc+vng+jChMH3BZFaRC2vusENpTz3EcdgcF/la/hov98T8LAMWAvFF5fn5LivMNA4EEBT3SmYvoDeXri8Cjr+cvxUQnZXNPjhNGH41qC1WCEKI73NsdKcrTJZV/cnTE7jBYjvP2t6txghSOVDaa72p/mBoJ/urLiHFgnQyOuj1K5nforNscA5/fNQIqHGvvAmq2nsNMT5dKdzjgDox+z7pobyew9pjhIM8T2C4f7Y4yjMdzOGz67cAWOXZUelzve4hR3GWb7c/fjwuJzH6MBHmD7MxKmECuLXKlBn1WEAhrjQpVdAJkitSbMO3FE3Tzkx+7e5GQni2VgG9P2Gm5iwIFPdGgMGyGmCIXdxOq3qPHCTIkgwgL5vwXAQllcDDfUBnmXv7EOGvBA4DS1dLpO6K9y99G2LP8GR4QE7jb2RBPuAuhRh2jAdswoRrgqOA6aC/nX7PFbkE3Ye0U+RA5Z3pjNCDk+laUBVpOhWbZuuSPpTg6smS9mP/Pr5WvitieHeI2zNgGOY2xXIKGbIe75yhxLvWDvejlYQjejaBSq9AcuEC3qiJ+AbrliDRtV/H X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------aoqq7qrWpFMhe4oFcSi6Yr0A Content-Type: multipart/mixed; boundary="------------45hlspUwZhLEQRFzYiDC54yt"; protected-headers="v1" From: Alejandro Colomar To: "Eric W. Biederman" Cc: Matthew Wilcox , David Howells , Kees Cook , linux-mm@kvack.org, Rolf Eike Beer , Arnd Bergmann , Thomas Gleixner , "Paul E. McKenney" , Dave Jones Message-ID: Subject: Re: 'struct dynamic': struct tag leak in UAPI headers References: <926f8e5c-40bd-dae0-2492-f6e6dbd6c96e@kernel.org> <8a7df4fd-9cf6-9a2e-feec-1c70197ed5fa@kernel.org> <87wmxdokum.fsf@email.froward.int.ebiederm.org> In-Reply-To: <87wmxdokum.fsf@email.froward.int.ebiederm.org> --------------45hlspUwZhLEQRFzYiDC54yt Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Eric! On 2023-08-29 18:48, Eric W. Biederman wrote: >=20 > The kernel rules do allow removing the structure tag if we no one > is using it. If someone is using it then the bug is a regression. >=20 > If you have the energy you can do a good faith search to see if there > is any likely hood that anyone is using it. At a quick look I don't > see anything including linux/elf.h. Add in a debian code search > (is there a github or gitlab code search?) and you can make a > pretty firm dent how widespread that is. Thanks for suggesting it. That gave me the energy. ;) It seems nobody is using it. At least not in Debian. $ # packages that contain 'include [<"]linux/elf\.h[">]' $ curl -s https://codesearch.debian.net/results/e5e7c74dfcdae609/packages= =2Etxt > include $ # packages that contain '\bstruct dynamic\b' $ curl -s https://codesearch.debian.net/results/b23577e099048c6a/packages= =2Etxt > struct $ cat struct include | sort | uniq -d chromium hurd linux qemu qt6-webengine qtwebengine-opensource-src $ # chromium: Seems to hold a copy of the UAPI header. No uses of the ta= g. $ # hurd: Same thing as chromium. $ # linux: :) $ # qemu: Same thing as chromium. $ # qt6-webengine: Same thing as all. $ # qtwebengine-opensource-src: Yet another copy. >=20 > After a good faith search you can merge a patch to remove it, > and then if anyone reports a problem because you somehow missed > them you can revert the change. I've prepared a patch. When it finishes building, I'll send it. Cheers, Alex --=20 GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5 --------------45hlspUwZhLEQRFzYiDC54yt-- --------------aoqq7qrWpFMhe4oFcSi6Yr0A Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE6jqH8KTroDDkXfJAnowa+77/2zIFAmTuLvwACgkQnowa+77/ 2zLMQA/8D8KcLDdHWAFCAK9bY+PKoUtSt/cWPp9rTyduX8f5Iaj+gz46G8DcHyIt DUmnE1/69un1P1hQkoTWCFMG1HWXqK4KLRCEx6DWPTN8R4irR+iAZ65cp0kRlkvk GreI8OtFVucvAJpm6h7p4JivcGheJxrccCOVdZAzkjuppvC44iPNvgyYu0wGbve9 l0nwJN8lPXuBancN0taABhEhh1Mmj8gb6cvuMQ7CQYnV/QjA8vgjfuqCvcYhPuLc s3Pfp47hYqCcfs+Y8EZ78KLDTMEUF0n+NG62ABKdwJrn2P+ewaF6OjHqD1E/A0Z7 KYGIM+a9hQt4eyVQVr+ly8AhGBHV7JA9nVayl56oi3wZde88vaO2MKqS6p6KJv70 hWeuUzNrRXeEdGEM6CuMVD32pyf2uBOnTh7W2VxlfrDljrromnrKYJjyk7J6pr5c etv2ePsvn9eC0u65cyzeb+TXgxKm6kIFlDJUmXamG/0wNdLa71mRBs07bevr7G7m lXn52NR3RLLh0QbUOqVU9sgsThBrkjkjR2geX+rMBbDobIprvayZXClkns3+ZATs 3Ilh3PH7KvCCI41DdzjB/75wFJqRureMmlhS1p6Zdmx0ZTlyRej2AfmYqJUufaZh 28cURqqf8mf6VW+++pTjuH+wTvEtl4H3MCc1xVTAYqKrj7ZoMdg= =Txil -----END PGP SIGNATURE----- --------------aoqq7qrWpFMhe4oFcSi6Yr0A--