From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FE7FC761A6 for ; Wed, 29 Mar 2023 23:35:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 349806B0075; Wed, 29 Mar 2023 19:35:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F9AB6B007B; Wed, 29 Mar 2023 19:35:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 19B316B007D; Wed, 29 Mar 2023 19:35:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 087276B0075 for ; Wed, 29 Mar 2023 19:35:43 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D1894C0EA1 for ; Wed, 29 Mar 2023 23:35:42 +0000 (UTC) X-FDA: 80623545324.14.894E8C1 Received: from esa5.hgst.iphmx.com (esa5.hgst.iphmx.com [216.71.153.144]) by imf04.hostedemail.com (Postfix) with ESMTP id 4EBCE40014 for ; Wed, 29 Mar 2023 23:35:40 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=e4tM3OB6; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b=pGtiZj8F; spf=pass (imf04.hostedemail.com: domain of "prvs=44543d287=damien.lemoal@opensource.wdc.com" designates 216.71.153.144 as permitted sender) smtp.mailfrom="prvs=44543d287=damien.lemoal@opensource.wdc.com"; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680132940; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=liArph+6JLot/OfPpdm7e7BPVHtWheclIVeKaNwaNTs=; b=LKqDnt3110MZ1ZHKm6OBWYhiJm5oi3Vr7Ks3iK6xLH9nj0r+N7gz/4j2jtiw+uIVWJkOjl 2OaUOmjwZ9jSRCoGp+7ywMTx1BzTxpwfJxHYCu10xWuP1He5B9Ck7XP+GhalHsYZsFoDml AaPSJsBXJPaGqsPvfyW7HYYkX6tck40= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=e4tM3OB6; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b=pGtiZj8F; spf=pass (imf04.hostedemail.com: domain of "prvs=44543d287=damien.lemoal@opensource.wdc.com" designates 216.71.153.144 as permitted sender) smtp.mailfrom="prvs=44543d287=damien.lemoal@opensource.wdc.com"; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680132940; a=rsa-sha256; cv=none; b=MpK8vilsk6444XtfSpYC7+sUmrupYaFjs8HK7Z9RM3JUSqNtFekMqANg6VaRLpPOmRP4VB 5tSafMvqolrdgdBBU1xZDYG44PP2Abl+RjgwAkKf377P0xv9LTV30WeieGgeexn98Rm0UU HH6odCu22j3QKC4dWy5wBVQ5w1G1v1A= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1680132940; x=1711668940; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=DWbdU79pQfFU8gOZbr/b3mO5eH7xSF4O2WK0oT2d+QM=; b=e4tM3OB6qnFZwVEAoNE/wDAps8KIxbd/qD4mXGq0DbK4kTTcdvXQVL4x 63ZrciB5rGU83XfGNxNAYrxCbry7s/hZIkVhCdoxrJAmqdDwSNjIIDZRB 9nTry9v+b5yEBuwRWneLdjd94waWBdnN5MeblhCPzA+4SrBGnpP48NF97 rpYcHE37waXOmIAqCD5NCTZsgxa7jTzb7E9+5rj47NUROLsFNM3p7Nx2B cwUtkjSlibyTXUMgi1sm0W7m90BVrbIgH8E84VIh3ZsGIdtJ/kjRI7yWl NVHtUyJHG9npjOEvlhMhOjYXZjmLFNsjllOJaXkYcedBQkhq2ivtFPslE g==; X-IronPort-AV: E=Sophos;i="5.98,301,1673884800"; d="scan'208";a="226648339" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 30 Mar 2023 07:35:38 +0800 IronPort-SDR: 0oQvkVRbdg4c2/0159V0Wrwv29p589I0RSSOcJheZwxsX67273Rjw8NTCQXCS2hlPOFwjeEFBX ix0cUAnHSnVWPhPnwNN+DJp/UXlwplPHtKGyCVDhXdXbUlAaJqOPkVeUDEkp+ScVvcQwhScjPO xoWLqRsneGgaz0cH/iBmvdJ6Jihtqd3i1tLODQi5XblS4/hSZ0sjN+u8fm2MLj0Nc1n2c9k7NC xchfCxNhPIHnYQSDJ0TOgXnSejls50wsV3JGg0adrtRCVTKlju9brQGyvzP15aTTzo1PU+a8Ut p6I= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 15:46:06 -0700 IronPort-SDR: KXm1RVoXtththqGypiK4hzL6lx+jGUPZCUkwQfxfPdHXbec48L6WiLZ2CIDkFrDB1F+0tZZU/y dRa9785OGwYk3b1FUE00QL6oXLKnzlvKgLggQ/i+1WIhgscGPPqIdDNx7GhtnOXwWZGSaXh1V5 TgJ1qpZFoRmGkUOng4f0A2fr4/ANEi3m303bSsIkxrzjOAi8X92gM1bXZKlgpbDO7Ejt7L501s ajUdZWeOELEGEwOW3IUoDRe5j0W2vDyO7Lqp7qBx6nhO89y1A5N/7cdwqLzCMc/puxoQAkQ4R7 4fw= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 16:35:39 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Pn2wp2RRwz1RtW0 for ; Wed, 29 Mar 2023 16:35:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1680132937; x=1682724938; bh=DWbdU79pQfFU8gOZbr/b3mO5eH7xSF4O2WK 0oT2d+QM=; b=pGtiZj8FTU2zGz7vQdRVApevxKgf2Ka8vvY3tec47efsQI9KN3F 6TNrUUZy3srMM5hOLLaNJ9cj/RFbng7Lw8c+GhcUj+WX8KJI8fIL7Yjnd4bTPSsy stRUmGBxBOV4gys+ZZFaJ27DeqO7fJhqYFoNYW7LF3jJeGSCgJuHLKFdrC46mgR5 469/TVxEK1vciOHd8I6Ja/b0kn7Me63VLOI+P7tjou+N5OBIOT0FMExqkO8OsOGA 8OP7Fy+8XEeqfKciX1F/w0JzBSWbRunSIFL7UwQ/deJBQDb0gvxDp5EIV13Eq79s Squ+hzD5gSNXTu1SYU5Wiz5w5imKszOHOFQ== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id TpORaPw7uJgK for ; Wed, 29 Mar 2023 16:35:37 -0700 (PDT) Received: from [10.225.163.116] (unknown [10.225.163.116]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Pn2wk4Fdnz1RtVm; Wed, 29 Mar 2023 16:35:34 -0700 (PDT) Message-ID: Date: Thu, 30 Mar 2023 08:35:33 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 12/19] zonefs: use __bio_add_page for adding single page to bio Content-Language: en-US To: Johannes Thumshirn , Jens Axboe Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , David Sterba , linux-btrfs@vger.kernel.org References: From: Damien Le Moal Organization: Western Digital Research In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 4EBCE40014 X-Stat-Signature: j6e8ouzzimhfxpsctmsxmzno85nbbsqj X-Rspam-User: X-HE-Tag: 1680132940-306498 X-HE-Meta: U2FsdGVkX1+X24Br/zQvu/ZL14tNaZoua1eK+x3+aZXmabminGQiPm98cGG7rITl/zZoI9XaLtVOV6JImRHVY1EPZRFwF4utZjE/ZI66ZYPtJxEP1cGKlFU1l8GbwwdXmUtWPiBwx09S6mAP7IAsXszsfch7CdxXCj5FYBlex/k49rFbKI4ZwIkNI5f1vMA8XO7QMe3RzZ9XkB2oA7su7xJSUmI27XSlr996kI01gSXclWXkGaRm3yDBXT2ZUBYAtLlqrGf1sLyjH5JJmm9nMlSvz1XEx2uYG/vMKd0cjmpC2N/m4NPI6TeRL43FTuGdheO1fnf7pI6A02vKIsuQAgdekw3dYNZVhk9ZKa4vldi++XZ4lLPlXgKe5s7sMVBJtLSj5U6WWvAnZ5lx7e+ZlKcHWQ5mV+fuyD4vToBDBjIfjoZoURF/IYxN0gLRNBOdBGuMNdh14ghGM6r6U+L0fId3wajrxginQoBedM6exG8a5oKQ1R77r4y2aA/Zv4Gzg/DL+oMiH/w+pX3HsGfdiqCS4A+n6Qz/VH1YkYoNFnb5ZbvIKbeZf7ELIHczqmnJn1wpSJ/r2TtZQPcqkzHB4Q71jZhklJFEpzATFRko+WkJSwJDImFYjaJikcB3Cvxi1K8tw3kNAAvWTy3p76qGyVa4xyqD5iEGzGHXtFq7Y44rKWmiVQ8vGAS/yO8EO+IpxKjYbs9M1ST7t4QKkb4i5YVhbdrodtnUTxkFmkwDI1W082r0+hF5hAMAsmOOMAIAMGEzcqZw/ei7nbEowofPLz1z67dF+c7slyX35YaxajZUJ9ZAWVRTOzvnuBo0n7M34hp6dEzXWGKXkHBi3QfQBTv6ohOXEgD2P4WlPOJs2koUJTHXfVZIB15UrCvBabfNAwoWPNpa7dC2UYyr/2m6xvEDQX+JhKtF0K83GqDdezwXJACrm3Fi955ITg5yqTXlIfMeyZcyeayXcLhTfOc FhmtcwjQ BW0txCcBknHu23t+DxcLnhb/NovxhjDjT6jp7nIaa6lIPtwsH1oMRUPdzAQrH6vFg/UkH1rmcGp5KfhEVX40cxtgYdaA8br+LRhPqnFQxTo/JFY8WaPRp2fUf9tzIS2mKRJMBjFcI3hLEb9C6LAXvoFsVV8OFg9Ebbi/D3L71va5Zv0ag0DeTmOWPgwDo67Rb6apNuWn6vqhqzrJ5UZQhjqQmToHXYNHkD8y9wq2dF9af24ZZyWWAosP3h5Xy39q7eHtHayKcLqjP+HDGI03dM2nTRvYTCuejq0s7AzXwBv41fQRw2uPsU3DgcBHb0ezEInXbJ6A3y8dPQwJTwqz/ZMNSstzLyWHEnzQXOvsymUO9o4V8Lk7j+EvE1NJfbFy3+RKIM0GFpmoCThdti+qM+fyqvjzr/tw0zxX13OEyke6Ck7vKzUBmtlKWs3FOMARJnAaAEubS/VY1GrkkZ3c23mCXy2DzfotAegTrisAuDtUA9jMaSTX1/k9+xf/rxsX9fuA61QUZVnWbR/qn/aoMMQGN+vg9vf0qK7SZZ/as5C+PHPrc/uu4Ul2YT8aQwYfk6EWS+OsABXz7buVnvHFPioUJoQHoEKQm/GidOPp3fm2W+P7lMIxt36phl9d3cKeZaFWgM60Qo7RcDswfbwYB1hh0ptn62g4cfHXwejPUVWL2+113nc3EYH2b2PpyyvRAcK0MvqXsCRHKCElEVIw1OdOzYpvT90KbTQ4fy8Kha3IJh1C+1XOu1B2WAZuSo4p3Em/+H9/MGiszBWlTpvVkymBpLxG6JfMmKgI4BZL570Hs2vo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/30/23 02:05, Johannes Thumshirn wrote: > The zonefs superblock reading code uses bio_add_page() to add a page to a > newly created bio. bio_add_page() can fail, but the return value is > never checked. > > Use __bio_add_page() as adding a single page to a newly created bio is > guaranteed to succeed. > > This brings us a step closer to marking bio_add_page() as __must_check. > > Signed-off-by: Johannes Thumshirn Acked-by: Damien Le Moal -- Damien Le Moal Western Digital Research