From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23B89CFA451 for ; Thu, 24 Oct 2024 10:23:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7EA8F6B007B; Thu, 24 Oct 2024 06:23:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 799C86B0082; Thu, 24 Oct 2024 06:23:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 612AC6B0085; Thu, 24 Oct 2024 06:23:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 428656B007B for ; Thu, 24 Oct 2024 06:23:53 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B9D601611D3 for ; Thu, 24 Oct 2024 10:23:31 +0000 (UTC) X-FDA: 82708109358.23.AD8647B Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf07.hostedemail.com (Postfix) with ESMTP id CEEEE4001E for ; Thu, 24 Oct 2024 10:23:24 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=1sHTJhXr; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=g+FX7HKc; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=1sHTJhXr; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=g+FX7HKc; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729765353; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6FLhILfbPiEBCiN9SHFKWQURQTQMt2eKXUD1yQfLPFE=; b=xoHIMMTQYx3UdiOOVoLU9moKkmvRH3BLUNSfpkanNwf7UGRT+g/0Xa9FzGPJP5pxLcTAoG CLXyX1pmeLU7F3mzI1HGMBUTfj/mznwNeleoz5wDWZcfQBgyPQv5LdXA5Qdffi5hhsp5tR OiiuCvPLQhWNYiAO+4drW4BsWyXC/tg= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=1sHTJhXr; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=g+FX7HKc; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=1sHTJhXr; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=g+FX7HKc; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729765353; a=rsa-sha256; cv=none; b=mo8lnEEuMDD+YTiBtXVJ/+OaL6qEo7UxBHqB208en2zxjKdfzTtPH1twq/5ay1hKxtIYmm 011jUe7TEH4GLDd5sO0IPM5nEvDkLmxqP+X9kFM2hLE92bE/ymAElM/Zry5P7RaC2M0fP4 z0qPAFmqYcBy+NqoXlbAoYKs2oyur9E= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 605B11FB40; Thu, 24 Oct 2024 10:23:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1729765428; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=6FLhILfbPiEBCiN9SHFKWQURQTQMt2eKXUD1yQfLPFE=; b=1sHTJhXrIPDG+Q1OIDpDAY5cw7NThmx2HKTb+6NefKUpz46N0Fm0mYz0g6N4wk3aF/mXLe p/WfJ+WvbBJx3GQ6SYzBi2rBNoHHzxd9jcpx8h0siDBBIViWKOJOIO2zFj8vk/orn7xHCO ueN7yYfM4bE3sjAscvJT/Y9Oum8ixTU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1729765428; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=6FLhILfbPiEBCiN9SHFKWQURQTQMt2eKXUD1yQfLPFE=; b=g+FX7HKc4q8AVWs9Ab5wSVx8jUs/LfhRNu1WQL/ICf0qFHx0FYmFPbNdeHP3qBNuzBxoLe asOoHvssO3lnlTBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1729765428; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=6FLhILfbPiEBCiN9SHFKWQURQTQMt2eKXUD1yQfLPFE=; b=1sHTJhXrIPDG+Q1OIDpDAY5cw7NThmx2HKTb+6NefKUpz46N0Fm0mYz0g6N4wk3aF/mXLe p/WfJ+WvbBJx3GQ6SYzBi2rBNoHHzxd9jcpx8h0siDBBIViWKOJOIO2zFj8vk/orn7xHCO ueN7yYfM4bE3sjAscvJT/Y9Oum8ixTU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1729765428; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=6FLhILfbPiEBCiN9SHFKWQURQTQMt2eKXUD1yQfLPFE=; b=g+FX7HKc4q8AVWs9Ab5wSVx8jUs/LfhRNu1WQL/ICf0qFHx0FYmFPbNdeHP3qBNuzBxoLe asOoHvssO3lnlTBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 466B6136F5; Thu, 24 Oct 2024 10:23:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id yK50EDQgGmdhXAAAD6G6ig (envelope-from ); Thu, 24 Oct 2024 10:23:48 +0000 Message-ID: Date: Thu, 24 Oct 2024 12:23:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: darktable performance regression on AMD systems caused by "mm: align larger anonymous mappings on THP boundaries" Content-Language: en-US From: Vlastimil Babka To: Thorsten Leemhuis , Rik van Riel Cc: Matthias , Andrew Morton , Linux kernel regressions list , LKML , Linux-MM , Yang Shi , Petr Tesarik References: <2050f0d4-57b0-481d-bab8-05e8d48fed0c@leemhuis.info> Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: CEEEE4001E X-Stat-Signature: qxokjr9wnifte4fzoiw4nq8xq7d8nj6k X-HE-Tag: 1729765404-37610 X-HE-Meta: U2FsdGVkX19AhoMjkp8TahliT0NGzhfzwOnTrEiW9AGFBU75xHTuzqg97WJRCD61vTh+FZ14o5jMbv65To42rpN7mQwUFevBxjipQ7cwfZ880QFUyjtDaIjekLsmb8R2n1wHlkQ4FGJ0jveD9zEMXBc412LdKyS2vvkzlVD/xJEmVtdauY3xa39yRlNdFhtFbyrUMhUCuE4s/8UjfTZDB5eeaFH/v1qV9cvBqqhqBabjfShwtms45ALEHwtcKCcIqBm1irI3WpyU61asbxnH5KXfTMta/BAnBqut95UWmGvHPKSYJekjk/E/hg0k4m3JZ2R4t2jtMyq2VIFQrre62VLWvQe/uPNla6dqoV+3oQ/xazTIKw678bwAdv+Y0q/l/o8LXO/zODStT7VjO5oNkj7mIoFGMitlY+zaN8mUWzYmdc0USB+CD9Jg38ogEwj0GFuP0DADJosqduLRJn6Yokj0UOoYrRKKzn7+zql7d8kZkGG8oCgLAgKH49drg5WoVtnNM8efNrq5xGh2w+Q6TUj/dz4QfIUbmk2FpyQI6H3fhHyMjb59jVpKzbwhINf49ipWcpIGtHMQuG+oQsGf0R+ECl1OTCHadox4ievb3JxnZYblPw3cKKVQa9+rNlUVIYosbda+a626x1RLCQOSPtKjUWU7+Cvo5BpOmx76wBD/hludyyHlfyJj2ReQ+dUKf6poZLkq060fOhnz36n0qgK9p68A9Z5sMdl5AsfpZ2lAFLQrf/MzmOCif2LImRTPQfA7WNw5tdcJsflD/RELtffRvH4YS5+v0B6bduZiucOXlBOWiIGjDiQpJ0cVEr0KIhuCvvKjohCVBWGVg7laYdlg6baBbz09XHdjJRiDgivkskS03MnZw4D03KSvRC4gDD5vy6smow25K+kFR4tgikD39fbazWk2bLi/clnK8vAkAhF33s7BC5/48oW0Ne+PMPdQ+DnItE9hhDXV3te qyr7qp0S WB1nlBmLE6Qi/iU84OHKbXgGiCqLcAk0LPdQsTVJVydVJ/yTvFcyqCZQYmoNCUEnqNVquvKuswN0dfe6IdIb9skuxcE21LRWOeyrMu3zzmcD07ZC9iTcmKMBJ+b84PjRJvY7OApRlzJwOkBIlECSZEAG3GVqGRYyWJcvXRoWZlOpMdjOZVsrAWJiqh4Gm7MnXCbL5zZ01jxInGpdExFA6FOUjePfSG6kQjOsSSRJbdhY9YXqudmQ8gPcBpMjve8XMunBVdTl8iwwBhf+H1lL7bIFydihGTZciTmmAIjpStpybfSg/MWxPf55AZEpVxmQYIp51Mb637Rq5B6O+Q4I/pnHjJsMEcPJZupbenTt9S/mkBYEydY0hVWaPNQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/24/24 11:58, Vlastimil Babka wrote: > On 10/24/24 09:45, Thorsten Leemhuis wrote: >> Hi, Thorsten here, the Linux kernel's regression tracker. >> >> Rik, I noticed a report about a regression in bugzilla.kernel.org that >> appears to be caused by the following change of yours: >> >> efa7df3e3bb5da ("mm: align larger anonymous mappings on THP boundaries") >> [v6.7] >> >> It might be one of those "some things got faster, a few things became >> slower" situations. Not sure. Felt odd that the reporter was able to >> reproduce it on two AMD systems, but not on a Intel system. Maybe there >> is a bug somewhere else that was exposed by this. > > It seems very similar to what we've seen with spec benchmarks such as cactus > and bisected to the same commit: > > https://bugzilla.suse.com/show_bug.cgi?id=1229012 > > The exact regression varies per system. Intel regresses too but relatively > less. The theory is that there are many large-ish allocations that don't > have individual sizes aligned to 2MB and would have been merged, commit > efa7df3e3bb5da causes them to become separate areas where each aligns its > start at 2MB boundary and there are gaps between. This (gaps and vma > fragmentation) itself is not great, but most of the problem seemed to be > from the start alignment, which togethter with the access pattern causes > more TLB or cache missess due to limited associtativity. > > So maybe darktable has a similar problem. A simple candidate fix could > change commit efa7df3e3bb5da so that the mapping size has to be a multiple > of THP size (2MB) in order to become aligned, right now it's enough if it's > THP sized or larger. Maybe this could be enough to fix the issue? (on 6.12-rc4) diff --git a/mm/mmap.c b/mm/mmap.c index 9c0fb43064b5..a5297cfb1dfc 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -900,7 +900,8 @@ __get_unmapped_area(struct file *file, unsigned long addr, unsigned long len, if (get_area) { addr = get_area(file, addr, len, pgoff, flags); - } else if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) { + } else if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE) + && IS_ALIGNED(len, PMD_SIZE)) { /* Ensures that larger anonymous mappings are THP aligned. */ addr = thp_get_unmapped_area_vmflags(file, addr, len, pgoff, flags, vm_flags);