From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0BEBC36010 for ; Fri, 4 Apr 2025 06:39:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 563296B0007; Fri, 4 Apr 2025 02:39:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 510AE6B0008; Fri, 4 Apr 2025 02:39:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D7716B000A; Fri, 4 Apr 2025 02:39:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1E6196B0007 for ; Fri, 4 Apr 2025 02:39:11 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5DC8512215A for ; Fri, 4 Apr 2025 06:39:12 +0000 (UTC) X-FDA: 83295409344.03.1B2F488 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by imf13.hostedemail.com (Postfix) with ESMTP id 8133920010 for ; Fri, 4 Apr 2025 06:39:10 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=UVXvNaRv; dmarc=pass (policy=none) header.from=igalia.com; spf=pass (imf13.hostedemail.com: domain of bhsharma@igalia.com designates 178.60.130.6 as permitted sender) smtp.mailfrom=bhsharma@igalia.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743748750; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uXwHVhIQiwQ3uewZeyB4MHzXT2Md9jRYI048JFRNUHo=; b=rt8otA9s2/Kp6TLXDn71jo5s3Cy06dWHY41g5DpJIyaqEcN2VwgjDsgNaub27ZxrlHotaL rTE5ePLOg86E5WDu8X6GBCSjogy1sw+0lf+RcaDGi0+s+KBE30pxDh2fdNg3WbGKoZ0bWH zcly97ahSsZRPnuJ4AGdBey4kXQvfuM= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=UVXvNaRv; dmarc=pass (policy=none) header.from=igalia.com; spf=pass (imf13.hostedemail.com: domain of bhsharma@igalia.com designates 178.60.130.6 as permitted sender) smtp.mailfrom=bhsharma@igalia.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743748750; a=rsa-sha256; cv=none; b=KpCP1w1PAeW9O3p9TTJOP9Q5+0Kkvmm3bZBH8x5b/DTBnk/teQNCj5N6RdnyIEWCwMgYiK F7v+b4jnRqgGhboAz9ZRSbbXQtv+N9tha0wXfKe5dPBHZlBVNr767tpgomiUnBiYl65W/8 sa64wQgONFTPesJsJGw2NBrXgB+W1AM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=uXwHVhIQiwQ3uewZeyB4MHzXT2Md9jRYI048JFRNUHo=; b=UVXvNaRvohlIod85Wo7r6eTwEA eaQFuyGce9TLEyIIkuWx6dA8epXQXo5zR91aSQsoUMN2mFXvENJz8wmC2LWbgZnp5YblZXkBOXmoy 1tJLQ2Gp9QU7iNaxP5VMd8mN9iRAaWTQ28+kIDY20WM98OfYfhpM2pmGhz5kIUXV1z5mI1lcTMdXi 0hC5CUXpWhq16z4Pk47YCNXFcCVzPJjXZjXjYULxjvEuvwvFGOEPXCgmM/XfszU+o0ms42YD4Rp/S vHd//uyxeQ8qE0DAfUPVMOJ7GVblx8/yJZEkVlq+rBAz6aSwQHlA++xcueVcPf2C29ihSZUB1I+1A liG80V1Q==; Received: from [223.233.74.223] (helo=[192.168.1.12]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1u0ahf-00BDfn-Mg; Fri, 04 Apr 2025 08:38:59 +0200 Message-ID: Date: Fri, 4 Apr 2025 12:08:55 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2 3/3] kthread: Use 'task_struct->full_name' to store kthread's full name Content-Language: en-US To: Kees Cook , Bhupesh Cc: akpm@linux-foundation.org, kernel-dev@igalia.com, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, oliver.sang@intel.com, lkp@intel.com, laoar.shao@gmail.com, pmladek@suse.com, rostedt@goodmis.org, mathieu.desnoyers@efficios.com, arnaldo.melo@gmail.com, alexei.starovoitov@gmail.com, andrii.nakryiko@gmail.com, mirq-linux@rere.qmqm.pl, peterz@infradead.org, willy@infradead.org, david@redhat.com, viro@zeniv.linux.org.uk, ebiederm@xmission.com, brauner@kernel.org, jack@suse.cz, mingo@redhat.com, juri.lelli@redhat.com, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com References: <20250331121820.455916-1-bhupesh@igalia.com> <20250331121820.455916-4-bhupesh@igalia.com> <202504030923.1FE7874F@keescook> From: Bhupesh Sharma In-Reply-To: <202504030923.1FE7874F@keescook> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Stat-Signature: igyi8dumn7uyue3c93a3kb65nd88rqfw X-Rspam-User: X-Rspamd-Queue-Id: 8133920010 X-HE-Tag: 1743748750-10722 X-HE-Meta: U2FsdGVkX1+u+o/F8ZDu2xMjuAQ7oRxNuzqJMh+fjalS+a2NzhvDcCuvrWh/sg/qvQEvDVaA23eSQufegVsRXfXy/FU9Jfe+dxaZVvWS2jrSNvshJvO79udnoUnG1gIKdYSvpOvet1efPmiCbX4HzErapoEfSQnDZNj0yegu5S5R2bd965f9R/xA10rIVAsfqT+tbhoRJOAEoLyYsTOAH7Abc08Rfo1IXEWmRlIOqUR4skvGLor3L/Cabdmhw1P1L1IAwnMTeipTB/Ehe7lbX/71cj2KG+rjJeGlObxXNfe7bKHXtJqcCDTHpChuyrfed83bx4RzsQuH8ehAyNUfUeZrL1i5N16W1A+qnItPm5GwsaffafaI8fXjx6olSKf/MbLyYLGBUywDKbfoCa+h8pIEjL/opKYDUU6fsvHw8Rg8ijtX7hPZzP8yaGUC5oogdl/LLkqHxCUFXaO0y62mBvIe3ICJL7ztqpoNdBMQ2b/WyoKgroY+cwCRoQFN+iiRpHM7FMlg+BWia7VHaTVNs3sexOwRv1msTI55YDIUdLdCzfJxzdyD7BcuVigAHw1ob4kaOCHFRMHKZCxf23bgZ7sunJrgONfZS6+OODPGYVC4+lia4yy04eKdzyMCqGsF8SohKK/z3voH5oTcM33yFrTH0o8DGHFMTQyLBX40e9h/Ag8w12imWeRBryh+gc2O9Whov8Y6LAnEc6C2Dmg75fBa31F4+4FMEnAkteRq2JZsaH3ftm8GNJPFpBUtvtj2VfeYbzYnArgXHyGLszuZRPp2WFrvGJ6HZI6tSIYAa2TKg/EIYw29L65zH3diz07I8RVHcJ58XXYodG5hjNSh9O+EYUU9M1uV6VtMht0/zdcMzic2EkDGqZIqpTVsephyqn6V+mA+OLwavLK/TpkImX+kq6QJ9x7lFFWd2UHpNtvtJ2rVA7uBgtHqKFg9dI7POLu9AsPHmO9r4LwWafW 2GlxtQg7 OeUhXHA3XCWIj9TxU4U7svR6AV5SO9J9bvSpotFSZNlaQ2fEJm1uuP64Uv3mP/XJwQVpXeFNQGibGgU+vwOlEb/PLxHHwYDZJo46rHSTaLscFHzw51SZW4NEm0KDirqkcWFPrrsQOrAd1hkoRuS2WF2YKORcD25d6MU2vTdLQxcsAh2/GMHGEbeetcIHKNISUaTGBNjF2Z+VjyTujp23D5UEp3KynjABthRo8CxOYOwoqVLctRMagsDgSjvqEA+9qWHmZLhzDvITNQVmESKlfTEokMT89+CcPHBP05n0hqnULaUPDPM2pg5WJdORh+8/IL1xvwVSJHWa7kYmvfLghXMGhYdMYfI5xy7g+peF0W7vbyV5e9XsxfDSzqrMqcmFUwSqmucNPfn5vOSxezoZtT+81eQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Kees, On 4/3/25 9:54 PM, Kees Cook wrote: > On Mon, Mar 31, 2025 at 05:48:20PM +0530, Bhupesh wrote: >> Commit 6986ce24fc00 ("kthread: dynamically allocate memory to store >> kthread's full name"), added 'full_name' in parallel to 'comm' for >> kthread names. >> >> Now that we have added 'full_name' added to 'task_struct' itself, >> drop the additional 'full_name' entry from 'struct kthread' and also >> its usage. >> >> Signed-off-by: Bhupesh > I'd like to see this patch be the first patch in the series. This show > the existing use for "full_name". (And as such it'll probably need bits > from patch 1.) Sure, I will fix this in v3. Thanks, Bhupesh > >> --- >> kernel/kthread.c | 9 +++------ >> 1 file changed, 3 insertions(+), 6 deletions(-) >> >> diff --git a/kernel/kthread.c b/kernel/kthread.c >> index 5dc5b0d7238e..46fe19b7ef76 100644 >> --- a/kernel/kthread.c >> +++ b/kernel/kthread.c >> @@ -66,8 +66,6 @@ struct kthread { >> #ifdef CONFIG_BLK_CGROUP >> struct cgroup_subsys_state *blkcg_css; >> #endif >> - /* To store the full name if task comm is truncated. */ >> - char *full_name; >> struct task_struct *task; >> struct list_head hotplug_node; >> struct cpumask *preferred_affinity; >> @@ -108,12 +106,12 @@ void get_kthread_comm(char *buf, size_t buf_size, struct task_struct *tsk) >> { >> struct kthread *kthread = to_kthread(tsk); >> >> - if (!kthread || !kthread->full_name) { >> + if (!kthread || !tsk->full_name) { >> strscpy(buf, tsk->comm, buf_size); >> return; >> } >> >> - strscpy_pad(buf, kthread->full_name, buf_size); >> + strscpy_pad(buf, tsk->full_name, buf_size); >> } >> >> bool set_kthread_struct(struct task_struct *p) >> @@ -153,7 +151,6 @@ void free_kthread_struct(struct task_struct *k) >> WARN_ON_ONCE(kthread->blkcg_css); >> #endif >> k->worker_private = NULL; >> - kfree(kthread->full_name); >> kfree(kthread); >> } >> >> @@ -430,7 +427,7 @@ static int kthread(void *_create) >> kthread_exit(-EINTR); >> } >> >> - self->full_name = create->full_name; >> + self->task->full_name = create->full_name; >> self->threadfn = threadfn; >> self->data = data; >> >> -- >> 2.38.1 >>