From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2999C83000 for ; Mon, 30 Jun 2025 06:41:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 454D56B009A; Mon, 30 Jun 2025 02:41:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 42C836B009B; Mon, 30 Jun 2025 02:41:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31B416B009D; Mon, 30 Jun 2025 02:41:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 218FE6B009A for ; Mon, 30 Jun 2025 02:41:53 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 97D02C03FB for ; Mon, 30 Jun 2025 06:41:52 +0000 (UTC) X-FDA: 83611121664.14.AA4FD6B Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2089.outbound.protection.outlook.com [40.107.92.89]) by imf09.hostedemail.com (Postfix) with ESMTP id C39B614000A for ; Mon, 30 Jun 2025 06:41:49 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=m28f3JUF; spf=pass (imf09.hostedemail.com: domain of apopple@nvidia.com designates 40.107.92.89 as permitted sender) smtp.mailfrom=apopple@nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751265709; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n84GGnr1O4AP41/l/7AI2KHUOcaglNt1YqGoPwfk1kw=; b=Ym9ZjPnoJX+WsxD5cSrqq2+cbmPB7rbqV5KO2Uv7K+wy8QoT7uek75dYGrQ6lmeQ4yqQGR xbWKKkj3Ckt7FKoRuBesSV8WZhBSYrfi1VjLb/os9TEIT+aDypISnhSWXd89mDxihxutzr mJFYyfXwPPPcaTsSPBgeZK+uEWhLSJo= ARC-Authentication-Results: i=2; imf09.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=m28f3JUF; spf=pass (imf09.hostedemail.com: domain of apopple@nvidia.com designates 40.107.92.89 as permitted sender) smtp.mailfrom=apopple@nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1751265709; a=rsa-sha256; cv=pass; b=8LLk3zOIdtd8OTh3xzmjJMatHQ0rmNJRp77KVry46c6t8jaA2frm6mYJPK2l/7IIdrZJJt xJYFkjy+X53eg7jSmXrb1OGSAhP8FAvGDxmiuYdkAuWNFpOgQIdZsFfkP6IzBOKtEtHvTS C98k/woSkgwFM0RL3GzDkgAWBwvZNUs= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AUb8RPeIGJBlzMbJUMQr+0HJ3VbH3MiNpVgNc+eWLOVh1IyZanabAOw8MruQzTAZ+5OZ2eve6saEplGxb6NkODGKovXDRL8jqxS4bmTQyyB25D+A0OBeCmKLulf3xNz/bYMArMm3JBoplcA/ISgHVOK4L0KcpRdIaebAEKcU7vpY0D71R2n69w4czAuyL2cysbrs9E1UOuMAwQ1D4m4xD4BEPLPCZA2d8ZsHC/gWv8qXsUi4wb/tFfB7vK4WYmepM6QWrXZ+DSpj8vRq+xSwMM56/MRgp46HSB0RrRlN2GxME3gslbWZ2fUTvDhgJAqcGqsHR/6/0LDdSNf06mFXRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n84GGnr1O4AP41/l/7AI2KHUOcaglNt1YqGoPwfk1kw=; b=M0CuAX6U4DfDCpqTYvgtj3lvTCJw2tKRDlEmGOleFKdK1qfuV1ztKhrwOlmM7hty01RRXJNJ+8PlIeh2gvEHPKMzPF3EVuj6MUsrlvU/5wCUExs7eZSEUcAiBQxghC+HIPgQzCo0Ayr/Slx+R3dlZPlERpT1Ne0mUxuDLRXdKyyWaO4WXEgthGeQadrmprFa81vZMDqACgHvKtOG4ohIEMCj+K2Ie9bYQMcB7laRLdC7freWX1ty6qY69njOd+2UmAEmY+LvDlCndXDEYTvF1bntGkI7Lad/vu3JZAVp8r14K/yrQ0QPEpkhyGP3W2PhBRjCXsnQSQkfMLIyqsXnwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n84GGnr1O4AP41/l/7AI2KHUOcaglNt1YqGoPwfk1kw=; b=m28f3JUF65o/DWtaQ6kVARQmT+MUH1xDdruyDiGxLPXE0SjKhWT8HC9Ob5kNFON5HJ3fBUpelTaHljm6xdai4IrlIKbzJNZSogn/hRhfoQwc5Z5PJ8fTbXCdo5ElCx2LjQjFiVYGxm/NEYywEP/deYyR1tomIlcEvLAsZ6xilDv53Z7rFDbZwo7sz0T5BqUBtt88un7GtX27O75SyRqZJCIstfIImQjPzOMjyw9K9sL5FV+hYisG7VhdpkECh3BDkeozp/RVTI1GLUyP8drKb0vJ2hvxs6rry89Za5VF9bSy59qv+Sp0EK6KicF/jD1MNFLoKG8fc5CAZssPOmE0ZQ== Received: from DS0PR12MB7726.namprd12.prod.outlook.com (2603:10b6:8:130::6) by CY1PR12MB9628.namprd12.prod.outlook.com (2603:10b6:930:105::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.20; Mon, 30 Jun 2025 06:41:46 +0000 Received: from DS0PR12MB7726.namprd12.prod.outlook.com ([fe80::953f:2f80:90c5:67fe]) by DS0PR12MB7726.namprd12.prod.outlook.com ([fe80::953f:2f80:90c5:67fe%4]) with mapi id 15.20.8880.024; Mon, 30 Jun 2025 06:41:46 +0000 Date: Mon, 30 Jun 2025 16:41:41 +1000 From: Alistair Popple To: "Huang, Ying" Cc: David Hildenbrand , Zi Yan , Matthew Wilcox , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Eugenio =?utf-8?B?UMOpcmV6?= , Alexander Viro , Christian Brauner , Jan Kara , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt Subject: Re: [PATCH RFC 07/29] mm/migrate: rename isolate_movable_page() to isolate_movable_ops_page() Message-ID: References: <20250618174014.1168640-1-david@redhat.com> <20250618174014.1168640-8-david@redhat.com> <9F76592E-BB0E-4136-BDBA-195CC6FF3B03@nvidia.com> <4D6D7321-CAEC-4D82-9354-4B9786C4D05E@nvidia.com> <87h5zyrdl9.fsf@DESKTOP-5N7EMDA> <878qlaqc4k.fsf@DESKTOP-5N7EMDA> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <878qlaqc4k.fsf@DESKTOP-5N7EMDA> X-ClientProxiedBy: SY0PR01CA0008.ausprd01.prod.outlook.com (2603:10c6:10:1bb::7) To DS0PR12MB7726.namprd12.prod.outlook.com (2603:10b6:8:130::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB7726:EE_|CY1PR12MB9628:EE_ X-MS-Office365-Filtering-Correlation-Id: 31549e38-fdb4-4f89-9030-08ddb7a12f0f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?dyA0gVnFehtUhCyOMf0qDGRcnJnWd6ni5hyLf9UFfAHIlZK8bbEshFH9SfI0?= =?us-ascii?Q?T89FVz5mnFxgsJu4dVPYzSuIRFOHdxwqVRMQVR7CQoaTO9Ak7pnmJtU4fsFi?= =?us-ascii?Q?h9rzhGYXG83c/JTZJA4BOVfBpSLLErXG5UOEx0gReXzeSjm84EEihKHgPaR6?= =?us-ascii?Q?EEGrmfcOPaCHMwdpno4g9piEO/Nf/SuAbywNbn2qdMOtHNJSya896SXyofDH?= =?us-ascii?Q?MqOGMkod+sGO0WOXf0d/1sOkie1y5iun2wOSbRiFI+oz38oNZKQeowoO7Clj?= =?us-ascii?Q?ez+I1upqcybPVp2yE4bXnepDBfrBlbxSoKZMhH4RFrRQsLFmqc5m+/a9yGmF?= =?us-ascii?Q?MCQXWcqxLGmp/Uems49g1HytILEjoLtMKKH+AqAusVJgE0skfhNC112Xs/aW?= =?us-ascii?Q?oXLDeHFIUEQTG3AHyHKNMYAEzZHTG0BBQk4iUyBdCmy+rILV3eY0Zhe6wlKZ?= =?us-ascii?Q?iTfns7E1S1WC5ETUF0F+jNyORxTrcj4y3aCZ3NFahp7LmHYfkmpZ6J1QzqN1?= =?us-ascii?Q?V2lFmK/WFEzJByxJxTVezYtO+Joi8PE+NtbrdEKO5W+TLiMXRM1bF0RRxaBz?= =?us-ascii?Q?INPRgSC/oPx/wjKVY8ZxZcsWqnJimm4Zr4gbAaltUL7djUfmU/yzGzBKteA2?= =?us-ascii?Q?E3kflCxLBYHkuH7z4czZ4YJGcbF0ODXj91UksS4SOH5QyOOjAvPhthERBqVs?= =?us-ascii?Q?rfApukAbNHGS0+ynBaFnJ/2ohzWVgpv06JwxVGxIAZ1lfjPhYzh3TYjZU//l?= =?us-ascii?Q?j2plAfCrxUJhx+x+xqJe6sh22+8IDXOC3XQZ1MrUUPCqXxeriy8FjNyqtb0Z?= =?us-ascii?Q?BOY/PS2CbMPnU5VhpPx0AdQH27f04bj+XYeMRuOlxWOPLGAJIXRFAAU6FQG+?= =?us-ascii?Q?Rao2iryHA6qPa568IvWDHhhKlbQGoHkxc0oJMaas0CZNfiuK2QMv5qraHcmu?= =?us-ascii?Q?MI1NTQtkI+nXm00Xf+l9On1F2fx3WHuNnvmiUyJU1ebh68OlJShl2owrxhpF?= =?us-ascii?Q?LGCKJDEJFhdaNG/cu86s81dFCSt5iiZuzshCeHrs4Psvk+Dw0ic+ry719FGB?= =?us-ascii?Q?BYceN5TO8z/YOLN35eH8+daNjm4qYRQVjW2zaFIvis4WHuA/WVkioviLjjDg?= =?us-ascii?Q?NxhQbKjbImINUGS+nlonXGDXDgevXSPCPBPVxZqZ06ErCK/5xjNTibtBrJKE?= =?us-ascii?Q?W8AIPjGYzFUFHg976VhBQrW8Ge7sCKC0mDJMZa0sWTsmAak8O4Hy1nHCkdnJ?= =?us-ascii?Q?mWZIYS3FjAhf9OFIKq4LiY6ldc0wXJoezDoj0e6FDR9VkcbZ63R6pl164V/T?= =?us-ascii?Q?GfJZ5KDcoBT6EUgOi8vLa5dtYg84BFxIROweUn0MbdjCKOZbH/0+3RQ5kr6b?= =?us-ascii?Q?fJm0vFXNcb8vjQN1TnEy1rpSBQLIGUBAN55FZ7Mh8DyFt7j27WRj+lknRAeA?= =?us-ascii?Q?f5TPk2WMpbk=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB7726.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BJtC1xv/WNFa+6d4XgOdawM3jJJ9Qal6GmpekSdgKVzFQPtdOAl1W4c8VgFW?= =?us-ascii?Q?VXit8+36Q0SPvbkZmDu4tSQYOr4YiYfSmhjhvZULWRclOi2pKNrOVThpJEc8?= =?us-ascii?Q?b2ZofZ+NxgrZgskoL3+bZa4AQ8lHa6cIxNpf3nETQsi7vYOjtjqzcLB8HIvR?= =?us-ascii?Q?dnLO1adWeMRAxdqP5gShvDhnmzbx3nIyYITsfI/9by/p8yVUE6+RJrMDCG24?= =?us-ascii?Q?tWMQBn3P6lgc6ij+/oUU/dnseAWXyBS52M0Ladm2+1uUQ+QnUFkI7vN+XDTR?= =?us-ascii?Q?iCD1A1v8/N23hfKtG6D+VNfJUvS0LRRHK9TTvzTtjwRuWeJuK00rOiKOBZil?= =?us-ascii?Q?I/g9E7Klm2/L8P1b+oo7Q3yZOugNQ11+LoV+H5wnorGRzOkjrAMUUfM3L6Si?= =?us-ascii?Q?4nWwIvWwBc7GVpyDLV6wC5/BeHXE8cWUnUGonsIXtLO7amhzpBc4s+HfKXfO?= =?us-ascii?Q?EjYgd9A8bc6oMPr88X9cPPcVPwJ66NfCJVaBSVDjzLdHFTcVtpvBlrozpk+0?= =?us-ascii?Q?8lvld3TlihOjZR4VWkMIPUlMIZx2aRfOQ9LeL0q+y1EDw2wGMfnnpSdpu/i7?= =?us-ascii?Q?jBIPjGGaO3M3jEzJO0UlSyYMQi7w+0UHFABJ0JFG3ldtiJSCMImuoJ4Uz59M?= =?us-ascii?Q?iE8dxWesnzFBnnziXSXnnDlD+wVkpwA1S3jBCC5AYlzpYW3mCYvi5OmCM/uR?= =?us-ascii?Q?D/AoUO590AML2e8HU8tXzR8tK6IW/zgBLnstwJuGhepJzFwbuRPGEior8iQX?= =?us-ascii?Q?jzgvmgTKYz5+VrlQY39n0i3SP2YFrhVABdMgPlUTc3plc8mXEQjInlex5w2d?= =?us-ascii?Q?zn/ChhCVWekYbeIkZPCeoyw2/U/zH7NN82Z27rZnQiTlmMrm/mPpZPjR76Kt?= =?us-ascii?Q?4uN2znKfRemIpQqjanJlq40QWTWkZnH+Vja++X6rVUq+4Aip64Gnh6bjL0m8?= =?us-ascii?Q?xYhpPbBEIGBzciik7HBYDUJFZ0jExJp9hYgxqAkW3hf+k3hPVMivVHtA09kw?= =?us-ascii?Q?uRPjKDtwSzLSkvMP5EG+6je14n4Uo2eAkJUacKT6kCH+7fzs/gUYDQMahfsd?= =?us-ascii?Q?dDhTTcUjbppR63n73ujm6aqT/JxyPgouVxkv3mIx7fc0MkcjRJGx8f6W+h6L?= =?us-ascii?Q?axANE+6okVKMPNGHZ5T2lTdJJeBcuhp+H4Xz07oTIEnwbKbYaSKjIc8fNWB6?= =?us-ascii?Q?ZpUQ05VGHBUokqgB3jt+FRHIHbKRnQ5bO/KMkLZc+BUUs4hbzFiEKnP6onk7?= =?us-ascii?Q?TmjQKcMnOofDlbXLPC4vAqzKPdpWoW7rsUR0rCbBIqfpv/lnzkSkfza4wvgw?= =?us-ascii?Q?zlVjTNT+k5C5Bb03VT+DlbFb1O4GpfKEabZOA7sgTQPwUf8daEo3d29deS2p?= =?us-ascii?Q?vHR461jKmpfOVEQNTrMwD9La9Qhe9qTR3FySI8Q+xffJj3DnhI5j/lRjOdYd?= =?us-ascii?Q?4Lghx0RZdU9bSlNa6m0DaCieJ3Rqhpa1ygnCH154r9ZYvhybeh1X2sbiexmL?= =?us-ascii?Q?voozNL/RWroetCl0HH0YMRxCdsH4jLIKOpukkKUtRMFcHryYxxL6j2vlCA8c?= =?us-ascii?Q?VKcf4UEcMAd+8bMxTHSOIKSE8GFoUMYx6cXt4Ufl?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 31549e38-fdb4-4f89-9030-08ddb7a12f0f X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB7726.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2025 06:41:46.6773 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wbBJ0fikRvMAP4KIXiZ75EeetHN2npqyljX5rlIRKqWyS7IY8N2YBgCAr1Ivbq0s8/JgrPR2e5vGvpNewHkl0A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB9628 X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: C39B614000A X-Stat-Signature: uyaydyt3rc4qmi64345qhqi3fr18adb4 X-HE-Tag: 1751265709-524916 X-HE-Meta: U2FsdGVkX1/RF+F532AzzvmvnrpATe+SBq1BHQjMraOmK5hFakD9V3A5xDcXnaJ0/Q1AjFr6jwOMdqQKVEnqfb0XZUUya2ghegMTQF06kA4QLlYM7l3FvmiSSkFNXhlj0yYvQOknsKWOZ7pP/RTLP4bkjGD09d3Z4+wAo9npYXUaXYodPbxDTPVfucBMt+dPPyzqZGR6WaU/aWlTDvj/kQ612fNUPv3cN4krCG9ffx77xAvFYmPWJ2PBhxNVZ7r70Sc/YMCKk21jxMO/+9sTKIundhLfllhjVqvB3VZWy2U5z3TM3HD35bmln2UW8QISktbsYJYXpNt/ArEXmVqf8ThANgqR/tEEeF7TIKB1YnLIm3PP7CCMMlfWIcaQIg0qPxFLEHre+NWZ1v9/K9IgcUbG/rLh/kjS/t7iyTMXzYGce7SZxySzA9IOsKyf6KPQGyc9MgaGJhJwbYX7uc3Sny7wf+8HnFLSp9+xe4d7w7mQZAXt4bVelbLIkYAr0gjRNS3XUoK80TUK6qN3tev4i84aOIYTPN6lfDWNySG3IBvru9FeQ7sbONew85NqlzXfOc/tjElAsNQMw9DeKkPOWGGPRSTVo9Cr0mbkkOJY5BOdjJD9JK9/RtZ2UX8EmNJdY2ycaNGIS6qHu212zOKaFb2HBVpmMupNJ/2QnBi8npjkjfjiRJF057uvLbAASLFQgwdkddtCnyKJGuZIx2xcb7ehtD3EH3lYN+Jn4Lir+HCUAxQUKdp8yCb0XGgy1m/U2j6U2zmYfGPVC7PnhLUZ++00ETtzYnRgP07zz+YSsXV7tb5Wgfs2Qitrs+2zY7urwMc1bq93b0i/i5Ei9FjoT7ceChaj6xDr33AZAzwsauhJkTIB+ZAvhE9TWb4CRHnIF6d9UPr8TFlcq9y+NwdxUxC9y1X2wKNTy00fVJE/AL2wfvsYv19tX2rbZ92ZKF4axhuNjpSTPAfoTtJu04h MToVN0YW 7Jw/OzQDCDTi7oK2qvOIZFCjki/9XOM4IUO3BAfCSp9XymwWNQt4f8R7Tge7qutFiD0xjGDdEM0L1s66s6gOjSaSN4NMOuZ7q8lyKLJ+E+5PLfj8mWSjGGA8+Vtrk1eodwuKk84eUDE1u7TA4DLsa+Q1NEbPX8gD13XYT5pG8i1ypnKXoHCLB0wU6yklxzXFEb1JKOGFY5m1AucJT9zZ0Dlf/XtC7Gu3PTxhQTGBUUUe8r2/VRgnANqyBzXfwErSP3P5WfMljJM75oNv+czMKdgKlFbIpcbiOo5lm2z1omMPtD/uzwQN5xSrc9dIffHtG8M7+K9rRVOOUMZkrTdT1n27hF9KUf5fwtnexMqwOiVpgs38aSiumb8bPGHCNMUAUVeJBs1L8rXtTvToxKsrPGWrO6dcWxL0/DKSTgIWgsxszSIRSbRR/ZbSfl6+MUgMDH83jnxfRHJfWlNNxuBI2hkJchF6/wTjAIiUwCFpeBc/gPFmypjmQj9IJFVwwrkQzcyGFN0yig7aLPFiTfdHxckwyEopLK9BpICgJsLS4Ihj9XdB6d9AWXq35eCOqPTxI+sUF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 30, 2025 at 08:58:03AM +0800, Huang, Ying wrote: > Alistair Popple writes: > > > On Sun, Jun 29, 2025 at 07:28:50PM +0800, Huang, Ying wrote: > >> David Hildenbrand writes: > >> > >> > On 18.06.25 20:48, Zi Yan wrote: > >> >> On 18 Jun 2025, at 14:39, Matthew Wilcox wrote: > >> >> > >> >>> On Wed, Jun 18, 2025 at 02:14:15PM -0400, Zi Yan wrote: > >> >>>> On 18 Jun 2025, at 13:39, David Hildenbrand wrote: > >> >>>> > >> >>>>> ... and start moving back to per-page things that will absolutely not be > >> >>>>> folio things in the future. Add documentation and a comment that the > >> >>>>> remaining folio stuff (lock, refcount) will have to be reworked as well. > >> >>>>> > >> >>>>> While at it, convert the VM_BUG_ON() into a WARN_ON_ONCE() and handle > >> >>>>> it gracefully (relevant with further changes), and convert a > >> >>>>> WARN_ON_ONCE() into a VM_WARN_ON_ONCE_PAGE(). > >> >>>> > >> >>>> The reason is that there is no upstream code, which use movable_ops for > >> >>>> folios? Is there any fundamental reason preventing movable_ops from > >> >>>> being used on folios? > >> >>> > >> >>> folios either belong to a filesystem or they are anonymous memory, and > >> >>> so either the filesystem knows how to migrate them (through its a_ops) > >> >>> or the migration code knows how to handle anon folios directly. > >> > > >> > Right, migration of folios will be handled by migration core. > >> > > >> >> for device private pages, to support migrating >0 order anon or fs > >> >> folios > >> >> to device, how should we represent them for devices? if you think folio is > >> >> only for anon and fs. > >> > > >> > I assume they are proper folios, so yes. Just like they are handled > >> > today (-> folios) > > > > Yes, they should be proper folios. > > So, folios include file cache, anonymous, and some device private. Oh maybe I misunderstood what you were asking. We have anon and fs folios, and we currently have device private versions of the former. However ideally I think in a memdesc world we would have anon/fs folios, and the device private bit would be in the memdesc or some such and so at the level of a folio we'd only be dealing with "proper" anon or fs folios (of course in practice we may never permit device private versions of the latter). In my earlier answer I just wanted to highlight the fact that order >0 device folios now look the same as normal higher order anon or fs folios. Ie. we don't do any of the special pgmap refcounting, etc. that we used to do for higher order device folios. > >> > I was asking a related question at LSF/MM in Alistair's session: are > >> > we sure these things will be folios even before they are assigned to a > >> > filesystem? I recall the answer was "yes". > >> > > >> > So we don't (and will not) support movable_ops for folios. > >> > >> Is it possible to use some device specific callbacks (DMA?) to copy > >> from/to the device private folios (or pages) to/from the normal > >> file/anon folios in the future? > > > > I guess we could put such callbacks on the folio->pgmap, but I'm not sure why > > we would want to. Currently all migration to/from device private (or coherent) > > folios is managed by the device, which is one of the features of ZONE_DEVICE. > > Yes. The is the current behavior per my understanding too. > > > Did you have some particular reason/idea for why we might want to do this? > > No. Just want to check whether there are some requirements for that. I > think that it's just another way to organize code. > > --- > Best Regards, > Huang, Ying