From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAD8AC3DA4A for ; Sun, 11 Aug 2024 20:30:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B20D6B0083; Sun, 11 Aug 2024 16:30:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 461126B008C; Sun, 11 Aug 2024 16:30:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 328B36B0092; Sun, 11 Aug 2024 16:30:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 15D366B0083 for ; Sun, 11 Aug 2024 16:30:32 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id AD40E1A03DF for ; Sun, 11 Aug 2024 20:30:31 +0000 (UTC) X-FDA: 82441107462.21.D169882 Received: from mail-il1-f179.google.com (mail-il1-f179.google.com [209.85.166.179]) by imf28.hostedemail.com (Postfix) with ESMTP id DC56CC0013 for ; Sun, 11 Aug 2024 20:30:29 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=z5eSe3Ih; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf28.hostedemail.com: domain of rientjes@google.com designates 209.85.166.179 as permitted sender) smtp.mailfrom=rientjes@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723408153; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e5LHinhJkPM7mgzzCEWfaYX6R0BuSflcxoeZfjEH9AQ=; b=pa4SzG6o9BQoJST0L3Pult7lhT2xAjVjIXhTtAO/Up5JF3dU8OmM8xM1stdbtVQzNjs2do wxqh6nr2gvoSK+2ceUbCDxMK1r0IQqp6ph8ImVyHhE4jOqNRWjO0NeIxUOVNnNdIq8Xq8m xvyqTTclVSHOU0Q/RATUiO8bo8FG+Tw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723408153; a=rsa-sha256; cv=none; b=BRcYd8YvhT2p98DOjSLhAfYkyo82IlcdXvPpwmPFtr2Y3FbQ7PxzNvIyq9m4FXx/AC/oQy op7bXQbkJQ4Le16fkaufmcZV/LLumsBgr1S2bgWZysUnsXeqZH/NHj9XYd20NOPyrEe5YI OJlvxA402YRU9ZdZfnOljwkWTWj2dgg= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=z5eSe3Ih; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf28.hostedemail.com: domain of rientjes@google.com designates 209.85.166.179 as permitted sender) smtp.mailfrom=rientjes@google.com Received: by mail-il1-f179.google.com with SMTP id e9e14a558f8ab-39b6493b7dfso220705ab.1 for ; Sun, 11 Aug 2024 13:30:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1723408229; x=1724013029; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=e5LHinhJkPM7mgzzCEWfaYX6R0BuSflcxoeZfjEH9AQ=; b=z5eSe3Ih1sAO7aWYPNtTXUwjR297pBRIFACUdbpNByBOtBiZCc7QyFz2OrLYmPKy3f 5RvfhebpA3bfb4fDeDWIwfFz5McLD1GvmcWDYJO6JX/zEIU4qNXyIkbSMQwkvvssXORo UbiWSRX5g91ayK1e/LoU5V7uuWiDY/42pXsQKEZWD4ODEPELAbBcqLc4l877jr4fHwk3 xGTnzv4mCZEp5tvxNgHZ2waG1Z9bRgsSfQvorzVIYDwyxHGJQQBNIkoShaNC/FsfCWMM Swq7sIWvs0TVTeTKWpjqIWi3MNDtPV5KBbWYGPyxYR3iFRLLPwcAnas8gn4plbc6lTFJ rnsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723408229; x=1724013029; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=e5LHinhJkPM7mgzzCEWfaYX6R0BuSflcxoeZfjEH9AQ=; b=WTIlCxVLokx6n3642ghzTNNS7dQvtczlbJ7Eh7lpGxB5dtVS8rt5IE58dQB2Uc0QE0 CJEkMxnR9G3vf9CNV9k+qJxdInZxQv/0s2p67sCHwAw92XGnuRzdL9Q5naeDeJYdAZG3 edSENjC4Uvw3Msx42LrGqKpND/5d4Y7VBdHUehOW5o4+6oIf7FixyvFEiieCRWodkmlp YId8JWLOm1pMFswZ5olJ0LLBPOuISSZ8TjArC45ZAzPDdLv7mf8zI0FeFO37HbmBYjVu YpVxh+9Nm9SW6fPMQRbO/luOuhfcX+QC6OiuOdWj9+ZFrLB63IU2ZPqyaiHJW3u7g5LL C4ZQ== X-Forwarded-Encrypted: i=1; AJvYcCWX+fPghVIb31WPJ+91xg9KlmsI6w42UBqdPUvpPLa6fK6SLG7PMldTevM0nVtb6H9eeyHN+Ab3vAr5G3/o/PTDExI= X-Gm-Message-State: AOJu0YxMLlSm263A3BTrIlGIneRCOZmulpGFrpWwAs07zZcwVpJyuMi8 CZhmPeP75Fg65goohMxm9NUxP9rV04VIF1Pa9ylJXoRn5YRnSdwkKpcr1aWmww== X-Google-Smtp-Source: AGHT+IFXIUx75qgMWLqs135JhpCsuvZbm9wkrWd9JKjCSRxOax9133ZPYsZN263oH9Ox29T93Eb/FA== X-Received: by 2002:a05:6e02:1448:b0:396:2b04:f489 with SMTP id e9e14a558f8ab-39c3146b4e4mr2784305ab.15.1723408228737; Sun, 11 Aug 2024 13:30:28 -0700 (PDT) Received: from [2620:0:1008:15:49ba:9fa:21c6:8a73] ([2620:0:1008:15:49ba:9fa:21c6:8a73]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-200bba3f374sm25712555ad.259.2024.08.11.13.30.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Aug 2024 13:30:28 -0700 (PDT) Date: Sun, 11 Aug 2024 13:30:27 -0700 (PDT) From: David Rientjes To: Pedro Falcato cc: Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] slab: Warn on duplicate cache names when DEBUG_VM=y In-Reply-To: <20240807090746.2146479-1-pedro.falcato@gmail.com> Message-ID: References: <20240807090746.2146479-1-pedro.falcato@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: DC56CC0013 X-Stat-Signature: iuhxcfntp7uibnknpafx1c5b9y8b84nn X-Rspam-User: X-HE-Tag: 1723408229-354999 X-HE-Meta: U2FsdGVkX1/Qg3NqRvMm4EYx+70mIaOadc/Bk9jS/jmIITeMjymbiLLTTagBSNQeMFvgW/cBrvSsiu9Q6ifI2NuglBa+jtdXb+Bz678S+wPNsLAavfPNnLxH+cEWm2v8cXDFmxfuKwNqRjPGmozLJek8o9+yOl23OjUtBcP19oGRS+qKiYIedCX9k/Q08msDKzut8VOZ9NYB//Hik2khmAR04zKm6EIdjW5YcqY9jSC15roAMPrjVCPLtgn7HlgYI+DGcBL/wraaHmXdyUisZNGhQsPgRHZYUG9DhDoRP6h+utI8Uaxsq2Sw/KI9Kgi6y0S+1FhRNPMtC6q2M89Z8G/9NIpqSBr7c7tEHtG/UK+mw+jN7eoi7a9tuQhiGuela7hkwya1tBHruKW+Jj/CmDNY9P+eMoMJR6lZMUHl9bpSH92QBfWlL9uDIMe2RksfX7BU+gLwUJF/CgY8LQqCnCWLov068M8xF33llzwp6/e80A9y3EiZasGywlccbDXjur9ATRt1Cgp8ocyUG7Y7N8qQzkEVA/YnQhVdp7v8M12YhuTF9kNI5BeY8ZQxNkWU4YZQ6unQXbTO4XxyTnTAmU7i97lhm5uwitQ3mymcdj47z/SCGUdGfTmiU9ownpsYpU2fU1F2n3fPRcAGqWyK60gMGw/oaqtNuzFYQ6gqhv2G4JbFa0M7GEUECajVTdQq8MBPm/QbtPamUYw3WI1H72GKBnvDmmaqKhGMV2TpKuGZHieTMbVFJO36ovBKx0o4PwJgfGKESIWr9oP5m6Wb5u+nF3ucJotWd/Ob+7OCs8SVFpG6TVex6tXo/xo82NP6tm74nz2elVaiIaH1J8VAt+yTQHZfEyaXZfkRPMFeLv3WxBS6Bm4RtsX8YWZjKy03WfliCZsBKl6oK5lhyiYdV0QCArho3h/35K69BNozraqTjwsfnPJr4934HklpQDqwiMkjrQ7ExiTia87t1Rd twEdJmsP j/An5iwdwL0c7pQMl+c9s43wpa1HtgsL9A1T8XORXAfb2cu2uDHyPvB3G3vU7v930mN8J9ftvwjp3tLsMvp3tH2VVqhdyrb4ZqoVcQKMILaJ5xWYr9ePovDk6LpuSsdPQiZp9rzNGWrM4e3920hB8PRh5mxDqcIdEr6VqR9JYMaefiIS5i2Ck2N7l9G0OiE8M3keL3XRWKgnpLQp8MBFmHjXpr+eAYcvMmWsHXrcr7N292GUk+fIDKyYVtLOmRcJT4Bbpjt7Fdn1fEN+h7hRIiHOVHu3Bc2WxN1A7xpiZdSVSHmBd2YwKoz719OOOuN+o8z5XOi8n4VH1jK3W9ksIHq33/OqLcm5Fy4sbH0ejbyi9ZXjKpRNZuowu4BAYLilQnL5US4Hl2V2t/mPp9GLzhLsyAb90yDTVBbtiqh1V6OsFbEX6wuVpILxYS+EbaCB0yq0968wdG8jUrZKOHHesoFnT8A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 7 Aug 2024, Pedro Falcato wrote: > diff --git a/mm/slab_common.c b/mm/slab_common.c > index 40b582a014b..1abe6a577d5 100644 > --- a/mm/slab_common.c > +++ b/mm/slab_common.c > @@ -88,6 +88,19 @@ unsigned int kmem_cache_size(struct kmem_cache *s) > EXPORT_SYMBOL(kmem_cache_size); > > #ifdef CONFIG_DEBUG_VM > + > +static bool kmem_cache_is_duplicate_name(const char *name) > +{ > + struct kmem_cache *s; > + > + list_for_each_entry(s, &slab_caches, list) { > + if (!strcmp(s->name, name)) > + return true; > + } > + > + return false; > +} > + > static int kmem_cache_sanity_check(const char *name, unsigned int size) > { > if (!name || in_interrupt() || size > KMALLOC_MAX_SIZE) { > @@ -95,6 +108,11 @@ static int kmem_cache_sanity_check(const char *name, unsigned int size) > return -EINVAL; > } > > + if (kmem_cache_is_duplicate_name(name)) { > + /* Duplicate names will confuse slabtop, et al */ > + pr_warn("%s: name %s already exists as a cache\n", __func__, name); Shouldn't this be a full WARN_ON() instead of pr_warn()? I assume we'll be interested in who is adding the cache when the name already exists.