From: Dev Jain <dev.jain@arm.com>
To: Ye Liu <ye.liu@linux.dev>, Andrew Morton <akpm@linux-foundation.org>
Cc: Ye Liu <liuye@kylinos.cn>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools/mm: use <stdbool.h> in page_owner_sort.c
Date: Wed, 15 Oct 2025 14:38:01 +0530 [thread overview]
Message-ID: <cdd96bd2-f759-4637-b61e-c77fcd9a24c5@arm.com> (raw)
In-Reply-To: <20251015085843.104443-1-ye.liu@linux.dev>
On 15/10/25 2:28 pm, Ye Liu wrote:
> From: Ye Liu <liuye@kylinos.cn>
>
> Use standard <stdbool.h> instead of manually defining bool, true and false.
>
> Signed-off-by: Ye Liu <liuye@kylinos.cn>
> ---
> tools/mm/page_owner_sort.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/tools/mm/page_owner_sort.c b/tools/mm/page_owner_sort.c
> index 880e36df0c11..cbd195d7b5da 100644
> --- a/tools/mm/page_owner_sort.c
> +++ b/tools/mm/page_owner_sort.c
> @@ -13,6 +13,7 @@
>
> #include <stdio.h>
> #include <stdlib.h>
> +#include <stdbool.h>
> #include <sys/types.h>
> #include <sys/stat.h>
> #include <fcntl.h>
> @@ -23,9 +24,9 @@
> #include <linux/types.h>
> #include <getopt.h>
>
> -#define bool int
> -#define true 1
> -#define false 0
> +//#define bool int
> +//#define true 1
> +//#define false 0
> #define TASK_COMM_LEN 16
You forgot to remove these :)
>
> struct block_list {
next prev parent reply other threads:[~2025-10-15 9:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 8:58 Ye Liu
2025-10-15 9:08 ` Dev Jain [this message]
2025-10-15 9:37 ` Ye Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdd96bd2-f759-4637-b61e-c77fcd9a24c5@arm.com \
--to=dev.jain@arm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuye@kylinos.cn \
--cc=ye.liu@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox