From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00B46C36010 for ; Tue, 1 Apr 2025 13:32:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5F3E2280002; Tue, 1 Apr 2025 09:32:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 57BE4280001; Tue, 1 Apr 2025 09:32:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D003280002; Tue, 1 Apr 2025 09:32:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1A150280001 for ; Tue, 1 Apr 2025 09:32:26 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9DD431C7E25 for ; Tue, 1 Apr 2025 13:32:27 +0000 (UTC) X-FDA: 83285564334.20.4D496DA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 59B004000F for ; Tue, 1 Apr 2025 13:32:24 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ItW3f3yb; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743514345; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sJ1EzOeMWUiKJA0f867xhDZEsw0/li5T0Nd7mgeA0bs=; b=sugpZZD6h7r9aqDczb3XpRJMD02E0w4fWmgLL9iZhtY/fDR+rDixvDRXajiON2ohAgUcNt 7K58XARTx4G/1HwboRbLylqO+eZHcGM/+28mm8uracfDZffdXEDFgBznS0Z+RAH5zLuHtx xqrrTa6/sVe86tdGEMtEGnXtnNerC3M= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ItW3f3yb; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743514345; a=rsa-sha256; cv=none; b=uNxqhOb8mlEYVco4EL0Ny7/nvim1bdkrQ+wA93SlO4Db/EuXX3MBaSOafw/jDslT7gTyso Km1EL4PbNh75kQjQzMIJ2H9cVWGutAFcnQ2ovOM/Q0vuPMXngA8olXa02yoQi3+2oDOoY0 QeNpYby1wmXHh4P7mznWgjfMYgopYqg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743514343; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=sJ1EzOeMWUiKJA0f867xhDZEsw0/li5T0Nd7mgeA0bs=; b=ItW3f3ybpW7w0G++uNXrQHJSGGjYhDljPhV8T4AFuMYZL44hv+KYGt8v07f1wXD0sMDxGT qm+pInN6g/pAuhjdchWUND6hKCRA4vLGJRYO9Z1BsCjkVVE49DiWj0GxLAej+c/gdwoIFI rwBo0qcL4k0lBcIEVu2y5tWZ5H1I6g0= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-412-q8pSOTQWP0WX-8_VwMx_zQ-1; Tue, 01 Apr 2025 09:32:20 -0400 X-MC-Unique: q8pSOTQWP0WX-8_VwMx_zQ-1 X-Mimecast-MFC-AGG-ID: q8pSOTQWP0WX-8_VwMx_zQ_1743514339 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43d51bd9b41so49771985e9.3 for ; Tue, 01 Apr 2025 06:32:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743514338; x=1744119138; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=sJ1EzOeMWUiKJA0f867xhDZEsw0/li5T0Nd7mgeA0bs=; b=NruCbgaNNpYTzsfd1N56lCd46X2D6VLZbeB1O7g03OPCwiMfxFoE0G0nMtSCuhTc4Y hyfPktAZrkUdDSAj8VhbK8zrdfoBzetBr686g+cXC8bM86mPDOqa6JGotBSFOnQbdXFz ACeWNX50OsflJbOsdiS95z4g7kaJAeRqa5pg4k04+yl0I9nMS57ibBXeYxRvp/MbEn5M xw3vy5gk7z8oSX8x80vQtnkbPCSpzs0kCeyhnVwmtElyvlS0faUMRhTSnMc+0FBCV6a2 oxzYr7KR+2wU/nw5fb9YEmEdfJsPLOQeyaxXrmQBIz4SY5xOdsCbd7tZY/Yn9sdD6dmK qzmg== X-Forwarded-Encrypted: i=1; AJvYcCWXLUM1STGe4BZNaKkrHyn9N7ntIQEbtnYvk9Rp1OHFo4jeovkblRd6G6mgUy3xdWVqTi9CxzmyXA==@kvack.org X-Gm-Message-State: AOJu0Yyhsmw+8jvINqpX0EZYg1o98UX7xG1C6m3Z/t3fQbVgrmCFl0fw WSrhS1UQcAGfKkN1PV1MMa8BSvg3dHkiSzPiRweZntN+QHgDBOf+NW6bJrwHuDBmWLqbmP1mmAD ExRjsRxPCsBwYjJGWZjV/vUkszdSBQfEytZ/NaXJk2XYbwEPn X-Gm-Gg: ASbGnctwkAJxLs5nUMIqlAzz6m3fR00cEGOTbsTBFjGdo9bv2yH7bByfLNd/heJfQv1 XdqBswjvq2xH51orCsKSw7xI0wafvCPuIJxdYzbiOtLlkeHDJI9tsGANrbqFZ5iToERdKhJjWHg LOsOOoyXe45J5PDPJRvsfRL5uD8Dw8MGDkngAt9jstGgjvAioLDL3P3r4Aahi+KWsekaWuqcNNZ 3QSu6sQjYwo7oSyQs3eMXTnqdnNAAz5556FCGFCbKZ7d7GHRKTXHX6caX1ZFuBeX363vrYBR20O XlG33vHUyq2z2To3UA/xU0k4xh0zZlt8kepiZ5Mkaqm+t0h+nwUm3ADW3UwhRe0NU5DIfnTGJdO UJx8+AsGZ/Ohseb9trGEWDuu13Wankwca6O7ZBYjz X-Received: by 2002:a05:600c:4747:b0:43d:82c:2b23 with SMTP id 5b1f17b1804b1-43db62b726amr104175445e9.23.1743514338534; Tue, 01 Apr 2025 06:32:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF9H0Zs0TAn/KOqN3yRaE82yn6P7LcocO31c/mwIX6D53TADopy6k5fq5SAMG/q8wXKsDUy5g== X-Received: by 2002:a05:600c:4747:b0:43d:82c:2b23 with SMTP id 5b1f17b1804b1-43db62b726amr104175185e9.23.1743514338180; Tue, 01 Apr 2025 06:32:18 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:4d00:6ac5:30d:1611:918f? (p200300cbc7074d006ac5030d1611918f.dip0.t-ipconnect.de. [2003:cb:c707:4d00:6ac5:30d:1611:918f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d8ff02f84sm156099075e9.25.2025.04.01.06.32.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Apr 2025 06:32:17 -0700 (PDT) Message-ID: Date: Tue, 1 Apr 2025 15:32:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/11] migrate: Remove call to ->writepage To: Zi Yan , Matthew Wilcox Cc: linux-fsdevel@vger.kernel.org, Joanne Koong , linux-mm@kvack.org, intel-gfx@lists.freedesktop.org References: <20250307135414.2987755-1-willy@infradead.org> <20250307135414.2987755-7-willy@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 35J26yS9_cdIAhhgtLctIx-o6I_1HeS-FaiT2LEjCp0_1743514339 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 59B004000F X-Rspamd-Server: rspam05 X-Rspam-User: X-Stat-Signature: r49n78x85dm6iosjezxqp6kfwdry6ju8 X-HE-Tag: 1743514344-802877 X-HE-Meta: U2FsdGVkX1/jRTpuC+3+5UxhpevzfLwk5uByZfLWeB0satiKZgOrhush7ErSxR+7jfdr0B6zuvJYMj4n7rWWMWs4BHgtAUe+b2cghkMELAuEwC9NYHMiw2+dL8OfLzIuWEght/p5yvmFNUp5nlE2GA37NlS9Lr1VvedRpu6EcqTl7vY85H6rFgbyJcaentLDgNBjdX3VQko/HIBZZw1ywb0TNeszxrDaiOIaz1jWffGlupMcwueadh576Fupw7Vvtybl+tYQncM4Z+igR9/6tsU2Xy7nQ6sIZizE/8O1m6InVdUjFMiA+aJTHGi7SAgDPGK6jwWk7TfBtumNdLlvdkIEnIGZ9YSPSxC6tZT8uKAOxn/oqdP3jy5uTIXvJLHPj1VbhBE+qFXNeW+KifErQchoWU2MqiOSEvFsQ6bUetXum47MX383vbHKGZfy5hMgCmoD8iI/pWGT/ZYvdbubaAzXwDYHTUwctYwPhuXOuueMWEHtf5MCp24TsjqLmQQYC0BznWZqBh3k1psKQiVKwRmxZu3KjCbY0/Z2qWGPRaRqY6JfZTLeRczLB3aj1+e08jkzthVYd3rqabiB257X1vnp6ckim7PiCgC5FQFDcBkEpacIusZnq2f5mdnwS5hrW6Ctfs5Q+7ImbNC7fkdPtkxJuPC0qOT7uS4QW6KKcvwGh4Z13oLSACP9sd5O0vFpULEqLij3sGcQZy5STTfyH8MkfFLIZ+Sym0x0sKRlkWyJP7f7e5GtErMJqDweOBJDFvMb8mYzw4abERkAHta6k9uo0M0xykgSxnv6IY5mrbsqYFPoiVgLG5SsauGWMWY9oLTwZUZSaw2lx2I664iOZTE/+7mGHFpPEFWgawV22zllnQcovjlPgeoajzBsgnpujFpZu/gCYD6heFO0HNAvENyHJuDHoGpHwPUYhh7Kl8WdhQSCtd3ZjUMtBa3aHDX2facSxgNkjjiMhDUtWTV SFwBO0Fx /Ru4rdTUj3ihOrnTkYJnAlqYpCCEUilfz9iRj1Mx6G9+Wh99o5XUoPnYbR3X6HVAh4CBoasPV/8UnU3s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 27.03.25 18:22, Zi Yan wrote: > On Thu Mar 27, 2025 at 12:52 PM EDT, Matthew Wilcox wrote: >> On Thu, Mar 27, 2025 at 11:04:57AM -0400, Zi Yan wrote: >>> On Fri Mar 7, 2025 at 8:54 AM EST, Matthew Wilcox (Oracle) wrote: >>>> The writepage callback is going away; filesystems must implement >>>> migrate_folio or else dirty folios will not be migratable. >>> >>> What is the impact of this? Are there any filesystem that has >>> a_ops->writepage() without migrate_folio()? I wonder if it could make >>> the un-migratable problem worse[1] when such FS exists. >> >> As Christoph and I have been going through filesystems removing their >> ->writepage operations, we've been careful to add ->migrate_folio >> callbacks at the same time. But we haven't fixed any out-of-tree >> filesystems, and we can't fix the filesystems which will be written in >> the future. >> >> So maybe what we should do is WARN_ON_ONCE() for filesystems which >> have a ->writepages, but do not have a ->migrate_folio()? > > Sounds good to me. Agreed, that will also make it clear what our expectation towards filesystems is. -- Cheers, David / dhildenb