From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D11EC02182 for ; Thu, 23 Jan 2025 08:07:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7118F6B007B; Thu, 23 Jan 2025 03:07:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C2E46B0082; Thu, 23 Jan 2025 03:07:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5895C6B0083; Thu, 23 Jan 2025 03:07:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3A8506B007B for ; Thu, 23 Jan 2025 03:07:07 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 303DA140CFA for ; Thu, 23 Jan 2025 08:07:06 +0000 (UTC) X-FDA: 83037986052.16.B4191C7 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf24.hostedemail.com (Postfix) with ESMTP id 4846E180005 for ; Thu, 23 Jan 2025 08:07:04 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=OmeTY+Dy; spf=pass (imf24.hostedemail.com: domain of hughd@google.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737619624; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RxLyd0j5M0G3spzS+RTBF1u+LB8fnxQzXix63wIwVfk=; b=KMU92/ORbIwaQGeT6XJJyopIuhYoUteatpgLi8Bov2CyhT2vCm1YQNQG12BvZ2XWqb+eKs /SmPlWaW+vryTyOPVqmrOlZuo2wSwqd0y4fXHeks5ohxcp4cLt6iOfTvwWZfUBHpRZQqnY WxaQc2ahWqegwUqTk5ucdeaavjkgNqM= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=OmeTY+Dy; spf=pass (imf24.hostedemail.com: domain of hughd@google.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737619624; a=rsa-sha256; cv=none; b=O2+W+6CFHRF8l3UkMcJYN27pBWKZNd+vUNt8jQ2c5KOaaTVM7td/rqVZogis7EF60wd5yO L9CVsDhtszmgtLSny1huBfO12yuC+S6S6MT5eYp9kBENlLfW7X1uDvSxirffTfSW/z2hc5 p2mTA97ZdhSW/nfHzTYUPJTDKWDuuz8= Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2166022c5caso8366995ad.2 for ; Thu, 23 Jan 2025 00:07:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1737619623; x=1738224423; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=RxLyd0j5M0G3spzS+RTBF1u+LB8fnxQzXix63wIwVfk=; b=OmeTY+Dy3piGhVLPg9SY8QmxZtEvRsOIHDDoVsYGGqhJh/XtURo+FC/RF0H5y4ESas MPN8DNwsUVcf7QK0D+3YMOfbCUVKpLMi9/RjKL7P1I5pQadgBwPKpfj/gFfpYESWi9lx sy5UWyEtfXdZAKKTKTgcBJTCO31Y15Wfri8USfsEQjE/uftZHSSLys/JXQVnXzRkejTK 1L0P6CXklSqo04ovU3ARKtdQ9zPktod4zALcwZO3PR/u5PkQ1z/H+29BnesiL/RMx2yp 2TBnp66Bxn4766BH1adJKtznzlrG1BB8lGjzF/glYsWuLacFGSylBO0C/cnp/lfPU/n5 1pkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737619623; x=1738224423; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RxLyd0j5M0G3spzS+RTBF1u+LB8fnxQzXix63wIwVfk=; b=UyHbpYdEHkJdbvsdwZSrrIA4YzIZi6D3S6/jiKmETDaQzISUJoboSgyf7tGTMhWBIx SkSVhZIcKndbwwAwACMIfzEAQ2MgGoqxTQJEH/XvAhZxSNHY6Ogq2hl2Xhb6GogfGEPh hO5Wof52DXUA7QDer59WHJQK83eG5z3Mgm3u3Hf3Y/NAB5ZPASVWLPoe0XQcVFgAzwCC r0w7gOJmhwP36Lo6oQ8tVGkd7r6eW0KR5HZVTj5+qN43+2hXQpuDzEHDvUjtr31u0u0K tm3qEh1pvQuam585X0JEdDG09Gjnn223fwToe81uVsPu4YVzKfm9dM8MJ77jCtLB4J/e mr4A== X-Forwarded-Encrypted: i=1; AJvYcCXjm404OefgVtNA9AqzUVA9fzK/Ein/vXr5s9LjxAxMSSDSk3c4k8lxd3pbYBPbNr2gUK+D4YCMiw==@kvack.org X-Gm-Message-State: AOJu0Yw+MB896m3ok0FI+lZiBUTOsF4A2SOtQLLgLS3M3nCazb3lrJz6 /lH7UXEKVYfKgsjMHMJnObs1hvypJSeDA7Nzvi5u5R/iEnjUCTrTYcaTdkvYAA== X-Gm-Gg: ASbGncuZSmqiB/B5VFvaenkSvKOWiMjdNt3hQMiABocFO/0ygJjF4vfO+JiZRc82zUc EiXQKRJs6IUPbImP8n7H60hvXPf2ihnV2p3OQTI76KLBjJ2syCCAMWzrG+bkj6Bi2U2v8gRlb25 hInzM0Im+WXeNRt8GvU1IQ7bBGR4MGYNDAwE2UQAyDzZRBZWx8Za9x3kFBpSyKTEld1tS85aRtE pfeEDnwW7+UOztIafOmxRlUJRQTUCCoC5NN6hDGVjX0sRDuw6k5AqS25G1JU/HnS6U7rzzJ1Dow JLm792V99S7NgKQXMaL1I13kBNF1FA4qlhYE1W6HbT3fnctkFUeiNWkNlaMCNsW0 X-Google-Smtp-Source: AGHT+IE7u+9Ai6CeI4NF8qNYNW7JMWK79y0CWYSHpK6OSfOIGBCitwQjVFd+BOZdZ8v0vVLAtIJgnQ== X-Received: by 2002:a05:6a00:6ca7:b0:728:e40d:c5fc with SMTP id d2e1a72fcca58-72dafbe2776mr32050779b3a.22.1737619622728; Thu, 23 Jan 2025 00:07:02 -0800 (PST) Received: from darker.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72dab9c8da5sm12254458b3a.118.2025.01.23.00.07.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jan 2025 00:07:01 -0800 (PST) Date: Thu, 23 Jan 2025 00:06:51 -0800 (PST) From: Hugh Dickins To: Roman Gushchin cc: Hugh Dickins , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Jann Horn , Peter Zijlstra , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , linux-arch@vger.kernel.org Subject: Re: [PATCH v2] mmu_gather: move tlb flush for VM_PFNMAP/VM_MIXEDMAP vmas into free_pgtables() In-Reply-To: Message-ID: References: <20250122232716.1321171-1-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 4846E180005 X-Stat-Signature: t5octqcpdzp1r9k81zc4wxh59zjyx99x X-Rspam-User: X-HE-Tag: 1737619624-149324 X-HE-Meta: U2FsdGVkX1/ToYMRXqCjNthXgvFVkQFaEwBf90lttynJKGXt2VcFZdxcTVqI6imIHyts5buMfuslbJqPTdsGjkJivkazFl2/2PkhNB7Llm+m84eSyEN74hmi1FZsDjrwUpFlVyLOKKkXPjDfLAJNOIR/ylOzryLdLQ2KHGCPawLt5UfXbh3SUQ8US8fTaSDRy2hMdmofpOh8W8zf20+S0I+jjAPJ8qb6xI9usWBWNHCWHpEW/kHO6kHrxwWoqoxatEJlgQ0xvasHbGC5vDt8UrZ70Awz2D84vyevHt1DYN8Yd83+IpCQ+bJw8vTzn3oAbPC+PvGGHXUw4iL85kiCt5qscFy2REK/hx7lUO2amGd+vIQY8pNR9F5hMyigEoaspDO/Lsyp4CfGNYOmquD7TGOQUcKTPnLoql6RgE3/E++445tIt8vbobIS1ZcIWV+ltQ4aGS7i/MQM/rF2gp+j3dr5InLO36/jYjL3lSfD1HhHfiL6WmAm4UY4ln6eXfcG+LCBanCqYwerKt6148nDE+aI5NOogvfK1ITWkg8sYyO5p4N1a7Y51RoG25nvVQDaPcaVW27RaAC/CEGt6gxSU5egUyjqoQ63XVO90fVpqeGVvrRKUtJ4o7A4C3qPyKRSvNHpc2B4kLpgMALBjNTFmPDsJE7iUE9gkkIKE6g9eiX5cbZPBQRG0GrDxiTVtkAlUmQ3BcdK2ogOU29FlWhALPQhjnVhm3bN6sHkklxwPEIJOEzA/MTOemsLMdi0Qc8nuiFXaX81kQ0E9B8ia7ML2f1uw1x1uequcxEenvh84gF8tlri8wjfOA2LwPzNRNCKmPMF+5Vx58/osTvGU4lQt0NZm2HhZPfdcsUgRQ/BY9R8Q8L0GyFk1XbOeROIZkmbtvxSCYvA6/ErLemU96Aqp7p5YtYvJvqJp3iYJ6AknfLiDVXpotbaqk/hVmdqzb47rm4d4OPX5Mf8KmCgnFR QMVtmYDi VFgpRqvEPuRa3Zkc/bcFPKDRmdXaA47QOCrip7EMSAAa0GesLpenYcwrXACOoLglY3RLLCxijrmtYReXLc24x+inluzzbINEFkDIR9yzmJOQKSTCQ7qZ2veLZf7qjuLa6v3vo2Xn2W6H7pmnBsgJq0nI4WEinLncdoOOn7N5PLTbZlOQfP5xoXm4XeZKB7flTYovoreYQlaUta00EVQ7NqWK096spd9ElK5l9KRpqS/Lfg4d5SYNRADIlDbssp8x4lCd5caAHw5LdrrDKRqFQYCEXXTvyTxYolGNHRmmEPUnBMlK5HhMrNC1teGLny4H1egw6r5sjJRFoLryXZW6eti+YDyZ3josyv0VKIEk599IQuxFgc+57TDX+5FXs5Pf1xhsVi/zYmcX/gwQkY2JByXJQ4w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 22 Jan 2025, Hugh Dickins wrote: > On Wed, 22 Jan 2025, Roman Gushchin wrote: > > > Commit b67fbebd4cf9 ("mmu_gather: Force tlb-flush VM_PFNMAP vmas") > > added a forced tlbflush to tlb_vma_end(), which is required to avoid a > > race between munmap() and unmap_mapping_range(). However it added some > > overhead to other paths where tlb_vma_end() is used, but vmas are not > > removed, e.g. madvise(MADV_DONTNEED). > > > > Fix this by moving the tlb flush out of tlb_end_vma() into > > free_pgtables(), somewhat similar to the stable version of the > > original commit: e.g. stable commit 895428ee124a ("mm: Force TLB flush > > for PFNMAP mappings before unlink_file_vma()"). > > > > Note, that if tlb->fullmm is set, no flush is required, as the whole > > mm is about to be destroyed. > > > > v2: > > - moved vma_pfn flag handling into tlb.h (by Peter Z.) > > - added comments (by Peter Z.) > > - fixed the vma_pfn flag setting (by Hugh D.) And in v3, that changelog should be after the ---, not in the commit.