From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8C56C05027 for ; Thu, 2 Feb 2023 02:00:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 645BE6B0087; Wed, 1 Feb 2023 21:00:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5CEED6B0089; Wed, 1 Feb 2023 21:00:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D3436B008A; Wed, 1 Feb 2023 21:00:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 25FB06B0087 for ; Wed, 1 Feb 2023 21:00:46 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E37BAC02B3 for ; Thu, 2 Feb 2023 02:00:45 +0000 (UTC) X-FDA: 80420698050.19.4387033 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by imf24.hostedemail.com (Postfix) with ESMTP id 5D9B5180008 for ; Thu, 2 Feb 2023 02:00:39 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=YuryE879; spf=pass (imf24.hostedemail.com: domain of fengwei.yin@intel.com designates 192.55.52.88 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675303242; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KbNFXHILSxuruetzjR2mhQyxMfSFA3yTvwVqfUTPzgE=; b=XxgqSGX90Y5q+DJSbGqG70F20nv5TGFueBnsMUvdI3as5ypU0Baf6pD8ozEyS7cY+sQ7ww 9m2IoqV3EiWhoKfjuED6YdHtQ9CUNeyY3om8coPqCiLXqeW6ZxP3D3sYGj6qW88JXUc60v 2hYDmVq+aGMT6/fIIyDQV+CpewjeVUA= ARC-Authentication-Results: i=2; imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=YuryE879; spf=pass (imf24.hostedemail.com: domain of fengwei.yin@intel.com designates 192.55.52.88 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1675303242; a=rsa-sha256; cv=fail; b=BGQAIG9gAzl7hk5g7umYPypFRAFtDTpzxcQzLlNRHYLkFhe3Qp8YFR4GDvpiK1CVKgAO8R yWARREJQWt8ZQS9qz250mBBUSgVWvLry8AzxJ4a8/C7ToYdA/PbfgfLcyR/GIGUNfpjI2H p8xsFYA7TDUUC9LKXuDYwtwRXpejgG0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675303241; x=1706839241; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=Llht7baXBvkDmpsXeQBnyaILfwUDnC8rRci0VNLLZNg=; b=YuryE879Jlh2t14ujDdHMTJQNst7cnCUzCMuVvq4G2y27li1Vf/ASxJb XqnHtMlNl3SXcsPeA8uOML9fiSjXw2DxnuZ5dAT+met3eXz4psVKcKg7u caq4IAJCAjNsUs28vkddCeeD7cv1S09QXTTuQCFYu2uF/G/1EgEe0S6bL hwdsvVIvc/HRPapY2BFvU82baW7KXB1Bnv6DcUralGRFxuOVrx3+BMct1 CZ6rvIoNCpLAUm/djBItFPiXQUXpx5MKsDmlcClE+G2PCtPCld+IMga17 6d1uoDJDOax9uvTjL9GT1mIBr21a3bD/Zfg4K0KaxJiy50vAAQTDnTrbv Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="355663247" X-IronPort-AV: E=Sophos;i="5.97,266,1669104000"; d="scan'208";a="355663247" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2023 18:00:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="667116626" X-IronPort-AV: E=Sophos;i="5.97,266,1669104000"; d="scan'208";a="667116626" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga007.fm.intel.com with ESMTP; 01 Feb 2023 18:00:34 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 1 Feb 2023 18:00:29 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 1 Feb 2023 18:00:29 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 1 Feb 2023 18:00:29 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ApniZ2vA1ZY/YuhysEB21w4ehqLGCBnfsFzsOJ4z1INWc7ZGUnCBqI+qQxnXFMv8TulUq63g0VsPkOltmy96yBFt5a+qPGKEHedfdo48pedlQxurUJo2dnqbQ6s2572mI1IxA905kJQJi0GfVcezAfV6b5DuAQfzTJozHCdwAus/vUIDzdP+3hl2xjm+p57Qxb9RZyFJvV4CBfL6ewf23oAWhmgKe92GB+ssXbB7XCu46t2Gjplw3MmQzx6MR02fdd6By3RVOmmg33vLPlMUSLD1ppkIpfUlphDheiydTHktHGSt+o80k1NjfwEablHNxNvH74wWQ+L0g/o9sOM/cQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KbNFXHILSxuruetzjR2mhQyxMfSFA3yTvwVqfUTPzgE=; b=Qm9ywHe3eKWFYtpnsCqSvwMXy3rhRznGyutxx9M5Zk78Q2OWnhK+CECjgeFI9SpAHpD4MoIo+ZHDHnCCiggJedNqfP7B7TX2rBRti2lsUtez1OW2WLntb1Dot4FkS4OqJBebKE5GjSYdaCPWEUunfJNRItUr/k+FBiF3J5xpRhz9VQEviAlzT9dh1mbXZADv+ygyROr0e3zWLSZFjt8mgqbb3WumviQZcIq8tQnS69js19/T9T2UsVR8n7dYetN9cjKtPh8c3PyPMrv3WsD87Z9aRgsYowrqo6MSDwk5TSucZoDkqQjNSnSFD2IueyUpQF2ZsOXT/OImitSx0OX4zQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) by BL1PR11MB5223.namprd11.prod.outlook.com (2603:10b6:208:31a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.38; Thu, 2 Feb 2023 02:00:25 +0000 Received: from CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::1531:707:dec4:68b4]) by CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::1531:707:dec4:68b4%4]) with mapi id 15.20.6064.027; Thu, 2 Feb 2023 02:00:25 +0000 Message-ID: Date: Thu, 2 Feb 2023 10:00:17 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.6.1 Subject: Re: [RFC PATCH v2 3/5] rmap: add page_add_file_rmap_range() Content-Language: en-US To: Matthew Wilcox CC: , , , , References: <20230201081737.2330141-1-fengwei.yin@intel.com> <20230201081737.2330141-4-fengwei.yin@intel.com> From: "Yin, Fengwei" In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR02CA0091.apcprd02.prod.outlook.com (2603:1096:4:90::31) To CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PR11MB4820:EE_|BL1PR11MB5223:EE_ X-MS-Office365-Filtering-Correlation-Id: 036f5268-ded9-4885-f8ca-08db04c14004 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ui9JTvBJSvXEPqUg2n2S+ZW3kMghtJxlYHaWTMNS/CHIvg3O90i5x1oVfxSGJU7djSZ6fTOmx0ikOLmCFuQdJt9ZfzJTgaaU8w4d/3j1zQTFpeR9+qDR4SbVO4rCpB0aFm9t3+yyF3WxZbKOGMgEIFLqoWLvCNO2EEqUOty3TjEWmGU0x944p0KTzSCVXPKAgXGBBg/WU8wtsoqkTvOddm1Y6EpVMwUrJEbWKHIVCELG0JJz1Y8VhRN/R2N5wGnFOVw9enQErT6AU7/YxR/vBrCwscI+u8wveJUv+6Yu9ze9OzimeilKvDdnpcsrzRY62LJG0VcKdTZkxh4M49mSYYepxLIzbF+DjrWH9H2jfvlYcRG/KIEEnnhX1GbonNhxm8oPGIjHdgS6pwJAVt+8oxlcd+Q81trgEz/GQM5ptTf6/NLvEmfXYqWJCeseTE03AjxZ49E9fVjb0Cvcfw2SNk9Hk/o4FEhiX5HyQ3IaEmSepjyB7/mEbxW6qXMRlSHpPtO28yobkIOG5IfVHxOMsCZhPTJoGE3taLiTxVoAhRJSzgTMZ43dm749fMIBHCpX/eJQYfGh9vG+ttfRlaPd+I/rtRu+ciyz0A/dgXrtPHHFkDje3gAVIlshZzpSu0PFHN6j0/YjFe6vV/vYK0ph9sk+X3zp5xthnltEG43SnUFCY0WBEy0qWS0LeNAmfAJ2XTNaR0crtoYEBVgsTrslRFl1Gu58Pf7ThJGL8uVJXa8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4820.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(366004)(396003)(136003)(346002)(376002)(451199018)(83380400001)(66946007)(6916009)(66556008)(66476007)(6486002)(31686004)(4326008)(8936002)(41300700001)(478600001)(8676002)(107886003)(82960400001)(86362001)(316002)(2616005)(31696002)(38100700002)(2906002)(36756003)(6666004)(6512007)(5660300002)(53546011)(26005)(6506007)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SUpkU2lSTDNiMjROUXhxdkdGNjlrVFlFVVI5RGhzUjVUL2pqNTVObHBlSDdw?= =?utf-8?B?SnRZVTN3Z09WZWFGQnhEWVlEcVZocFNGcS9UZFJQbStodkxnSTF3SXJUY1lZ?= =?utf-8?B?dmlkQmNTY1BuRnRJbWI4YThRTFhlaHZ1NG9lYjNsVHo3b2creDcyaGNrN0pJ?= =?utf-8?B?S0hKd24vZUQrV2h5MDlHL0RsS2ZZbzU1Skdmc0RIZU56ckQyM2grcHUvTlkz?= =?utf-8?B?WTB1U3BjTVRlR0Y5RFlBVWsvTVFRLzdBTk1COXFhOEdHOGJ1WWh4ekVnNjF5?= =?utf-8?B?TE9SWTBTZU11V08zRW1NZ2tUVGovZ1V4YkJQa2ZrMkF0aXprR09lMVg5QVRD?= =?utf-8?B?NEFqMytQYWxCVm8waEJuZjE5KzlBaGg0S0FUQ2NWSTIyT2t3SFBIZnlVVVk1?= =?utf-8?B?bHlsYXRtVTBuKzlmOXA0eVhtWTVCWWtGTDUwOEN2ekxGK1lIeUVPY3BoTlBt?= =?utf-8?B?eDRVUnljaEZIcitKSWh5YXhtd0JuTVpsb2JEc1JKL21Da0JHeHcyZHVoWUha?= =?utf-8?B?T1h1NWdISWo3a3Q5b2dYYXQyRWgvdm1UUVF4cW9XMHMyQ2lTUFBxVkZFNlEz?= =?utf-8?B?WDB4cmZCYWtLajlOWWtHcXhwWTdoL2VUZVRVb2FLYzB0SFZzYU5YVXFwdm9T?= =?utf-8?B?WUNPalVVd3I2ajFidmZYRGQzcnMwMmducTRmeSswQklQcXQyN0gxWWdSdlF1?= =?utf-8?B?djY4UE1VZzlHTXFxK3R5bTU2NS9UWUtwSzczQWlLcndMRDlwSE1SMlJBdVY4?= =?utf-8?B?U3Z5SVRuUnR1UVNaY0lRenV5SGxQTXpqZHgzZkd4OGM1RXhCQXErdDdOVGR3?= =?utf-8?B?YkU1UEd0NHBrcllFU1VmQ0g2bEgrT2lnYkV3RUF6cHNTaGpIV1ZITGdycGlW?= =?utf-8?B?c3A1ZmFmRmtyNGZYdDlNWW5uemNpaDZHTkFmalNWVmhXeWJuSnRTQVdqSDhi?= =?utf-8?B?eVJDYnNtaldrYlZkTk9kRDBpK3FVUDJJcmI2eTltR0pRTVBjVG10TUhZekky?= =?utf-8?B?QU83RHRockRUU0hlemtmczVRTlA2SGpVdHJla25LbHl0RWt1ZGZuazlBWHRU?= =?utf-8?B?dk1FZmtJMlZXR2p6UGkyYXlzSGhOa29hN1BoSFJ3bkZ0NWQ0VFhOd0lEV3pq?= =?utf-8?B?UEVHMDIzUmNWcC9KNEJWZHl5STZRanVvSHZXVksvbCtGaU16TGF0V3I4Rkc3?= =?utf-8?B?OVMreUpKWTZiUHdzQVNxTGZac1pnM0F6SkdaTGk3T3lZdnQzcVp1MmMzV3gr?= =?utf-8?B?d2tyT1FQdkJaZUpkbWVDT1Y5UU9SQXhmOEN6bmtSRHZGMVRTZ0lydHJDNnND?= =?utf-8?B?RHdUd0FtVFlZbm9mbFpXeEQyT1RpUHAvdzRleGZ4amp2WTRqeWxaaFdlVjFk?= =?utf-8?B?bUdFTEQwSDRXeVdWUVZONjNBaGF4V1BZczlXUWg1NmxhRzB1WDQva3ZNbDlN?= =?utf-8?B?eTN4NkFHaURES1ltK0sxV2RzcE5SZ2RYSi82WkxmcDBrdzVHczl2RnZPUnlC?= =?utf-8?B?Mkg4eWF3ZWlubVNUcmsyS2lVUmtwOGFZdFpmanlZOGMzYThRY0l3L251REVj?= =?utf-8?B?bmIyektHU1lPSmVYNFRJUWFlNVltVGorZzBnN3htZGF2UisxZHNldTFEQU9U?= =?utf-8?B?UTFxWVV3RmRUaHFCRktNNUJ5bFA5dzc4RGFOczR0MzNJUDZVRGl2YTVhTmsy?= =?utf-8?B?eUEySldIeHR0SVhhTCs0dzdERURWcHlCcGhtUFhCODhVQWV2V1RPa0tqRFZv?= =?utf-8?B?VkZGZzY0S3loVzNha1NVa29XZVp4SzVPYlZKeGlIdUtEMHIwTlU3NnVXaXM3?= =?utf-8?B?dlMwZ2FyZmc0LzQvUExoUWFyMitwbUViZHYvZWl0UTd4MGxaQkt4dy9GaVRo?= =?utf-8?B?SC9YU1BXbk9VY0ZnZ2tPd0luTk0ydHpOWXRKQS9ZSjhoYlgzWCt4aDNBd1ZX?= =?utf-8?B?VEhGVXJFSFhjS0pMWWYzMVdFaHpQbnNjanNmQUEwVHZEOXBXWDIxcGhBYWc4?= =?utf-8?B?SERvTDFjcHlESEQ0SVlkUWUzUVRXOWVmY0hxVmRoZ0xPYlkxUjlxMTJUc2pQ?= =?utf-8?B?RjYwelQvSlRpeEIwK2VrRVV5cFRwam53eWk2NmFsZ3JVUkdieU5qQkZSS0lz?= =?utf-8?B?ZTF6aG9HcUFoQVM2UjQwa3h6aktsNXVVcm52VXNMSVdkM2lsb0VqSUZicWpN?= =?utf-8?B?Nmc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 036f5268-ded9-4885-f8ca-08db04c14004 X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2023 02:00:25.6541 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XckCijeJVqnrfZhCdGiBYvmTcsbkGujrJsMq+4dvKLUXjVaJeUPRFJrHT29xQlLTnyb+8d2vk3PO2fxS1XUCEA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5223 X-OriginatorOrg: intel.com X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 5D9B5180008 X-Stat-Signature: 4q4i5cmsyg1htbxcofu1ezufasxkm4q5 X-HE-Tag: 1675303239-635615 X-HE-Meta: U2FsdGVkX1+O3MumdCtRaQYbUBgTIecMgj+gUf0tVFOo12rGSeZZHnhVe/N826f7h4WtHktK8HW8gatL9kzYapqrjU5IE8ORTRJn9j+veV1vEMkb5qPkdHlVd/5IQN+u+J0vbWDw4pq72EiYCvDXDRQDR53uq8UJ3Zlq4FT6XgPyYNGeEG1K0GAPLYkG5Kw5JXErd1JCf2RH/NH02fy0QqNtG9l0FTQ/DcLHblyyurb5ohDyQI7u0ZY4nYiZeTGCOGyMqzTZCH2BEUqC6Ee0B0SkZXn7rY5eiAn+SwJVV8tkPCl1z2EpmX6+y14TXvr7Y6x6YNcFE5Osa07S8YaXNFCJkpU21cuM0U3Y9nQPZX2tZM9axo7sUsyF+LfhUMZTKcuoZ1RhdsHdbBAxtBEpROpgOWOd4TMm/wEB0bR6ZciG6fojpr2T9i+Udclm2rjssMFSfhe1DB2UgvwVGhs7p3tZmitdxLPCiv26srYIb2p+63pL4JligoUTpjDFm2ECSUQuccbIBhfe7AoAqzzG2B57Iz9ItIDUqy/fVFE4WyrH4UjOmV/lLTJq4COf3Mss/oZhGPVjcN1W55DReYJC4Snqr56ERvfUPp2xZridkN7Y4kyipzsRNFGYsQ7GqyLNfqbzT93+L8iT1HlDe61GtfBaehdgsrE1DaxYAUGj4VTLCtlsqZhIHfI8zRL/FKCTQkOx3v79PgBYQT79RiaaVijq+ifph7TNpwyl07JVXo3eOGpfM7r6ZDqVsPuoaIKvozvdhq5NIYl4d9LlfkWDHBfnzMQHrvz4euKy/4YEgQTEpcR9r2VNdMWMpqV7bvIuug6Lmw07SHMUuNNczh8DsAmTKpmkBS4ZqFxwjR++QWjHeuYHZTzwxIyUfR/vpM3MMk6tj9B20+7WTTGkiWY1/5crI3pNsD6fX+TuZG6XtJmYe/rpe1XLP9Ag/0wEdzHjnI4NTCGxmFrXY8kS6OL TftQawom ZosirUBSnSYuYa9fdYJPgIVDBjbQRFzggHezkCkgpZ5ezK69Ex2DetwTqo9owLp/KNtgFmqmoRPQ4okfWwyi8t5CDMh+H9DsKb8I91ARubofRqXMOKSS01hkhnH33bzs00zIO2SZcug9KBcJ4OLJkmIBjuNTXXQzbY/uSHzdXS3YbwaOvMEtf0gYC6ryuKsovldJoAiA7obyVf+sCEUVbrxsOaoP6Xjfo8iU++d1fpNGLTfh2+BdFlxRFoa7BYltIhqc1BhojuYo8tN12WaTx+JhocXcqJZsLEEkpS7cbX5zeUBN6hYHrs/XsLzs3Cwj8PBv7WE/kZAunwNrX9wb1q+Oh2A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/2/2023 1:32 AM, Matthew Wilcox wrote: > On Wed, Feb 01, 2023 at 04:17:35PM +0800, Yin Fengwei wrote: >> /** >> - * page_add_file_rmap - add pte mapping to a file page >> - * @page: the page to add the mapping to >> + * page_add_file_rmap_range - add pte mapping to a sub page range of a folio >> + * @folio: The filio to add the mapping to >> + * @start: The first sub page index in folio >> + * @nr_pages: The number of sub pages from the first page >> * @vma: the vm area in which the mapping is added >> * @compound: charge the page as compound or small page >> * >> + * The sub page range of folio is defined by >> + * [first_sub_page, first_sub_page + nr_pages) > > Lose the "sub" from all of this. That's legacy thinking; pages are > pages and folios are folios. "subpages" was from when we were trying > to use the word "page" for both "the allocation" and "the PAGE_SIZE > range of bytes". OK. Will remove sub in next version. > >> + * >> * The caller needs to hold the pte lock. >> */ >> -void page_add_file_rmap(struct page *page, struct vm_area_struct *vma, >> - bool compound) >> +void page_add_file_rmap_range(struct folio *folio, unsigned long start, >> + unsigned int nr_pages, struct vm_area_struct *vma, >> + bool compound) > > I think this function needs to be called folio_add_file_rmap() Yes. Maybe a followup patch after this series? Let me know if you want this change in this series. > > I'd like to lose the 'compound' parameter, and base it on nr_pages == > folio_nr_pages(), but that may be a step far just now. Yes. I had a local change to remove if (folio_test_pmd_mappable(folio)) test (It's very close to removing 'compound'). I didn't include it in this series. I prefer a follow up patch. Let me know if you want the change in this series. Thanks. Regards Yin, Fengwei >