From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB811C3DA4A for ; Mon, 5 Aug 2024 10:38:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C57D6B0085; Mon, 5 Aug 2024 06:38:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 174506B0095; Mon, 5 Aug 2024 06:38:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0A436B0096; Mon, 5 Aug 2024 06:38:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D03906B0085 for ; Mon, 5 Aug 2024 06:38:34 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 24F2D160248 for ; Mon, 5 Aug 2024 10:38:34 +0000 (UTC) X-FDA: 82417842948.27.34E2E31 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf18.hostedemail.com (Postfix) with ESMTP id D23C21C0012 for ; Mon, 5 Aug 2024 10:38:31 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=OPloIyiL; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=3uMzWRbs; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=OPloIyiL; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=3uMzWRbs; spf=pass (imf18.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722854281; a=rsa-sha256; cv=none; b=HKC38cEZitHkbfUxkhUuG2ava2y01K5urI2n5+qNkhJeiMDn9thZvjsTw2iL6zDRBQuRrl DLP1DW9K1NQ0IKcc1+Ds/ER6VKhoUtVX0JRCkDZsb9Yt2hiYNofoSbE8QlAsx5LJJqQrAN DbsswxPruptZ0xxPSOL6aGWrwdWVyfM= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=OPloIyiL; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=3uMzWRbs; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=OPloIyiL; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=3uMzWRbs; spf=pass (imf18.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722854281; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vnBWnFwJKfaa5k4oPmmx2WyIgoL5aERcGe2MFm4Hrso=; b=gKG7BqzYknuBY0brLaK+IlboTVWmQ198Db1hlRYo6Mm6DZBDUMEnsx9Igq6fKnTTR7WXuo c0gU1XxWH9MNuTxHNMJ8mHLHNgcstWB6MfG964Q6J2ZqMvZv2ldsKLpVFtjKQiUYRXDbaM YRLtvYX8rlydcUF3UsNgzgb/pX2O5Qo= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E58FF1F831; Mon, 5 Aug 2024 10:38:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1722854309; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=vnBWnFwJKfaa5k4oPmmx2WyIgoL5aERcGe2MFm4Hrso=; b=OPloIyiLHjdXT+/nW4JauFZupCyvQxOLooXxPJPNQipoPUKx1tiN4Mh3UWYSu/Ucfs0qzJ qJTyto0Ns/uO0Dkg94d3BkzoqtUqddrU7E05Dqj6EzC8ehs1af25PoGws3tYWNvOb2aBJr R8CjoU0tvc4c2mDJvlIIqo+6ZSGUgPg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1722854309; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=vnBWnFwJKfaa5k4oPmmx2WyIgoL5aERcGe2MFm4Hrso=; b=3uMzWRbsxAc3OmR+J13x99HIUtCPW59IiGWCE5MtEeLrBTvOYQR9TIdXb/110FyB0deKxf c9KsQTqF+FAZ5fBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1722854309; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=vnBWnFwJKfaa5k4oPmmx2WyIgoL5aERcGe2MFm4Hrso=; b=OPloIyiLHjdXT+/nW4JauFZupCyvQxOLooXxPJPNQipoPUKx1tiN4Mh3UWYSu/Ucfs0qzJ qJTyto0Ns/uO0Dkg94d3BkzoqtUqddrU7E05Dqj6EzC8ehs1af25PoGws3tYWNvOb2aBJr R8CjoU0tvc4c2mDJvlIIqo+6ZSGUgPg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1722854309; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=vnBWnFwJKfaa5k4oPmmx2WyIgoL5aERcGe2MFm4Hrso=; b=3uMzWRbsxAc3OmR+J13x99HIUtCPW59IiGWCE5MtEeLrBTvOYQR9TIdXb/110FyB0deKxf c9KsQTqF+FAZ5fBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id CA53513ACF; Mon, 5 Aug 2024 10:38:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 2UOrMKWrsGafBAAAD6G6ig (envelope-from ); Mon, 05 Aug 2024 10:38:29 +0000 Message-ID: Date: Mon, 5 Aug 2024 12:38:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] slab: Error out on duplicate cache names when DEBUG_VM=y To: Pedro Falcato , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton Cc: Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240804212839.685795-1-pedro.falcato@gmail.com> Content-Language: en-US From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Stat-Signature: y4nx6moimcgfsignxbh3jakmxzpj83wm X-Rspamd-Queue-Id: D23C21C0012 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1722854311-263941 X-HE-Meta: U2FsdGVkX1/MiQV1tzMYyXU/grixJJ7u26MX0PssaLt8SHUXTD/KKvX7G6A9h1GZtB2ioevhMwgt77eup9fB1d8dbpI8CoFD2pieAJFZkofWafQiRKAgTrwYHzz2BMH6wBlwlPX8yWm8InVrhkQJnxeyq1eUDqNae5aTOiOILAsW5vfGP56iO8LRqABn/qZViAgCtfum3GBmgtTR2nZuNPfLiOy1tm7Ng7NFs7g48kmzDsvxS5E0AKkEEVMvvUJWFe8Q89/hNAPZKmaTHnpf/aAtUP/mPK4S1XK3zYZjy0oSH9BcomZ+6quRHITg4+VsT9BXZO6VdCH3jVVAZR9JiAfCZVjVAgaFUlRWnRhE04qoh6WHEUhHe01H7dnQ6rXbXckRqZASHWJCiesWpKByR/YW0BgxLWhTBViqyamxucZlCkPQaFMQtGCZOz4q9BJQUQbpYqLBfEFhz881Ag36ShfMxeLxAi5g35x1GJXTXt9oBRBR38i9WLgETxULxth89Icb291S6u1jJLo1dhxrF3eiRU8tVgWkOShdt4ksJ+be/1uwD40/xg6t8ztz2NDQruqJAn9NdBjix3ppWmPDL8Na5mxZLCvhjeT3AcZsZnvEFaJthlTFpk5whFdUut5uYFc6CFvZsq0WVfY9TfSiQWxAuluQGNYqmNzg4wkv7UrqBDUFJLlf/dvVXmJK2dzsyGIg10GpAxGDgv07JcAHmW2Ygsqet7GGehPbacaZ4T+bbwk1vaG2+G7lon0B9NPFbfpuS4K6nJETUGo1qgWQjqHwsXjOH8Pw3PvLUkqUykA8k2LI3gUXv1F/pVsWIFanAwspOf0I8KclAXiOi6p0dpfwKezq5csUzCVJGIkGIDLMhaq+rf7QUsaZn8eimjOa2g3pckBL49vGtQmv2CYJNLq7qZVQaJJnfNJLfmDCUFa2aqJvlA45o1P+iCKm0ZAOZtLV2ENixapeN3PAKHS sxoR6MS6 2SrkFjoEaUTekrghqsxQfUc+7XECagn0Hxo0Pau34BcFNXr5dYlZcVbbnf3Bi+i7CuQNkmRE3RIwiVdMHbbJxMS8yNTqyn80Cm4bSy6Wbh8JPKjxzbnO171fcoW+43GYTbIyNKGr2IGeJgtcGkERaRyIi98UEJ0L3Q48A4ohO98HJUJcCCixcOf6aoXU8WLlsUMIbSOfJMPVI8I7nsvKS77JubASZiWJc41F9Ir63LIqqYnG8wl7hcH+uVU54uusbZlrtWbKUw4HrYlVbN2DnyfSTx3/w9add/ddUDDUsvKMC0gVL5j0r2R5q/MCCCSbelgz9JK/mfv3KMeCB7/+DfGdLVNQon+iGEsjS2nGTi0HJJ9qBhaNO6uL7KAsoJV4NxTKkPAX3eUnTfPWEo807Wk9sCUJzmE0EaYF9i8X/d/LTcjU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/5/24 12:24, Pedro Falcato wrote: > On Sun, Aug 4, 2024 at 10:28 PM Pedro Falcato wrote: >> >> Duplicate slab cache names can create havoc for userspace tooling that >> expects slab cache names to be unique. This is a reasonable expectation. > > For completeness, I just had a look at duplicate cache names around > the kernel using > git grep -Eoh "kmem_cache_create.*\"," | grep -Eo \".*\" | uniq -d > (which seems to be correct) > > which results in the following patch (on top of torvalds/linux.git > master, so file_lock_cache hasn't been fixed yet) > > This patch being so small is what leads me to believe that erroring > out here is safe. Of course, no one knows what the out-of-tree modules > do. What about module unload/reload with a SLAB_TYPESAFE_BY_RCU cache that will delay its freeing. Soon also if there are kfree_rcu()'s in flight. And the zombie cache can stay also permamently around if it fails to be destroy because some objects were not freed. In all these cases the cache's refcount should be 0 at that point, so minimally the check should ignore those. But I would also rather make it be a warning anyway, at least for a few releases. > diff --git a/drivers/scsi/snic/snic_main.c b/drivers/scsi/snic/snic_main.c > index cc824dcfe7d..abc78320c66 100644 > --- a/drivers/scsi/snic/snic_main.c > +++ b/drivers/scsi/snic/snic_main.c > @@ -873,7 +873,7 @@ snic_global_data_init(void) > snic_glob->req_cache[SNIC_REQ_CACHE_MAX_SGL] = cachep; > > len = sizeof(struct snic_host_req); > - cachep = kmem_cache_create("snic_req_maxsgl", len, SNIC_SG_DESC_ALIGN, > + cachep = kmem_cache_create("snic_req_tm", len, SNIC_SG_DESC_ALIGN, > SLAB_HWCACHE_ALIGN, NULL); > if (!cachep) { > SNIC_ERR("Failed to create snic tm req slab\n"); > diff --git a/fs/locks.c b/fs/locks.c > index 9afb16e0683..e45cad40f8b 100644 > --- a/fs/locks.c > +++ b/fs/locks.c > @@ -2984,7 +2984,7 @@ static int __init filelock_init(void) > filelock_cache = kmem_cache_create("file_lock_cache", > sizeof(struct file_lock), 0, SLAB_PANIC, NULL); > > - filelease_cache = kmem_cache_create("file_lock_cache", > + filelease_cache = kmem_cache_create("file_lease_cache", > sizeof(struct file_lease), 0, SLAB_PANIC, NULL); > > for_each_possible_cpu(i) {