From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99154C2BD09 for ; Wed, 3 Jul 2024 10:24:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 354F26B0095; Wed, 3 Jul 2024 06:24:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 305026B0096; Wed, 3 Jul 2024 06:24:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 17FED6B0098; Wed, 3 Jul 2024 06:24:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EA3536B0095 for ; Wed, 3 Jul 2024 06:24:51 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 72C4FC0AF7 for ; Wed, 3 Jul 2024 10:24:51 +0000 (UTC) X-FDA: 82298057982.02.AAEF79A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 38C9380017 for ; Wed, 3 Jul 2024 10:24:48 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CvvR4EBC; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720002270; a=rsa-sha256; cv=none; b=iO/cAWj1Liktpl7ATESZV0A7H3ABZkgclHU2paSM/SqH3/bXRDiwwr2vHfhE6/Hj+SHUX7 tQ1k4R0aHAWW6eCW3foK0K8gCr0X3YQfpE36mIpPrKlxcknxfiuHnhnfLAw6zZFoarQuL7 WB6HkaX63j0ik/NCMdMbNXdSUvW1ANM= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CvvR4EBC; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720002270; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1XI0bCyw0Ess6YcQD74Wt1XFlFKMszy5OU57DGvuPbc=; b=DFtuGLlw9Cb0a/aHsdUbszBg94rgUq1KHLZIqqT4Bn2ZsLmDb5KqhotLMOzKM/jXjhLQr+ kironGHjve2NLC6Kdm7iW5m08+wpopvimpCq5Pfi7KHJcBR5s7GDI8/k8tlhrRoH/4fLA8 lfUrbORkGY/RiJRa7ct6gP7qr6sl/2o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720002287; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=1XI0bCyw0Ess6YcQD74Wt1XFlFKMszy5OU57DGvuPbc=; b=CvvR4EBCsEf/i3ku2zokWCLVPafgaLeSKB/wLH4DEYSrK/QlSHE/iJOGIz9I5S+9QcLxb5 DdiDV5vNuobp21y7DGIv6nngH+Onhz5/cqKGZmHya9Jxge5ewQZ63XQJUl/ww6XX2AacTW mb58NfhzcSVjGaHkhv2T2FVCdkayTV8= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-389-MgXb-SFBP3CjQmbuIs_hog-1; Wed, 03 Jul 2024 06:24:44 -0400 X-MC-Unique: MgXb-SFBP3CjQmbuIs_hog-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2ee4ce81697so55137031fa.1 for ; Wed, 03 Jul 2024 03:24:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720002282; x=1720607082; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1XI0bCyw0Ess6YcQD74Wt1XFlFKMszy5OU57DGvuPbc=; b=XXd7yZPuBm+6kVhjGMFCXNuswGRLeW9/SAlFadCwbR/O0u6p1bz0EXALJHLTwIPpzI h+U3fvZfUQdfoziFk6HbET5LgnSzj/MXPqPpSd7HHqG4k6VeUvlys9UoPmgL8ax+ax5y 3oRJukSABWPomJWh2ESUH9gzkRI83aYp9bvkZQHC4Hp8NtpP5rUqYOm4WryR0uGrI/2f XFJfuOFDBI7CYiDiEx/2c4jO0mjvT9JvGDoaGD1N4gVHKKrHK8P+JPlYp7ZYHO09b42w ef356MD29OAlsvoZO0lAAV664rTw5vL96G3eaLjxIRNK2MNukMGAsdHdJeqjyg4L+XL8 a58Q== X-Forwarded-Encrypted: i=1; AJvYcCUm4LdaF0jfr0Mub4/0TvC0PnRmlzwTS6UPSrhVNHAJJladB7X/5kifaJJrVg1b3jq7eGGRVKEHG/b3KlTHNO2UZug= X-Gm-Message-State: AOJu0Yzp5tfIVCDmKQWuHQDayVWU3dcU1gb11H8jWROOKGrM9Yir02Nd vR/s5o1RaFQaMmLXTbPpMWSdYp2LNNqG/iGioEJg3uUDo9lP9FvZGzLy5jcDLoB3psyDr4QHcQw /hHWK5rwajXEHS6Mdts6jfrfmUbA+/kcLnl2HopzCgUCcRf7y X-Received: by 2002:a05:6512:1154:b0:52c:e5ac:ecd2 with SMTP id 2adb3069b0e04-52e826feb8dmr7546289e87.51.1720002282466; Wed, 03 Jul 2024 03:24:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHiZD2DbI9EXGNzgB3Co15zbpLQ2EaK+/TGFKXNCVLc6THVQYc2kmrtEmqxxFSBSAl/WRckww== X-Received: by 2002:a05:6512:1154:b0:52c:e5ac:ecd2 with SMTP id 2adb3069b0e04-52e826feb8dmr7546272e87.51.1720002281989; Wed, 03 Jul 2024 03:24:41 -0700 (PDT) Received: from ?IPV6:2003:cb:c709:3400:5126:3051:d630:92ee? (p200300cbc709340051263051d63092ee.dip0.t-ipconnect.de. [2003:cb:c709:3400:5126:3051:d630:92ee]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4256b0c0f99sm238521675e9.41.2024.07.03.03.24.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Jul 2024 03:24:41 -0700 (PDT) Message-ID: Date: Wed, 3 Jul 2024 12:24:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] hugetlbfs: add MTE support To: Yang Shi , Catalin Marinas Cc: muchun.song@linux.dev, will@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240625233717.2769975-1-yang@os.amperecomputing.com> <9dd065aa-f377-4b4c-893a-df69c9f67360@os.amperecomputing.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <9dd065aa-f377-4b4c-893a-df69c9f67360@os.amperecomputing.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 38C9380017 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 14bg1iz8orm5qwb6xgxw1becw8k5yfzi X-HE-Tag: 1720002288-610401 X-HE-Meta: U2FsdGVkX1/nZH0r0LlEXEdo1GkUlwqvJODGvyEMN2GBVKglauPZXbIYeZ6W3CMcOK/A5XUAVeHnxnPyvbBiGRoh7IULcwEPPSvrPN6jago/J6iiPFkvJzB9E8a0xQc+Q0yhTky9YzJP+V1qqVNLCbpMOa19s9jlQOig6jukImQ2lOf6mLvvcSBYwi4g2sb0EyIlmC9G9nzi+KCZO4iwjl3hY1p6oYIoaNefAqGZqPnMCuNdV6okf5jb7dfCugZi30xM0IEyNBPoPcDLCipwjEw9xbNzXPtFhpQeSqQ80cbCKmykLlrxugbPfrVOfGNy2RPlyHwwB0t7qNEmnwjaPk1TVjaBcAdhceGNhgzveFmzvYq/k166g49F9CLsQBwb2DWqJRyuzkIInSQbCIV1j9NyrKHDhHMiPSjyca09lddMO1Z+xiOlD6Egm5/QRIVUW485MH3gOIYE9gsHJxgNWKJXBByLNfItrDatH73PXyD9Bt9lxXXCISGLISZxb+4EhlKQEzPLmKp4bnDdZCC0adX1GviU/QRggvKSmpydIBS3OILgng5iZanseLG+0/8aDPvpUCII2W7+xJmLrR7E6apSfKHEkFaH+yuMqJ5OUx8VONqkYMeF9g5JeR8mGBgzWda3RA6MzI5S0X6q5X0NlwN35vOPhR9gm8PsnceRgq/X+T1iOiIkhXeN7rcp6N4TMmr7K7y2Kkof/0mT/5p06sW8G7Q09+jLRuXUAfIzbLDhveiwgnCgmrnm76xaPaf15MDVOIrAtmpQz3pt4aMXg/d5s/jRj59TqaqMX6/pm3QAm7vZunqpQLZsKtJbS1HC7xx7wGA5fBiqDSdTWB2AvP8Psls+8YYL+r7rC+2/Y8ihlqHI2VpguixWob+Mcdw3NpmJG2qzsBORU3f+rQYsB0k3Um+csWWkDNnDLWeLrxK2eFpebvJ82rjd3hzrQ0fBS4TzKmFktSmM0/cwqdr S0Vlr8l0 9hYvGQLIGh8tEHDEU5kUxVx4raDe9vbPvw9d2qJ3vDBC9PR/UeU+TbIgzfta3aZQYHNBoT3DHCA4icWTBwoYEyFwSYXhVFp8n+KYUiN9JpjrY3CPKx1dMunUqTn5ao73/TWvzVyM41/m//ZH7z/jMmIh91a9h7HcjRj0X/gaQsh5qVUM6k1AfdL3Enukc3t2jeqVR0aFto5bpgEAhT9eopTV2SaUZnBLeTvLA7NMrISvRR+UY5P77TwdIfGau32bPW94yoHrfXDrsf8wkUqvfLrkAxHCtvA9jHYH6B17joLJZFjjm3MtQWk+4kvIzjIVXG07nkUS2DuMLxXt6tH6p9w6oHJar7eeiXERYpgbWl5fflwxSwgO5deQ7UNVSKO2ZSD6ldn7SK+jfSA4KMuJJYOEvmWzJCPvxLHUQfDtMGr5BUiYmJHIVsajC+Uw/6RKeAWhhzHYvVnPhjkM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.07.24 02:20, Yang Shi wrote: > > > On 7/2/24 6:09 AM, David Hildenbrand wrote: >> On 02.07.24 14:34, Catalin Marinas wrote: >>> On Tue, Jun 25, 2024 at 04:37:17PM -0700, Yang Shi wrote: >>>> MTE can be supported on ram based filesystem. It is supported on tmpfs. >>>> There is use case to use MTE on hugetlbfs as well, adding MTE support. >>>> >>>> Signed-off-by: Yang Shi >>>> --- >>>>   fs/hugetlbfs/inode.c | 2 +- >>>>   1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c >>>> index ecad73a4f713..c34faef62daf 100644 >>>> --- a/fs/hugetlbfs/inode.c >>>> +++ b/fs/hugetlbfs/inode.c >>>> @@ -110,7 +110,7 @@ static int hugetlbfs_file_mmap(struct file >>>> *file, struct vm_area_struct *vma) >>>>        * way when do_mmap unwinds (may be important on powerpc >>>>        * and ia64). >>>>        */ >>>> -    vm_flags_set(vma, VM_HUGETLB | VM_DONTEXPAND); >>>> +    vm_flags_set(vma, VM_HUGETLB | VM_DONTEXPAND | VM_MTE_ALLOWED); >>>>       vma->vm_ops = &hugetlb_vm_ops; >>> >>> Last time I checked, about a year ago, this was not sufficient. One >>> issue is that there's no arch_clear_hugetlb_flags() implemented by your >>> patch, leaving PG_arch_{2,3} set on a page. The other issue was that I >>> initially tried to do this only on the head page but this did not go >>> well with the folio_copy() -> copy_highpage() which expects the >>> PG_arch_* flags on each individual page. The alternative was for >>> arch_clear_hugetlb_flags() to iterate over all the pages in a folio. >> >> This would likely also add a blocker for >> ARCH_WANT_OPTIMIZE_HUGETLB_VMEMMAP on arm64 (no idea if there are now >> ways to move forward with that now, or if we are still not sure if we >> can actually add support), correct? > > IIUC, it is not. We just need to guarantee each subpage has > PG_mte_tagged flag and allocated tags. The HVO just maps the 7 vmemmap > pages for sub pages to the first page, they still see the flag and the > space for tag is not impacted, right? Did I miss something? In the R/O vmemmap optimization we won't be able to modify the flags of the double-mapped vmemmap pages via the double mappings. Of course, we could find HVO-specific ways to only modify the flags of the first vmemmap page, but it does sound wrong ... Really, the question is if we can have a per-folio flag for hugetlb instead and avoid all that? -- Cheers, David / dhildenb