From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3639DC28B2F for ; Tue, 11 Mar 2025 06:03:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B19AA280002; Tue, 11 Mar 2025 02:03:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC8AB280001; Tue, 11 Mar 2025 02:03:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B7B2280002; Tue, 11 Mar 2025 02:03:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7F06A280001 for ; Tue, 11 Mar 2025 02:03:10 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CBF101CB7B9 for ; Tue, 11 Mar 2025 06:03:10 +0000 (UTC) X-FDA: 83208227340.10.1DE5C47 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf10.hostedemail.com (Postfix) with ESMTP id B8D91C000A for ; Tue, 11 Mar 2025 06:03:08 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741672989; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/HKIQeltzgDwUgYFlTVvM0O5leAJH07t6kwuK+SWKRY=; b=IOHBnfJxQH4WEHUVO9IXW4z2wR2AQkxXs6OqR+Wz+SScVEeDPvvNCdRMSWuFwA4DRiV361 u5omQuGmfCdse8Jem3AY4I+u017Vker7CqnCoUQIlWPKbaK8D9vYyv4ZKDl+igB7ngPaO7 XQiykk2roJC9921a8pfTZ2MO79fabl4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741672989; a=rsa-sha256; cv=none; b=vAasxdx5FIXYpjGgu1uAnTl9q0OrSOrKmtaAeSVmtgkOhdtOVBV6L6DosDF25HkpwVDEiu TC5cwojvTB+bolrzzW7usDT35T0Q263YQ0miybjZCZmQibmKYcXwA7ikyL1DXKvrtR/csn 1OAV34imWk0eOg2+P/55t6ZeGZjlgQ8= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 14EEC1516; Mon, 10 Mar 2025 23:03:19 -0700 (PDT) Received: from [10.174.36.193] (unknown [10.174.36.193]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 20D003F5A1; Mon, 10 Mar 2025 23:03:05 -0700 (PDT) Message-ID: Date: Tue, 11 Mar 2025 11:33:02 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] mm: use ptep_get() instead of directly dereferencing pte_t* To: Ryan Roberts , Andrew Morton , Lorenzo Stoakes Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250310140418.1737409-1-ryan.roberts@arm.com> Content-Language: en-US From: Dev Jain In-Reply-To: <20250310140418.1737409-1-ryan.roberts@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspam-User: X-Rspamd-Queue-Id: B8D91C000A X-Stat-Signature: e845nf4u4syonadzgp1omywe8cx43bbg X-HE-Tag: 1741672988-374442 X-HE-Meta: U2FsdGVkX1+G0LhCJJb905BhMzm6pwZweeR3BymMxzF4msH3ckiOLEMzRaIwZ8bPwNZ2K5bf9UlMFHJPa3mwsR3FViXWswxrA5/YXl1t6ZyxSJKT7+KyS9o9n9yv8iUuYm0eQCzZr+N0ORFmWZtZ+B1LKADuuuEOk3OqdNrgwv2984rLDhUGssUBwYLKhkEEbdYJsOeXN4SKYiy0e6MBOEvVbYg4nJVoTDX83SLngPesfHU2IeVbM2+vTNny2MBjyGx8o6GDoUbq7eQB6n7W1G190IbMLm8VSXlvtWGNUhK0MyYthyMK1+J9Drq5mg85xK6QC2eVVyDx+uDnGhcxlGZ9k7u71j/hnYvMGSjUU8mEyFc34RAg1PmFabAZ/bWe5Jdjtkfe/D5v8c3fsPZY43215j4SR2hvpRyA/4DoKfMmDQi2jAbEIIqipa/OoQpUYJSEn85o7lnHd7qNSaedXx1aeky07DMn8OQueQHeg4u6rCwk83acU3I1Cb14TIlDLRxnRa0ycC5QIVUw02mgDBEYTMC3kMCjIUUApGprm9bsstkemWmrgSHhKYbzUIwgvKJUF8Q6/ro9frPGtLtB88mddLegAFp2DcWRQc+M9nhw0+g3XVCRkn4aIQFOIi1fDq3myfNRdkrS+n9Tx0g7B8zGxpdoOwyrE9iFuwS22Y2JYPuIHwzuGc3/vNTju1kJofYjKkyErLYtPlJr2rTPIMusShwDVnUGsmiuxp749N8a6DeW+EKYrjh5S8MHKdKR4JpNiGmKi9wOULW36TkHAGkQsnk/S6yJULehsh+ZJgBe9sBaZcwjwyVqh0BT06rL72TC2HmsbrcCn/3ORFA/0X74MWVo/K2HFS9G6yX4R2u+GhXQv2o3UbXlDq7GmBKe4xCyhRyjVHpsQV8UftQzhRLnZtqEswSWzmvmC8FQUZA260JujBSeoC32n5O2Tq7TPXFa0MhiYJvFPtFQdKA WX5ipLBC wi4NreqtU+aCZoTWDq9iOYV5FAYAOc5+CsP8GJSdRfy5x96puUbVy2oWGslqYT0ikgCNFl+8uFiym+jw2n1xFGhfHh8xT/aXJ2Rz/YuVJlSmNQpvM9xPGJm0mKR5ogf13+DQCNq5Rhxo95anVSQsnd1190Z8govx9LTjn6gNAfgiL4euKSsesRQKYHbkKsp7DVsLaxnVTkK6wwpm8UWUBqiT/WHZ3ufybRlnRS9RQinjyGh6+hG0e3CkKTQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.079298, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/03/25 7:34 pm, Ryan Roberts wrote: > It is best practice for all pte accesses to go via the arch helpers, to > ensure non-torn values and to allow the arch to intervene where needed > (contpte for arm64 for example). While in this case it was probably safe > to directly dereference, let's tidy it up for consistency. > > Signed-off-by: Ryan Roberts Reviewed-by: Dev Jain