From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8026C35274 for ; Mon, 18 Dec 2023 15:59:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 887B86B0080; Mon, 18 Dec 2023 10:59:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 810FA6B0081; Mon, 18 Dec 2023 10:59:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B2316B0083; Mon, 18 Dec 2023 10:59:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 555B26B0080 for ; Mon, 18 Dec 2023 10:59:50 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1F7EA140209 for ; Mon, 18 Dec 2023 15:59:50 +0000 (UTC) X-FDA: 81580399740.14.821D3FD Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf14.hostedemail.com (Postfix) with ESMTP id 57787100012 for ; Mon, 18 Dec 2023 15:59:48 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702915188; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IzcCUNAohJNzInTQ2xsrZjXdFSalJM8++pt5uWYRauA=; b=kXWXYxMKUR8/HAsw6y/YmvrmXuks/v/t8zpUNOGrQ6oCPVgl+r0h27zTdm4hK81gH2xhz2 JO7WWGHSnNg2WLB/U9zTjV/6wxFJtAjubFRsqXpMzvjUlk3EQmW0p9DcVN98IKJ2VWxF/H sROxhMHc3vvR6fN6fuYLM8jzdGmS8FQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702915188; a=rsa-sha256; cv=none; b=XFwh2QlYnxr8HJo3k6PhJiwbsjEb2f5JVMHIRvB0ejCNTRA78/cZ16eBO1xVBQq/QUX8Th 7ybWMaAI7oI8S8Mi+FehdmhKI9gCesbFeokLYBCkemDU4TQlOM0NGQz3JeNypVqIrB02Km vP5/zBDAlyGe7ilhrdFc7RmTIFUbw1I= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E17D82F4; Mon, 18 Dec 2023 08:00:31 -0800 (PST) Received: from [10.57.75.230] (unknown [10.57.75.230]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AE9893F5A1; Mon, 18 Dec 2023 07:59:45 -0800 (PST) Message-ID: Date: Mon, 18 Dec 2023 15:59:45 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 11/39] mm/userfaultfd: page_add_file_rmap() -> folio_add_file_rmap_pte() Content-Language: en-GB To: David Hildenbrand , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Andrew Morton , "Matthew Wilcox (Oracle)" , Hugh Dickins , Yin Fengwei , Mike Kravetz , Muchun Song , Peter Xu References: <20231211155652.131054-1-david@redhat.com> <20231211155652.131054-12-david@redhat.com> From: Ryan Roberts In-Reply-To: <20231211155652.131054-12-david@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: iskux1gcgt6untnk1f7uz47gjajtx8e8 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 57787100012 X-Rspam-User: X-HE-Tag: 1702915188-265687 X-HE-Meta: U2FsdGVkX18KDZCtTaeqafkXh4MNkq6dDZJXiLS6z+ahynG7CJqdeUvBEg83Xe/eEZTNuay2gEMZ54LPwPXtZs9tQnFE023DC1roHrMypW/PpIH3TMjMw+kbDKgcBguG9VWsmSvOVKkKHvlc2uWEa8l00ZFnyW/jMOAX7s74TxmabTtrFPG20SXWPG+9GhWSQNa35f+7N2AFqtRI6lHQoYllrVsqDPIxsDdWsIuLIJG5+PEmwoXuW/NQAQjtRucSN0K/wXR3Xtd8G0lyivf5Z8db4uooagPFDPCfmU3xcQOMkCpttoZ6z1ZMtRWp8lGLQFqlriXM/rmBksRZl8SFGMoh3GdR+Ssv8H2F/BP9svObnXbLToT2W2L6K998BhOrTW2z6oeMwDIERsHlOYfCTNGzkbhxy17DX5oRNZHgL7hINMTndwm82AApMpT2wGzyThVb79fUgxsfeoQWHBUb/TfcIY6Vrc5VW5wxntVpV9R+aX135sssHCeJ86gCSUe7fHbh1pwgsOD5JG6NR5PHzocNoaq65E/RSubK5kWaqoM5dP5O5dqblktxR1Sv9aJg622pwnM/71tdaF8uTiwJbOSyluAGnWR6ruz49mH6jhCpxZFieMjfID+gVVlLhdrWenX8y50eO5gxVGtTBtr5HLTI1IfIPPlafyjUZeRKkpx9kmfabttSFJAXSKBx3jmbiaBW1xku5iFWbg3NF9r+/Suvva1W73qeWshy+xRq29dQ7LbOtr18CCnCzQ5HGJEBuArCPRjnq01vqq44xWv5Uql82ZK80X+0nKF0TypWFMZuxWLlwV2l6P4DMuOLwlzxzvElBufU6d+YirYSJPB1hZL0TEtCy6h+q4S7NnvfDxJFYxuiBBoe2Vy4byt5vW+5+vwllbjiguN1dbQFcKLClrSD+L9Vrwavv5WXxZ/1EQPq1fDtmTQJuQ46Gdo4YWbu9LUTG9IbY+LuRN4uveR noW1f1Je GmUFfew9gB0nCoJNxWxy16SPk9/aHnsDNQFLIcfz1Fdi99nRfXwbrqjlXQbKt2dA9A4A5jnDQ9R/An9hAOIbN+cDgZmzQVOiwQdPjLAOiIdijFRT2r2Im/Y1+Yynzpn1Wtlbqbuc+P/w7Js7YJaCxp87TifWzwmStwnKxaqylq+wh5XEqPYcbGYJTsMC5TyYQVXT3erzP3VpgulzpVDA7gkrZ+y4Hbls3zAyHE0GRy91NKcrPcDQENT8+mrrydIqenPksUtzeM/wHwjZ4anEwc8WYkoMmO5sGtx6qsrFWm2gILQM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/12/2023 15:56, David Hildenbrand wrote: > Let's convert mfill_atomic_install_pte(). > > Reviewed-by: Yin Fengwei > Signed-off-by: David Hildenbrand Reviewed-by: Ryan Roberts > --- > mm/userfaultfd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/userfaultfd.c b/mm/userfaultfd.c > index 9ec814e47e99..330a481a1654 100644 > --- a/mm/userfaultfd.c > +++ b/mm/userfaultfd.c > @@ -114,7 +114,7 @@ int mfill_atomic_install_pte(pmd_t *dst_pmd, > /* Usually, cache pages are already added to LRU */ > if (newly_allocated) > folio_add_lru(folio); > - page_add_file_rmap(page, dst_vma, false); > + folio_add_file_rmap_pte(folio, page, dst_vma); > } else { > page_add_new_anon_rmap(page, dst_vma, dst_addr); > folio_add_lru_vma(folio, dst_vma);