From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6105C64EC4 for ; Wed, 8 Feb 2023 14:26:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4937E6B0072; Wed, 8 Feb 2023 09:26:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 443A06B0073; Wed, 8 Feb 2023 09:26:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 30C276B0074; Wed, 8 Feb 2023 09:26:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 213B86B0072 for ; Wed, 8 Feb 2023 09:26:46 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DEDED1207C4 for ; Wed, 8 Feb 2023 14:26:45 +0000 (UTC) X-FDA: 80444350770.03.ACF59BB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id B1DAB40011 for ; Wed, 8 Feb 2023 14:26:43 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BEtSwUTm; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675866403; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2YoPhd9bpXWL6lLJ4NV4LZTMfi8HRWQ/LgINx7BRO7E=; b=apKJb7n09azd2AXKIbgUHOJeoBmhr0zYTBqHHcGOD+EnUGCnjYSQRGX2ouTnYhQY1g+cJt +FSeOJVCvwbGa4lWkNH5wlKO4wrT8eby7IuMA4r28l/gM7+l0phxcpgjt2cnye14xJv9m7 CjqsWLnafEER5ha+UE4xEcuT8hnkbow= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BEtSwUTm; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675866403; a=rsa-sha256; cv=none; b=m66cCLEwmZew+bG9+eUe6J7gYLZomWFDR8l2D9AH/Jk0nsFwuDA4Jlr7WVeIF60e1OGKdd 6AS1Y6iXQHmFFZ3icIjSCSx1YsZGXP+ip3u19DmUL72+bvwAbAtsy0gz6V15ulnRv8Uq5O JV9mIvzh9lFz94Luy4Ii3dyQD1wifBQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675866403; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2YoPhd9bpXWL6lLJ4NV4LZTMfi8HRWQ/LgINx7BRO7E=; b=BEtSwUTmPvQ8/4ABaIQxceOJf5cQtKcq8lxW9Njch6lHZlg4mfqMjKHtz7/U1V+c5xlX11 qc1EGd5FgZsKok3Gvip7Dz56dLnPitgJwQq5MrAkWGx5QM7GOOf3/EUKFLVpaSP6up+njV WgbsHA9ZvGKWJ+quY0Rj3twGctouSWA= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-440-d1YRHzu8OWGAFbymtnSLhg-1; Wed, 08 Feb 2023 09:26:42 -0500 X-MC-Unique: d1YRHzu8OWGAFbymtnSLhg-1 Received: by mail-wr1-f72.google.com with SMTP id y2-20020adfee02000000b002bfb44f286dso2924491wrn.11 for ; Wed, 08 Feb 2023 06:26:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2YoPhd9bpXWL6lLJ4NV4LZTMfi8HRWQ/LgINx7BRO7E=; b=BnOpzYZX13ysXUZkl6Bp/eV1K0ksywphO8X3A+zqIrX7Sjl18kTqTu5ticKpVvCQ/g iVW//9AHNBT3/NpY2EDXl5bgOG6nkGpsvsOmTqcR9alTkmaZSfyqbJ8+ko4J3oMXabDn NcD3TFPd4O0Cs2lnsC4DVkEwiwuPcdcCwy5vp/YE5nhcAxZ/KaasZJ9+3gmiapdhihAQ LbbLmbEE+tOPnQ+NusIafOWgh7Ibp/nVxm/5vf2GQ1J2toJtUJWaDp+9aeyChrmppkAj uyWYEyWOxeJickgPgJ+AZdRjoHk8bpAn6hPYPrO8lXbN86lMaeJSev23NupIo+tanfyQ n2OQ== X-Gm-Message-State: AO0yUKUfRenqsfOk7E4++g/0Zvv80IJsNE+DvAHv3yOz3luTDLu9/6k6 NM9E4y0bMRlTxPyRv3GNQtHhf6L5Q4KmDSSntwZK6DV/f0ZalhW1aMJ/Ym7lUE82NKQUlOL/yQp suYVOY5KnK5k= X-Received: by 2002:a5d:5604:0:b0:2bf:ae11:c40c with SMTP id l4-20020a5d5604000000b002bfae11c40cmr7369940wrv.32.1675866400584; Wed, 08 Feb 2023 06:26:40 -0800 (PST) X-Google-Smtp-Source: AK7set+DV96N30MkqzzVb8t/lSlsYdo8AFzmYGBbibLbqozBJjq5Ryn9hpbgMTMc/FhikE/ugG1nrg== X-Received: by 2002:a5d:5604:0:b0:2bf:ae11:c40c with SMTP id l4-20020a5d5604000000b002bfae11c40cmr7369925wrv.32.1675866400330; Wed, 08 Feb 2023 06:26:40 -0800 (PST) Received: from ?IPV6:2003:cb:c704:b300:758c:6214:cd51:8ab0? (p200300cbc704b300758c6214cd518ab0.dip0.t-ipconnect.de. [2003:cb:c704:b300:758c:6214:cd51:8ab0]) by smtp.gmail.com with ESMTPSA id bv20-20020a0560001f1400b002bc8130cca7sm13640519wrb.23.2023.02.08.06.26.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Feb 2023 06:26:39 -0800 (PST) Message-ID: Date: Wed, 8 Feb 2023 15:26:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 04/13] mm/gup: move try_grab_page() to mm/internal.h To: Jason Gunthorpe Cc: Alistair Popple , David Howells , Christoph Hellwig , John Hubbard , linux-mm@kvack.org, "Mike Rapoport (IBM)" References: <4-v2-987e91b59705+36b-gup_tidy_jgg@nvidia.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <4-v2-987e91b59705+36b-gup_tidy_jgg@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B1DAB40011 X-Rspam-User: X-Stat-Signature: 7nrtxdfj9g4hrdnbgi4fo3db6mru45wy X-HE-Tag: 1675866403-53227 X-HE-Meta: U2FsdGVkX19+/QXIorzFXAgDpqAs9OrGLoVpU+Z/hlgEZaAOPfzKF47xTZrjfwF0pF0cGrjEZ8ZzMFYDfrWgA6E8gYNbcPrF4bKBiHAMtRh3mwixYspDmhTW9WSJiWSjg89hgYPhxtlXpKw7L9kYH7kXiznSHfLQcgZUrqqIbAWqoqWEYQKUaN2by+ROsmH7LV5OmDXH3jx+2Np2voOnCVv5+naOwz10fcxCeeSfUHlM80u2ysdgy0bVbhCYkpKySOltxU3uFwi7GmGsmmvPP6IjBNRoBfRHFiOqf5Rqk9C2IW05Bmlduai0A22dhBhuPbJ4KXPv3FnVg+bsRTyAVSo6meEO96OoOz+DrAW83kWR4Z3hsTqqqqtfLsiCNEwwWyAPZz+0IPfhAk2zbeYM8A6ZW9N3rfNu9w69aTwhml6ZmtR3WiQrOy7TqcidqvbmXJHCirTuVIMMvaFyUKFNjFY6qXTxZwPbcFwi5HbA0Fm1stT9xGrObAb3g033o0wWuhqgG+LsiYv+EfZhdSL41XDiKF0adKj2FFVngZTgXwheJLibc/T3EgIYMx6DwofaA4hpfIqrSrfKh55Dq35xFGLmbf1RHPNAeHeFgpLr3Rb00CDMPqvBZ0GwsWHf7YGMf1WtkPQWyAThYL5gDQO6WvJI8NShH274NLgcwwX+ZVZj6RKJuQfQz9Yl9msOZKZ+7w1gK3HLOVydCO4lBbgHzrOuQ2EpyA+Wnqp9vkRSYmo4vGC7AifO4fLh5VcBb2yhbXxsNN2WehL+bufqCyn6o4YlN7AbNTF/g0lDolDnilBPeiaLaIRHoCq5RrWOVYe9LBCaAX5lGthL2EUMmMEpLesCIt9qRTUefnFhCQmmQPu+d0gObW0aDt4TjKRlc/E4RbcFCmqNBraRAf6pmjYJ7EYMABZFIHsQBuheoEejHGlF+OPq3DWOd6bXVcBBV7qgh2LpJ95EB5PwgVV+NBU pshUojnD vYz9LdhAPJ0w96Cw65ESmtuvOgK/az2CumPIRru/0rTsO9qcpfnrFxKWh2KjFC1PUBdsru1ecQJ8WUt8fqJAUD2bzPILM9LCuuj0dt2hFho4bPgCwxZ+EAozqk5Sm9xJJMQ5Plq2E8ieFaMcoju6WtUS1Mi3k3sS69+lNBBszCGQwjQtZ7qTrtHjA66OsfIxFp3Tcgnt08jea8mFkQDQVbTEguI7alGSsK1W/fb35pNlZOteNe1Nve8ROZgUY3Cl5t4NK2Moty8/dzz6OK0aeADLDDcaS68zoALQ45P/kQ9aoltOlV6fDDV8vA02z4GaPXZAIciq22bjZ0WbZLIRSuvPY0hPEOCyD73iTLy8NTdffb9zq5zSPqoxhCQyH39uOG+e+yDtW7STtTes= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 24.01.23 21:34, Jason Gunthorpe wrote: > This is part of the internal function of gup.c and is only non-static so > that the parts of gup.c in the huge_memory.c and hugetlb.c can call it. > > Put it in internal.h beside the similarly purposed try_grab_folio() > > Signed-off-by: Jason Gunthorpe > --- > include/linux/mm.h | 2 -- > mm/internal.h | 1 + > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index c9db257f09b307..dfc2a88bc4a8ed 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -1173,8 +1173,6 @@ static inline void get_page(struct page *page) > folio_get(page_folio(page)); > } > > -int __must_check try_grab_page(struct page *page, unsigned int flags); > - > static inline __must_check bool try_get_page(struct page *page) > { > page = compound_head(page); > diff --git a/mm/internal.h b/mm/internal.h > index ce462bf145b441..0f035bcaf133f5 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -852,6 +852,7 @@ int migrate_device_coherent_page(struct page *page); > * mm/gup.c > */ > struct folio *try_grab_folio(struct page *page, int refs, unsigned int flags); > +int __must_check try_grab_page(struct page *page, unsigned int flags); > > extern bool mirrored_kernelcore; > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb