From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DA21EB64DB for ; Wed, 14 Jun 2023 06:46:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B5C36B0074; Wed, 14 Jun 2023 02:46:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 73E116B0075; Wed, 14 Jun 2023 02:46:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 62D598E0002; Wed, 14 Jun 2023 02:46:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 539646B0074 for ; Wed, 14 Jun 2023 02:46:08 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 20C1F1C83C4 for ; Wed, 14 Jun 2023 06:46:08 +0000 (UTC) X-FDA: 80900418816.21.75D4F9E Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf14.hostedemail.com (Postfix) with ESMTP id 0960910000E for ; Wed, 14 Jun 2023 06:46:03 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf14.hostedemail.com: domain of mawupeng1@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=mawupeng1@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686725165; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=koi7J/T+G0LP5J7UHOUTrx5PlJmu7P2SfnlOZgR7K4U=; b=Q6I0IjEfp8BYCJK5wdmmnEr8qqBF8n0gBwKM50mwCjWyfd9+9NNVi8gqhKKNv9g8do7hgt smif6DwZImy1DVGn8dQt6+ZT4nLVM4itF/YpIiZp1fHzkmjfuVJ787fboc6CB6DStKBQer fkUt+nP41cmcwSuMnOZe6v+te/GKXsc= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf14.hostedemail.com: domain of mawupeng1@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=mawupeng1@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686725165; a=rsa-sha256; cv=none; b=z6yWk7wTJCaH6wHKcxbgRe50FMI98j4T9xPSji8feponAWdP3UWXA20iT+03nsufeE5qM+ WiEa/SCLI8dnEQCdzswOBPb02dmWiMBbLHMP3MGXJs8GXzIxzIfk0bljnHtCdrQ278FaRY lJQNDiBSuStrG4+KZqz6ckLuWYk6iyk= Received: from dggpemm500014.china.huawei.com (unknown [172.30.72.57]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4QgwmZ4blkz18MCF; Wed, 14 Jun 2023 14:41:02 +0800 (CST) Received: from [10.174.178.120] (10.174.178.120) by dggpemm500014.china.huawei.com (7.185.36.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 14 Jun 2023 14:45:58 +0800 Message-ID: Date: Wed, 14 Jun 2023 14:45:58 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 CC: , , , , , , , , , , , Subject: Re: [PATCH stable 5.10 1/1] mm/memory_hotplug: extend offline_and_remove_memory() to handle more than one memory block Content-Language: en-US To: References: <20230614061900.3296725-1-mawupeng1@huawei.com> <20230614061900.3296725-2-mawupeng1@huawei.com> <2023061440-showing-happiest-937e@gregkh> From: mawupeng In-Reply-To: <2023061440-showing-happiest-937e@gregkh> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.120] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500014.china.huawei.com (7.185.36.153) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 0960910000E X-Stat-Signature: 8xax6tdarbum88rckhjra59skk9zupjh X-Rspam-User: X-HE-Tag: 1686725163-263132 X-HE-Meta: U2FsdGVkX1/RRTcno6V8LFgVHBzMKDSKSKU7IKMRrHZ8/sHuXD1nbZOtnOpDvL1naIwrbNndreEPCcVhKpXaF8ZLzeaurcOMmOF7ZHOvzhh1WmWJhq80R9ByHdnoskkaMXIh3vhkpPRWt41HZCkJ9Lm5NjYDqqMNDSFdnfBfXH9h2i0HgpwdPmkMZwzC8PEM7sFPcvSKxTjynP69gmofMsdWoH422r8NbyvLt/UgUmZ9Lheg53G1OrBbLIkGBbAFZpePrfoufijQWLzOULd/BdojIIEIYm1Aiv5GVhQFsaRh47PIoxAuzVT1GbNabs4gBQhKepstNlq6XAF/+c8ZE1hKQav+wIC9Wm28fR2xgfTET53C32GWSRZHPYxQg6PznH53Rb1YQwgBgVX422b/jjzy+b8xiq3d9mAnhrQr1d/cGUc9XtJMYtWUsi9Y7uex2prj29sd67jRFU/UrDgigVVmvptj2yvc8okoutVfl7km9kOx2I2SJ65FfiVZOxkKcMMKbQEWCj7dW8GiZH2SNvX+1irbwn+1oodHhtPXzDv25/XbK5hm5AEtfdYh7VKrY3EBpjOERG65yexYyNa7aBmUoMASN6wJm03NDz+or9nVe2nQG+hOSua5/4oYFAtSKMhBdxaEG0jM9gQvgIqUUmk6kK674OuJkxZyy9YxIylrs9EgkyZNgjsGRiWTrX9XIvSqvd5DS9HMxKZy7At8vTNneMn/NCeFi6ig+WPAaPTJDUPDB3aYNulaXxT99nzJmXrnT2Jkfjbofi39Uv+jCXwwESM7bnraBoBx75z84avzdAQIatErCFXAJWoKrTms2wUlz0U8eqwKuZEwXVmVL99MopMSStjZtSVfLgVqj/lKEWAifO7kbhcV7UiqM3My3dq/8wVgbgIDavtNkzVIv1H5rU5uYTvTd6lhioEXjkY1P1nyq2VkjJd31HEmW5ERAzdkEsmEGm5IhamYdAJ 8mCOD4MK A+x4dFWFopfglpWWfCpothgI3mq5BjWbN7/mIJBb5EiMa654mYys7XS4mp7hcryAosub+W1ewRYpnbAAk1ffJ0yvforpUjbPrRwfQYtanaTuWklGetyZH7HbGjMo6QbEZei0c1nXjFWBO1zgwCfjddSbbtWYria2yANJcClCnv3eyYpGWjWImhysl7CZbHRR651UMyJJaqSm9Lum315W/qYO15J4KvIHMyxOpSABL8T1AMwKpKWrBTPbUYK//ZXFBtQ+ekk7keV8FbfjIvoFn1vWJWjlTFIwUfSnCZ8iW5yG/1pPEEiyOnRGJ1NsqgHmF6Z4gEOOnsP5AxhPW9ctQnKqVbrqP3wmPh/x103UVXJicBu0Ac023w205YgD+HPZ3dFi1lTYtCUBbqxPcVxbuLxV2kW2UU9Kt8CrPxudbF5kFY1VdesGppxdzs5z31G1+UXXRQ9/+qAqkNEW9XGDjbW5Ung== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/6/14 14:35, Greg KH wrote: > On Wed, Jun 14, 2023 at 02:19:00PM +0800, Wupeng Ma wrote: >> From: David Hildenbrand >> >> virtio-mem soon wants to use offline_and_remove_memory() memory that >> exceeds a single Linux memory block (memory_block_size_bytes()). Let's >> remove that restriction. >> >> Let's remember the old state and try to restore that if anything goes >> wrong. While re-onlining can, in general, fail, it's highly unlikely to >> happen (usually only when a notifier fails to allocate memory, and these >> are rather rare). >> >> This will be used by virtio-mem to offline+remove memory ranges that are >> bigger than a single memory block - for example, with a device block >> size of 1 GiB (e.g., gigantic pages in the hypervisor) and a Linux memory >> block size of 128MB. >> >> While we could compress the state into 2 bit, using 8 bit is much >> easier. >> >> This handling is similar, but different to acpi_scan_try_to_offline(): >> >> a) We don't try to offline twice. I am not sure if this CONFIG_MEMCG >> optimization is still relevant - it should only apply to ZONE_NORMAL >> (where we have no guarantees). If relevant, we can always add it. >> >> b) acpi_scan_try_to_offline() simply onlines all memory in case >> something goes wrong. It doesn't restore previous online type. Let's do >> that, so we won't overwrite what e.g., user space configured. >> >> Reviewed-by: Wei Yang >> Cc: "Michael S. Tsirkin" >> Cc: Jason Wang >> Cc: Pankaj Gupta >> Cc: Michal Hocko >> Cc: Oscar Salvador >> Cc: Wei Yang >> Cc: Andrew Morton >> Signed-off-by: David Hildenbrand >> Link: https://lore.kernel.org/r/20201112133815.13332-28-david@redhat.com >> Signed-off-by: Michael S. Tsirkin >> Acked-by: Andrew Morton >> --- >> mm/memory_hotplug.c | 105 +++++++++++++++++++++++++++++++++++++------- >> 1 file changed, 89 insertions(+), 16 deletions(-) > > As you forwarded this patch on, you too need to sign-off on it. Thanks for reminding me. Signed-off-by: Ma Wupeng > > Also, what is the git id of the commit in Linus's tree? Sorry, here is the commit in Linus's tree. commit 8dc4bb58a146655eb057247d7c9d19e73928715b upstream. > > thanks, > > greg k-h