From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B264AE7716B for ; Wed, 4 Dec 2024 11:35:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 309318D0002; Wed, 4 Dec 2024 06:35:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2BA8A8D0001; Wed, 4 Dec 2024 06:35:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 15B828D0002; Wed, 4 Dec 2024 06:35:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EBCF48D0001 for ; Wed, 4 Dec 2024 06:35:06 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 92E4C1A0FEC for ; Wed, 4 Dec 2024 11:34:56 +0000 (UTC) X-FDA: 82857069372.30.9E445B2 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf18.hostedemail.com (Postfix) with ESMTP id 9C5091C0010 for ; Wed, 4 Dec 2024 11:34:47 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=0NW3vBdI; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jPvzJv34; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=0NW3vBdI; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jPvzJv34; spf=pass (imf18.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733312084; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zUstk8tbjq5S0I1KhklgFOKjNgIM66FGicV9JJOnHG4=; b=YhtUgQhuOcPI37Ez5JVbkQGHqYLie7NQ9MzXUS7jD8rTaJus3Cjkz325H9h5Nkg0NZh/Oa OZ5XwSiw07UCsVcKBX4Pe6rvFkWFq00jgyuD40kUSqAx0Dl6UOCoJeVFcXIgmLW5YXHtXZ r1Vywa9LJIQqvpimAxtVTtwSSx0P/6I= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=0NW3vBdI; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jPvzJv34; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=0NW3vBdI; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jPvzJv34; spf=pass (imf18.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733312084; a=rsa-sha256; cv=none; b=WxOA0i1mDt7/AVZTmheO23tE9nxvLzjuXt1EpiaXT0c8wOPRYAol22PkCAvf2D/NacmnOY FGASAFNwL/AhqWLrxgbEU9HnYfLI1JaqiFh1LZP/q7t+C1ziYNre41qzLUTXzZk2FgkDQE SJ4B1SIWXB6mNQDOuta/iuBpRZWd6bY= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 702E61F365; Wed, 4 Dec 2024 11:34:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733312092; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zUstk8tbjq5S0I1KhklgFOKjNgIM66FGicV9JJOnHG4=; b=0NW3vBdIjpaU002zGBNWBCIop+uUbULgIdalfeDXL/kzNel8m8mij5EgsxUFWY7aur5mfd GR2fBoTpspRfYxvFj88mqUOQRg7zb4oY0ve1J7IOjv833GRVInT8ijbTRFyqMPKAv7UxSI AJmmnd041hejwJMjGaql0kHb1z2AmY0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733312092; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zUstk8tbjq5S0I1KhklgFOKjNgIM66FGicV9JJOnHG4=; b=jPvzJv34d8auGHsvuAheUQ3vNaJb7qi2oTF+hIM6vFotMjWH837oFXhmZjJaQWwBXxm0lE X61fRpXRa80g9/Ag== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733312092; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zUstk8tbjq5S0I1KhklgFOKjNgIM66FGicV9JJOnHG4=; b=0NW3vBdIjpaU002zGBNWBCIop+uUbULgIdalfeDXL/kzNel8m8mij5EgsxUFWY7aur5mfd GR2fBoTpspRfYxvFj88mqUOQRg7zb4oY0ve1J7IOjv833GRVInT8ijbTRFyqMPKAv7UxSI AJmmnd041hejwJMjGaql0kHb1z2AmY0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733312092; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zUstk8tbjq5S0I1KhklgFOKjNgIM66FGicV9JJOnHG4=; b=jPvzJv34d8auGHsvuAheUQ3vNaJb7qi2oTF+hIM6vFotMjWH837oFXhmZjJaQWwBXxm0lE X61fRpXRa80g9/Ag== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5A2B71396E; Wed, 4 Dec 2024 11:34:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 1G02FVw+UGeFFQAAD6G6ig (envelope-from ); Wed, 04 Dec 2024 11:34:52 +0000 Message-ID: Date: Wed, 4 Dec 2024 12:34:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 14/15] mm/mempolicy: Add alloc_frozen_pages() Content-Language: en-US To: David Hildenbrand , Zi Yan Cc: "Matthew Wilcox (Oracle)" , Andrew Morton , linux-mm@kvack.org, William Kucharski References: <20241125210149.2976098-1-willy@infradead.org> <20241125210149.2976098-15-willy@infradead.org> <2A0E6E69-5765-411C-8667-C49A2392F10F@nvidia.com> <0583ccce-538c-4291-89e8-2e0223b2c7fa@redhat.com> From: Vlastimil Babka In-Reply-To: <0583ccce-538c-4291-89e8-2e0223b2c7fa@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Stat-Signature: 76oyoneyipg96s3nebmemh9pahddmo1t X-Rspamd-Queue-Id: 9C5091C0010 X-Rspam-User: X-HE-Tag: 1733312087-225670 X-HE-Meta: U2FsdGVkX1/dsJLYqTA7pA2e8Nk1JULZ6wt/6/CnQLo0Pq+6gFGm8JhquBcbNX1XhY2jGQP+/z7x+gdEBG9YH6DYxbgg2ZS85L84DRnFxGDnA0A52rnMlgVHSO4x4bRoL9Zho99NvB/yclpmzY0scMPmvWfx7tyaIHhSWNpCa8GqnQvD2Sa6B71JNOkBA/7lFuRj6P2unVoCYz+z+Z5cGjrStisGHl9eVF67cJSbI+SIhffsCTArifJGVjSCqoe6fCJIw6Mg/WQkqh+VKVHd/CTJl/B2kM5X/CRIExQOmdBhIx4nMy7DYD3w+owexrLHKKc8y+JBgUSpVJvARDe0WfV2RVoTY+4I033RXgAgW1ke8ZHClVRbASnnkjcIIpYoihKyURXDXDz8dlmgJqKrCYe7ERE9pazWo3Poir2EAdXv8lcygwhaGg6sH111JAuX4Xi1cFPGqfACCfWQLlfmkJFnnm8vkIJos8MzDWB/XWwQbwaP1CpajMKzRt0oBqFlQqSvsCBk4OeXF5IgNoGzcI/yQAP6QlalvSFXkxZxwIxHosffrnJQJwG8e3uSg18iWlaH3wP6675c61pjEotTjcGpwsfjyz2OWttlyv3TR83f3Ha8Y7CXopiCiAm3jNGc9Vg1tSuu88UIYEQ/iInMT3aTmV+MONsCXXmdauXYYTwNXIuwXw93Ad4162jifyX0FNlvj82hACZugC/LoL0ZKhfC9XmXwXBINO4K/y0NC/15FlJBBBm3elCYwukSzsZe94V+fEdkPADhEC1QJ67Sqo1buJxkL+F3kTSI5OMfvaTEFpKezGURzP5+3Q+4RtvTa1w4GGpWsQ0ASHUeXAa8RsaqpV3lgqGG2gt+nl0i0iVlzA/ps4k9L9YPdLgSDeVwIOSqXqJm6sZXdDmK44xYf/zPvqqro6P3MvTnMGyQMwdE5Wqk7Y1wKvvc5fHMWCYZ8q8az5A3flaEK2QagR+ 6eclQm5J otj6BYp1XwDhqMoxFgHI8u1pPX4pmbaO3xW7nv0qoyHdV1wN2tSuI5Q5eLXVSnw9buT1D5prYxWVDeCrcrBR3/j5h9QtNpZKFnJ2MY9qa2CUDyM/uHioETqqRI7P2EvkcTJ43ylZZfnD0Pv+Ry/W08Zdv1xB2oo1n10U6GFrZWMyR0SY6HeMvwmEDYSizM8X/UliAJpyi8n0gplsA8ke+UVRhNsi/ggVYUL8542lX6cWKBkozYxLk3PlUlbTOTLrO5+N2VezgQtBtzqWP4Pp77vGYFRHM+Vp4hzDCfIBEvybf+RTz1nwzu33PEJbV4U1nxgTQww0UlpJFBf0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/29/24 18:18, David Hildenbrand wrote: > On 29.11.24 17:29, Zi Yan wrote: >> On 29 Nov 2024, at 9:44, David Hildenbrand wrote: >> >>> On 25.11.24 22:01, Matthew Wilcox (Oracle) wrote: >>> >>> What I don't quite like is that we now have a bit of an inconsistency, that makes it harder to understand what gives you frozen and what doesn't give you frozen pages. >>> >>> alloc_pages(): non-frozen/refcounted >>> alloc_frozen_pages(): frozen >>> folio_alloc_mpol_noprof(): non-frozen/refcounted >>> alloc_pages_mpol(): ... frozen pages? >>> >>> >>> Ideally, it would be "alloc_pages": non-frozen, "alloc_frozen_pages": frozen. I don't mind it that much as long as it concerns only static functions. We didn't add _frozen to all those in mm/page_alloc.c either. The exported ones seem consistent, AFAICS? >>> The same concern applies to other internal functions, like "__alloc_pages_cpuset_fallback". >> >> Or all internal functions (with "__" prefix) give frozen pages and external >> ones give non-frozen ones, unless with frozen in its name, i.e., alloc_frozen_pages()? > > If we go that path, we should make it consistent for __free_pages() as > well I am afraid. That one seems to have many callers so not worth the churn.