Re: [kbuild-all] Re: [linux-next:master 9576/10864] include/linux/rcupdate.h:412:36: error: dereferencing pointer to incomplete type 'struct bpf_prog'

["Chen, Rong A" <rong.a.chen@intel.com>]

On 1/6/2022 12:15 AM, Jakub Kicinski wrote:
> On Wed, 5 Jan 2022 17:21:31 +0800 kernel test robot wrote:
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
>> head:   7a769a3922d81cfc74ab4d90a9cc69485f260976
>> commit: b6459415b384cb829f0b2a4268f211c789f6cf0b [9576/10864] net: Don't include filter.h from net/sock.h
> 
> Thanks for the report!
> 
> I'm slightly confused how to read it.
> 
> The issues is already fixed by commit 7d714ff14d64 ("net: fixup build
> after bpf header changes"), which is present in linux-next. Should this
> report be marked as "already fixed" or "transient" somehow? Why is head
> reported to be at 7a769a39 when it must in fact be at b6459415 for the
> build to fail.
> 
> HEAD has a special meaning in git, it's the currently checked out
> commit. Perhaps we can avoid using it with a different meaning?
> Maybe put the hash on the "tree:" line in brackets instead?

Hi Jakub,

Thanks for your reminding, The HEAD here should be the confirmed commit 
that the bot fetched at that time but it still has the problem.
in this case, the bot didn't check the HEAD (7a769a39) which causes the
false positive.

Best Regards,
Rong Chen



> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master (7a769a3922d8)
> 
> 
>> config: i386-randconfig-m021-20220105 (https://download.01.org/0day-ci/archive/20220105/202201051741.TQVhjCyh-lkp@intel.com/config)
>> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
>> reproduce (this is a W=1 build):
>>          # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=b6459415b384cb829f0b2a4268f211c789f6cf0b
>>          git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>>          git fetch --no-tags linux-next master
>>          git checkout b6459415b384cb829f0b2a4268f211c789f6cf0b
>>          # save the config file to linux build tree
>>          mkdir build_dir
>>          make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/net/ethernet/mellanox/mlx5/core/
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@intel.com>
>>
>> All errors (new ones prefixed by >>):
>>
>>     In file included from ./arch/x86/include/generated/asm/rwonce.h:1,
>>                      from include/linux/compiler.h:266,
>>                      from arch/x86/include/asm/atomic.h:5,
>>                      from include/linux/atomic.h:7,
>>                      from include/linux/refcount.h:95,
>>                      from include/net/act_api.h:9,
>>                      from include/net/tc_act/tc_gact.h:5,
>>                      from drivers/net/ethernet/mellanox/mlx5/core/en_main.c:33:
>>     drivers/net/ethernet/mellanox/mlx5/core/en_main.c: In function 'mlx5e_alloc_rq':
>>>> include/linux/rcupdate.h:412:36: error: dereferencing pointer to incomplete type 'struct bpf_prog'
>>       412 | #define RCU_INITIALIZER(v) (typeof(*(v)) __force __rcu *)(v)
>>           |                                    ^~~~
>>     include/asm-generic/rwonce.h:55:33: note: in definition of macro '__WRITE_ONCE'
>>        55 |  *(volatile typeof(x) *)&(x) = (val);    \
>>           |                                 ^~~
>>     include/linux/rcupdate.h:854:3: note: in expansion of macro 'WRITE_ONCE'
>>       854 |   WRITE_ONCE(p, RCU_INITIALIZER(v)); \
>>           |   ^~~~~~~~~~
>>     include/linux/rcupdate.h:854:17: note: in expansion of macro 'RCU_INITIALIZER'
>>       854 |   WRITE_ONCE(p, RCU_INITIALIZER(v)); \
>>           |                 ^~~~~~~~~~~~~~~
>>     drivers/net/ethernet/mellanox/mlx5/core/en_main.c:569:2: note: in expansion of macro 'RCU_INIT_POINTER'
>>       569 |  RCU_INIT_POINTER(rq->xdp_prog, params->xdp_prog);
>>           |  ^~~~~~~~~~~~~~~~
>>
>>
>> vim +412 include/linux/rcupdate.h
>>
>> ca5ecddfa8fcbd Paul E. McKenney 2010-04-28  407
>> 462225ae47d717 Paul E. McKenney 2013-11-11  408  /**
>> 462225ae47d717 Paul E. McKenney 2013-11-11  409   * RCU_INITIALIZER() - statically initialize an RCU-protected global variable
>> 462225ae47d717 Paul E. McKenney 2013-11-11  410   * @v: The value to statically initialize with.
>> 462225ae47d717 Paul E. McKenney 2013-11-11  411   */
>> 462225ae47d717 Paul E. McKenney 2013-11-11 @412  #define RCU_INITIALIZER(v) (typeof(*(v)) __force __rcu *)(v)
>> 462225ae47d717 Paul E. McKenney 2013-11-11  413
>>
>> :::::: The code at line 412 was first introduced by commit
>> :::::: 462225ae47d7175f886281d8a91708550cd5178c rcu: Add an RCU_INITIALIZER for global RCU-protected pointers
>>
>> :::::: TO: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
>> :::::: CC: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
>>
>> ---
>> 0-DAY CI Kernel Test Service, Intel Corporation
>> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
> _______________________________________________
> kbuild-all mailing list -- kbuild-all@lists.01.org
> To unsubscribe send an email to kbuild-all-leave@lists.01.org
>