From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89420C001E0 for ; Wed, 19 Jul 2023 17:34:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF4AA280079; Wed, 19 Jul 2023 13:34:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BA5BF28004C; Wed, 19 Jul 2023 13:34:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A45F2280079; Wed, 19 Jul 2023 13:34:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 95A1928004C for ; Wed, 19 Jul 2023 13:34:37 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5D4DE160402 for ; Wed, 19 Jul 2023 17:34:37 +0000 (UTC) X-FDA: 81029060994.16.DB46E4F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id D18E340011 for ; Wed, 19 Jul 2023 17:34:33 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aJIQ1pZv; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689788073; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FcSmUlnfPR5r9QDVWlDed1kmwKvJ4NFeMyH/cuBuG7c=; b=MzNcH/csTc8E2CxJz+t3mQjorH/zXzsnXTO8M1FbN+A22cxDr+R7+a9yKauRT8Wh3VLYpj d7l+YCvW1BRvpJdgV/AHnWtGAKHLjzlvMd66iG0ycSIGQ6OB43bTGiHbEHhDM9GdqcrPmo xcpFvl3kcAezGdwngbZdTMk9mLaelc0= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aJIQ1pZv; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689788073; a=rsa-sha256; cv=none; b=kWbh6CFthFp5xlG2o4LZdc0+lHDMTda/pOiqBCBkdGYoF5b2Suv4XNW6hK0M4E0He+Z/dv eXtbPUPBLaooKk3ouVcnPgjrgH6Lm4giQKvIvwaJ2ffrM5dRvOcVG9ywD0ah8xZgkuuJfK rVUCQKIsU0dej09KiuoMLYLXw4ilNcQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689788072; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FcSmUlnfPR5r9QDVWlDed1kmwKvJ4NFeMyH/cuBuG7c=; b=aJIQ1pZv7q/wIa0U6GOXFXtQxyIJ33KBK02wqOK6PSO9E5EbEXNLEBa1t+b//BlYgrxsd+ vSHN/FQip+4dtOGz7TnGt5CBLuwO64EJtuuKotGqK51JfjYyh1LdUTBAsg/7W1lqlagc9a Z/1uWwPgIvslU+jwYTHoFhWHDzdilKU= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-42-NAPCPLiWO-iZZP7oG-XNGw-1; Wed, 19 Jul 2023 13:34:28 -0400 X-MC-Unique: NAPCPLiWO-iZZP7oG-XNGw-1 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-94a355cf318so419953866b.2 for ; Wed, 19 Jul 2023 10:34:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689788065; x=1692380065; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FcSmUlnfPR5r9QDVWlDed1kmwKvJ4NFeMyH/cuBuG7c=; b=YftHHq+d2f8GOkQsivt909tpVytRwa6leusQkdV0VMcYbsFQBKnLYi/fyRAGquBXAx dhOvCRxkoe/EoZ9uX4WbFw1CpDRM++qLY03H73i0gsjEqVDknwSvL1o24WfPwc0jsbuV S0J0dEu9+8E9m9wr36hI4TWwuGNhiIFZeBQrTk1SRGCzRsboYYPvejVgEk7u0CYsCsnU GWSBr1eEkKk6iJtBEwdrmPkUH7Ct8Nu06CAA8RmPcb0mihCIJ7wH1JFGHaLAxsePqdVT rpdVcSbFZHIMlJMCmQPBMZQNKE0ij0nYP/iYgsjbUeUrXwoQo32b2IrPb7zLrVOMqe26 sJjA== X-Gm-Message-State: ABy/qLYcxbooFnv5PJp8HWVU8ckUFfHbUj5SPx6u1XyZWsLvlC9wJ7n5 ZQsEjAqDZXdCLh6L2Ib+6ww/wNC0u+ZD0Zt6hK84ldBAfyL+CUw68LVnIpqFoQ/HYn5fGsAkjCv V8WEbS6pqD7s= X-Received: by 2002:a17:906:2c9:b0:987:6372:c31f with SMTP id 9-20020a17090602c900b009876372c31fmr2869612ejk.37.1689788065622; Wed, 19 Jul 2023 10:34:25 -0700 (PDT) X-Google-Smtp-Source: APBJJlE859wKxHT5sx+ykGb2dhB/IoiUODuwlK2Yw9t+Sd2xKiIGoiM0e7JvZWSr4FhhJlM9v/AU5Q== X-Received: by 2002:a17:906:2c9:b0:987:6372:c31f with SMTP id 9-20020a17090602c900b009876372c31fmr2869597ejk.37.1689788065328; Wed, 19 Jul 2023 10:34:25 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e? ([2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e]) by smtp.googlemail.com with ESMTPSA id gz18-20020a170906f2d200b00991faf3810esm2633958ejb.146.2023.07.19.10.34.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Jul 2023 10:34:24 -0700 (PDT) Message-ID: Date: Wed, 19 Jul 2023 19:34:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: Sean Christopherson , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" , Alexander Graf , Nicholas Piggin Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Peng , Fuad Tabba , Jarkko Sakkinen , Yu Zhang , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , Vlastimil Babka , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" References: <20230718234512.1690985-1-seanjc@google.com> <20230718234512.1690985-5-seanjc@google.com> From: Paolo Bonzini Subject: Re: [RFC PATCH v11 04/29] KVM: PPC: Drop dead code related to KVM_ARCH_WANT_MMU_NOTIFIER In-Reply-To: <20230718234512.1690985-5-seanjc@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: D18E340011 X-Stat-Signature: r9ct9s49zr9jp186w8dwdzerkz797i98 X-HE-Tag: 1689788073-453013 X-HE-Meta: U2FsdGVkX1/uGl9c8zhuFUx0QpEq8eGfWxBlGBd0eJgpayLbN0jYSMN45LJjJkOsaWPIdr28w/8F0JGZQHF5/bAw1TnrOFNpjLhXXOExevAIn3Z6cfR7aDbgeOj8iiXTAZC5pz2FJxg36jcOKtYkuIEm19hVBsmGuInf0H4IAEHx/i2jGBb69uaWF2RSmgSYj6jH+IbNF48jQ1OoWXVTZ8seGeuE+sGTefAE3YbYFnPmIeddGH1+jvPqs5UavLy3w5fOGtdkYvCuAqBx7DHuigE2n94TUs6teTMPiVgFk/FQp+njV1gFQ0VAWav7llY+8h8Gw8CanpgtXzDX0Un595p513vCOudKX3y4Of/VRrxa11IQcd+fNoG2BBakX1s/GEabeeaaXchfVTlCsZuLyWDKhU8Bh2AwD+pYmZSaKefJJJ7OzbZUjCU1FKmW5e+dRS89P1ZnrYlwPPJGWxALHgMOlLFVR0Qq5OPBk16264U2h6kfXzoxxyVBa3AhNe3e+Z/uS2zALX2Mj6bPVQotXMkDDAH7vBvZoVArsGruTi76nDiiRKSm17qLqliFZwWs2uzpOKcRR3UTQ7uAAggXZlZDf055M3bBoymH6VhPu5hhLz8D/4GmuiAtBzihj6xKYeAeWsfexs2XmdDzQzWu6xYXwMaa8IVU7UZNig+lf4mp+0n2g1sFVTSDTzgc+Dq4+ASHDhhEgG4USiunyoBv8t35lMUFjE3xDk6ZowPLISndbt587/JUoV9OdwyY6+aGEo2L+912qLEcnoWcoOLthSETLOfVVkJi/hZT12lPDnYW4bE7nLohG/NovgFrDUkfh/zMSw3OD31UkZFcY+LwPO1D9XrT/V5aOynz1PDXOes0Jli98X/HAlSZr6HFxC7g0oa/Dmq6EB90Qs9da5/btP18Q7BI4y23daOnI3Ep2wE/1XdrZ8RB6CRynSqNnJw8B8m5uU+MT0E6bsypD8J /C3bCEJt BWpzu4/QjXvXsT3pz0B7KtTrSoBSiIvf8A7jNrb/OfA68Z3S7zPkm42OfjaEW2XIIfdBMgSvHmzo5q4zSFVtGzswJt38Masd2/7ToQzUL/AQ6oDPCAMZ/U1kfg3G+bLdJQqlyIzRiKOMnchAg9E+QtZGbiDMRYzUNqZaZ+xtvBxqTlFkD6p3Yhe4756EBcARtZ94lHxHBHHLANZ2+/LZfnILKqBBHj7V+c6t74BpyKdqI1KN05/Fz2xjq9YBqB7sgUJ/lP+EkmvyhUDA2XAZyXc0WPop/uAfWO3UCz9xJbkYKdI6ylEZdAn82+ucoAcwI1oKwShaJgedLcxwFEnHUrQQaGjO/7iC8xLBFqLba560Bo9svJOgDxl6oMsYlIOQSk+Gkp7h7Ts75Dihlf/RKY7d9vAG85bEvXSdN6CHgkq3fiOScVo2voTXuCt+zzTIAzU/awQrcods0JEMuPA0SApOTy2oLusd32S4PC8wW6L2ppMs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/19/23 01:44, Sean Christopherson wrote: > Signed-off-by: Sean Christopherson > --- > arch/powerpc/kvm/powerpc.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/arch/powerpc/kvm/powerpc.c b/arch/powerpc/kvm/powerpc.c > index 7197c8256668..5cf9e5e3112a 100644 > --- a/arch/powerpc/kvm/powerpc.c > +++ b/arch/powerpc/kvm/powerpc.c > @@ -634,10 +634,11 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext) > case KVM_CAP_SYNC_MMU: > #ifdef CONFIG_KVM_BOOK3S_HV_POSSIBLE > r = hv_enabled; This could actually be unnecessarily conservative. Even book3s_pr.c knows how to do unmap and set_spte, so it should be able to support KVM_CAP_SYNC_MMU. Alex, Nick, do you remember any of this? This would mean moving KVM_CAP_SYNC_MMU to virt/kvm/kvm_main.c, which is nice. Paolo > -#elif defined(KVM_ARCH_WANT_MMU_NOTIFIER) > - r = 1; > #else > - r = 0; > +#ifndef KVM_ARCH_WANT_MMU_NOTIFIER > + BUILD_BUG(); > +#endif > + r = 1; > #endif > break; > #ifdef CONFIG_KVM_BOOK3S_HV_POSSIBLE