From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: "David Hildenbrand (Arm)" <david@kernel.org>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Zi Yan <ziy@nvidia.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Nico Pache <npache@redhat.com>,
Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
Barry Song <baohua@kernel.org>,
Lance Yang <lance.yang@linux.dev>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] mm: khugepaged: make scan loops suspend aware
Date: Thu, 12 Feb 2026 17:42:19 +0900 [thread overview]
Message-ID: <cd6ra7w47jmroy7ww7imyhmz7bb2yblohls7hd27uxvdv57os5@3i46rvvz2tgc> (raw)
In-Reply-To: <0787227f-c707-42d2-8f57-5795ca19a53d@kernel.org>
On (26/02/12 09:30), David Hildenbrand (Arm) wrote:
[..]
> > > > -static inline int hpage_collapse_test_exit_or_disable(struct mm_struct *mm)
> > > > +static inline int hpage_collapse_test_exit_or_disable(struct mm_struct *mm,
> > > > + struct collapse_control *cc)
> > >
> > > Two-tab indent, please.
> >
> > I initially had it like
> >
> > @@ -393,7 +393,7 @@ static inline int hpage_collapse_test_exit(struct mm_struct *mm)
> > }
> > static inline int hpage_collapse_test_exit_or_disable(struct mm_struct *mm,
> > - struct collapse_control *cc)
> > + struct collapse_control *cc)
> > {
> >
> > but wasn't sure about the 80-col breakage. Is that what you meant by
> > two-tab indent?
>
> In MM we prefer
>
> static inline int hpage_collapse_test_exit_or_disable(struct mm_struct *mm,
> struct collapse_control *cc)
>
> ^ two tabs
Ack.
I certainly see "(" alignment in that file (e.g. khugepaged_scan_mm_slot(),
__collapse_huge_page_copy_failed(), etc.) so I thought that maybe that was
what you meant.
next prev parent reply other threads:[~2026-02-12 8:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-11 3:15 Sergey Senozhatsky
2026-02-11 6:15 ` Nico Pache
2026-02-12 1:51 ` Sergey Senozhatsky
2026-02-11 9:50 ` David Hildenbrand (Arm)
2026-02-12 1:50 ` Sergey Senozhatsky
2026-02-12 8:30 ` David Hildenbrand (Arm)
2026-02-12 8:42 ` Sergey Senozhatsky [this message]
2026-02-12 6:32 ` Sergey Senozhatsky
2026-02-12 8:44 ` David Hildenbrand (Arm)
2026-02-12 9:05 ` Sergey Senozhatsky
2026-02-12 9:10 ` David Hildenbrand (Arm)
2026-02-12 9:24 ` Sergey Senozhatsky
2026-02-14 6:35 ` Lance Yang
2026-02-16 9:24 ` David Hildenbrand (Arm)
2026-02-16 9:50 ` Sergey Senozhatsky
2026-02-16 10:05 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd6ra7w47jmroy7ww7imyhmz7bb2yblohls7hd27uxvdv57os5@3i46rvvz2tgc \
--to=senozhatsky@chromium.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=lance.yang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=npache@redhat.com \
--cc=ryan.roberts@arm.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox