From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E579C369D3 for ; Tue, 22 Apr 2025 11:23:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 778A16B0005; Tue, 22 Apr 2025 07:22:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7279C6B0007; Tue, 22 Apr 2025 07:22:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C8496B0022; Tue, 22 Apr 2025 07:22:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3C4916B0005 for ; Tue, 22 Apr 2025 07:22:57 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0DEE380401 for ; Tue, 22 Apr 2025 11:22:59 +0000 (UTC) X-FDA: 83361442878.28.01E1E0B Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf08.hostedemail.com (Postfix) with ESMTP id BC885160006 for ; Tue, 22 Apr 2025 11:22:55 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745320977; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OqUvGb/NeuZBLQIo7HiJxW1y6UF/RrjPcLqaKD9mJUE=; b=ttkHEp7eGRn0PCLB3sK/HR/DklyEnOUjZ3pDFBpEKsyZHqYVEXKDKdQ8KsSA4XYO9dqEYi RYFPK37fuosDlTj5c3L2Azd2sG8fSNu0/w7R92J+x489uKn9H3jON2iPbDB8GmJK+Mv89f q6LOsfCXI/tC6DJxpEZdiFDfeGIhNi0= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745320977; a=rsa-sha256; cv=none; b=8UKLjx7Fc18YWu4+X5pBddadA3ZC3yghyIaAbKsJIqDgG7uSi8ZLHJWpH4QhFZWdz9E1Z7 tlPFqo+Q9xCs11r8/wttc7QPIN3tWyOu7hDp68yIqGSzD23CldOxgjUFO/t/pHipRF2X9R g1U9Sl2y7ccJP5DgdQWNwVglYepW76g= Received: from mail.maildlp.com (unknown [172.19.163.48]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Zhfr23R0RzvWrs; Tue, 22 Apr 2025 19:18:42 +0800 (CST) Received: from dggpemf200006.china.huawei.com (unknown [7.185.36.61]) by mail.maildlp.com (Postfix) with ESMTPS id 395C9180087; Tue, 22 Apr 2025 19:22:51 +0800 (CST) Received: from [10.67.120.129] (10.67.120.129) by dggpemf200006.china.huawei.com (7.185.36.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 22 Apr 2025 19:22:50 +0800 Message-ID: Date: Tue, 22 Apr 2025 19:22:50 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] mm: alloc_pages_bulk: support both simple and full-featured API To: Leon Romanovsky , Andrew Morton CC: Yishai Hadas , Jason Gunthorpe , Shameer Kolothum , Kevin Tian , Alex Williamson , Chris Mason , Josef Bacik , David Sterba , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Chuck Lever , Jeff Layton , Neil Brown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Jesper Dangaard Brouer , Ilias Apalodimas , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Trond Myklebust , Anna Schumaker , Luiz Capitulino , Mel Gorman , , , , , , , , , , References: <20250414120819.3053967-1-linyunsheng@huawei.com> <20250420112110.GA32613@unreal> Content-Language: en-US From: Yunsheng Lin In-Reply-To: <20250420112110.GA32613@unreal> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.120.129] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemf200006.china.huawei.com (7.185.36.61) X-Stat-Signature: 5akw6esr9ptzjk3o6538r1wue8cpbo1u X-Rspamd-Queue-Id: BC885160006 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1745320975-353105 X-HE-Meta: U2FsdGVkX1936INCdeAxbtfsdprT4LiWFyXveIJEjfTHhqPwm6lMp6Pkm9g42HoWdrZCCkuANA1QXNpoAxwE+iaJ9FMgHwaZxWOGS7L4+V0nQqSgwOlWIQeV97TIRMxVC2WMtqftngO8R67j9nCVadxfRIG51kNthlWoksvHDuEJWQjnwptdAJxoCELX7bNyqQGG5pHAli1rfH5H1/UbQEgH70/3Fb+c48C/273gizOtGVyryYH+C5uGxnW9XMw/KNC0EP99lNqgVigeKh7bb+79xBA8vZQeJXmkmF8+ydgQzvFJj9b2inA4trzdPxkqatkq6sh3QLEAUK7etvl50w3e2p86ZvUhrpaAFWnPVNUXFTFIvTjc5dt48KUE9JuP00rXqGzVNaJXZDpkqqlQaW7BgalnbcqRGkAYMsP72ncUFUqD6g17gxiYcEC4MN8R61nUGsLKV9QX19JPZFl6SM/grK8k+hT94qEx99/7Bj+yWNOyX8Yr6yGdRDnjNcDh76w5TyBhSH2H2Ony1i9smXn9AqqlkXXR//jN432s5PN3LPn1P0UgoR6EO/LkRMluxmoI2L7w8SlQrFFzfcJD/kHNHxl31aNmWMXlNZiZmiPfFmwrI7xhmne3FrzTRJlb8SSYJjTkaOMjp0fzuZKwjbSpD5xDAZcGGRt6/wY2Uc+DQY2gTbzVDrltC/pHzauBsZRyvK/DjPG/+7P5rJb4TgiWEsXPL6ZF4qp5OF6zRlCJcufyqZXcncJcHEOCvfY2CDUJ5TZoNttwPdo9PlX9TPK46tjIRc8/0PS+qklAFh9Itb/5mSQJMHyt5uXV/4dnylDz51jIdXkVS51aUbOOVq+uuYjlgyoXZ79661BeE9DQqdkEpS+Ta371e9gPIk54yd5IunVIxe3spL6gXgoZA9AvvMJhXd04CzyzKD2ZJbhIY6fKbHu4mDk5KI7UPe2UMHoRHP2eiSvu9Eo7mvu mUsLS91M pVqF6I62biP5tQ4HY1Kvw64WELwq3zpOEJHbuLD2oJAvaqGHYEThNMwTFHIDFYeKFGwfVMF8F+U6CfJpVtnoHNkO4mUdWuP+oZGL2oTj9Y+l3REak8ha+Ya1AZ8ytx9ajt4FCrgTAEgcsWaqIRgu7Nr9yWj6bHz9RBesWSPa8bTSTPbBg1wulpwF9BpyeS1AUUtoLlaOvOB8oNtjeCVsAqFId15xz2iWLLTX2woGVfa9PsjjTXJmJN8wYr6RNikKu+eIhuqErlnMf1wQ4rvTfyp5ZlsuBTEKoMzJxoaWZGSaIxjoOUoR6yi24qA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/4/20 19:21, Leon Romanovsky wrote: ... >> >> diff --git a/drivers/vfio/pci/mlx5/cmd.c b/drivers/vfio/pci/mlx5/cmd.c >> index 11eda6b207f1..fb094527715f 100644 >> --- a/drivers/vfio/pci/mlx5/cmd.c >> +++ b/drivers/vfio/pci/mlx5/cmd.c >> @@ -446,8 +446,6 @@ static int mlx5vf_add_migration_pages(struct mlx5_vhca_data_buffer *buf, >> if (ret) >> goto err_append; >> buf->allocated_length += filled * PAGE_SIZE; >> - /* clean input for another bulk allocation */ >> - memset(page_list, 0, filled * sizeof(*page_list)); >> to_fill = min_t(unsigned int, to_alloc, >> PAGE_SIZE / sizeof(*page_list)); > > If it is possible, let's drop this hunk to reduce merge conflicts. > The whole mlx5vf_add_migration_pages() is planned to be rewritten. > https://lore.kernel.org/linux-rdma/076a3991e663fe07c1a5395f5805c514b63e4d94.1744825142.git.leon@kernel.org/ It seems mlx5vf_add_migration_pages() is changed to use the pattern of passing 'page_array + allocated' and 'nr_pages - allocated' in the above patch, so I think it is ok to drop the above hunk. Hi, Andrew Do you want me to resend this patch without the above hunk or it is possible that you can drop the above hunk when committing if there is no other comment need fixing? > > Thanks > >