From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 992DEC678D5 for ; Wed, 8 Mar 2023 21:54:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C928D280001; Wed, 8 Mar 2023 16:54:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C424F6B0078; Wed, 8 Mar 2023 16:54:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE29F280001; Wed, 8 Mar 2023 16:54:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9EDF06B0075 for ; Wed, 8 Mar 2023 16:54:35 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 4B57312041C for ; Wed, 8 Mar 2023 21:54:35 +0000 (UTC) X-FDA: 80547085710.19.1F7126F Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf21.hostedemail.com (Postfix) with ESMTP id 4AACE1C0005 for ; Wed, 8 Mar 2023 21:54:32 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=We7y8kny; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=dOj8qjqM; spf=pass (imf21.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678312473; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZffRSpnIz3pxkGcZXFr/83FfQBrEkTYvERBDI5T6DPQ=; b=axLqZl4XlMVI73W4Jf5C9CNPW3kYaTuH/9/rk1Y7ZNYKP71I36QAHb/LYEunxiH9Y3zDY8 005nIDR23SmjKdHTtOdVTlbDmX5WPYrI5zfwbRXTc0VBqrTlUVqNb2V6gBLxieqDKhRFnW lu1c5xAw+vkEb+WBsdBRdEhOU9RbfFs= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=We7y8kny; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=dOj8qjqM; spf=pass (imf21.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678312473; a=rsa-sha256; cv=none; b=3uVmiXrzXiK2UOFD0tAR03CN1bIXy+iOzL/ojNopNk0HvTZ8PoqRUMPhMzwvEH+xI4UCt7 YAllY087AIe1jJy+vKK6nKRHoA9o+vhxEdfr7eGwRka2cwz3ChJMFcdrm/OMn76nIgJVw7 CGw29W/zN49fnxEKJpHgen+PMbaoqdc= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8755321A51; Wed, 8 Mar 2023 21:54:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1678312471; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZffRSpnIz3pxkGcZXFr/83FfQBrEkTYvERBDI5T6DPQ=; b=We7y8kny4V3YEjS9jQYfqTqjmHPuw4W6uBXftAIJbK+vQHFUYqZ+V/W8p/6/7ExyZAlyl5 z4+yrqwwwFJOHIm+blA7DnLjclZIkosaZ55VDy1s6vH7oiJevHamMs96VV5yZ+JVRj3+jG jB1VrX4/KPWstxkSA+zYk2P2pBbNCKQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1678312471; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZffRSpnIz3pxkGcZXFr/83FfQBrEkTYvERBDI5T6DPQ=; b=dOj8qjqM7WATrweRSGyw7OFtgLGzuqeHRpH1Xmm2ceEHb5nlTP0Gavt8o4XjUL/vbnnP5s wLQbxTsXeDXpjKDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 58FFF1348D; Wed, 8 Mar 2023 21:54:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id waDXFBcECWR1VwAAMHmgww (envelope-from ); Wed, 08 Mar 2023 21:54:31 +0000 Message-ID: Date: Wed, 8 Mar 2023 22:54:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH V2 2/2] mm: compaction: Limit the value of interface compact_memory To: Luis Chamberlain Cc: ye.xingchen@zte.com.cn, keescook@chromium.org, yzaikin@google.com, akpm@linux-foundation.org, linmiaohe@huawei.com, chi.minghao@zte.com.cn, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org References: <202303061405242788477@zte.com.cn> Content-Language: en-US From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: qktkhasxq1p5tyn7ncndqbyzurjf79sn X-Rspamd-Queue-Id: 4AACE1C0005 X-HE-Tag: 1678312472-554589 X-HE-Meta: U2FsdGVkX18e5RrcdEdDq5YYI8lDh/lIhz2v86dlazzjICXarRev3Wog1XdZQuzCwF8dZzf5hjueUO66A74Dnz1ueXvpfSPqLZg93VGEUl37qXDU1zj9+8Vc2SDLt+TpybY1rYaWKS3OXmWIjS4FTHwhSJi5OfV8U7AERjFcwcWiaEcEjotNJSQlB6uYqJsey+h5cqU5Nk7y9aM1Q+EgsW8FFbPVenJWNCukJa+IQ6CKoqbwcrXDC53kp5jsyS46YXFiJcR9KuOaRxm6TUy3Ptzd08k95FdGp0y8/dL40X2GkTWyfYYOqqr698O76HJ+0frAELPJL3Uz9W5l5ZaTdpLZ9CiNO/nHjIHBqdbUtiObVvf08W9MhKvexleomXKyHExP5DBqnSJL99jBCkgmKXlnwmB9o15/q0j2mpToZCvm9j1A/wPl/T9S7GiID5m6+Oxbcmppz+bO4UFOazt6nKOvwJYosJKvusv1B4UoGi5i6ijLna4DlXRDw1LaL3aZVL/lwx6o5F51jOkrVRSYwUof+pGhxeHil6oyk3QD37rF7CEn5advoWWdtSIjmabY3Zkmbe4JiRCFMKWq6Y0y9ecuSfv2dLkxOONI8+DqzPa1m9DQP0lzoHTcAeFN17Lg11l10Pb8dOZnPBc0f6t0BIOZ073u0lKAc9VwRI0aYlytxf+HqpkND4amjOCI4CvkhbdlCqEF2vD5EmooxeovsfbPXK5d0ucV03sJV64JSFdzg9Lo0aMw98kTR2N0xgBQ0kC93ctDq3vea7ehrlqBF1tO2fr0dIkADwR72+C8boJOnHDGbJzqFM1kXJb9hBK+z6j/u5KFOW6VEBsUQwMiyd/IHslJqfsp0ZOEEFeGAvI2VSXzY64aBeqGvB5IoVI4IVbHfe71BFhI0FVlopZAIxRAdYAIzcXvhiJGEZHaf+mqywGNH/01Bs3oNW2UhdHiMpbuljW2VDzYykIhIL6 jfkFxbwG zttwJfEroQV6UJxnhByHjOBRAjSWEzdnTiS4DGshza/XsMx2CElJ2+V+ohW4Ll/dz73ROuF9lxwRQO0z+GPJ6kzF57Ez9ZlbewWPEtmbnQ2OwkUGfK8dYQ1c90l2tSod1fSVVMEVJQc8a3gPbTezz42A3ddz1gdJAcYixFowikIk42GepiljKHs2tyfE2+SClAqxsd0CPCSs9V8n5wwyDPf4h2mtNVWW98tZxk+CqqU5cQJOdXN0ErwCa6RCov4vsLOG0i4tlFLGnpTA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/8/23 20:57, Luis Chamberlain wrote: > On Wed, Mar 08, 2023 at 11:23:45AM +0100, Vlastimil Babka wrote: >> > { >> > - if (write) >> > + int ret; >> > + >> > + ret = proc_dointvec_minmax(table, write, buffer, length, ppos); >> > + if (ret) >> > + return ret; >> > + if (write) { >> > + pr_info("compact_nodes start\n"); >> > compact_nodes(); >> > + pr_info("compact_nodes end\n"); >> >> I'm not sure we want to start spamming the dmesg. This would make sense >> if we wanted to deprecate the sysctl and start hunting for remaining >> callers to be fixed. Otherwise ftrace can be used to capture e.g. the time. > > Without that print, I don't think a custom proc handler is needed too, > right? So what would simplify the code. But we'd still call compact_nodes(), so that's not possible without a custom handler, no? > Luis