From: Vlastimil Babka <vbabka@suse.cz>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: ye.xingchen@zte.com.cn, keescook@chromium.org,
yzaikin@google.com, akpm@linux-foundation.org,
linmiaohe@huawei.com, chi.minghao@zte.com.cn,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH V2 2/2] mm: compaction: Limit the value of interface compact_memory
Date: Wed, 8 Mar 2023 22:54:31 +0100 [thread overview]
Message-ID: <cd60d29e-9512-dcc6-e72a-a4936fed42f5@suse.cz> (raw)
In-Reply-To: <ZAjorPD2nSszUsXz@bombadil.infradead.org>
On 3/8/23 20:57, Luis Chamberlain wrote:
> On Wed, Mar 08, 2023 at 11:23:45AM +0100, Vlastimil Babka wrote:
>> > {
>> > - if (write)
>> > + int ret;
>> > +
>> > + ret = proc_dointvec_minmax(table, write, buffer, length, ppos);
>> > + if (ret)
>> > + return ret;
>> > + if (write) {
>> > + pr_info("compact_nodes start\n");
>> > compact_nodes();
>> > + pr_info("compact_nodes end\n");
>>
>> I'm not sure we want to start spamming the dmesg. This would make sense
>> if we wanted to deprecate the sysctl and start hunting for remaining
>> callers to be fixed. Otherwise ftrace can be used to capture e.g. the time.
>
> Without that print, I don't think a custom proc handler is needed too,
> right? So what would simplify the code.
But we'd still call compact_nodes(), so that's not possible without a custom
handler, no?
> Luis
next prev parent reply other threads:[~2023-03-08 21:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 6:05 ye.xingchen
2023-03-08 10:23 ` Vlastimil Babka
2023-03-08 19:57 ` Luis Chamberlain
2023-03-08 21:54 ` Vlastimil Babka [this message]
2023-03-08 22:23 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd60d29e-9512-dcc6-e72a-a4936fed42f5@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=chi.minghao@zte.com.cn \
--cc=keescook@chromium.org \
--cc=linmiaohe@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=ye.xingchen@zte.com.cn \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox