From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58D9EC76196 for ; Mon, 10 Apr 2023 08:23:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D269A6B0080; Mon, 10 Apr 2023 04:23:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CD563280008; Mon, 10 Apr 2023 04:23:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC2B3280002; Mon, 10 Apr 2023 04:23:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id ABD156B0080 for ; Mon, 10 Apr 2023 04:23:52 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7044C14012E for ; Mon, 10 Apr 2023 08:23:52 +0000 (UTC) X-FDA: 80664793104.22.83AD863 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by imf29.hostedemail.com (Postfix) with ESMTP id A4A5512000F for ; Mon, 10 Apr 2023 08:23:49 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="bdPG/gHp"; spf=pass (imf29.hostedemail.com: domain of zhangpeng.00@bytedance.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=zhangpeng.00@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681115030; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X1W005AayHnSnC0Q+oReD/D5t2+Li6rvV6AQr1B7Tyk=; b=lX40MQelrm64lTWGNd3kCqpqu+CB5CD4QWb307cIHsfqdEKP+tX+MyQXJi5JiWmKmVNDzO iBlls7VWwB+GAP4rnGWH1JFhXlOYWLihPD6XJVOj4tvQFsbSV08F3UJhIswsRN9kISUg3a y6TfCPwlGGpjJCHlJ56u9RQabiwvnzg= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="bdPG/gHp"; spf=pass (imf29.hostedemail.com: domain of zhangpeng.00@bytedance.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=zhangpeng.00@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681115030; a=rsa-sha256; cv=none; b=QbwzGZrVZwcrfbEUNbGQ2WoJVhlLOlM5XDLKGqqePpL8lvonfI+8j28wRoyVIdWnAsOSYi 5PQIlyLBCNcjqItKwUoirC4DUMTuv5bADqrS4KMR/yQ6MJ/dAXyQZso+wjqMCaBq4RPqQx SD1P83stz5mQpU4QmI64flKnUWwzLEU= Received: by mail-pj1-f43.google.com with SMTP id jx2-20020a17090b46c200b002469a9ff94aso2083103pjb.3 for ; Mon, 10 Apr 2023 01:23:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1681115028; x=1683707028; h=content-transfer-encoding:in-reply-to:cc:from:references:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=X1W005AayHnSnC0Q+oReD/D5t2+Li6rvV6AQr1B7Tyk=; b=bdPG/gHpFLO7zfO27S5nMmHY+VfdcQg0Rg94jRyuweXxzhXMohVKcyLRl2CN9EwVZB 7csG30jy10quW1ZNPe+n3gb4YsD8c1yolLHAkLtdatUBPuYIe4CzwxyZW5e7PeUJtN1U 8Xs9ujh0areeiTd/kQ3wYsefuwdGqLb0j+fp7qrgXiRQuBahL1DVv4CorsrTlYyPuM84 nbIIaBSo/q/WmSGrVU+8/sAtO9zaOTdkZ1DMr+lyr2F5ivegwgPnXbi0lCTPU7FFQAeK jNpwNBCaZ+A7l/3nypkc7V6bCUCFxxxOxR00lBG4AUjr/Bk6fstwlwNgWqRgNK8Ynd5i Y/ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681115028; x=1683707028; h=content-transfer-encoding:in-reply-to:cc:from:references:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=X1W005AayHnSnC0Q+oReD/D5t2+Li6rvV6AQr1B7Tyk=; b=dR3A86sWEb2cx3eS5MzoQSvfAcGQmBZ7nnDAiT/M9tNnl62KvxDjW59wpqNSS8QjtN rzrPz/R1kM+77N5c7MjauZbG4VPbltPdFtrQ3aG+KYYWwuk14tYXq0fYGkqI5o7jNz+p ze0bnhgxqfbyp7EusYB+wQKyjVPKBt0/wCzcy3ZwAdav4DzmuPTPKdxZ3kEDPU1CPxjS OYpuw6MA5gldiSzejjWsgVuGRnjUCVhL3ACNXCFQdMdpbjEVk3rTocLWmk9StuIQuu5R JI7HJIRvKP1uXWCKOffE7BiwvTt5kYU4y3hcKdXyKsAPbm9cdDwLxGeq8I0LUm4v4b// Dv6g== X-Gm-Message-State: AAQBX9d5HJq+fNEqT4Dm6PDoeFFQ/Ymrdl+iRlLXu1XI2asdGCvl4IxV bb3gdOJ8TEdq6K2XyTv8kgnW9A== X-Google-Smtp-Source: AKy350YEB+Ka6I6jeIr2IK5nIlbB+75TTNeBj0SufalIOGCjQdxIjZ+U2+9TWGJdo885+jIatimTcQ== X-Received: by 2002:a17:902:d492:b0:1a6:4c2b:9e7e with SMTP id c18-20020a170902d49200b001a64c2b9e7emr277284plg.64.1681115028272; Mon, 10 Apr 2023 01:23:48 -0700 (PDT) Received: from [10.200.10.217] ([139.177.225.248]) by smtp.gmail.com with ESMTPSA id y4-20020a170902ed4400b0019cb534a824sm7219758plb.172.2023.04.10.01.23.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Apr 2023 01:23:47 -0700 (PDT) Message-ID: Date: Mon, 10 Apr 2023 16:23:42 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: linux-6.3-rc6/lib/maple_tree.c: Two style issues To: David Binderman References: From: Peng Zhang Cc: "Liam.Howlett@oracle.com" , "linux-mm@kvack.org" , Linux Kernel Mailing List , maple-tree@lists.infradead.org In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: A4A5512000F X-Stat-Signature: k5a93gerre5szinriakgwmksffco9kwi X-Rspam-User: X-HE-Tag: 1681115029-643522 X-HE-Meta: U2FsdGVkX184rnK9f72zf49RVWYWlZ5jhKs9SND7N658tqfER8wveSHSiwV8p1FtNI5FB8YL6VQeJecf4fl9QzT1O4k3eETLGJaAGH1VYWRoEVL/8D0UHSfS+M6th/wiOoOKrwPLTzz8qBeI0pdIxZVtckLo0l6uTmUT/LmL6auiHkIEiWcgZRVHmWqZQVrCCWncTouLoNiRi1wDsh0qM7itudc59G8g+UlehF/4HfWutQsJ5g5JAEKkRZLialzNm1aa9Yw2i+J4AjLnHGYhuKMog80MzpBu0SMhT92mlA+e/K57taQr/4cZ3x6Tlhy7J3h5REAAzDAFCaZ+TiycQGyc71E70QgWq7rvpQAj0oJbV49Cc7oC8wuAWHTsjBAk47uhugs5iEdgJgo4pcG4YTH8J1StNIbvJoXk4reW/RrxoE+kUuj+GnvwvnWTLfBqc3wYYw9KObZrvUxz4skDsmx9GH3BZYnlUXoXfnB8btQzBk8lKw8fJmH6RXAktibbAEX4KtFe/dfpxacOKniF8uGXMcLVa/NEcD/C1WwpQ+9EijXxo3Jwqp+RZx/pZvFg6U3br4ttpFxGku+3jlBHn8lrkso4nhvoK2dHEj8Znlqd0ZODgbzciF2ZwFNnvGJOMjmSg11Q+7GBmnEygg6lf0vDxkwX8G0hwqMG057iVggIB+Kfs7lhlPBfBElsl98HOaQ1RXqLysJ0aoA19xCn9qS+xFD6K3qth4mEsh5mqv2V7ckMmngwA6enoSe/kPkrORw7cONh6c9N+rOLSJgIadBPfkm8xyv+zCy9QaVupZmpyqqJu1FSNvh3MHLNxz3iYxZKr7yaZgPFojhvtgCOKdfrRcMbkmduPB9xlacPvCBo2/twlJ7+VgYGNhuPjpa3cx8TCosuDtmbD6i40mC+rYr4P9eq+CmOwj2S2Vk+iEN7jCs3yn2hNipLgivcPqZ5Qi2JL2G+eJTjEW1hNy2 lzSppGNC SjuSCXFxWj08uwTg+oiJjl8cVylW9ayGmMoNIR1uGtx1B6i60Dk3+XXcbi9aC4H3PZrKVPNjADzcEkKobj/Bjv2zirMYAAd5Uf2rarig9O6pGPf+YcFwCBm76H6WtFlps9e1/Ijk9sXGxJ89J1dIzt/OD2m9yWEqfT0uKMgfo5f2/PjdkhGH+kfrgMB/QQXj6t3QmzG41STiOx1StqSqbt2WJbCBXLwXhLtksI6dO7LId2BqJBRi0defzNZvsJOhmf/kb/90RJ5oEXZRI0ZBtjp4xP7tkYmlKyRQ3Lnqovn5gXIeynIlSWIPfgEJXmUvWua3lKt9dttM3Ww7Y85F4gvc1soOvqPCHP3vH2LdiEp1ZdIbhHj3QrkWiTpz0tkLsk6SrAo6wlOubScjzqfHvj4bHFTQI3g/PFlCG0Ciw+gm+3ehJkDDVsTTGml3aZjdaW7ki8Cvo8mAHEA+bAVYpDsK8fA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000042, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2023/4/10 15:05, David Binderman 写道: > Hello there, > > Static analyser cppcheck says: > > 1. > > linux-6.3-rc6/lib/maple_tree.c:1951:21: style: Array index 'split' is used before limits check. [arrayIndexThenCheck] > > Source code is > >         while (((bn->pivot[split] - min) < slot_count - 1) && >                (split < slot_count - 1) && (b_end - split > slot_min)) > > Suggest move limits check to before use. Hi, It should be fine here. The upper bound of split is b_end. The initial state (split = b_end / 2) must not cross the boundary, and (b_end - split > slot_min) ensures that it will not cross the boundary in the future. > > 2. > > linux-6.3-rc6/lib/maple_tree.c:3289:11: warning: Size of pointer 'pivs' used instead of size of its data. [pointerSize] > > Source code is > >            memset(pivs + tmp, 0, >                    sizeof(unsigned long *) * (max_p - tmp)); It's not good here, I can fix it. Thanks. > > but > >     unsigned long *l_pivs, *pivs, gap; > > Pointers and long don't have to be the same size. Suggest code rework. > > Regards > > David Binderman >