From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 542E3C432BE for ; Wed, 1 Sep 2021 10:15:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C4C9F6101A for ; Wed, 1 Sep 2021 10:15:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C4C9F6101A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 406578D0001; Wed, 1 Sep 2021 06:15:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B5556B0071; Wed, 1 Sep 2021 06:15:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A4128D0001; Wed, 1 Sep 2021 06:15:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0055.hostedemail.com [216.40.44.55]) by kanga.kvack.org (Postfix) with ESMTP id 1D8846B006C for ; Wed, 1 Sep 2021 06:15:54 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id B7C4118019567 for ; Wed, 1 Sep 2021 10:15:53 +0000 (UTC) X-FDA: 78538598586.10.720359A Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by imf08.hostedemail.com (Postfix) with ESMTP id BA44730000A8 for ; Wed, 1 Sep 2021 10:15:52 +0000 (UTC) Received: by mail-pj1-f49.google.com with SMTP id g13-20020a17090a3c8d00b00196286963b9so4241559pjc.3 for ; Wed, 01 Sep 2021 03:15:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=a9Kfb7wAmZrrrmnSPc65CnKgobH9A43eRy/F3HVanHY=; b=ktBaN4pw4D94xBPBGtv47AE7E824CWAXMo/jdRdOir8ofINSsb4P4J8usLGA+5daAn e7kbuazNA5QrGI2mMsSamMzJrp0UQU/Yu7wJVUZLkKsAsghAFE4hVv45uKBG+lMKbmJx p3u4DS5023sQ9mlY7jjUTNZHqHiCdD+rtxWLuSg84CpRbNbeyH9rYXUfJ4EEMx3Xm8qN lErC5DHTpeGiLTLHMwXr+SCdjtG1LDD1QN+9niCTEitmNcRUflaZC9umWsC2AXc1fR1v dTtVoVWnFcPVj6qz3TWZKs29xnLeSqns+EGqA+cEUyrA7HTDgGZXpsR2u5uxEZSsteAT Chug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=a9Kfb7wAmZrrrmnSPc65CnKgobH9A43eRy/F3HVanHY=; b=OP2Ch+d5IvGDTPfXAwdwL2fgabe8QsBsxn/YBm/doDbwYfcp7PpS+ve+PrOodGtZaA 7SXaVnaekn89oA8zcVuS7mQEWDAlstgdMUg0S8VEcUDzeHTWxkG4m1aeSADB/TU8fE0V 1ci8DgirHFV9UdiLrz+EwmjJ0x1jYVWmjL8MA8S8/xwCqj2F+LyGIRwQccViO0sIhz6g nW9bTwApQJ5C8iOxNV56AURrBK3fsPNr6N4ZVcwIZGlXjz/j3FwJfVAp7INeKRpEnJau z4xyrnD9DR6yvoLy1BbX1nXFSWPhSI+jkbPnPQ/wsgJJVcuWHJ2x/s4WzvG6YamuVB79 FDtQ== X-Gm-Message-State: AOAM5318TgDd5P4rH0mzt7bfiFspBbjlmERs+xmuv/3AmdH6wYAAqQf7 GLdIsCPYJDGyB6cqjgAbeL5q2w== X-Google-Smtp-Source: ABdhPJxhe4FVoyyM9qgNUA7XB+DpgXLzpJWFs6gAwpaqEhpUPZjBR7TbfzzWilv9WL7YEhcES/OhIw== X-Received: by 2002:a17:90a:ae18:: with SMTP id t24mr10895503pjq.92.1630491351412; Wed, 01 Sep 2021 03:15:51 -0700 (PDT) Received: from [10.254.210.255] ([139.177.225.254]) by smtp.gmail.com with ESMTPSA id y12sm23232967pgl.65.2021.09.01.03.15.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Sep 2021 03:15:51 -0700 (PDT) Subject: Re: [PATCH v2 1/2] mm: introduce pmd_install() helper To: "Kirill A. Shutemov" Cc: akpm@linux-foundation.org, tglx@linutronix.de, hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com, kirill.shutemov@linux.intel.com, mika.penttila@nextfour.com, david@redhat.com, vbabka@suse.cz, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, songmuchun@bytedance.com References: <20210831132111.85437-1-zhengqi.arch@bytedance.com> <20210831132111.85437-2-zhengqi.arch@bytedance.com> <20210831232301.ilehcpc3n5bqodsz@box.shutemov.name> From: Qi Zheng Message-ID: Date: Wed, 1 Sep 2021 18:15:42 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210831232301.ilehcpc3n5bqodsz@box.shutemov.name> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=ktBaN4pw; spf=pass (imf08.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Stat-Signature: ddtapdgbd6hda35ah11ebp1zs4n483fo X-Rspamd-Queue-Id: BA44730000A8 X-Rspamd-Server: rspam04 X-HE-Tag: 1630491352-414601 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2021/9/1 AM7:23, Kirill A. Shutemov wrote: > On Tue, Aug 31, 2021 at 09:21:10PM +0800, Qi Zheng wrote: >> Currently we have three times the same few lines repeated in the >> code. Deduplicate them by newly introduced pmd_install() helper. >> >> Signed-off-by: Qi Zheng >> Reviewed-by: David Hildenbrand >> Reviewed-by: Muchun Song >> --- >> include/linux/mm.h | 1 + >> mm/filemap.c | 11 ++--------- >> mm/memory.c | 34 ++++++++++++++++------------------ >> 3 files changed, 19 insertions(+), 27 deletions(-) >> >> diff --git a/include/linux/mm.h b/include/linux/mm.h >> index a3cc83d64564..0af420a7e382 100644 >> --- a/include/linux/mm.h >> +++ b/include/linux/mm.h >> @@ -2463,6 +2463,7 @@ static inline spinlock_t *pud_lock(struct mm_struct *mm, pud_t *pud) >> return ptl; >> } >> >> +extern void pmd_install(struct mm_struct *mm, pmd_t *pmd, pgtable_t *pte); >> extern void __init pagecache_init(void); >> extern void __init free_area_init_memoryless_node(int nid); >> extern void free_initmem(void); > > mm/internal.h would be a better fit for the declaration. OK, I will update it in the next version. > > Otherwise: > > Acked-by: Kirill A. Shutemov > Thanks, Qi