From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93255C71135 for ; Fri, 13 Jun 2025 09:59:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B91B6B007B; Fri, 13 Jun 2025 05:59:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 16A106B0089; Fri, 13 Jun 2025 05:59:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 080BA6B008A; Fri, 13 Jun 2025 05:59:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E30D56B007B for ; Fri, 13 Jun 2025 05:59:03 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 888061D84A3 for ; Fri, 13 Jun 2025 09:59:03 +0000 (UTC) X-FDA: 83549928966.22.D1AFF32 Received: from out-170.mta0.migadu.com (out-170.mta0.migadu.com [91.218.175.170]) by imf22.hostedemail.com (Postfix) with ESMTP id 9A42BC000F for ; Fri, 13 Jun 2025 09:59:01 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Lm1hYnvJ; spf=pass (imf22.hostedemail.com: domain of ye.liu@linux.dev designates 91.218.175.170 as permitted sender) smtp.mailfrom=ye.liu@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749808742; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cpXnDBPpqquBgfe2bBHutO28w9qj/2gJIO0pSbxaZ50=; b=qXkAtW8MctrQ0a+pXndpvsWLwV1uhIDNvrYB0AGROLcYaZEkKPzPIr3PE0Vx34OaOA0zDP EYElxUTU76EbCPG7r/QYrHhCeALKmfAfVZ+jeSfjOgh2ADzbJlDTjtdtUa1kUXkBAJHnxI MV841Mm/DKp6e7A4Yus8ZtXEKPuljJ4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749808742; a=rsa-sha256; cv=none; b=eIENXXnVEB/afGBLPFDXjwBIpqxg2sEDISTBs9Z+I6ifPuzjppdkEXubwtubrKJH8ccpLR qnxPEA5v5xmX0oFV+LmoAfrNnEvPO29tWUSvAS4f342nxJWPkFeDgdX+7LdvSjb68Zwnf5 0FGgIPBCVs7BmZnI5don7GzFDd8UloI= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Lm1hYnvJ; spf=pass (imf22.hostedemail.com: domain of ye.liu@linux.dev designates 91.218.175.170 as permitted sender) smtp.mailfrom=ye.liu@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1749808739; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cpXnDBPpqquBgfe2bBHutO28w9qj/2gJIO0pSbxaZ50=; b=Lm1hYnvJ9HU6vP7pHVeLj5Zxhag7MSKDDdqABGGniKu6GSSmH6WXBln+CCWDvl93ImbCxF l8p4eK2b/z0LxgleJWUtL7iQqXH2JeX5mS94okz0X64t3M5AL7PqOGk4mfokRVXo778lKP gIHwGLMcx7NhSqiYYVeavupuN+GjGUg= Date: Fri, 13 Jun 2025 17:58:38 +0800 MIME-Version: 1.0 Subject: Re: [PATCH] hugetlbfs:inode: initialize 'error' variable at definition to reduce code redundancy To: Oscar Salvador , Hu Song Cc: muchun.song@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250609065615.108240-1-husong@kylinos.cn> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Ye Liu In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Queue-Id: 9A42BC000F X-Stat-Signature: g8epfpwy3nccakawkijeqopea11dhn5e X-Rspamd-Server: rspam04 X-HE-Tag: 1749808741-39209 X-HE-Meta: U2FsdGVkX1/8EJ7S9HfTVem3Fe2jTbztLo1F6WWpED1menLFo9MtW2gW3oroXiJ+Q2oxAvUFy+rJ9+HbK5B2f8i2Mss/1fAGuUe3YQXiucbs2mqqr2avFifNVPXZLzmQEmUXuP7VE78EV1F9eWjJUvQhyRpGlZHDnY4uLhIpzSy+UoKP8L7/EbwDQWyYG87Fe/JV3hIKukwvaSoTNwNvzqmscUtBy+ut4+hifcYcR2QgbyTNomw3yLFYXOaInAL4+ywMf44ikRKeq59tte6afNhIX4mvsiILIxPu1QVxVujiriMk6LiDx6WKdV7es2x8o19F59L1kfT57PJvmpdd7dyL/pUtmwcxXdEv23okVWcrSOPkkKODypXFS7IW1sQByS6qea2ovDD+5pIwIdnpku6cl/nOaN6eAuwtbeFnROQ86B/RP1HXaW3wlBPz39BucQk7HD8K4Z5whg6Kr2dp4elDf7OpvE9SC8aev1YC8W5glI0nHJymBH2V2iLDRTgfOetnvE6suBtd1vBbRg0kuObDWYYhpxCDwzU/3tjyXZq0e00iXN7Sdo5bmous7kQ+6ghuiEV5UiGNJeedIO7xBk1pjYYd5+dVfRUYoFdoEJMmDWU7DHUKj+fjOwb+SuxkrxJ6nSX8ZevpNBzBSbTWmzQ0z47Zwv4gVrEt6S0FhPypdJ/s267xMQKVD/uT0W5gxabDf9zYa1R8Af7c42P7e7sjjwtlNQi8u0BP3UAvFHkZpPuMQi5iJOT/VbIFmc03YZIKf650PYhMEEGy5Cvu7vsVsRnIafc8cVki+W92L8FPGgoytr/EiWRRCiKXtiV0zXk6BeM6D54Lj92h0bJMPxAnhipaWcb2tzwcSlJgvCImfhTWlzQt/pf1ruXht5cRMZn7erDyd1of7f9k8JP+uOStHcXKhaLVwOZcnGSb4+ofKyx82kGhR9+0BojXB0qe9822joN99Ra43w/X3MW 0a33jVq/ dEenJd/IIsa7Fuc2lDT/EMHnouhT6Y9SROesOm6kIZBQ5I1S+9yOZI6u9wK3UhO/UZs2wzPEO5hsz5d2HngZMmn78Bh+qFBLvn2FEfj3BMr4rA3Ggso9OBTqSTfd8LVrqPgpC6RT/CiwCpwEPzne5sTLYBanoRwe3Wcu40JdeZlmnyEjGWslZLW2TPQzO/TKaJ5J/597IAy+N5AAAbLJnsZ5bzw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/6/11 02:51, Oscar Salvador wrote: > On Mon, Jun 09, 2025 at 02:56:15PM +0800, Hu Song wrote: >> Initialize the error variable to -ENOMEM at definition in >> init_hugetlbfs_fs().This removes the need for a separate >> initialization later and makes the code slightly more concise, >> while still preserving the original logic. >> No functional change intended. >> >> Signed-off-by: Hu Song >> --- >> fs/hugetlbfs/inode.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c >> index e4de5425838d..390cddd5872c 100644 >> --- a/fs/hugetlbfs/inode.c >> +++ b/fs/hugetlbfs/inode.c >> @@ -1600,7 +1600,7 @@ static int __init init_hugetlbfs_fs(void) >> { >> struct vfsmount *mnt; >> struct hstate *h; >> - int error; >> + int error = -ENOMEM; >> int i; >> >> if (!hugepages_supported()) { >> @@ -1608,7 +1608,6 @@ static int __init init_hugetlbfs_fs(void) >> return -ENOTSUPP; >> } >> >> - error = -ENOMEM; >> hugetlbfs_inode_cachep = kmem_cache_create("hugetlbfs_inode_cache", >> sizeof(struct hugetlbfs_inode_info), >> 0, SLAB_ACCOUNT, init_once); > > Uhmf, I do not know. > > Often, we tend to use those declarations in order to mark what error > code we will return if we fail the next operationg. E.g: > > error = -ENOMEM > if (try_to_allocate) > goto out; > > error = -EINVAL > if (check_params) > goto out; > > out: > return error > I prefer the following format, as it avoids unnecessary assignments: if (try_to_allocate) { error = -ENOMEM goto out; } if (check_params) { error = -EINVAL goto out; } out: return error > No really strong opinion here, but I'd vote for leave it as is? Currently init_hugetlbfs_fs() pre-initializes the error variable with -ENOMEM before the allocation that might fail. This creates an unnecessary assignment in the success path. Therefore, this change might be preferable: diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c index e4de5425838d..3fa7892ac865 100644 --- a/fs/hugetlbfs/inode.c +++ b/fs/hugetlbfs/inode.c @@ -1608,12 +1608,13 @@ static int __init init_hugetlbfs_fs(void) return -ENOTSUPP; } - error = -ENOMEM; hugetlbfs_inode_cachep = kmem_cache_create("hugetlbfs_inode_cache", sizeof(struct hugetlbfs_inode_info), 0, SLAB_ACCOUNT, init_once); - if (hugetlbfs_inode_cachep == NULL) + if (hugetlbfs_inode_cachep == NULL) { + error = -ENOMEM; goto out; + } error = register_filesystem(&hugetlbfs_fs_type); if (error) Thanks, Ye