From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2A9BC54FB3 for ; Thu, 29 May 2025 10:44:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 32B226B0129; Thu, 29 May 2025 06:44:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2DB7B6B012A; Thu, 29 May 2025 06:44:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1CB456B012B; Thu, 29 May 2025 06:44:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id F0A556B0129 for ; Thu, 29 May 2025 06:43:59 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id AA0531A110F for ; Thu, 29 May 2025 10:43:59 +0000 (UTC) X-FDA: 83495610198.24.4ABED4C Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) by imf24.hostedemail.com (Postfix) with ESMTP id 9245F180017 for ; Thu, 29 May 2025 10:43:57 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b="S2Td1ge/"; spf=pass (imf24.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.53 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748515437; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mBKHhBlBfRf8OS9bGTTn4Xut5Q4UhzCrCrJUCDJ3k2w=; b=CcXagkICP+c9s90ol42zJygCj3u9If0bd1Vw4LtgoPQh6wUrNsIlubvNHOutk6WPtCsrHP Fj+n4uJzrvn+/YCYYrsYEzzDHJCWMqGg7StR2tskqRMmutzPoqXPs9LeN0Z4YdA0z85tcy eXJWKJsUcE5rjRujRtfxqGSyVuF96nw= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b="S2Td1ge/"; spf=pass (imf24.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.53 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748515437; a=rsa-sha256; cv=none; b=Z92CTe7yY30pcSBCYLTrIlJUygzedsg4mpqBg4BmAE8ezjqPPK+LMEzL8P2iENeS5TAax4 Q1p0aXLRcdog0HpVWNn2Cp+tzAUobKMykO/GHsM8FwoqHuNrhS7fvOGKBeS4NopFJj3PPa QN7gvnB7BrM+AmarH06O+p6vv7xr4ps= Received: by mail-io1-f53.google.com with SMTP id ca18e2360f4ac-85e1b1f08a5so16905539f.2 for ; Thu, 29 May 2025 03:43:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1748515436; x=1749120236; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mBKHhBlBfRf8OS9bGTTn4Xut5Q4UhzCrCrJUCDJ3k2w=; b=S2Td1ge/E1hrX3Jhw7gq4kQ2oUREmzFfEWtXyVAANgAvhVP8CQNcq0/NbCr8ZpEwZP bni+5N+tSGn/ueJfZpj5E1VuJNr0VFfpnfhhqdDtcZkE4dGCxJlpAYA2R0LhtL7/jJMz 6YtCWhWBlSuMWxudAcJPu8yBdQfcQH4FiCt9RvK5vmRkXAimcGCORv7+naC4b3gYdsQr Km8bUprwh1wNlrlxLD3WYzQn5q3RjZQIfgaALwFvCKqNW4Hv85PmW5TdH2D6H8CJLV4P pzsChVxbCLxJzexOvN144AFq5KYwkt9/m848AnztNNj+WFGWSEk9VcN0m+IO9GtePwta FX/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748515436; x=1749120236; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mBKHhBlBfRf8OS9bGTTn4Xut5Q4UhzCrCrJUCDJ3k2w=; b=iMtuWG4RwrOmXHI7rvJ21DZReYza3BsloC4h3LJbEWBFJd9Hnr9LIdsLPGwFptI6aR DUTo7KLn7d5zcW62xOYGUhXC1Yyb+noKDUzLLjRsKjrRiWyVCC/f7U/kBVsxL45yzHgY ZjnzzDudtQSsJChn8Mf+uS2NVSbdzBJeo78v5o2BsviPWW1xb2VmLzHk8T1G0Su5YK5L k09crfbwTx9b/I92Ukflw1sluWHC7pWHW/TxWb2yRz7R7527DWmnYTiuqh9k25oBn89D bO9PDAvMeRY61xGt5T/6159Y9JAch09l6fEEGEVqvVsshoEmu5RaWrH0/+kg5kacdmgD ZA8w== X-Forwarded-Encrypted: i=1; AJvYcCUTWjUMKoENApks0S1tAfqzzzZrIMmEyVb9ZNrtGWQLll+BuzkrNMF/gqHt4JEUMCkRNxDybK6gcg==@kvack.org X-Gm-Message-State: AOJu0YzKGHoavKy7CP9nzNgihHhMJEW+LB4Q2nq9LiTjKitJrTguknU/ owK4Xyr4zohUiNYM6LPrFB88zVSOTLg8xJN6GDm7NY37uEXAer7Q8iQloBjuZ7m0wiI= X-Gm-Gg: ASbGncto47KXeZX6rEwlZB4f/hnhmu+7r2MJpYzPLvgOGjCcONsfrjyT2vxZ0dsadVT upJoJ9ZHfz3leDExzhhtkBpl3N5gEPGJbOkVNjE8B2P4NM2Yve8hMEke0Nq9nG60D7hMb9GgbVi HuFjFDlS0k4lrbwLZflnM14rdIZuZWyzywX2bvoQEdRlqkyMJFqi/+0dBxCbEH4M68SeOMOovU2 KqJDj1TBpkmtRiYBSP/l/MeDMeICq7m8huR3QI20Jh2jIfXQSnF2FdREkfB0nasccliL/zL/56c cg7DuO84xAcCid+TDYA/UbdTZsePDyf3OFCpL+xK7mOX0bv3KX3+z6+GLKA= X-Google-Smtp-Source: AGHT+IHGVGn+63JWl0t2CYty2GIDIfHTGjGGUyr3yYuuyCx1E71eWmROwfUZXoYGh7QKeqcJ+9RtFw== X-Received: by 2002:a05:6e02:2289:b0:3dc:8a5f:7cc1 with SMTP id e9e14a558f8ab-3dd943d0d04mr17643405ab.3.1748515436218; Thu, 29 May 2025 03:43:56 -0700 (PDT) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4fdbd4bb1e4sm608197173.43.2025.05.29.03.43.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 May 2025 03:43:55 -0700 (PDT) Message-ID: Date: Thu, 29 May 2025 04:43:54 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: Fix vmstat after removing NR_BOUNCE To: "Kirill A. Shutemov" , Andrew Morton , David Hildenbrand Cc: lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hongyu Ning , stable@vger.kernel.org, Christoph Hellwig , Hannes Reinecke , Johannes Thumshirn References: <20250529103832.2937460-1-kirill.shutemov@linux.intel.com> Content-Language: en-US From: Jens Axboe In-Reply-To: <20250529103832.2937460-1-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9245F180017 X-Stat-Signature: xb8n3sot6ram3xtu4x9rkicz7ydao7c7 X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1748515437-758210 X-HE-Meta: U2FsdGVkX19yA1dYgUVhrsB6X/CReP/mN6VOSvNeozS+CN/Vq2XjjPJ1jQGvoOyRtUwxmKdzY4yr6ltSdEqgSzBC0OK9YR2hUBEuAFJX0mEpmcHHDzquNSAeXK6R90wzvL4qPCzvx55LOWGKXM693F6O/AV4q6WgrWHow398wUfnTNBYDnkCFDVnobewYeluaBOHvWiOdVyoA0SXKBZTTItfyW2aIApTmMC+8HjK9xw96VWMwYgWE2Cq7fspMiQ0w8fWi7VUoCcFSMbW7vMdi7BBxiphW77Hczd+cGG6ifa5JdM4JHJs33YsqXYNbOpxQpZwy5m+dcnwYNWLWTMWF+reP1I0VxOWqI/dQgJ28I3O7eNkkM39NWzfaN8fnqU4XZ/PXM4QoUaqm1AImq/+eZ5D0cHqnQ0l9r8QzD+8EabnxmuTo9mOz4189l9L6fpN1Q8jHt06zOpS3SSGmW06BHI0+ivDzWu3Ti/bBSwJuRykZ1axRDuhbGPXmAMrWhp1f4orw4MDCyhmgczqMhOD/0/mWLxUM/w41SGDd4z6S7wQnI+AXj/Q7cbfsBdIHXa7NaUgSheb1blMz8VrlGQMNe1Y5LbCzRKs4PJKyZvFOJ1aNtgm9vCRnwrVrfAb2f6nLjRfK7RLAMUfK91wpeiB5rQgqLSQ8JHy9dXZ2frNUOxbDxGBa4Sgq3Iipq8YsbR/yaH2qnC4jyYinTYaeWMIzQCw+8DHND/UpQxskJLG2bJoU8HoQJ7KWv5woJnoaVHNQDz3R3V00Pd5QKQ3gAOdUs4FAX9WO7CeXHZH2ao65/ZVr00B1G5al1oxoRySkvvcimw+gVa6MsLhUTkDn83qGr0PTtIZjcz/jrt3gRhlFRLHteDwE1zFgSKl35uXnSJc32AUmVluItfI1PJLZAmbIscf+KjJcmOGpTjhuZG/OrvTe7REXyqOhmz6D/cZri0TupfzzUmBTu9MwoBJIMI WrgnuA2p Y36SReftpTywRisJqCohC0nUDCLywBzCBXQnzjOzI4WvHt82BwvZpVo/+dxPiSzv8mrSyHDh0zZlE6Qk3IaKAdvx5yiyDGcenWAIlFkHvOIxguHBHQtk5MF/kUVXBckUNhRN6wYVZCCttnEAa8kOcNE3fAJ3+OffMbP6tMoQUkK26QULCw57RDAdKzYP6Peja13YgT2u+B48aSr1LbThMUv0J2pbw4Usd7ClOyBTm/YrWf1qt8tw9Tg/JbkBqiE6z75s71Bui0qdbPInPy+TYCCR+CSPmp1A/RTJLmhB6Dd5TIWlHU/MpqhQH7wgiqihWxDbeRfTvq6A4qeHFVsAMVvp8b1UeqGEVkQt2jAtzV3QCd4ihwzAiSGP9DpxkA3kdEwlffhCDJMxbrfsjnscHRMpd/Bk8NhZezw7AzYQUQhHlTLo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/29/25 4:38 AM, Kirill A. Shutemov wrote: > Hongyu noticed that the nr_unaccepted counter kept growing even in the > absence of unaccepted memory on the machine. > > This happens due to a commit that removed NR_BOUNCE: it removed the > counter from the enum zone_stat_item, but left it in the vmstat_text > array. > > As a result, all counters below nr_bounce in /proc/vmstat are > shifted by one line, causing the numa_hit counter to be labeled as > nr_unaccepted. > > To fix this issue, remove nr_bounce from the vmstat_text array. Reviewed-by: Jens Axboe > Cc: stable@vger.kernel.org No need for a stable tag, the patch went into the 6.16 merge window. -- Jens Axboe