From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45CA4EE49A6 for ; Mon, 21 Aug 2023 14:41:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA52C900004; Mon, 21 Aug 2023 10:41:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B53E98E0006; Mon, 21 Aug 2023 10:41:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1B57900004; Mon, 21 Aug 2023 10:41:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 932EE8E0006 for ; Mon, 21 Aug 2023 10:41:35 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 46CC2A0733 for ; Mon, 21 Aug 2023 14:41:35 +0000 (UTC) X-FDA: 81148375350.08.65E417D Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf05.hostedemail.com (Postfix) with ESMTP id BC7AE10001B for ; Mon, 21 Aug 2023 14:41:30 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692628893; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d+1cxZtIc+jABd9gpvlvnsSzzWDtSHESEnOJIcCk/8A=; b=1G8FluoG6HIGcQzLLzGJ6IyFLvXI2gS2KDB8GsFyOhsiQ9bocqBOcs5Rov7SGAi1EaHmla 6jqfd0dJ8mhxIbPbsN4MAf1JbRq0pa3teDxru/xutUIN3SuEKrlvpMjJR10NSjXjGIz8ky +I/I1zD7rH4ASbaIPY6PWWnIjjsdLso= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692628893; a=rsa-sha256; cv=none; b=xMo799p5rKhNKXhg6pV0lXkdGQGsjzEs9NMhW1A8I3aqSYznyKoxVRIBdkwxOzu4+DUZxM U6eRzLmQPJVwxbkCuV57mxh0dgge97PhlwPSbQDoGRztixBawdffFQeYcdHk74SvYOtbiE yMJ0JemEtQggxkx7T5Ctl4/TSlJNqBQ= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from dggpemm100001.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4RTw7v1BZ2zLp2r; Mon, 21 Aug 2023 22:38:19 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Mon, 21 Aug 2023 22:41:21 +0800 Message-ID: Date: Mon, 21 Aug 2023 22:41:21 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/8] mm: migrate: remove PageTransHuge check in numamigrate_isolate_page() Content-Language: en-US From: Kefeng Wang To: Matthew Wilcox CC: Andrew Morton , , , , , Zi Yan , Mike Kravetz , References: <20230821115624.158759-1-wangkefeng.wang@huawei.com> <20230821115624.158759-2-wangkefeng.wang@huawei.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm100001.china.huawei.com (7.185.36.93) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: BC7AE10001B X-Rspam-User: X-Stat-Signature: fq1zggz7ntjr8tjz7p9sz9jnyr97s1hj X-Rspamd-Server: rspam03 X-HE-Tag: 1692628890-887643 X-HE-Meta: U2FsdGVkX1/XImKVZf36j0aglon+LbQyxSI65R4H4fFbM+NN31/LgvPQGeNE6DDxO4jVlYPq5mYelJZlw6lE1Ny0U/cqb1jVmV7pD8evFvI5eX1VAe829v2QCxmBYTAQuhIo3eFMix62HZ+7/zx87uDO/iiaW0+8FT4Gnk2T+66JphbZG7hSl/WACmBCMfuYBO93zOsc39bnFecQLW9zMCsSI37Mh+ZI99YX5e9THdBxgmh5EXy4aZ2aMag6MgK1lJPUBY84Io/18nYZUGOUz/oCMFON8ccBKun2tZiWMqUXf5W2bHIZvDYWhE8Y2jeikFjWr3s6qEsfzbuKsYQ1gtAbyP+YnwJ1whnmhPhVZSbRkv8+F6jl5BNrE2db2TpAqGuSpFAZQgdORryQbIjg13vTsuJtNpZcOezZlZIp/Bbd/btUT2Yezdvvg8adOjT12PvGISXDkTnCZPdXvvyU1XzxgCoBaWWZryLNoH8Ctde+Bs33emaz/9EQTMJXxhby5WBR44HhyQ43Q2j0HOpn0y2+eoon/t2oC0itJYDtFnSODDvTa2utMbTREtyUrC0ne7YBohTSVs448V2VLHYFFTKo9A1OOsqvkSB0zEogT6DoJ7WPtOp8dbNNXPidZxa4r4Aa4PwKK68cbdQA8faEygVPiEbjupFmZbWmNzonGZlKaU/vkyGxbfUtVN/VT88bAiiu/CL6wUZ1vxIFhqECP1eBqxgfmtr9hpKZFZMEEHxA3Mn3ks/P8J5+ytGqWYdOFP5NfN9OGPpk6RIpli5GFMaAlaFkqRs2eyvP0pfzVvBs3vj7Ci62EUvh/NZK24xHGlgR3Ivy/SqOkp1WInG91cJPYRdsArM1H826MkV9sPRGLj0uWY2OV1Jef4YC+d7xMt0RQ50dGDYetfchTrdrcCTW2BQTgJoJLvHgBVSujzliTUbyxhaNF2BUYQ7am8Op3xUkj/rT6jQ2os8KPF0 9jcd7TL2 CPwLMXgRjBKzro9gBeKm/Ipb8vbuOtz4SHFgUdLLxhs9ORvJI8j/Gf0s0QsFuQu+0So9S7VYJ/TnMj/ucJ2J3bHXh8u0/FwKRIZUCD///E3H37VFgaqSnW/GUEdogo5TLMMQuHx5VgfjX4of7UVUrhlgJoW6y0G/aZKQu2x2Xt3PA5Eeuuvw/WJU6JB4/yxKRPOgXhQrF3wlojcMKQSNC6WTTPD5wdbN6xQQwqyo/WGYQk0YS1HgdKHasiUAJjG0FZZOjmcIwYfezZm5ota52rZ+pacNwHhp/ejTGwvYjmKTibSo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/8/21 20:52, Kefeng Wang wrote: > > > On 2023/8/21 20:38, Matthew Wilcox wrote: >> On Mon, Aug 21, 2023 at 07:56:17PM +0800, Kefeng Wang wrote: >>> Since we begin to convert the numa migration code to use folio, which >>> could let us to handle arbitrary sizes of folio, so drop assert that >>> we only support PageTransHuge page(PMD size) when order > 0. >> >> Have you looked at the implementation of PageTransHuge()?  Your >> description doesn't match what the code does. > > oops, not only PMD size... Please ignore about reply, sorry，I misread， PageTransHuge return true for head page, and BUG_ON for tail page, and compound_order(page) will return 0 for tail page, so when begin to convert page to folio, we could drop this line since it is not useful check for folio. > >> >>> Suggested-by: Matthew Wilcox (Oracle) >>> Signed-off-by: Kefeng Wang >>> --- >>>   mm/migrate.c | 2 -- >>>   1 file changed, 2 deletions(-) >>> >>> diff --git a/mm/migrate.c b/mm/migrate.c >>> index b7fa020003f3..646d8ee7f102 100644 >>> --- a/mm/migrate.c >>> +++ b/mm/migrate.c >>> @@ -2483,8 +2483,6 @@ static int numamigrate_isolate_page(pg_data_t >>> *pgdat, struct page *page) >>>       int nr_pages = thp_nr_pages(page); >>>       int order = compound_order(page); >>> -    VM_BUG_ON_PAGE(order && !PageTransHuge(page), page); >>> - >>>       /* Do not migrate THP mapped by multiple processes */ >>>       if (PageTransHuge(page) && total_mapcount(page) > 1) >>>           return 0; >>> -- >>> 2.41.0 >>> >>> >>