From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 015FBC0015E for ; Fri, 28 Jul 2023 10:35:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 768D96B0072; Fri, 28 Jul 2023 06:35:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 719A06B0074; Fri, 28 Jul 2023 06:35:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E1118D0002; Fri, 28 Jul 2023 06:35:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4F3C96B0072 for ; Fri, 28 Jul 2023 06:35:46 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 222AC409B9 for ; Fri, 28 Jul 2023 10:35:46 +0000 (UTC) X-FDA: 81060664692.14.CB2784C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id D16184000B for ; Fri, 28 Jul 2023 10:35:43 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Mp6i+tWK; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690540543; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jOcaw/0qBs1pPL6pAEnr1BL8Snh0gAK7vHtXru4ReFI=; b=YTso3AeQM183POVVb8LLkuo7rlDl9FG9Wfyn1rfMTvQD8oC7No/GmqZah9WpzzF2VL084E xVPyaSgaqABpHy0uXr4Kj/vatcypwYI1AhVxSQSJwf13btU6/LofeLSTYXZaCVJ4T+Pzu5 PvCbcLVYhbrr9fbAuWLUDiPoDFe1Or0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Mp6i+tWK; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690540543; a=rsa-sha256; cv=none; b=N7iw3Hl3iryRLKi0z9QuUAfa+DpgoM4B1L6AQ9zZMD1g9nFQ6uamGA9BZ7LfuDu/8V/PyQ xNklihn22GUPf1BL0K9Ig/2AtYF7tO1In9JNZHQseU+aFmTurp6Y/+U7+Z9F3Ejcy1JCfZ 5OB7bW9T1KwhwhmTmhWsffAxxFMXORo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690540543; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jOcaw/0qBs1pPL6pAEnr1BL8Snh0gAK7vHtXru4ReFI=; b=Mp6i+tWKHowr6O8EBcPtrZP8HXhjy7fNpLcdmaKsw6lGuvJeO/TN7fS7Cfkgw5tD2LoaX5 Yx81O/b+Y8jOmFzaz0nwBNXubtOQi4O9RYIJhFBORgbVaGLlIXUfoF7boVZebfR3z3IHii BoM9EikcfqIN8CapwOKphO+zjm1oXvs= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-219-Unp8cyTGP-CcLw39uLzkZg-1; Fri, 28 Jul 2023 06:35:41 -0400 X-MC-Unique: Unp8cyTGP-CcLw39uLzkZg-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-31774e023d6so1287727f8f.0 for ; Fri, 28 Jul 2023 03:35:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690540541; x=1691145341; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jOcaw/0qBs1pPL6pAEnr1BL8Snh0gAK7vHtXru4ReFI=; b=hLZCAvPUgdyflj5BBWXbFkRe+LxQojq6UQHzxIIKnkSTa5cV1+ht11YjBFI82XoI8W 8akkVQMazwkWElj17vuKeLZUesvz9+X3yzKbi5jDYf8VZqmmvdDgzXX6gVUlMyitohXG Q/Prn2e+dXZt759YcWRjc95CGf+ltWgu/yOsp5tFHX4KFfuiW6HrQ/bAiSpHq07yCWWE rFpeDOrnrzn2psf0KFKDA992CWUw7cgwpeUdjpM1jDNy/cYHUD/7Yn5+n7yfjPx/DJaG 4e6kHZJSdqVH+10uSMGhXybEfhxtNnuAKqFpaS0mf/Kf9MMRTtY7KibEuAxUwC+rEjff AZvQ== X-Gm-Message-State: ABy/qLbSBBExt9hd8C8UXikNzupVyJOMZhIn9gT9g1Cgei+5k3eMGPRG bll79A52pPkW/2wl1FNaQNoc/wYqBE9rYV5xlPnqeIHt8ArPxUrJjLzTprRVT7KfbtlQs49vCGg dfMv/H2pf+5M= X-Received: by 2002:a5d:424f:0:b0:317:7c31:f3a7 with SMTP id s15-20020a5d424f000000b003177c31f3a7mr1510170wrr.17.1690540540784; Fri, 28 Jul 2023 03:35:40 -0700 (PDT) X-Google-Smtp-Source: APBJJlHjjIUzyCArZTitz+9i+d3qhAkwJUs0xSjHxU4IyWnOBX1very2BprXi83soc4m7lHWi0Qymw== X-Received: by 2002:a5d:424f:0:b0:317:7c31:f3a7 with SMTP id s15-20020a5d424f000000b003177c31f3a7mr1510156wrr.17.1690540540408; Fri, 28 Jul 2023 03:35:40 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:6b00:bf49:f14b:380d:f871? (p200300cbc7066b00bf49f14b380df871.dip0.t-ipconnect.de. [2003:cb:c706:6b00:bf49:f14b:380d:f871]) by smtp.gmail.com with ESMTPSA id g17-20020adfe411000000b0031437299fafsm4497581wrm.34.2023.07.28.03.35.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Jul 2023 03:35:40 -0700 (PDT) Message-ID: Date: Fri, 28 Jul 2023 12:35:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 5/8] mm/compaction: corret comment of cached migrate pfn update To: Kemeng Shi , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, baolin.wang@linux.alibaba.com, mgorman@techsingularity.net, willy@infradead.org References: <20230728171037.2219226-1-shikemeng@huaweicloud.com> <20230728171037.2219226-6-shikemeng@huaweicloud.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230728171037.2219226-6-shikemeng@huaweicloud.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: D16184000B X-Stat-Signature: gq5qt6fzxnqfche8a5n69qaqmiirdrzs X-Rspam-User: X-HE-Tag: 1690540543-684908 X-HE-Meta: U2FsdGVkX1+p7ilbKQhzLfBoGcGxWvx9ldYFO02eayPgoVYeaURgsjU4614JDwhTv/GLZalQED36NW2M7Dgyx26OdLMrcbLN4z4K/T4GOK2Co+e4g8RtJHNQHe8yh64ObXKHaRGG3xfUbFoPOirqA8RWw27wq2cF7G/5MexOgKcpLzSD+5bJ7CIapbLsTOblzfzisDINkkbON1o1TeXxa1NxAQP+SNaxFLGJ1qy4LWZJfwNxz78uD593lhUWXR9eeKzCaDCRxJPLkBul3HEXgRzUpVgCztmIEWewK8rvoeXlQ4Y1cCLbdq/J1LJnJs1h65Ht2Kxss1SS2Y3s5tA0VhYEbI1gZ2a8AXW7YOq4ux4P3dpHOVF4/ltbeUnvFZKiQ2EIc+2Yo2H6j7952PwqefOMZdMcUhipGM52WGvTvPGXy+lyv0641eNor4clCzKjXulmXZVmmfTLGbBgzU1c9dvE945X7zUVrHpup3einGoRxi25FcBVe5JGb6ioU7D1ubB5fgZyTRqHPDvFI8392ydPhUh93c9Byr8n7E9TxuPWVXKAHMbXNe15QTI9eH1j43cUoIZLHdZ/n5KGPp9jfCUm0xcLnwdzK4v+W3maXD+vQR84BWN90EVAMd2glk900IDto3rBOn3qNJJU0cdkUNNJ0SGpuB5FNk9+Edys4QVRjjpmTtbDl903ubaq8EfLXkggk2c070c2iaJorh9WbMy67SMLGdNWl2qbzy3Wsw1hvXgbtkBouARbtyezEmkV/YtFuHU7r5gObgwVJrsGsbsJx1Uz1CdZKaEJai+aw1h8H3DAIDFe8abeI8HUqgoYgfe8606Xn6g/2cmcbSwIqLM78Hp+cZFrch45K5vutoCeGLw7ImAt7E42v3N76qZf+phaOfwur+KjztkGAXpbZeCvKH2BIUmf7z688876rc39d4/ir5jfBLdYyYByxu071HqC/l9GjyZ+74DxYYL MEbWzAdB XXRqX44npmvE4ucOCZj/pjAvLdzfCyXXWNXLl7ESoCVJGRSGC6CNffsCa90RuJd2Q8ab24u+u/27HhlsISiBn43/3TUdekT30zLIgxpzq1jMG0h7v3zsGDzPKv+fGTjseKaA9A18JzBCwVUP0D1mekb68vueY3iAd9FKAjQURwo69QqdmmSltZb5KXKj2YVWnojxqhzA2JOAtAtitqDNd7pmpQXfeGEL30Y+tQzn3V1BrkoptURgIz85jSJqeoa+5e4oltwXyX0KaaG/RVxZUnJwiVvTcqmFi39BQa4PBTqjVSQ9pUFFPO++BU9gNsjS9BeT996m/h/p5VfXp6A0nNPDwFUkG+crQKWRrtLphSSOg2B+CoEVWnr7mdZATkZH157wXklUD4XebAbcGxa7HHXwH/I6MRz8GCHZFqTERmPWsdq98O9wKZ9IzGEPJIKECeWXQR9zkh9aF1FbYDMscSzjU4g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 28.07.23 19:10, Kemeng Shi wrote: > Commit e380bebe47715 ("mm, compaction: keep migration source private to > a single compaction instance") moved update of async and sync > compact_cached_migrate_pfn from update_pageblock_skip to > update_cached_migrate but left the comment behind. > Move the relevant comment to correct this. > > Signed-off-by: Kemeng Shi > --- > mm/compaction.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 09c36251c613..1eebb61a1f63 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -464,6 +464,7 @@ static void update_cached_migrate(struct compact_control *cc, unsigned long pfn) > > pfn = pageblock_end_pfn(pfn); > > + /* Update where async and sync compaction should restart */ > if (pfn > zone->compact_cached_migrate_pfn[0]) > zone->compact_cached_migrate_pfn[0] = pfn; > if (cc->mode != MIGRATE_ASYNC && > @@ -485,7 +486,6 @@ static void update_pageblock_skip(struct compact_control *cc, > > set_pageblock_skip(page); > > - /* Update where async and sync compaction should restart */ > if (pfn < zone->compact_cached_free_pfn) > zone->compact_cached_free_pfn = pfn; > } Again, no expert, but LGTM Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb