From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5D63C433EF for ; Thu, 6 Jan 2022 10:40:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A6AC6B0075; Thu, 6 Jan 2022 05:40:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 656886B0078; Thu, 6 Jan 2022 05:40:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 545666B007B; Thu, 6 Jan 2022 05:40:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0041.hostedemail.com [216.40.44.41]) by kanga.kvack.org (Postfix) with ESMTP id 414B66B0075 for ; Thu, 6 Jan 2022 05:40:25 -0500 (EST) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 02B9195B16 for ; Thu, 6 Jan 2022 10:40:25 +0000 (UTC) X-FDA: 78999518010.31.DCF7C7E Received: from out30-130.freemail.mail.aliyun.com (out30-130.freemail.mail.aliyun.com [115.124.30.130]) by imf02.hostedemail.com (Postfix) with ESMTP id 7305580017 for ; Thu, 6 Jan 2022 10:40:16 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R101e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04426;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0V15yZ6T_1641465619; Received: from localhost(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0V15yZ6T_1641465619) by smtp.aliyun-inc.com(127.0.0.1); Thu, 06 Jan 2022 18:40:20 +0800 From: Baolin Wang To: sj@kernel.org, akpm@linux-foundation.org Cc: dan.carpenter@oracle.com, baolin.wang@linux.alibaba.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] mm/damon: Remove redundant page validation Date: Thu, 6 Jan 2022 18:40:11 +0800 Message-Id: X-Mailer: git-send-email 1.8.3.1 X-Rspamd-Queue-Id: 7305580017 X-Stat-Signature: ud6b7q5z5z419qegm4gaoitswapceqaj Authentication-Results: imf02.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf02.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.130 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com X-Rspamd-Server: rspam11 X-HE-Tag: 1641465616-486979 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: It will never get a NULL page by pte_page(), thus remove the redundant page validation to fix below Smatch static checker warning. mm/damon/vaddr.c:405 damon_hugetlb_mkold() warn: 'page' can't be NULL. Reported-by: Dan Carpenter Signed-off-by: Baolin Wang --- mm/damon/vaddr.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c index 89b6468d..8a52e00 100644 --- a/mm/damon/vaddr.c +++ b/mm/damon/vaddr.c @@ -402,9 +402,6 @@ static void damon_hugetlb_mkold(pte_t *pte, struct mm_struct *mm, pte_t entry = huge_ptep_get(pte); struct page *page = pte_page(entry); - if (!page) - return; - get_page(page); if (pte_young(entry)) { @@ -564,9 +561,6 @@ static int damon_young_hugetlb_entry(pte_t *pte, unsigned long hmask, goto out; page = pte_page(entry); - if (!page) - goto out; - get_page(page); if (pte_young(entry) || !page_is_idle(page) || -- 1.8.3.1