From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C75A3C27C53 for ; Fri, 7 Jun 2024 19:38:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5BDFE6B00A4; Fri, 7 Jun 2024 15:38:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 56DDA6B00AD; Fri, 7 Jun 2024 15:38:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 483906B00B5; Fri, 7 Jun 2024 15:38:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2B6826B00A4 for ; Fri, 7 Jun 2024 15:38:35 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C5103140A41 for ; Fri, 7 Jun 2024 19:38:34 +0000 (UTC) X-FDA: 82205104548.16.F9893DF Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by imf13.hostedemail.com (Postfix) with ESMTP id E86ED20002 for ; Fri, 7 Jun 2024 19:38:32 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=Ix7UY4kd; spf=pass (imf13.hostedemail.com: domain of gpiccoli@igalia.com designates 178.60.130.6 as permitted sender) smtp.mailfrom=gpiccoli@igalia.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717789113; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MTEzRWAwJ8LSeiEucNCTCesadgMsTVrZqtI4H5H8Hj0=; b=OqWukF4ORl6KBZNv/7xEPs+FN9gpDhfuEGKW9ap3v4KugJOj04iRu72ZNs3BVl5n26j8hr W1TdW+LXtbQJQtDcktKaty0ee9XhZOiDPkERl2Qpq2j8qBfxwYtINJwisdbDcVkdHXxkNA JFNuvImhue/5htEznSeCYAskihnNOWo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717789113; a=rsa-sha256; cv=none; b=NmRbMw8/hlV169EAfxIB2oVSze9ZVXheJocPivjb43Bf7LzjaNpsZM9KKZwZqj7JZys3rk rF6Uh2oiAF/p1JtOBbbA3CdJJbEhvPznBmr6AYCvP6bjC/t3rF63Y4gzHMG/oFqiSSz9re DMR/e+JBl+pAi651N+PKBFpLAfQeUco= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=Ix7UY4kd; spf=pass (imf13.hostedemail.com: domain of gpiccoli@igalia.com designates 178.60.130.6 as permitted sender) smtp.mailfrom=gpiccoli@igalia.com; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=MTEzRWAwJ8LSeiEucNCTCesadgMsTVrZqtI4H5H8Hj0=; b=Ix7UY4kdZPsy4Alki1oHK0Wmbg zmyUnbpdgvF1WCQyOyB6+q/D8Zkr65aLzU97FOb7x+c2i7fxy7r5qKYlw0hG1QWk6fX82yx1uzj/2 0jWgn5GnwbY6LypKEs5c9g2/bx2htbFCY5xU4+niILa9jWdjXXOv/A3g3v3HWFRC8CW8CIVDDd8s5 VBG2odFDNPhLgeGHLoyxYQjwEVbBmvGEyVocDAAGLwEq0jiCDgfi8tj66tarvEI9D7JJUQSZ5y8no VNsoXvgLLTeUwHIUw3OpLbzZcGOEmmFHbrEqKyqL3n+KUTfmo7r77YkNZs14f7A8zUiZNEC/panes Vs3tz7dQ==; Received: from [191.205.188.103] (helo=[192.168.1.60]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1sFfPk-000e9A-VB; Fri, 07 Jun 2024 21:38:17 +0200 Message-ID: Date: Fri, 7 Jun 2024 16:38:06 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v2 2/2] pstore/ramoops: Add ramoops.mem_name= command line option Content-Language: en-US To: Steven Rostedt Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , "Liam R. Howlett" , linux-trace-kernel@vger.kernel.org, Vlastimil Babka , Lorenzo Stoakes , linux-mm@kvack.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Peter Zijlstra , Kees Cook , Tony Luck , linux-hardening@vger.kernel.org, Guenter Roeck , Ross Zwisler , wklin@google.com, Vineeth Remanan Pillai , Joel Fernandes , Suleiman Souhlal , Linus Torvalds , Catalin Marinas , Will Deacon , Ard Biesheuvel , linux-kernel@vger.kernel.org References: <20240606150143.876469296@goodmis.org> <20240606150316.916395285@goodmis.org> From: "Guilherme G. Piccoli" In-Reply-To: <20240606150316.916395285@goodmis.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: mf87kf77rkn43harrxyn3kyiiythqaa7 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: E86ED20002 X-HE-Tag: 1717789112-279930 X-HE-Meta: U2FsdGVkX1/FpfIR2gFoNqc0IdKUFaacsiK7WH99C8vxsLR28up+yajZs9wXTSruCpTV3eY5cchlICQdVAblYQSS05QqKszcOsxiXD3cpAZB86MVedqwKKQKDErAy6xN2RPZGTamY9KuGYUlCkSSeVlVBytgXnFY5jEpOgrwXrp6IkYejYBroYr7CwwWeZ3742PfLgtloEE2ihCp/Gl8hB9lg3JIezHO8mZz8s9fXLGQYMZQZCqNnAwuNeJvTf8nFdkLNiHJGR3dyLubfDQ8kPSuJPpPWMxeaQDsegJUfssLC4Gq9svabJ9qffcGRXCNi/xBJdXjyuRARvUUxIi4CPZBDcMJH7eznzy9ijaQamYa01cf11hSIMEjM1ABCbZ74kz6AsVDu0Vc0sDl3UcI0ao0ZmflGHUJlER3lIsX9qgk3AXaMksMdlChU1b489JUwuUp8InkNt9o+lgFUZ/Wk86djmVrwQPFHcHplg7hNpOhmClJCb80Dxpt2taaNtNewkD1F2ZZvBezjGjuK4sD5Y7IBuf09znR0Pf7p6Kvdg0HyHLmWDXZSSewcw2mvNPk7sDcRsA7kufp4euSSWxT1B0ZWOaPKq7CtFtkiSqcd4ie4GAghGuz2VBHOiiorSn3HIl4SbQqZVMdFkVxQN+iZPGtTKdMmj3HWhEpqI81eraH31eyxpKK5Fx/0brsc1sOAhaPv7N1SgOdHYAUACK4ko05lxCJ+bZVjoEMrAdaeSJbqTR/bBDVJTPYXVa74hzGnEqdK7jiSm7mlagVMklCoOFUDx4uLom0rgEUTgWRZ6J62bVFOeLZql5T3qN0tWStWK9Zl5Wfwmp0ofoM/8ySYxjjZp9dcQ35RkvEq+xkSfU4dTy5ftpu6qoIeJLClSCo+Ap9uDM0jFmMV5F3JQmkQcZn/2JZ5zeZmIu5Mr4faOyzAIfZ8ni/gsdfvG2uOKuDGI5R/dY8fOgMLHMhpoj Sxj26SAQ 6gOwxSWh3jBCPWjP+hmW6JkJcwuv0NGzDzpzwYts15gZvmMPK9FWDRk91N3WcEyKwSnP2h54TWQZ7UWHbM1hZ6CTYel/jAFnLn0Xfb5tydN7hWx3Yk/7QAVXMsYMZVBpoQ27hw+GRQwFRvuvh8M+2lW3TKo3XXFlocgESkLN6kKj1tjl+kC1vhsxNjN9erBkKbY8K X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Steve, thanks for the patch! A suggestion/fix below, inline. On 06/06/2024 12:01, Steven Rostedt wrote: > [...] > +static char *mem_name; > +module_param_named(mem_name, mem_name, charp, 0400); > +MODULE_PARM_DESC(mem_name, > + "name of kernel param that holds addr (builtin only)"); s/ (builtin only)// Likely a vestige of a previous version heh Cheers, Guilherme