Re: [linux-next:master 7918/13392] drivers/soc/microchip/mpfs-sys-controller.c:73:1-6: WARNING: invalid free of devm_ allocated data

[<Conor.Dooley@microchip.com>]

On 18/03/2022 11:59, Conor Dooley wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On 18/03/2022 11:02, Arnd Bergmann wrote:
>> On Fri, Mar 18, 2022 at 10:43 AM Nicolas Ferre
>> <nicolas.ferre@microchip.com> wrote:
>>
>>> Is there a drawback to this approach in the sense that it can trigger
>>> other test robots?
>>>
>>> This way, we won't have to disturb Arnd as I believe that his branches
>>> are all ready to be sent to Linus after this week-end. Additional
>>> benefit, you don't have to change your plans and enjoy St Patrick
>>> week-end ;-).
>>
>> I don't mind taking last minute fixes for buggy patches that I have queued
>> up, that seems better than sending the wrong code first and fixing it up
>> later. I would fix it myself, but I don't immediately see what the
>> correct fix it.
>> Do we just remove the kfree(), or does that conflict with the lifetime rules
>> in case we unbind the driver before the put() callback is called?
> 
> I was just going to remove the kfree, but I don't think that's right.
> I'll switch it back to using kzalloc & leave the kfree. I'll send a
> patch later today.

Just to follow up, I sent a fix on Friday:
https://lore.kernel.org/linux-riscv/20220318172107.1599399-1-mail@conchuod.ie/