From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F98CC433B4 for ; Mon, 10 May 2021 08:57:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CD0B26112F for ; Mon, 10 May 2021 08:57:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD0B26112F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 22C7A6B0036; Mon, 10 May 2021 04:57:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1DD626B0071; Mon, 10 May 2021 04:57:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0560B6B0072; Mon, 10 May 2021 04:57:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0093.hostedemail.com [216.40.44.93]) by kanga.kvack.org (Postfix) with ESMTP id DA5A96B0036 for ; Mon, 10 May 2021 04:57:41 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 8F1ED98A4 for ; Mon, 10 May 2021 08:57:41 +0000 (UTC) X-FDA: 78124718322.38.421A01A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf10.hostedemail.com (Postfix) with ESMTP id BA2FE40002D6 for ; Mon, 10 May 2021 08:57:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620637060; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0iQuLfYZz1f7ybaehJQTtubU+TzHINy+qLk4Xw1aoYM=; b=IthGvRBR6+fIaeman5oGlg6tzPqMgCdWf/5az/znOScFaNmW+httm18H17WGo9zyWIej34 a+Sew7onjU3u5/GEfDP75TAprkx06/hSADig9mKfGv9q8jgCbleBmr4G9M05+CLhsQ34z6 6YAcT3X8SgKxzXoyb8D4WYit8crJfts= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-603-RpVCfpKpNEeoN5ttPv6Y4A-1; Mon, 10 May 2021 04:57:38 -0400 X-MC-Unique: RpVCfpKpNEeoN5ttPv6Y4A-1 Received: by mail-wm1-f69.google.com with SMTP id r10-20020a05600c2c4ab029014b601975e1so4185249wmg.0 for ; Mon, 10 May 2021 01:57:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=0iQuLfYZz1f7ybaehJQTtubU+TzHINy+qLk4Xw1aoYM=; b=aVEdRAlqz0sfGYpubdICNprsTKs5y+V/jQuWsv+UrPArPibrU9+wS7EJmzAoBlRN2g +0kOZURPhn/DuirXtrRsT2pCloAF5nSFXBgnMdkCIWlZ4gLrLbFQqQk/4NNhn+SWF4t2 Yy6MIkAFxqGTalwm+gMWZB/Mjv9Nm5haZ7AeFI1ZVSc0VUzliBw5y2gJyOaBhAQ0w3EU WSv3rXozRAg5vlHi+mlStIqMHl661LvbMKcX9A2o3PfSQfPjcIyKiYqlMDxk1kcDSQK3 ghUDhYFMNoJ8YUFTyShnsBaan7sZb1d5UFDXYv5rw5TwMCcGvu5YfkvY9bPBQkJoJebw 7XqQ== X-Gm-Message-State: AOAM530cinuLcurdOKUfC8q+9T2IGm0qumTGM0xzsb/mABRLQZ9F/7nM fEahzYJv2NrTIeCbvf+R66Spd2femZoPHnjGOW2DZwiNIcjhkEv5dTaTKhNlBZ1+hPgRLfk2sjD MklvifuZU3V03+PoUeTf2BUUGnVrd5ywbaFf+iEdUNL/DB9+Nysg6s44sEWA= X-Received: by 2002:adf:f1cf:: with SMTP id z15mr29939249wro.97.1620637057773; Mon, 10 May 2021 01:57:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJziY46OKdZ5MbcxaWz89qORssdCeWqIPpBRiGOU0ZTDnlTg6tqr9b6t4A4/lm26DBq8OzoGHg== X-Received: by 2002:adf:f1cf:: with SMTP id z15mr29939228wro.97.1620637057569; Mon, 10 May 2021 01:57:37 -0700 (PDT) Received: from [192.168.3.132] (p5b0c676a.dip0.t-ipconnect.de. [91.12.103.106]) by smtp.gmail.com with ESMTPSA id k11sm24236996wmj.1.2021.05.10.01.57.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 May 2021 01:57:37 -0700 (PDT) Subject: Re: Migrate (from, to) or (to, from)? To: Matthew Wilcox , linux-mm@kvack.org References: From: David Hildenbrand Organization: Red Hat Message-ID: Date: Mon, 10 May 2021 10:57:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IthGvRBR; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf10.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: BA2FE40002D6 X-Stat-Signature: 57fxg7rmr9bigrziaq4keuntrfco9tgn Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf10; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=216.205.24.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620637045-907116 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 07.05.21 15:31, Matthew Wilcox wrote: > > A survey: > > include/linux/page_owner.h:static inline void copy_page_owner(struct page *oldpage, struct page *newpage) > > mm/migration.c: > void remove_migration_ptes(struct page *old, struct page *new, bool locked) > int migrate_page_move_mapping(struct address_space *mapping, > struct page *newpage, struct page *page, int extra_count) > int migrate_huge_page_move_mapping(struct address_space *mapping, > struct page *newpage, struct page *page) > void migrate_page_states(struct page *newpage, struct page *page) > void migrate_page_copy(struct page *newpage, struct page *page) > int migrate_page(struct address_space *mapping, > struct page *newpage, struct page *page, > enum migrate_mode mode) > int buffer_migrate_page(struct address_space *mapping, > struct page *newpage, struct page *page, enum migrate_mode mode) > int buffer_migrate_page_norefs(struct address_space *mapping, > struct page *newpage, struct page *page, enum migrate_mode mode) > > rc = mapping->a_ops->migratepage(mapping, newpage, > page, mode); > > That's a pretty clear preference for (to, from), so I'm going to change > copy_page_owner() when I convert it to folio_copy_owner(). And I'll > fix remove_migration_ptes() when i convert that to folios. IMHO, memcpy() semantics make most sense. So I agree. -- Thanks, David / dhildenb