From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE37DC35FF1 for ; Thu, 13 Mar 2025 22:49:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 282ED280003; Thu, 13 Mar 2025 18:49:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 23110280001; Thu, 13 Mar 2025 18:49:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0AC19280003; Thu, 13 Mar 2025 18:49:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E144C280001 for ; Thu, 13 Mar 2025 18:49:07 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8A8ACC057D for ; Thu, 13 Mar 2025 22:49:07 +0000 (UTC) X-FDA: 83218019934.27.F3C4756 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 113BA140004 for ; Thu, 13 Mar 2025 22:49:04 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eMEAmqCp; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741906145; a=rsa-sha256; cv=none; b=wo7u6znvxd2TTqfyzt3o1mnqhjUYJe1Iy8d14idP5NvjWq3Ew+R155f4JORBdx18SE+3vq /T1tXP3NGCvO4YGsAnvPzhtf3rs1FNjaQVCTRmarfglBYQQ0bOa9iMHlHILgTh5bKagPwO p769K+fTIVUhVPk8HLqiBg7aGZeIx3Q= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eMEAmqCp; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741906145; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fNx6s3/J07DS7ObLj5D43SvIYaGPnmaHjq5aLXmff2A=; b=Bed3lmpOlnhSQYm0y6BOCciIKomqrtcFOtW5UBymYdpr1ckG8W9N/xHh8KAh23/KkhUbR1 vIExZyaxWxBT2t+f0KdH6H0/Jh/9vIjDy1oH5H9oD18/qXApPPcmGCXTFWdkJuB6OoaV4H LS9peK67E4o4loExAX0JCfAVftBLLKs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741906144; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=fNx6s3/J07DS7ObLj5D43SvIYaGPnmaHjq5aLXmff2A=; b=eMEAmqCpoLRTf+mnZ/5v/MQz2Xah8yc0BJGV3pB8+gGtqF0EvqUH5YdrlOAU3m3GlXsFUp Z2iJgmWsJtXmXKorhjeiijNdmiAPzWy3u94GW45Fz/D4hR4kQ0MYZfZzCRPxSy9E8UZIT1 gocZcYwSCbrkmmYHJXQzqBIvuVcnod0= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-541-Nu2a5_qSPGulfkPvqTR4PA-1; Thu, 13 Mar 2025 18:49:03 -0400 X-MC-Unique: Nu2a5_qSPGulfkPvqTR4PA-1 X-Mimecast-MFC-AGG-ID: Nu2a5_qSPGulfkPvqTR4PA_1741906142 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43ce245c5acso10787765e9.2 for ; Thu, 13 Mar 2025 15:49:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741906142; x=1742510942; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=fNx6s3/J07DS7ObLj5D43SvIYaGPnmaHjq5aLXmff2A=; b=uwtv3i7KQ+e7lmLIDnqvRqX7T/txniPDfy+lh/U1kHzza4M013q2RJH23u+nsWoR4W GlK58SAhw15ALdloa/ql9HOGjGLy5EXD8FU0ot4exVG7xdjp/V294LR0+4tFbsWdwkpS ewaD2XTDoR0j6B7FNBwHrGEIcIOjsIWHFoN98Hq7Xm6pbbWaeUJsmj0/fm997w7F9cVE WXVsDjbTxF7Gwv6x+r27hCKqvyp3Vm2PwaFrh3nMvNq/ONIpIWnQcT1DQfnUAy4y5ovH yjmxF5WXeZ7YkGrOBOnOUg5OrMtxn+HXObDhX1lESrGV19gvB3nw4uko8zjANdKInl7S TKsA== X-Forwarded-Encrypted: i=1; AJvYcCVHQClZHChsTZTHtlLyqCc1Rmq598QjBkPfpfjHJ6xRzwcEi6V9l0N2wuAhBMulAaFn6miujodtnQ==@kvack.org X-Gm-Message-State: AOJu0YxyL+9SHJSifzVbDDrFBYJa2K8rpj2SqZs+NYWy70i7PGcmjIoT f8tNNvN3GehDQpv/Ab1qkgXjmLIxTh3r+soQM4qzuNTicXm4XN83DXLkiRatn1Cxzi08G/eH+iP n+lGMLNAvB4U5FNSortKh6w3Cy6iy63v91521QSr06iPzxlWc X-Gm-Gg: ASbGncuuoS8yDD0qSK1dHjUWvxMebLMvVlD6Ep6z7k8/CtkkpwbPs0v58ql/Cqg4Ekt 47JqE0vKdYxHG0l69jkMun0KRL5YukxOZmfjwyyYVKW8OAeZVAvJB890lSlmCZoWNpnxqw6DgkL iEIsWyEOy1H3INxVpCUgyXtaDYJKdKPd5IuvOQsWIi6mLqSjgFa/8pvqbkol3lcvZtPmrbDUbPj fgfQ6yVgPrzBBU4VUYL1yz9W/9EHZvZ+jy8vO8d4scF+oCImN/Rd/CQcGVpl+hEOYpS0iDJn5d7 McbqvYMhkYK3QLANan9YLuxmPhVOW8FEJPmunjmX6PIGetR7JVWNfT9QP/sDQAvcq7E0Q9th2b1 DxdLMIscShlK9M7eWaQJ7HExj25UDE1VpPCEtiSVK X-Received: by 2002:a05:600c:354d:b0:43c:f470:75df with SMTP id 5b1f17b1804b1-43d1ec62221mr4569565e9.3.1741906142099; Thu, 13 Mar 2025 15:49:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGUwMZox+xV+pcOJHlgdYjfbekjvUxim3egvkV3xAysHIT4juylMW5S4p8Urr9Tnmdha0VrwA== X-Received: by 2002:a05:600c:354d:b0:43c:f470:75df with SMTP id 5b1f17b1804b1-43d1ec62221mr4569365e9.3.1741906141729; Thu, 13 Mar 2025 15:49:01 -0700 (PDT) Received: from ?IPV6:2003:cb:c742:3600:463c:fbbe:a2df:efd? (p200300cbc7423600463cfbbea2df0efd.dip0.t-ipconnect.de. [2003:cb:c742:3600:463c:fbbe:a2df:efd]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d188b0cc7sm34766725e9.3.2025.03.13.15.49.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Mar 2025 15:49:01 -0700 (PDT) Message-ID: Date: Thu, 13 Mar 2025 23:49:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] block, fs: use FOLL_LONGTERM as gup_flags for direct IO To: Christoph Hellwig , Matthew Wilcox Cc: Sooyong Suk , viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, jaewon31.kim@gmail.com, spssyr@gmail.com References: <20250306074056.246582-1-s.suk@samsung.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: V8XcvjNIr1lZIj9XpXOq_-ey47jPT9bSVPDROZurz0g_1741906142 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 8uoz7yyxozz5r66mhndh1oor9ww6czup X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 113BA140004 X-Rspam-User: X-HE-Tag: 1741906144-869016 X-HE-Meta: U2FsdGVkX1/F5vvyJjnQ52cB+xVZo6wfYoKRnbfEnUUKIXPkxmL7giU565DdGdTwyqPO6pDTtIalayQFoxQG9iM4SfXYhxxkspFKK0QQQvqquxkklKKzvoMf2s8rzDvaOsT/x3lux2u0kzzoGwpDybiAY1pjr345Jd6HradaC1D2t2TsAdNcqifouh+4AznrydCKA/IsicNVbYobGyU5e5upuQWRjQxhwES/urIdVzvjDOc0pnKLxou9sivqbwjeJRQzcuih3areE/GNGtgMEzHj009SjA2Gj04dbW5z7sJFuPMiC/3gfi97wLYwtVS0NUwnCCvukRDJ/VmKDZx5dDU6KCGWZZhgr97iPkXmR3XMB7Umbvm/xOK6IlUnfpTpvXI1XuQoS+AabFL/8EwMf0YY27Bbq4xrfHNCUkiKbyNjkZONSQ/eZjarff1IwrpchhayS3sjkUrt2a+2kmgqOC3xdb8D+5Dnu5fX7Ce6Pkzuwm0BV97sqpC999z1hNQX/4Lx8lkSVfoqnHrtHjm3zs6PG2a4mV3AHolzQJI2iUsxOt5DQ0nW5/uDxID8Yx8ge1xR4gagU9Vbn/S7OjKwh/Is2fpyUHm7MGY1cFHzhD++KeUTWyRocVQ5l0FbWBiuTiEc30WFmbhpatZ1AB5z7ocUplqqJgSyOW0rBk24Rc6+wy8wNZ8xLfB1YwYqZLR/TY92FjFijQ/um3YR1LP+1yGxbPl7YkecaK7KA2IiscAk4iKMErNYKgW3maG4F1Tf2ssosHvHCbXPxef8qBw0wOmfJW7tgKsmPST7ZOcJijon9wXJb9JoaMUfEahgCkTJC2K7k7+a16nvva+iYitcqQ/0TQAZTLtGHSUKA3lnLx4zQ8+ouZNK+5+hSJubWKltdIN1qkS+kv0mbAJeHzgiCHoBJwGeYqUWRt/+5Ow63SAEdZTtdr+EJcZ3RM+SrSnWoJQKLLk/emlN1kfYfrT OzkAX7AH xkG/ZIA5NdVs1dfYX+7LWmbP29wHZDrMltlzst+zyZ+4LAvDEeFe9RLlLM60YQYAbWzRnAt8ki+luavte9U4XyPI1WISLDFd8QiTCMmRTc9DYx5TneourFIlBCAWOw7PfLkLOPloSMgP6E6J8vIGTyrQ56jrSIi2RMX05NH60sH7Z3pJAUTeqv/dS69X9yOqIExwVwYozDBnMh/Gjtcl4LY57oaQl0EvISdmTqSxAFx8/HAwM1s4uBigcOXdxhXurWLW2Puc/4iaVPNslucCU7wFfKPRBCT0m6zpD9+LjStjzoEjIFCBVc7vV+i1CqNx6UYnuqihOJ8rR7C4d+PMChnDCVLZeHiq6KoeE8Ksn1KKBMBquniaOOQmNfK76jgfZCIfrU/pWp5mstcW4acLA0v7zkk/8xPweyYiZWogo7t9RCKVRhbv0Mccr5AVwvNfJsfUEGQsj/oEkQjgyzvyPlhVLOprawcrJy6EaWCAAaVLVIPK4FtoCabwWvpsSEenWQpsGT0wqTNdbepB7uXLrRxgCrqEZsyxDyXL5KLQt38+BliiJHQcJmX7urg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12.03.25 16:21, Christoph Hellwig wrote: > On Fri, Mar 07, 2025 at 08:23:08PM +0000, Matthew Wilcox wrote: >> Howver, the problem is real. > > What is the problem? I think the problem is the CMA allocation failure, not the latency. "if a large amount of direct IO is requested constantly, this can make pages in CMA pageblocks pinned and unable to migrate outside of the pageblock" We'd need a more reliable way to make CMA allocation -> page migration make progress. For example, after we isolated the pageblocks and migration starts doing its thing, we could disallow any further GUP pins. (e.g., make GUP spin or wait for migration to end) We could detect in GUP code that a folio is soon expected to be migrated by checking the pageblock (isolated) and/or whether the folio is locked. -- Cheers, David / dhildenb