From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40EB2C3ABB2 for ; Fri, 30 May 2025 08:33:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 685946B0085; Fri, 30 May 2025 04:33:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6355B6B0088; Fri, 30 May 2025 04:33:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FE416B0089; Fri, 30 May 2025 04:33:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 302316B0085 for ; Fri, 30 May 2025 04:33:24 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B50BB1627CE for ; Fri, 30 May 2025 08:33:23 +0000 (UTC) X-FDA: 83498909886.16.2F44298 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 4198720005 for ; Fri, 30 May 2025 08:33:21 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="e7EOwHE/"; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748594001; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KXrmciw8fw3IVBDeiE8IPSrAAHDX+SY7wQ0MY8GKbnM=; b=2Nf8Cw5IOiPGIKAkP4UcCEKOuNyCG6dUtfeMKeB9TOBaOtBDJ4lHU4EmWSMccp7aaX4eo0 zDMFUt4IgtCBUWiXG5Q8NoTKpjr6weIf8nRU1bcPYB3Gtdys6EcNPMiL72+PeS4YY5pTxX jICTYlWyf2CeltAyQ1EsRAyhjFoqfZY= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="e7EOwHE/"; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748594001; a=rsa-sha256; cv=none; b=dQA7wWDiWJP5lAyXn7w87hRCV2wXWudk7xkTr6F6nDjs2DdBoH8kxcx3Z9MmZgykqrLuqb a9tAUOXjffbO8vpG0n1D2NyFask1jvxp62YcQXTeWyZxfZLs3otKfuXyEXVQr9sl7WMnQr 1gaXnk4f1oBHKJMuzLiqz7N6/C//s30= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748594000; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=KXrmciw8fw3IVBDeiE8IPSrAAHDX+SY7wQ0MY8GKbnM=; b=e7EOwHE/45MMJTDiL5gd9vqi+FtaQszq/wNWJxeZxQ+77RRDkCkU396sL0TvNx5v/6M8b8 iQ6dem2Hbs5U/CjDyQEh2AeC2rNjF1zTjCp+LmEATvXp7/yr86VB0Wu6GKgMHquroBf1O8 IffNKwrn9qJIQ74iXNqN0qXjEfvIlLE= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-247-zAVZSTAvPvCqYC6qJxV-eg-1; Fri, 30 May 2025 04:33:19 -0400 X-MC-Unique: zAVZSTAvPvCqYC6qJxV-eg-1 X-Mimecast-MFC-AGG-ID: zAVZSTAvPvCqYC6qJxV-eg_1748593998 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-450d64026baso4056355e9.1 for ; Fri, 30 May 2025 01:33:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748593998; x=1749198798; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=KXrmciw8fw3IVBDeiE8IPSrAAHDX+SY7wQ0MY8GKbnM=; b=Vu6bRTLHaWqyw5NSRFM17UTYkUN2wHWXY15tegbZDsdAKppy8an4d+NT7Lylpz4Z/p Ee0KFAHnVkZwHu9KWjfHkSYOXhe6YxzWD8izIGXnAC3fT+KzlGJkzLJWAKrQx/cxWQXz EJNw3hL5beakzaVSs21XJ5mMNbLKGHdoe7FVGR6vg6VfAADFIlbzXHojdElpQCpZ6ema RxZKXu+TZUjerUS28c8MGyIKm2n5pqqBBAJbWElU0fordMpp4EHBrsPLu/VNI7D5jvQT gNB46p0ZEz4nVHWxprf+vsI4hlNBZkXAdbjDND+kudzN8EMk35BYhyNsvRJnxM8FWz23 102A== X-Forwarded-Encrypted: i=1; AJvYcCVrBcn4s2xP7GgLYuLRRtuqh97vzPyVrwniI3BAzje2yeBt3Jvu/bEJDmptcAwa3/uQ/AqkFCWy9g==@kvack.org X-Gm-Message-State: AOJu0Yw3CJUtCKe8BTA0bRRYhkyEkDAKE6nU67xcc+FzKI6B9Y9m1I1X 3xSdxQ4wmMzH3VaHfQK4wYlfQszkw/7jJoML4EnpyfwAXJ6ibo3YfX6J1Q1Wit2p/UaoW67K+h7 Ixb/6CJjGCJCo2tCPao4h5VuEx1HJs7wLKof9S3+HqlxHu1Vbf+ZW X-Gm-Gg: ASbGncub8km4ZadDmByTklrzgjvo9qoDrVS678jmqurNEEzRYEZG9jGb0d4KKmbCCTK d0coAbWdK0SDsufQdCqPvNbqLmmF9Z+cDkNl7M7rvWJTT2125plBKTY8TOIqMq0kxpoZ8rKmOVA KyJYBZIzmOhbGBlWC4STJTrLXjZZjLFpZ8FpzwskjuHUTl5oOXr37Y57KHbrMd/WnOWEfGqY82s d1qrJvsLAb6U1BsSaFjxKOJfKpmJcswpUvG+6rbn/IWgxLuI75TfhBLigbC09enyhA8OOtUF17B 96CaWwjRdLX39hhdWj+tkCvj+Eli6tqJFJjUhNUSS+fPEioo7oqVYY6wDp+SIImcJj/PU55B/2+ IdYQoRTEYDikLyAr5IfuCEND1nKHJtqrGk5IJzEc= X-Received: by 2002:a05:600c:8509:b0:43c:e467:d6ce with SMTP id 5b1f17b1804b1-450d64c313cmr24746785e9.4.1748593998106; Fri, 30 May 2025 01:33:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHVcr8PZ5QbPXx9wYXWNy5yUlTGaH5PzQJYlbqrT8pMQ5rU+6cBIGsOcxKenkA6npxlPlPeIg== X-Received: by 2002:a05:600c:8509:b0:43c:e467:d6ce with SMTP id 5b1f17b1804b1-450d64c313cmr24746415e9.4.1748593997547; Fri, 30 May 2025 01:33:17 -0700 (PDT) Received: from ?IPV6:2003:d8:2f03:5b00:f549:a879:b2d3:73ee? (p200300d82f035b00f549a879b2d373ee.dip0.t-ipconnect.de. [2003:d8:2f03:5b00:f549:a879:b2d3:73ee]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4f009fdbasm4086329f8f.85.2025.05.30.01.33.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 May 2025 01:33:17 -0700 (PDT) Message-ID: Date: Fri, 30 May 2025 10:33:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] mm/mmap: Fix uprobe anon page be overwritten when expanding vma during mremap To: Pu Lehui , Oleg Nesterov Cc: lorenzo.stoakes@oracle.com, mhiramat@kernel.org, peterz@infradead.org, Liam.Howlett@oracle.com, akpm@linux-foundation.org, vbabka@suse.cz, jannh@google.com, pfalcato@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, pulehui@huawei.com References: <20250521092503.3116340-1-pulehui@huaweicloud.com> <62b5ccf5-f1cd-43c2-b0bc-f542f40c5bdf@redhat.com> <13c5fe73-9e11-4465-b401-fc96a22dc5d1@redhat.com> <4cbc1e43-ea46-44de-9e2b-1c62dcd2b6d5@huaweicloud.com> <20250526154850.GA4156@redhat.com> <06bd94c0-fefe-4bdc-8483-2d9b6703c3d6@redhat.com> <57533126-eb30-4b56-bc4d-2f27514ae5ad@huaweicloud.com> <956124be-c73c-4023-9edd-25372f3f865a@huaweicloud.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <956124be-c73c-4023-9edd-25372f3f865a@huaweicloud.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: blvbuBYso9VlSif0l-ngSar8OiyfPJm8nr-QZXiVdzU_1748593998 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 4198720005 X-Stat-Signature: 7mrdk5tyfktjrwufitq6gu8k1ou7rsbb X-Rspam-User: X-HE-Tag: 1748594001-904265 X-HE-Meta: U2FsdGVkX1+61HhQDHi1N9/YGxIWM+vQZQ/QSoa5uVaol0It3JtVhTbkHiCZx8hK/6xWbHGzRrI7pgv/90XATCBqvD3CBH/dfgwiX+0h0rXBN+9F/nkfKzy8+i8H+OnNuIpRN9J5bJjYM+Ubof9vRdBmHsuKEGxut0ho8M/QrOr3pMbkImbxXQZQ/pSpqiNsGgKrEurymJA19CC9oauTu7gn67F8nK1uUXSBuKz8pmX/FarkQfXzauWeAbXxCwhmc8NT6JeH910yjQGgt1xPMZxvkaR9mJN1nEHvjb4k+jElUSZSR8dWbZlgazuQX6baePS5TZl5oH0ZMtL0RG6MgfGyPCrvv0lndU0tztwrBme3ykxk6cvCUTbkjsIohKWWy47BBu6+fwSfBV6Ouu3jRgn0kUoQ2yAgDm0P/p2Wa4hhzYCLWBHcCm+iE+OKzwEnA7sWrLnkK6lmVSD7l6ZcZAEUT6LE1agLWc9zZNkciI+yoK+LgqR51oDzh1theukiHncSkazQuCcS6Qz5yieoJiNbtaZSE8tauium4459NChOHVX0y+pdJVyiJ8MIBbe6wi5+EvTwcybgUjwvIPq36NxDwPUJ8XMhABhKgcxAyxKfIE0kZwVf2g/jYUfk0JWJ26hiA+vPM08BjCR8DCf+G4hzaNSvMRU9fpqTP4Lj8nDPSbWJ/UMIOdf25sqK/Bz8VYqYYAMoahe3k0E+9K2hMOJ5qXMaMuNT1nQxPxQALG8YLksEBpjcDwRlmdz54H4vOUMDYuK/4OzqOBLgG+UYXGXpM8le8U7GsmneORjqKTD1jysip3+AH7T1lcdA9wrOy/0jvwhqsx9XH+pbEhrdtb/cM8p0CEaFsoOVUmnvPPGZteQx+35WYiyMXkE01cnbIkUhHDETmd52HpUdbbEI4QmmSvrXeipYOcWgbqNPF+rhTRlPCnGjs7SDyr8o85Gtjsn7gKk1vq+4ZNKqxg4 iSSRRLHr yCPsJmR6g57atpjNleZ6u2SPtECWSr4HL/hwiAFP2tjVOQ0xw1TCqBel7YbS62iD3a5CXFGsDvxMIMVgSeZR/6ykp8jQhQMRWf3MpUligmiURQvGW0WHqVFx6r00Ot+I6f7Ksg8ERWuqy8Brs4lykzVCVTHrVXIxz4mJ31nfeWnL9vkuxaKhKVkTbtpKIJE76pg5wfuNe6Xva5QmJGejfJEeYHrCatkytFfexULB/JRu1QTny1WX57LRRVUZxNyJP/bsFhXHwJVqZQHSl0U1BYo+lC99ya2FKCE+ga4OZY4vkyCisnEq2diAT+Qx8QFp5i8cFYKb/VjMsevVrLexQMh9mTADvrbL4gTUvmu3P+MJ1PMVoZoDzp1CLNc3Yht8KqtP23dN+/+3IdYe8C7fREnULEoHQN/4ZJoDC13vhc66vaIY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 29.05.25 18:07, Pu Lehui wrote: > > On 2025/5/28 17:03, David Hildenbrand wrote: >> On 27.05.25 15:38, Pu Lehui wrote: >>> Hi David, >>> >>> On 2025/5/27 2:46, David Hildenbrand wrote: >>>> On 26.05.25 17:48, Oleg Nesterov wrote: >>>>> Hi Lehui, >>>>> >>>>> As I said, I don't understand mm/, so can't comment, but... >>>>> >>>>> On 05/26, Pu Lehui wrote: >>>>>> >>>>>> To make things simpler, perhaps we could try post-processing, that is: >>>>>> >>>>>> diff --git a/mm/mremap.c b/mm/mremap.c >>>>>> index 83e359754961..46a757fd26dc 100644 >>>>>> --- a/mm/mremap.c >>>>>> +++ b/mm/mremap.c >>>>>> @@ -240,6 +240,11 @@ static int move_ptes(struct >>>>>> pagetable_move_control >>>>>> *pmc, >>>>>>                   if (pte_none(ptep_get(old_pte))) >>>>>>                           continue; >>>>>> >>>>>> +               /* skip move pte when expanded range has uprobe */ >>>>>> +               if (unlikely(pte_present(*new_pte) && >>>>>> +                            vma_has_uprobes(pmc->new, new_addr, >>>>>> new_addr + >>>>>> PAGE_SIZE))) >>>>>> +                       continue; >>>>>> + >>>>> >>>>> I was thinking about >>>>> >>>>>      WARN_ON(!pte_none(*new_pte)) >>>>> >>>>> at the start of the main loop. >>>>> >>>>> Obviously not to fix the problem, but rather to make it more explicit. >>>> >>>> Yeah, WARN_ON_ONCE(). >>>> >>>> We really should fix the code to not install uprobes into the area we >>>> are moving. >>> Alright, so let's try this direction. >>> >>>> >>>> Likely, the correct fix will be to pass the range as well to >>>> uprobe_mmap(), and passing that range to build_probe_list(). >>> >>> It will be great. But IIUC, the range we expand to is already included >>> when entering uprobe_mmap and also build_probe_list. >> >> Right, you'd have to communicate that information through all layers >> (expanded range). >> >> As an alternative, maybe we can really call handle_vma_uprobe() after >> moving the pages. > > Hi David, > > Not sure if this is possible, but I think it would be appropriate to not > handle this uprobe_mmap at the source, and maybe we should make it clear > that new_pte must be NULL when move_ptes, otherwise it should be an > exception? Yeah, we should ay least document that if we find any non-none pte in the range we are moving to, we have a big problem. I think the main issue is that vma_complete() calls uprobe_mmap() before moving the page tables over. If we could defer the uprobe_mmap() call, we might be good. The entry point is copy_vma_and_data(), where we call copy_vma() before move_page_tables(). copy_vma() should trigger the uprobe_mmap() through vma_merge_new_range(). I wonder if there might be a clean way to move the uprobe_mmap() out of vma_complete(). (or at least specify to skip it because it will be done manually). -- Cheers, David / dhildenb