From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB4A3C54E4A for ; Fri, 8 Mar 2024 07:53:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 623A76B0343; Fri, 8 Mar 2024 02:53:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D4026B0345; Fri, 8 Mar 2024 02:53:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 474AC6B0346; Fri, 8 Mar 2024 02:53:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3891E6B0343 for ; Fri, 8 Mar 2024 02:53:40 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 09DCE121482 for ; Fri, 8 Mar 2024 07:53:40 +0000 (UTC) X-FDA: 81873107400.12.CC05708 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf07.hostedemail.com (Postfix) with ESMTP id D9DAF40015 for ; Fri, 8 Mar 2024 07:53:37 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=BynHUM00; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=RoFfSx5D; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=BynHUM00; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=RoFfSx5D; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709884418; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rp1D2QYjHNl+iUq7FT+HRREVK4qqEoRgZESSZNDJq4Q=; b=zauO6xw+rXXH7AExnXYWNpOFhlkmqMHmIXbuvHpy/HDGWGXa0IV18hAfKk/p8ys0I/Eyuz WbNIAz4xdgJWSjtOmC0Q+4jW6JiNpVGswe7/b31kggYmWgsAOAKeCnCVvw34Jswb9L/md3 vUvlMdwEpi4DV3mgqQgFC19nmgE9Kv8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709884418; a=rsa-sha256; cv=none; b=p99CoZPm8+3A6TCGbV8cO2NI+WDc9rb6kZmxtfnPhrCHZ4zRfTvO+JobonLiuOzIOKkgP8 amdT0sKFw3mPVC8z5XerXke2W6AUA2hHdQItw8DHQaEK4mLrsvqduavsW0C/1mX+Z7RJLF 5KREBhBll+unSXuKmSO9NNxzBBazm+8= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=BynHUM00; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=RoFfSx5D; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=BynHUM00; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=RoFfSx5D; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 299F120383; Fri, 8 Mar 2024 07:53:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1709884416; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rp1D2QYjHNl+iUq7FT+HRREVK4qqEoRgZESSZNDJq4Q=; b=BynHUM00jAgdskbp4wm6oemibVk3XPcOt9jA9PXU8Nrx09OF7i6r7WML6HkJ+fIFPY4IYo RpeIGguI1CYb/wKTvtqP7YKMMX6XYbR1Dfz6EkRpwMLH1GF2sMVfQsLNQ44XyxmiqpZAAS Pz7HWY6tJ1VvUvTzskoHceVw8dFITuY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1709884416; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rp1D2QYjHNl+iUq7FT+HRREVK4qqEoRgZESSZNDJq4Q=; b=RoFfSx5DnDMbTHqN1emARAv2MMV+7MlyKvgLo+oyUhmCRxJyLSxbPDane3A3m6TaZdAnAM HdUBjJPO0ZgJV0DQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1709884416; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rp1D2QYjHNl+iUq7FT+HRREVK4qqEoRgZESSZNDJq4Q=; b=BynHUM00jAgdskbp4wm6oemibVk3XPcOt9jA9PXU8Nrx09OF7i6r7WML6HkJ+fIFPY4IYo RpeIGguI1CYb/wKTvtqP7YKMMX6XYbR1Dfz6EkRpwMLH1GF2sMVfQsLNQ44XyxmiqpZAAS Pz7HWY6tJ1VvUvTzskoHceVw8dFITuY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1709884416; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rp1D2QYjHNl+iUq7FT+HRREVK4qqEoRgZESSZNDJq4Q=; b=RoFfSx5DnDMbTHqN1emARAv2MMV+7MlyKvgLo+oyUhmCRxJyLSxbPDane3A3m6TaZdAnAM HdUBjJPO0ZgJV0DQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0715813310; Fri, 8 Mar 2024 07:53:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id kPG5AADE6mUNSAAAD6G6ig (envelope-from ); Fri, 08 Mar 2024 07:53:36 +0000 Message-ID: Date: Fri, 8 Mar 2024 08:53:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] mm,page_owner: Drop unnecesary check Content-Language: en-US To: Oscar Salvador , Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Marco Elver , Andrey Konovalov , Alexander Potapenko References: <20240306123217.29774-1-osalvador@suse.de> <20240306123217.29774-3-osalvador@suse.de> From: Vlastimil Babka In-Reply-To: <20240306123217.29774-3-osalvador@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: D9DAF40015 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 6yt36rb1auha6gg5wt6cru7gxp8gbgzn X-HE-Tag: 1709884417-701160 X-HE-Meta: U2FsdGVkX19dMHtUJwLvnWOAxoe/G79fgYLMB7buNBrCo4lGZ1bq9XrY+i7YsIdGrqeq4bIW/npBBKWasT3uDkvg5sxI9BNHB2c37aXZuUW/yTmHgMNM5H/MYo7WWgo5sXyonN227Fv+sLrvU7+oizYEPSHlOknBwgtxzoBtAxt+gH3Yo9UPmMhJLjYtvQzDfBmSiKUZniN8UtMQJ9q+95kuEIYwi2kygbhEf54D1xO++hDmPB9yHdoMdAbrTBA0MJrNMcAWlFnySLeqVRUkGP1awUU6Fv1Wdljfb1KUEvYwnmVwtU52x2Gr9lqo+IdCwctJiCOQ9DCGu/+krNTcnapBQu+THNhnTdDhQPiLHe8Yqa/75rTwcZXNcWAKt51joPGRxN5kMup0oNZSkk+5w3LxM5M2ckXx3WDU6li/ZayuS7Ns4jCj8frzeEzK1CFVOOBb8jJrj3Cxe/rrCwFWXLRHjGJ/LW896rjDy9s0zGK4IxVs18TOdYq//Spe/3J8k5MNesuiTBGR/45d7SES5JP3Bn3XoP35IYLIkvlbvFECEqSuqk57fChpJoHRtgMVIXznJqc5uzbfJ75KbmCvW8NS1DucZGeJyHLf5LyxAaqDps0gkHAL7EuxU2zQPLoNYy2cmY0pw94nqsszc+v4ReUuZ4GqM2sHCPHYMbHIiccF/neoFIsAJhC7edEo+npFuzOXBFIsgfIkqHPCPY8WY0La+fqNB7EqXGQHGHcbiH8GucWlueKfZFdy99/oJTYangDsdQqWtBp8UsYqY/L/Y5Aqe58DBWlCKI8O1o/1nK/YVx5+k2514BY1/NepPGF0B3P5p3fdmeYVzIDRDOpvaDTiMM/UN16en/pzRN3jfm7XTfHEKOGjv8vWjOBxFdTETRZCMSZbXxBJj6bul34JKSvMxaUsN9SgmFndhLDnzKuZ9fdFmfVV6lch7bUzDHfgc3+/jTAYS0Vnqk0ViT7 k1ZHbOd7 IkoeZelLpHo8IhIE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/6/24 13:32, Oscar Salvador wrote: > stackdepot only saves stack_records which size is greather than 0, > so we cannot possibly have empty stack_records. > Drop the check. > > Signed-off-by: Oscar Salvador Reviewed-by: Vlastimil Babka --- > mm/page_owner.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/page_owner.c b/mm/page_owner.c > index 7163a1c44ccf..e7139952ffd9 100644 > --- a/mm/page_owner.c > +++ b/mm/page_owner.c > @@ -865,8 +865,7 @@ static int stack_print(struct seq_file *m, void *v) > entries = stack_record->entries; > stack_count = refcount_read(&stack_record->count) - 1; > > - if (!nr_entries || nr_entries < 0 || stack_count < 1 || > - stack_count < page_owner_stack_threshold) > + if (stack_count < 1 || stack_count < page_owner_stack_threshold) > return 0; > > for (i = 0; i < nr_entries; i++)