From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F167C71136 for ; Fri, 13 Jun 2025 20:17:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2BC16B0089; Fri, 13 Jun 2025 16:17:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ADDB36B008A; Fri, 13 Jun 2025 16:17:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9CC476B008C; Fri, 13 Jun 2025 16:17:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7C15B6B0089 for ; Fri, 13 Jun 2025 16:17:38 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 279D0BEB17 for ; Fri, 13 Jun 2025 20:17:38 +0000 (UTC) X-FDA: 83551487796.11.6A839EC Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by imf19.hostedemail.com (Postfix) with ESMTP id 149861A0007 for ; Fri, 13 Jun 2025 20:17:35 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=neon.tech header.s=google header.b=VRQRgo2W; dmarc=pass (policy=reject) header.from=neon.tech; spf=pass (imf19.hostedemail.com: domain of sharnoff@neon.tech designates 209.85.208.47 as permitted sender) smtp.mailfrom=sharnoff@neon.tech ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749845856; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CyQglbq3/0mpmKO8dOewpYZ8PCVwx6dPi9o99Sc4S9g=; b=BBnv7dDIFdoroDH0hbQxvMu08oIMcpsqSaaDORwg8jwH7qctDBOQ+GGleatP10UQ3TgJkE cg4aZ6OKrgb/uzNfzs48EkIjeqwYQzcZ+UTCYy0f4ZhiZJ51R134N7RKGZn+F9nc22Yk9l OXPHNVF0Se68EaNtTkHiS9OLnU/PfuE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749845856; a=rsa-sha256; cv=none; b=5KOTXjqDPT6KOOZb+F9jwBxB/jfpo/X4RCumuXlGBXem0DbfzKQwlWePM1RI3p4JzbKSO/ ZJlNBkCfmV5QAB+Z0MmU0ymuDK6sDj4Ks77CNdBeL78XL6uPlh1Za8dAvlx3DJBraz6RV0 NpWZOqeDjPysztUgfpavgjprL6Pei7w= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=neon.tech header.s=google header.b=VRQRgo2W; dmarc=pass (policy=reject) header.from=neon.tech; spf=pass (imf19.hostedemail.com: domain of sharnoff@neon.tech designates 209.85.208.47 as permitted sender) smtp.mailfrom=sharnoff@neon.tech Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-6077dea37easo4832243a12.3 for ; Fri, 13 Jun 2025 13:17:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neon.tech; s=google; t=1749845854; x=1750450654; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CyQglbq3/0mpmKO8dOewpYZ8PCVwx6dPi9o99Sc4S9g=; b=VRQRgo2WCtd1NwAsuf7Gtn1Oep4sY3ECu2i7VjlScV9+4+gUwc9RHIIdSRdxzYWqA0 t4YhiL1uTaT1r7neZiG/ryra1ohnRZ8y0LO2lwM/DQFtafNA++K+dVcUulvLMvwv1lj/ 4vohKlIk6xP855vO11etDnaHCGDV9cYa0yGcc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749845854; x=1750450654; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CyQglbq3/0mpmKO8dOewpYZ8PCVwx6dPi9o99Sc4S9g=; b=UfDAxjvvFR5Fimn9DRJFv2Km1HUBT2OjsWOUnerOhQwbPfBhdpvSn5hqPNLsIvdkiC 8gNsfwnbBVuPsZf7cuJGteb1akU6FRL8Kubt24uvbKE3cbWk/M4VKLfG651Hx/xOufRq DooWP4Ak9Pe0VVnz/O8+Js/KH4JKSSt6+HAjLmkP+oGZYDwSoGZtuSyT40iabinjLXn1 qugKWKlFLsGeO3gjuiGhXUk8GLru3IGgSaSq2YgJiT8Oon5P2ggKmruj+CtXx+KVBLIp cfO5IdbCnnYaB9c82WZAVH5JfRsqteygVlelhy53WvN04xm+mT9CXIztTlVcHKQ1tNGI uYuA== X-Forwarded-Encrypted: i=1; AJvYcCVGVKEBYwTs6pf5axXtADLqNmSCgjI1EVoLl2iy63QPpxxkSM5g1ZEKCALBW7SKZsKSvf1h448lSw==@kvack.org X-Gm-Message-State: AOJu0YzzVuEO3FiyROc4lbIwyPsHalOut/PWkKtiC3AVEDGYcpaYJQyM gsw3ey5Vi3Yd7jCKLYO2Wds4516IWEaS8QGLjxKxMPa8s3hbcIeiErxOO026g42iBfw= X-Gm-Gg: ASbGncvnYEifNuN1eNat9lUO0B1j/6sfZA4R+9PAZ/AZwNj6BfALGxLPNKfHoIux3bL jabuk296saW0qSUwoIgXmO25pdKBbPQ7KG0kwgS1LA2OYU6jJ3DaE3KDk88bzjTxBeMfH0zyYQt mdWdZi4ka5Q5xsqRWECBAIe7cgWFohkvExlTyqYkwJrtWEjNPHCpC6mJzHUtEtAyVDcX1bw4CwI xJZndQ8t2fZlgC4gzhbFkdOKZq9zF4c/rKGS7Fea77tmpa4BJ5bFlDpAmekjpBGmytISJY6b3Zj toA6ij5lAruO6/Opntg6stx1yFzvA11BkvR+ZzGsjqEaC0OfxtMcyxwFVwCAIcnaaA== X-Google-Smtp-Source: AGHT+IE01LEMd/Qic8Fd2OmHEm54/6La76xa2sKwbCrdjEu0M37Sr1UFg4VnN+fQSeCdY7kqlcKBuA== X-Received: by 2002:a17:907:1ca0:b0:aca:95e7:9977 with SMTP id a640c23a62f3a-adfad438078mr46790966b.28.1749845854453; Fri, 13 Jun 2025 13:17:34 -0700 (PDT) Received: from [192.168.86.142] ([84.65.228.220]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-adec892cd85sm177000066b.139.2025.06.13.13.17.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Jun 2025 13:17:34 -0700 (PDT) Message-ID: Date: Fri, 13 Jun 2025 21:17:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] x86/mm: Handle alloc failure in phys_*_init() To: Dave Hansen , linux-kernel@vger.kernel.org, x86@kernel.org, linux-mm@kvack.org Cc: Ingo Molnar , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Borislav Petkov , "Edgecombe, Rick P" , Oleg Vasilev , Arthur Petukhovsky , Stefan Radig , Misha Sakhnov References: <22cd0fa8-d14d-4d37-a6a1-5e6827d6182b@intel.com> <2080ec7c-8dc8-4f03-bd96-78ba47e55a97@neon.tech> <7c204a40-532d-4afe-94f9-e685fb9be454@intel.com> <586a10c2-fc65-4b39-add6-c383bbf46078@intel.com> Content-Language: en-US From: Em Sharnoff In-Reply-To: <586a10c2-fc65-4b39-add6-c383bbf46078@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: 5knoq3jmm9ku3imxwhn7nz7aythxxchx X-Rspamd-Queue-Id: 149861A0007 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1749845855-24891 X-HE-Meta: U2FsdGVkX1+TDz3aUn6qTVxa5hAVepYLkJtIS3wLjv4L9/OD59++4aNc2IEo4gNhi7Bw2xkrq8UOrtMrEr8tv7uZqcb1F0dslBx+0eoskqvYoDll+FIKeavNe39KqKdz1jOV1z8SdlyRxlXMChhlhOFX9LOQVlu9f2mjMbLmkIvj5MFmdcHKpE7TsubAvBCVsh8MOmMPbQifyaTNUnZN4u/t541jVpiuJD82Zhrwp7muLQjGQRAOJgSyjWedFfDeFyYcYPByFRpghXERfstlm6rSvmR3AEJMfx3YgsFjL9lgt+wQ9dwQ+y5tYoVSk4duNImWQxP6HVOCAaMk0T5SWunh1Ja1/qUYYk3icxLJv/YSfeNOP7no11nAbFsCxD+bwidMsiVmPcqqZnzOf3YNdS/3QoFq1vSPaXesktcCvgbuH4K+KuDcRUUd+ou88kEJzzY7i35iDqHS/I23pPfPMQp7xBf9d8SjPCTq/EZujlHUNCl5ibziWF2+FClwoj9zNGzuVbKbCHW3CfH7Sae6DVhI3jxo9RF6TRhBGFt+7KRdfvNxNKyB6JHlhFaF2S62F8QejwwP1bebsjg5NGzl/52Aeig15hM6ZXgwTWSyYjYgmvbjdqwabYR227GN5YZoU4vYJZ7N/Tye+fAl2OYoI+9KmogL6s5zbkSmOx4Y7IVH+I5yEqO8CU+IMV3qRc7kCkQU/hrkZ4odkvUg1PTs5CXwLd8XXI4+OESXVfOS/B8TMjYUDEggy++93ks7WWdauMt4d8jC/7Eay8FxBeKDTK/McfPenlUAI5mUEm3GOAYNhv0c/AUoHMCE60oJjma4DTqwjMdRZmF+VqgNcfVImN/9VQBzZRVRmWUdRFS6fLElDOHN5likQnHnV492bDkZQLmolbb6f2ILuXorWkcvPPOIrua3oGAcLiExldS0VOL7NtH/aJHpO+YQpf7qCBmo/WtSE+dZ+V7FONgQOr4 VLrpizKH cVBdvsE3Gsv3/VwmVVB0O00vHb5tP+cphc4I2ZpeA04g4wmfV6MgNIb7Ln8tSs5sxPAAdVhn4ZoOtxuUFi48mgyRZyoO+HQ94O/P4uvgnJeYElGdM9+xrbohNw94aWASySeQ0hIlKe9eV5fFzM/RBS9YWizwvwuzU5joAYbWo6y0RnmnVs4g37tCOPt97smHLYapUw2fYhUELfqpo0cje8BS1ueTjCCnKdWa6Etl1PJMHH6ziIs2e/T4YsThr8gRw/XLgCpqRfYKELZkDrqFJUlKxWIBZTl5Or5LnK0mpBSYnHZ/H2VyyYzQtBpu3SLjS5lyGEsDtq1/exII9AabhQCpd4POE8jopQ7F/mve6CgcyVrQXjdZssnas/k8eOaijg/t2Sw3VAt6WNnGV+c682U368img5wz8gUbD++monDtmX+hOwwAztkJIRYFokldVqjFn3f2sY739B9GrWSEIvqx+RA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/11/25 20:36, Dave Hansen wrote: > On 6/11/25 12:26, Em Sharnoff wrote: > > 2. Change the phys_*_init() functions to return int, and directly update > > max_pfn_mapped from within them. They already call update_page_count(), > > maybe this is similar? > > That seems like the most straightforward. Each time they update a > mapping, they call a helper which bumps up 'max_pfn_mapped'. Update on this -- turns out I was wrong again. 'paddr_last' is also used to update 'pfn_mapped', which is more complex. Hopefully still within reason. I've posted a new patch set, patch 1/4 adopts the "call a helper" route. Design-wise, it's less clean than I'd like, but let me know what you think. https://lore.kernel.org/all/7d0d307d-71eb-4913-8023-bccc7a8a4a3d@neon.tech/ Em