From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36400C28B2F for ; Sun, 9 Mar 2025 13:41:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A7D8D280002; Sun, 9 Mar 2025 09:41:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A0758280001; Sun, 9 Mar 2025 09:41:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 88153280002; Sun, 9 Mar 2025 09:41:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 680CA280001 for ; Sun, 9 Mar 2025 09:41:09 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id F3C031A26AA for ; Sun, 9 Mar 2025 13:41:10 +0000 (UTC) X-FDA: 83202123900.08.C789004 Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by imf21.hostedemail.com (Postfix) with ESMTP id 0C32C1C0007 for ; Sun, 9 Mar 2025 13:41:08 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=cAxWeMh3; spf=pass (imf21.hostedemail.com: domain of yunshenglin0825@gmail.com designates 209.85.214.195 as permitted sender) smtp.mailfrom=yunshenglin0825@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741527669; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LbqFVYGZKiXAHZ9rqZe+rnsj7EpBf3DH/8Ue+vs/s7U=; b=rH3bQU1hdvgxRIuM/KjFe7BOwEPzNexy/ZcrOm/n3jdneB0xxMeITozeIC9nsIS0diK/gu NnDjmkzJj5cU1RTdNa43uXKxShNze4LIz3m8C8NBzGgoTBHNwW6XC42W6Bf1SyEBW8nFTQ TRqD7idsZyo8et65bLpy/RA1GcSIxkY= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=cAxWeMh3; spf=pass (imf21.hostedemail.com: domain of yunshenglin0825@gmail.com designates 209.85.214.195 as permitted sender) smtp.mailfrom=yunshenglin0825@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741527669; a=rsa-sha256; cv=none; b=JdOOV13iDykU9sh0kQY8SelXk1DpJRnwcKItRHJ76hKHx90AcokXVqCFFMhWD5kA3PFGBm dwDfsWf4MEvw8FrG8q5v8wA00qOUlxcHpgJk88qH9poyyd2p/gmbjJohMDD+msbhuVpiGi uTnXkOTF3jN6VTF6KWP3r5W8k23XsL0= Received: by mail-pl1-f195.google.com with SMTP id d9443c01a7336-223fd89d036so64907615ad.1 for ; Sun, 09 Mar 2025 06:41:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741527668; x=1742132468; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LbqFVYGZKiXAHZ9rqZe+rnsj7EpBf3DH/8Ue+vs/s7U=; b=cAxWeMh30heTdnHj8qx2SmFLqNl0yPvJe/Nas3Uec4kYg4dVY6nWEIJUYaiXA/RO2U hOp6xikMbjv1JMBfafy8xsdtLXXTxJO0RotAaTTmM05LwHuptNwjLOvmMk50cWtCLmCx TfgI14RM+2wlkAJcGtueE2rwSBoDKjPD+Q+P4GWcPmJG1n0T4j6eJ+qd47xDsnOvBX8v KJSCeokdgWCsej1p8MDgHYR5K5xpcmcSgdB/iV2360S0ZMlznRdO9InOOmOHbfqn16za WTNTf2S0JdegkBVYgnEa5T4kp4DfwIpqxVd+rCGWCaAwMnlpBY8Yy9/dX1DsSqjTTHeD SSSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741527668; x=1742132468; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LbqFVYGZKiXAHZ9rqZe+rnsj7EpBf3DH/8Ue+vs/s7U=; b=gNjrKXUGOwVikz5CUIi0mQY8WFuAoBxAQCR53ulBwArkR9t/LXEfIWwtm/yv3L9KtY QhXNuK0C9DAKB1gv2FrwmWpxUYPv3utE7vbDptSYMampySa3POiq83N13Z+U4lJGB/Rl eTzVSnmrxRGEUaL3OMRN+XW0YMqwgufi8DitnSwQWSu0LoqcoeQe8KartL6pR8fgvYTa Ddm3pjGCGTmpS4Ovdbe6HtUlMaW7PXFHiOLJux1SWznZ7rhyU7ukEJRmmS2BwxVQQM+K BBv9OcacaavcQ/6Yk8WT+ubZTmDf14IsSFirPMZ0VbO2cHpyDab6e6q7L6h4qqg/pox6 ViIA== X-Forwarded-Encrypted: i=1; AJvYcCVSRUINjwJA5fdeLUfcBAAXkDXAMHfDvlgQfE2L3xfsLzfAG7M35KhF6bYA2DUu/mB+y8/LSZPE8w==@kvack.org X-Gm-Message-State: AOJu0YzzoKKboCiLxcc+Sdt4grec6LwR23b3FRuWQpGQX6yaomh2CPPv CSnXJTJdC47fM186d9rfcA6UldcMIeYLM7TLYYo4XpeaAPD1MO81 X-Gm-Gg: ASbGncul2ZtdHYI8pyQiFGMCz8sjWbvXXyeKWAmlTYLjsx2G9F/UtbGIshdQ/nwOC4B aWPfdabrTKOq9g43ftzDfDM1sVf3OvcLEh1DK+oDDxkFbaXqkjoP5VjgH+xfyHkgF3T3XGsADsf WsoTidAo4E2olCgO0hMIhSfMygyQfzK34NkYTSXWQFiNwXWkzRJebSi+yeP1uB8w2Qw/1/3Nhnq P04ruMfuBsbz2SMi+QRCHgZyOv8UgI2hbLwl83GOroCTO82QSIZ7nNcAqVW10lotL0gRLlbfvMw 4rj30zYzdpOImIMjnd7T3jPooln5i6eA7QJiUr6UrJ4Rs/d0Vhq8d8d+TNzTDQnve541SgRppu/ A9CV5EnC12lzsrBF5eSFrYecuUhspAg== X-Google-Smtp-Source: AGHT+IFypNCMIn41ibdTDNx4lnj5ojm64dR+2U0xpw0STk3CxsR4PZycEa3AfGJqpDAqBoyMWdx6gQ== X-Received: by 2002:a05:6a00:2e17:b0:736:5c8e:bab8 with SMTP id d2e1a72fcca58-736aa9c1effmr17581861b3a.3.1741527667817; Sun, 09 Mar 2025 06:41:07 -0700 (PDT) Received: from ?IPV6:2409:8a55:301b:e120:c508:514a:4065:877? ([2409:8a55:301b:e120:c508:514a:4065:877]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-736d4d14f66sm619646b3a.82.2025.03.09.06.40.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 09 Mar 2025 06:41:07 -0700 (PDT) Message-ID: Date: Sun, 9 Mar 2025 21:40:52 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: alloc_pages_bulk: remove assumption of populating only NULL elements To: Dave Chinner , Yunsheng Lin Cc: Yishai Hadas , Jason Gunthorpe , Shameer Kolothum , Kevin Tian , Alex Williamson , Chris Mason , Josef Bacik , David Sterba , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Carlos Maiolino , "Darrick J. Wong" , Andrew Morton , Jesper Dangaard Brouer , Ilias Apalodimas , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , Neil Brown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Luiz Capitulino , Mel Gorman , kvm@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-nfs@vger.kernel.org References: <20250228094424.757465-1-linyunsheng@huawei.com> <91fcdfca-3e7b-417c-ab26-7d5e37853431@huawei.com> Content-Language: en-US From: Yunsheng Lin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 0C32C1C0007 X-Stat-Signature: sndqrubrkuxngfiuxyg7c4zbhhdpww5p X-Rspamd-Server: rspam09 X-HE-Tag: 1741527668-161868 X-HE-Meta: U2FsdGVkX19lcCRuWRIk7qNqDvD04bC55xNTmCEwRoNemA7uU4Ev7v7mdCtH4n8luZ0xMiPUfRbYrrzeObduJYefjk2giPtaYCy/wK8Tp0L8pDn3Jsn95rMkDbfY0Tz6z6ZgFFspoNP0baWAMRojF4FFhyZf4gWOukrwlcPjACizF5NoMS+CANNdpKf0+Izjs80OeR8dugSNMRVCEh+gmbcuyC2zuNqKwCp44EdoCpeCACyYfFG4UHUe5xXnE/Kb9PTJQn2Be5qlUoM6aWzWjhK2ETMMrYx/CApRc8ioWrrPyhkZ5Al+ceAzKB3UiYFx/yexdH46gVP1fhcmR5bhEStTliXJTqf08oohTPRfdCMsyMkrLHDfQZa2co65s1g7olFstAnK6qjsT3rgbetgmVoYDgub5ftlnQQEJ4d7tQS3wep6wReNkTUxHiHQy+++CYAWtJBKIhECL8mjLAx3wCaso1w+yX+TGdgf/tyJtsrIW0uKo+JJ92e1+pc6g6/pXXMDMd1mpy3Oenk/Eo1r2jUinpPqZVcSipoopoSGTLOFxVelQDaAN4s31GYNPAxt1Q8bYvCNfIzSglsMGZMi3zH0nUvVpQU7Cq/oWyxGYLhech4oZ/10JcW08QZSOfeE5kh6z4WwyHTyGP3FcTqSTzx6skLQcGzPNJ4tVBRxt5IJJe9c36AXy/81iLkEYFh44Z9IaSjVRjPRZrMBL2eMa80KsZUgzGAqdw2fKXp0A0APNQ43lGIkgXK8qo9Q92Iaqxswz0xz4GVV5LxDi6xaH3DU7ZKFzPobj6QYjPw7uTR+1QsWp+Fe8je9hqjrfVqeKcSE/BJbBR9Z8RfzPp+tjIKx7z9GzXoW1UkImaISkU99gtzi7RQYlJ461bv/SfzoGJTEAvP9mvwfavLQhbF7JS3FRgEOAe3HH73FUbOv0H8Q+Ad6mYoELHSy4qGxZobeouTxlZsKlSh9a7ezQq9 sdOMvawy 8m1imrusESQU/dtuJeXjFLeCSAo/5s8wG+SvFODa3pez8CVkyf43drfLtqw1fUB5W7Q8RmeHj1pMNvgtmMc83IrNsNMDLhOQmWFs4wvLQiBhafgGdKf8YLT1BJrs1oyaOQJiY/9RQa3Fk48gpneTYcmQblWVCmLIvWZbN3kvqWJaFL3ODePWZjoACpom3brSrkCj5Egr2RTxE5uoXhPVlI/r5LJmmZaH9iUOyMcG/rAhQDU+Dk+XcqA5l5WqJ1l+gdZ3BO+IFv2iy7GrQjrJ6G6Dk3t0NEbVBfv1etiuaiuaO/ZgsxcUc6n2lVR2oljMh/Xn5zs95y3WsQEekXdkUEsRJreaYU12PN4WQN6AQwF7bwG0YCrF1r/eSd1wfK/8bDGFrpxqDIwdW1jrEXd9khatvUUSZX0WG6sKiZyDGe8c4gUzcbwGH6WYNd0nMxr1zScMByi+tyRG579ujpKOyhvovwAnrOaARYQxLHSJ3Vw5JSnP1ndrqf1CUtrXDivLjKXQrympI9+rgcAY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/8/2025 2:43 PM, Dave Chinner wrote: ... >> I tested XFS using the below cmd and testcase, testing seems >> to be working fine, or am I missing something obvious here >> as I am not realy familiar with fs subsystem yet: > > That's hardly what I'd call a test. It barely touches the filesystem > at all, and it is not exercising memory allocation failure paths at > all. > > Go look up fstests and use that to test the filesystem changes you > are making. You can use that to test btrfs and NFS, too. Thanks for the suggestion. I used the below xfstests to do the testing in a VM, the smoke testing seems fine for now, will do a full testing too: https://github.com/tytso/xfstests-bld Also, it seems the fstests doesn't support erofs yet? > > -Dave. >