From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BD58C10DC3 for ; Sat, 2 Dec 2023 10:11:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 99AAD6B04A6; Sat, 2 Dec 2023 05:11:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 94AA56B04A7; Sat, 2 Dec 2023 05:11:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7EB2B6B04A8; Sat, 2 Dec 2023 05:11:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6FE3E6B04A6 for ; Sat, 2 Dec 2023 05:11:32 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4844E1C0021 for ; Sat, 2 Dec 2023 10:11:32 +0000 (UTC) X-FDA: 81521461224.25.7912FDD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id F003DA001C for ; Sat, 2 Dec 2023 10:11:29 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZVJDHyrr; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701511890; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FR+VLmSLHtiOk787gJHIjLXiKhSQolv8Z3y5kaZ1lBU=; b=rtceUuwGtLxZ6WxSAtZ2ugaMVmBHVfO67UBLD4bwx2/qXkhTrZMa3Q9E+iWCDMckzl9XN5 mqJl+5tHFHlml/e6QFj5ZmRzcZczLbkJn3mp7KZ0H/Ow+Gp8ipLPll2BjCn9J2fjKm5EbG R55WLvhQyPPkH0ICGjl6VJXRUPpSeQ4= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZVJDHyrr; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701511890; a=rsa-sha256; cv=none; b=C4bo7sHZ2Ao8ryxmvUnFZZi4w3z7Y2xsT3N/1b5O3Q3WXPMAXYmop6EmY93zHd1koA+5oq oTtUPEFUe+2lH5LvJqJvi//KgptRcuJPMNDVrTUvttSq5Sd5vPmQ1t/hV8Zmuy2mPwKCxR aQGlgFJZTnfsXJW0tDIXaPV2CkLwvqM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701511889; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=FR+VLmSLHtiOk787gJHIjLXiKhSQolv8Z3y5kaZ1lBU=; b=ZVJDHyrrV56BggWooEaQVHQJYTg/vcwbOm0QdW6CYXrqwvOFTndUvFjJpld3MKptWzqCR0 sl7ZEy00wkYkrZWiT9BKobrxh9WiFMKojx9BBtUfxDZMngxUiENBe0QqJsEcuol44Wj09r 18IhxT0RHtITbnG1pAP/uYwtfWT8Hms= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-150-Xh1w-5zaOjS1_mdwfxOW6w-1; Sat, 02 Dec 2023 05:11:26 -0500 X-MC-Unique: Xh1w-5zaOjS1_mdwfxOW6w-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-333063a304fso2354959f8f.3 for ; Sat, 02 Dec 2023 02:11:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701511885; x=1702116685; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FR+VLmSLHtiOk787gJHIjLXiKhSQolv8Z3y5kaZ1lBU=; b=Aw1m7q9YDJzDpqWkW8rerlst01kITI0lnlR+bKJLTV3/TABjwXqsmdgH1ZKPJlIzXI +h0GpGmFE1VulnShLcgH9kCmMqvUPJOYU8mSAwVj4lYq/PyPMtRIJA7mlYZKFckw18E9 RCxqhwIIjDe2bxA/ojFj1iP69lKf3sx7OV/fS7HP6LH6EXjruGYq/X1DTBfsVcljpYzm lx3VijJvQ+NcrC4qJPE2ed9EOJ0n0Az0JD39S/XDFG46nYn4+KqXc+K3ERzCFg9EHcoo KQ85Ui3kY/rfvTYuF0yXUiV2dFLoAHKY26b4pb+LJWhuxrT60zShmmZPKxR5GARFGfGX /9ug== X-Gm-Message-State: AOJu0YzXlLFtswE01rz3bckueMt0CHMJTj2gZSYF3903uTPDs2ctc1We lxlcYCfzNDhSR/lJ97t3ICDDuagaaWy/oUAwAAUfOZ2W3cROM/Vtdm/WRDZ40z2KN9+llxNzcW0 02+IVHdlW2hI= X-Received: by 2002:a5d:5918:0:b0:333:2fd2:8158 with SMTP id v24-20020a5d5918000000b003332fd28158mr1528122wrd.117.1701511885522; Sat, 02 Dec 2023 02:11:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IHNUZF1AT7Nw3RxMFArdXopZMFsbeJQk9XxSA3NY+Xev6Db9lUh963rx9GT2CHZfGxW23DhTQ== X-Received: by 2002:a5d:5918:0:b0:333:2fd2:8158 with SMTP id v24-20020a5d5918000000b003332fd28158mr1528089wrd.117.1701511885107; Sat, 02 Dec 2023 02:11:25 -0800 (PST) Received: from ?IPV6:2003:d8:2f28:7800:30d7:645a:7306:e437? (p200300d82f28780030d7645a7306e437.dip0.t-ipconnect.de. [2003:d8:2f28:7800:30d7:645a:7306:e437]) by smtp.gmail.com with ESMTPSA id e2-20020adf9bc2000000b003332fa77a0fsm4394385wrc.21.2023.12.02.02.11.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Dec 2023 02:11:24 -0800 (PST) Message-ID: Date: Sat, 2 Dec 2023 11:11:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 5/5] selftests/mm: add UFFDIO_MOVE ioctl test To: Ryan Roberts , Suren Baghdasaryan , akpm@linux-foundation.org Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, shuah@kernel.org, aarcange@redhat.com, lokeshgidra@google.com, peterx@redhat.com, hughd@google.com, mhocko@suse.com, axelrasmussen@google.com, rppt@kernel.org, willy@infradead.org, Liam.Howlett@oracle.com, jannh@google.com, zhangpeng362@huawei.com, bgeffon@google.com, kaleshsingh@google.com, ngeoffray@google.com, jdduke@google.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com References: <20231121171643.3719880-1-surenb@google.com> <20231121171643.3719880-6-surenb@google.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: F003DA001C X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: w7txo33cp9wqbr8dfxzdke5m85npo5hu X-HE-Tag: 1701511889-739301 X-HE-Meta: U2FsdGVkX1+b1QwGR2Ow3GOuUi6aZNxPTZqtDgEuyZqHrkWyjiECP37Xa0nhP4AiAseTQh1ie6YRWf6zjltwxPlu+TalHIzLI8CeYEAhz3bY+JpNEo0R0esrQNJZQcrbdOxl9pj8PR+RkF/b68xlg2hWhPxM/yS4FJgYZ/JdEPS8Wj1qXT8WxcE0f4+i1CqlK92w1O1Nq32RRZx+ZoPSzu2ovvEjGRsd3GEcJdayE4B5v6TG/6KEnyfy8eDZ19jHuhGrIMl8NA9RpUxkyBoHMynpHApnEDICFJm5mGE8SefF3fUxNF1tiSpK0jq6RFpv4DTsMjJe8ubQyjs4OVmcDD/z+U9+6ApT19bfVdpv6zqgdXvJ/pnFwM00jzByFaGEByMw3yzSBRllI9AXuAOHnt/tie7UFj/NdO/ANEx0rUgoHKkNRW9fiZ16x/SJNAhkGlSntFCjhnj4r26ExxAK/uvj+EK8woouUFP9EBh9K8ytPqpbEswhNwkg0RX9GwXx1leJe3dqCEvpBd/H47Spmwrmc80Q7/QI0mN2q85dEderzaPRWndstxGevZ3A1Ci08KQZhDbvSqDhT4DqRpaNX58IRze9DQ6KwvCA/bbROWMOjxItErdFoyDmDrRmk81730t/rrZLmOA8N/NtZNobDDlAfDMJDaomhsDH9BrDwh4PO9UGBtLQdqWesJDa7gk/vb3T/IO7MslPIzKHorkeZiVozfcTTgjqfrAypKfEQvik1sktAC5ChI6m7yKiVRomhE2UKXk29AFDG7KDEYDzOCQhTXPP1BMbQ9MTS5nueMNiOAjU2i4/Qz50VIHELM2xzZIscNAeKufX7I27y9/eBgoJOIO3vfcDmYzx/jQCTV2aHDL138y3DK/Hex8qG7lSPyVIcJfCHJomN3VKCPg7bxpSttbQcx5pQ5AQ79O1mPg5RiQ2bWx4CK1nnH5qCCBLHOppk0AhcILtsyUEmjb oMYXPdhX YZ9tKfhEvrJ6uYzi4VmOFHvM/4l7KoHyPx0ldBNZ3vRXb2piKFHlsXhej/v0lcDz/cM6QE+puJkm0fG8QYDoPy80u2PVr2Oj7hhr9G+68i1lbIV7Du0r8V5k2JKGiU1RkfdcTZtT59T2LTIcBKy4b/PvTxKoKXBqhjjcbZNyJPfeqVzB7Na5FrrQwZAjAOWEv+5Z5CpS0gZDMdVELmJn0RfJJR6ZzcbwDqv8LYng/OyOvW5p+B788eaX1C7+Pf9gLDYVMMtIA1xAEEX0IWnK8rGQzdnRVmy1QBnU7H+mgycyDWTQ1UTOCBo76F0R8VERI07EvzyglGNwG9yUF3F7PxUpy9CZFY7JvcL0XeSdV6SMtVBInTts2aaUNT+zNV8CLPTFqOS07+0cGwnDrBUMFtWalvbnxARyb9WGV37sNxGaicrv4ZhiyzUX9fA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.12.23 09:04, Ryan Roberts wrote: > On 01/12/2023 20:47, David Hildenbrand wrote: >> On 01.12.23 10:29, Ryan Roberts wrote: >>> On 21/11/2023 17:16, Suren Baghdasaryan wrote: >>>> Add tests for new UFFDIO_MOVE ioctl which uses uffd to move source >>>> into destination buffer while checking the contents of both after >>>> the move. After the operation the content of the destination buffer >>>> should match the original source buffer's content while the source >>>> buffer should be zeroed. Separate tests are designed for PMD aligned and >>>> unaligned cases because they utilize different code paths in the kernel. >>>> >>>> Signed-off-by: Suren Baghdasaryan >>>> --- >>>>   tools/testing/selftests/mm/uffd-common.c     |  24 +++ >>>>   tools/testing/selftests/mm/uffd-common.h     |   1 + >>>>   tools/testing/selftests/mm/uffd-unit-tests.c | 189 +++++++++++++++++++ >>>>   3 files changed, 214 insertions(+) >>>> >>>> diff --git a/tools/testing/selftests/mm/uffd-common.c >>>> b/tools/testing/selftests/mm/uffd-common.c >>>> index fb3bbc77fd00..b0ac0ec2356d 100644 >>>> --- a/tools/testing/selftests/mm/uffd-common.c >>>> +++ b/tools/testing/selftests/mm/uffd-common.c >>>> @@ -631,6 +631,30 @@ int copy_page(int ufd, unsigned long offset, bool wp) >>>>       return __copy_page(ufd, offset, false, wp); >>>>   } >>>>   +int move_page(int ufd, unsigned long offset, unsigned long len) >>>> +{ >>>> +    struct uffdio_move uffdio_move; >>>> + >>>> +    if (offset + len > nr_pages * page_size) >>>> +        err("unexpected offset %lu and length %lu\n", offset, len); >>>> +    uffdio_move.dst = (unsigned long) area_dst + offset; >>>> +    uffdio_move.src = (unsigned long) area_src + offset; >>>> +    uffdio_move.len = len; >>>> +    uffdio_move.mode = UFFDIO_MOVE_MODE_ALLOW_SRC_HOLES; >>>> +    uffdio_move.move = 0; >>>> +    if (ioctl(ufd, UFFDIO_MOVE, &uffdio_move)) { >>>> +        /* real retval in uffdio_move.move */ >>>> +        if (uffdio_move.move != -EEXIST) >>>> +            err("UFFDIO_MOVE error: %"PRId64, >>>> +                (int64_t)uffdio_move.move); >>> >>> Hi Suren, >>> >>> FYI this error is triggering in mm-unstable (715b67adf4c8): >>> >>> Testing move-pmd on anon... ERROR: UFFDIO_MOVE error: -16 (errno=16, >>> @uffd-common.c:648) >>> >>> I'm running in a VM on Apple M2 (arm64). I haven't debugged any further, but >>> happy to go deeper if you can direct. >> >> Does it trigger reliably? Which pagesize is that kernel using? > > Yep, although very occasionally it fails with EAGAIN. 4K kernel; see other email > for full config. > >> >> I can spot that uffd_move_pmd_test()/uffd_move_pmd_handle_fault() uses >> default_huge_page_size(), which reads the default hugetlb size. > > My kernel command line is explicitly seting the default huge page size to 2M. > Okay, so that likely won't affect it. I can only guess that it has to do with the alignment of the virtual area we are testing with, and that we do seem to get more odd patterns on arm64. uffd_move_test_common() is a bit more elaborate, but if we aligned the src+start area up, surely "step_count" cannot be left unmodified? So assuming we get either an unaligned source or an unaligned dst from mmap(), I am not convinced that we won't be moving areas that are not necessarily fully backed by PMDs and maybe don't even fall into the VMA of interest? Not sure if that could trigger the THP splitting issue, though. But I just quickly scanned that test setup, could be I am missing something. It might make sense to just print the mmap'ed range and the actual ranges we are trying to move. Maybe something "obvious" can be observed. -- Cheers, David / dhildenb